summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* The great Flip -> Spdy rename.mbelshe@chromium.org2010-02-084-10/+10
| | | | | | | | | BUG=30747 TEST=none Review URL: http://codereview.chromium.org/580009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38386 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new reliability crasher in V8 to the known_crashes list.mpcomplete@chromium.org2010-02-081-0/+3
| | | | | | | | BUG=35027 Review URL: http://codereview.chromium.org/589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38381 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: support dynamic labels in GtkMenusestade@chromium.org2010-02-081-6/+29
| | | | | | | | | BUG=32115 TEST=show app menu, then toggle bookmark sync (on->off or off->on), show app menu again and confirm that the sync label has changed Review URL: http://codereview.chromium.org/573037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38380 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in clear browsing data dialog where throbber would overlapsky@chromium.org2010-02-082-55/+35
| | | | | | | | | | | | flash link. BUG=35009 TEST=bring up clear browsing data, click clear browsing data and make sure throbber doesn't overlap flash link. Review URL: http://codereview.chromium.org/577054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38379 0039d316-1c4b-4281-b951-d872f2087c98
* Disable crashy WorkerTest.WorkerFastLayoutTests{0,1,2}phajdan.jr@chromium.org2010-02-081-13/+6
| | | | | | | | | | TBR=dimich TEST=stop crashing now! BUG=22898, 35023 Review URL: http://codereview.chromium.org/590002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38378 0039d316-1c4b-4281-b951-d872f2087c98
* accept NETSCAPE_URL drags in gtk tabstripestade@chromium.org2010-02-081-3/+7
| | | | | | | | | BUG=34141 TEST=see bug Review URL: http://codereview.chromium.org/570044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38372 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark context menu unforking:estade@chromium.org2010-02-0819-323/+703
| | | | | | | | | | | - create cross-platform BookmarkContextMenuController - use the new class on GTK (replacing BookmarkContextMenuControllerGtk) - keep using the old class on views (now named BookmarkContextMenuControllerViews) - add tests for the new BookmarkContextMenuController Review URL: http://codereview.chromium.org/577016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38371 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix valgrind AutocompleteTextFieldTest.shess@chromium.org2010-02-081-0/+8
| | | | | | | | | | | | http://codereview.chromium.org/577028 caught the change to the cell unit test, but didn't catch the field version. Pull in that change. BUG=34110 TEST=Valgrind stops complaining. Review URL: http://codereview.chromium.org/570061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38369 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure chrome.tab.executeScript runs in fragment-navigated frames.asargent@chromium.org2010-02-083-0/+11
| | | | | | | | | | | | | | | | | BUG=29541 TEST=Install a test extension that has a browser action that uses executeScript when you click on it to do something in the current tab like call alert (the bug report has one). Then: 1) navigate to any site like http://www.google.com/ 2) Add #foo to the end of url and hit enter. 3) Hit browser action button. 4) You should see the results. Review URL: http://codereview.chromium.org/566041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38368 0039d316-1c4b-4281-b951-d872f2087c98
* Mark known crash turning reliability red.avi@chromium.org2010-02-081-0/+4
| | | | | | | | BUG=http://crbug.com/35003 Review URL: http://codereview.chromium.org/586003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38367 0039d316-1c4b-4281-b951-d872f2087c98
* Make LASTCHANGE work properly for make build.mmoss@google.com2010-02-083-4/+9
| | | | | | | | BUG=22044 Review URL: http://codereview.chromium.org/579014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38366 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky win32 wifi provider test.joth@chromium.org2010-02-083-5/+7
| | | | | | | | | | | | | There was a race condition in provider startup; first call back might arrive before the listener was registerd. This was previous hidden by fact that - until r37850 - an empty wifi result set was always condidered 'different' to another set and so it would create constant stream of update callbacks (hiding the fact the first one maybe missed) BUG=http://crbug.com/34832 TEST=unit_tests.exe --gtest_filter=Win32* --gtest_repeat=10000 --gtest_break_on_failure Review URL: http://codereview.chromium.org/577047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38364 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in making a tab phantom. Here was the sequence when makingsky@chromium.org2010-02-082-19/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a tab phantom: 1. close the old contents (sending out TabClosingAt). 2. TabSelectedAt 3. TabReplatedAt The problem is is Browser::TabSelectedAt processes updates for the old contents, resulting in: 1. close the old contents (sending out TabClosingAt). 2. TabSelectedAt a UpdateTabContentsStateAt (for old tabcontents) b TabChangedAt (for old tabcontents) 3. TabReplatedAt So, 2b is sent for a tabcontents that observers was already told closed in step 1. This triggered a DCHECK in extensions code. I've changed it so we send out TabSelectedAt after the new contents are swapped in. I also fixed a bug where I wasn't telling observers the tab strip empty if the last non-phantom tab is made phantom. BUG=34137 TEST=none Review URL: http://codereview.chromium.org/579024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38363 0039d316-1c4b-4281-b951-d872f2087c98
* Export bookmark favicon (base64 encoded png). nkostylev@google.com2010-02-0810-41/+406
| | | | | | | | | | | Code for importing icons from bookmarks HTML file is already in place. BUG=11362 TEST=Export bookmarks to HTML file, delete all existing bookmarks, import file. Review URL: http://codereview.chromium.org/543202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38362 0039d316-1c4b-4281-b951-d872f2087c98
* Send window frame information to Mac plugins via IPCstuartmorgan@chromium.org2010-02-0815-19/+200
| | | | | | | | | | | | | | | | | | | Sends any window frame and relevent content view location changes to the plugin process via IPC, so that the plugin process always knows where the plugin is rather than only knowing when the mouse is within the plugin area. This will be necessary for supporting NPN_ConvertPoint, and for supporting Java2 as currently implemented. Related changes: - Now that window information is being sent on init and un-hide, use that to get correct initial window focus information. - Add a missing window focus change notification uncovered by the above. - Use live mouse location for idle events, instead of a cached location, now that we have live plugin frame information. - Refactor and simplify the logic for moving the plugin. Note that containing_window_frame_ is currently unused, but will be shortly for NPN_ConvertPoint, and is so closely related to the added IPC that I added it now rather than having to immediately change the new messages and functions. BUG=34046,31858,31543,29457 TEST=Mouse tracking in Carbon plugins should still work correctly, even across window moves, info/bookmark bar show/hides, etc. (Automated tests of location tracking will follow shortly with full NPN_ConvertPoint implementation.) Review URL: http://codereview.chromium.org/573015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38361 0039d316-1c4b-4281-b951-d872f2087c98
* Mark NPAPIVisiblePluginTester.VerifyNPObjectLifetime as FLAKY.phajdan.jr@chromium.org2010-02-081-1/+2
| | | | | | | | | | TBR=jam TEST=none BUG=34997 Review URL: http://codereview.chromium.org/583009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38359 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.MessagePorts as FLAKY.phajdan.jr@chromium.org2010-02-081-1/+2
| | | | | | | | | | TBR=dimich TEST=none BUG=34996 Review URL: http://codereview.chromium.org/573057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38357 0039d316-1c4b-4281-b951-d872f2087c98
* Mark WorkerTest.WorkerHttpLayoutTests as FLAKY.phajdan.jr@chromium.org2010-02-081-1/+2
| | | | | | | | | | TBR=dimich TEST=none BUG=16934 Review URL: http://codereview.chromium.org/577049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38356 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionApiTest.ExecuteScript DISABLED because it's not only flaky,phajdan.jr@chromium.org2010-02-081-3/+3
| | | | | | | | | | | | | | | but crashy and it has been ignored for weeks! It's EXTREMELY flaky, #1 flaky test of all time with over 600 flips in the last three weeks. This test seriously needs some love. TBR=rafaelw TEST=none BUG=28630 Review URL: http://codereview.chromium.org/574030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38355 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully final attempt at landing ↵joth@chromium.org2010-02-082-0/+397
| | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Adds tests for network geolocation provider. In the end, it seems templated static methods cannot be called from gtest's SetUp method on a Mac Release build. Beats me. I'm doing my stuff in the c'tor for now, and made a note to come back to it. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38354 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 320.0 to 321.0chrome-release@google.com2010-02-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 34343: "Tab to search" hint on omnibox disappears on drag dropped tab.suzhe@chromium.org2010-02-081-0/+3
| | | | | | | | | BUG=34343 TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there. Review URL: http://codereview.chromium.org/576013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38347 0039d316-1c4b-4281-b951-d872f2087c98
* Move candidate_window from third_party/chromeos_text_input to ↵satorux@chromium.org2010-02-082-0/+977
| | | | | | | | | | | | | | | | | | | chrome/browser/chromeos/text_input. Turned out there is no benefit of having this in a separate git repository. No code change in candidate_window.cc, but modified the copyright notice from Chromium OS Authors to Chromium Authors. Slightly modified text_input.gyp to make it compile. We'll also change cros_deps/DEPS in a separate CL. BUG=none TEST=confirmed candidate_window compiles as before. Review URL: http://codereview.chromium.org/579026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38345 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Animation::CurrentValueBetween and gets rid of a bunch ofsky@chromium.org2010-02-075-85/+55
| | | | | | | | | | | duplicate code. BUG=none TEST=none Review URL: http://codereview.chromium.org/570055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38330 0039d316-1c4b-4281-b951-d872f2087c98
* Further divide PLT metrics based on cache policyjar@chromium.org2010-02-072-30/+138
| | | | | | | | | | | | | Divided the case of link-navigation based on whether the cache was being used. Many histograms were further divided. I depricated one enum so that the existing histogram could be compared better. r=darin Review URL: http://codereview.chromium.org/582010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38329 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38323 - Add IPv6 probing support, and disable IPv6 resolution when it ↵jar@chromium.org2010-02-071-13/+1
| | | | | | | | | | | | | | | | | | is useless I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution. I've also added histograms and A/B test support to evaluate the impact of this change. r=wtc,eroman Review URL: http://codereview.chromium.org/579010 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/582011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38327 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPv6 probing support, and disable IPv6 resolution when it is uselessjar@chromium.org2010-02-071-1/+13
| | | | | | | | | | | | | I've added minimal probing to check if IPv6 is at all possible, and when it is not, then we disable IPv6 resolution. I've also added histograms and A/B test support to evaluate the impact of this change. r=wtc,eroman Review URL: http://codereview.chromium.org/579010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38323 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Honor modifiers for clicks on home button.thakis@chromium.org2010-02-071-724/+46
| | | | | | | | | | | xib change: Change connection from "commandDispatch:" to "commandDispatchUsingModifiers:" for home button. BUG=34900 TEST=Enable home button in "Basics" in the prefs. Cmd-clicking the home button should open home page in new tab. Review URL: http://codereview.chromium.org/582009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38319 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38316 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-02-061-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38314 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeOS Bustage: Use string16 instead of wstring.ben@chromium.org2010-02-065-6/+6
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/573048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38313 0039d316-1c4b-4281-b951-d872f2087c98
* Make basic side tabs actually appear.ben@chromium.org2010-02-0610-13/+268
| | | | | | | | | http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/572041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38312 0039d316-1c4b-4281-b951-d872f2087c98
* Updated string translations from TC (for 4.1)oritm@google.com2010-02-06102-2161/+3662
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38309 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38307 - Test to see if IPv6 can be disabled: Will roll back ASAPjar@chromium.org2010-02-061-1/+1
| | | | | | | | | | | | | This tests to see what happens if the command line option disables IPv6. I will roll back as soon as the builders start. TBR=eroman Review URL: http://codereview.chromium.org/579022 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/579023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38308 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if IPv6 can be disabled: Will roll back ASAPjar@chromium.org2010-02-061-1/+1
| | | | | | | | | | This tests to see what happens if the command line option disables IPv6. I will roll back as soon as the builders start. TBR=eroman Review URL: http://codereview.chromium.org/579022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38307 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 319.0 to 320.0chrome-release@google.com2010-02-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38304 0039d316-1c4b-4281-b951-d872f2087c98
* Rework nonclient hittest plumbing so the NonClientFrameView is responsible ↵pkasting@chromium.org2010-02-064-10/+21
| | | | | | | | | | for the whole window's hit testing. Make use of this in the glass frame to add support for HTSYSMENU. Doing this in the opaque frame will be more complex, so that's coming next. BUG=6961 TEST=Single- and double-clicks on the upper left corner of a Chrome window in Aero glass mode should trigger the system menu and the window closing, respectively. Review URL: http://codereview.chromium.org/573042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38301 0039d316-1c4b-4281-b951-d872f2087c98
* Change how the opaque frame lays out its titlebar. This takes advantage of ↵pkasting@chromium.org2010-02-062-113/+76
| | | | | | | | | | | | a system metric I didn't know about to both simplify the code and correctly handle (by which I mean "lay out more like a native window") the case when the user's theme has a large titlebar height but not a large titlebar font. Doing this makes icon layout simpler and more native, which will help when trying to modify hittesting to return HTSYSMENU. BUG=none TEST=In Classic mode, setting the Active Title Bar height larger and then running Chrome should cause popup and app windows' icons to scale up like native windows' icons do. Review URL: http://codereview.chromium.org/573040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38300 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix use-after-free when dragging tabs with page-actions.shess@chromium.org2010-02-064-24/+35
| | | | | | | | | | | | | | | | | | | When dragging and dropping a tab who's window is going away entirely, the LocationBarViewMac instance and the PageActionViewList w/in go away before the cell. Sometimes windows can re-display while being closed, then BANG. Converted page_action_view_list_ from a pointer because it didn't seem to need to be one anywhere. Also plug leak of views_ elements. BUG=34110 TEST=Install an extension which shows a page action (*). Bring up two tabs, drag one with the page action off to a separate window. Drag it back into the first window. (*) For instance, the "Subscribe in Feed Reader" example at http://code.google.com/chrome/extensions/samples.html , then browse to Google News to get a page action. Review URL: http://codereview.chromium.org/577028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38299 0039d316-1c4b-4281-b951-d872f2087c98
* Pass login-manager switch value to login wizard to determine which screen toavayvod@chromium.org2010-02-068-100/+204
| | | | | | | | | | | | | start with. Refactored LoginObserver to ScreenObserver that could be used by other screens as well. BUG=34716 TEST=Currently there just should be no regression for Chrome based login manager. Review URL: http://codereview.chromium.org/574014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38297 0039d316-1c4b-4281-b951-d872f2087c98
* Delete HTML5 database in BrowsingDataRemover, part 1.jochen@chromium.org2010-02-063-3/+63
| | | | | | | | | | | This part deletes databases except for when they're currently used by a renderer. BUG=34633 TEST=open the webkit html5 database demo, create some notes. close the tab. clear browsing data. open the demo again. notes should be gone. Review URL: http://codereview.chromium.org/570032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38296 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flaky unit testhclam@chromium.org2010-02-061-1/+1
| | | | | | | | | | | | | This test is flaky and is disabled: Win32WifiDataProviderTest.StartThreadViaDeviceDataProvider BUG=34832 TEST=none TBR=joth Review URL: http://codereview.chromium.org/577036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38290 0039d316-1c4b-4281-b951-d872f2087c98
* Makes mini-tabs work on the UI side (at least for views). I still havesky@chromium.org2010-02-0617-433/+473
| | | | | | | | | | | a handful of things to resolve before I turn on pinning. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
* Implement copy/paste of bookmarks for macfeldstein@chromium.org2010-02-066-18/+267
| | | | | | | | | | | Implements Copy, paste, and can paste as extension apis for use in the extension bookmark manager. BUG=33461 TEST=Copy and paste single and multiple bookmarks in the extension bookmark manager, and between it safari's bookmark manager and plain text fields. Review URL: http://codereview.chromium.org/562010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38286 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where reloading an extension from an infobar when another window ↵andybons@chromium.org2010-02-061-5/+6
| | | | | | | | | | | does not have that infobar open but has another crashed extension's infobar hoses the browser. Phew. BUG=34683 TEST=follow repro steps in bug. should not crash. Review URL: http://codereview.chromium.org/572045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38285 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the AutoFillManager as an observer of the PersonalDataManager in the ↵jhawkins@chromium.org2010-02-061-0/+1
| | | | | | | | | | constructor. In rare circumtances, the user can close the browser (and shutdown the AutoFillManager) after we've set ourselves as observers of the PersonalDataManager and before the PersonalDataManager has called us back. BUG=none TEST=none Review URL: http://codereview.chromium.org/579013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38284 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the toast to append "--system-level" if a system-level install is ↵gwilson@google.com2010-02-061-2/+5
| | | | | | | | | | | | | | | | | | attempting to relaunch setup. The launch flow as it exists now is: Update -> setup.exe --system-level-toast --> setup.exe --inactive-user-toast=0 the modified flow will be: Update -> setup.exe --system-level-toast --> setup.exe --inactive-user-toast=0 --system-level R=cpu BUG=none TEST=Run setup.exe --system-level-toast with a system-level install. Toast should show. Review URL: http://codereview.chromium.org/581003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38283 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-063-12/+49
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't let omnibox popup text tighten while resizing.shess@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | | | | Sets the tightening factor to 0.0 so that the popup text doesn't tighten then rebound after being elided. BUG=24296 TEST=Get the omnibox popup up, resize the window smaller, all the left-hand-side text which stays should be rendered in a stable position (right-hand-side text may shift as LHS text is elided, but the spacing between characters should stay the same). Review URL: http://codereview.chromium.org/577029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert debugging crud I added while trying to track down bug 31719.erg@chromium.org2010-02-053-105/+16
| | | | | | | | | | | | Revert "Speculative fix for the windows theme crasher." (r36036) Revert "More debugging statements to try to track down BrowserThemePack crash." (r37259). BUG=31719 TEST=none Review URL: http://codereview.chromium.org/573036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38279 0039d316-1c4b-4281-b951-d872f2087c98