| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Removes confusion with the new "fake window" code related to the GPU process, and makes the name better reflect the reality of how the Carbon plugin windows are actually used since we no longer expect to replace them entirely with interposing.
BUG=none
TEST=none (no behavioral changes)
Review URL: http://codereview.chromium.org/660407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MD5 checksum verifies that the file read is the file that was written.
Also added sanity checks for the file header to prevent interpretting
random garbage as a valid count. Unit test corruption-detection.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660334
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When OnItemsRemoved() is called, we remove the items one by one. If there is more than one item being removed, we may ask the model about items that no longer exist.
This fix is speculative in the sense that I couldn't repro the crash.
BUG=37115
TEST=none
Review URL: http://codereview.chromium.org/660351
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Hypothetical" because the way this object is used right now, |event| will always be NULL anyway.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=36640
TEST=none
Review URL: http://codereview.chromium.org/661393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=37244
Review URL: http://codereview.chromium.org/661411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37048
TEST=Run browser, kill the renderer to get the sad tab, refresh the tab.
The contents of the tab should be displayed.
Review URL: http://codereview.chromium.org/660262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
code between windows and linux.
BUG=None
TEST=compiles, and still works as before.
Review URL: http://codereview.chromium.org/661225
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not send extra blur and focus events if popup menu is showing
Add flag to RenderWidget to remember the popup menu state and
suppress focus / blur events when popup menu is showing. This
fixes the issue that extra focus / blur events are fired after
select control is clicked.
R=darin
BUG=23499
TEST=none
Review URL: http://codereview.chromium.org/647047
TBR=victorw@chromium.org
Review URL: http://codereview.chromium.org/660408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subclass TreeModelObserver specifically for the CookiesTreeModel so that we can
send TreeModelBatchBegin() and BatchEnd() notifications before and after local
storage, databases, and appcache entries load, respectively.
This also rewrites CookiesTreeModelObserverBridge::FindCocoaNode() to do
breadth-first search, rather than a pre-order traversal as we most often search
for origin nodes, which are at depth 1.
BUG=35134
TEST=Get a profile with 1K local storage entries. Chromium-->Preferences-->Under the Hood-->Content Settings-->Cookies should not be slow/janky.
Review URL: http://codereview.chromium.org/660251
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pinkerton
Review URL: http://codereview.chromium.org/661403
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37106 (I hope)
TEST=no visible change, just faster
Review URL: http://codereview.chromium.org/661396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in debug builds.
Review URL: http://codereview.chromium.org/660346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gets --enable-video-layering working when using the GPU backing store. No actual visuals yet, just IPC message passing and a lot of NOTIMPLEMENTED messages.
BUG=33329
TEST=try it out and see if you get lots of NOTIMPLEMENTED messages corresponding with video playback
Review URL: http://codereview.chromium.org/661344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Implement "Add page" and "Add folder".
2. Fix issue where dragging a folder to a subfolder regressed.
3. Disable "Open ..." on folders that have no bookmark descendandts.
4. Add bmm.TreeLoader so we can reuse the call to getTree.
5. Add bmm.TreeIterator so we do not have to duplicate tree traversal code.
6. Fix issue where fast changes in the tree caused infinite navigation hangs.
7. Add some more strings.
8. Remove old temporary hack for the strings since we really need the experimental API at this point anyway.
9. Prevent system beep on copy and cut.
BUG=32194, 36457, 36459
TEST=None
Review URL: http://codereview.chromium.org/660196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I left the tests marked Flaky, since I want to run on the bots to see
if it works before removing the label.
BUG=37109
TEST=This contains test changes.
Review URL: http://codereview.chromium.org/661394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on linux where host and target architecture are the same.
Review URL: http://codereview.chromium.org/660393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
empty URL but expecting the deferred URL).
BUG=37195,33572
TBR=wtc
Review URL: http://codereview.chromium.org/660396
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate stubs for OpenMAX IL so we don't need a real OpenMAX library for
building. The actual library is loaded during runtime.
TEST=Build is green
TEST=Running omx_test works on hardware with OpenMAX support
Review URL: http://codereview.chromium.org/661135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(apparently) other recent changes.
BUG=none
TEST=ran Pepper test plugin with both 10.6 and 10.5 code paths
Review URL: http://codereview.chromium.org/661391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FormManagerTest.Labels
Review URL: http://codereview.chromium.org/660154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r40185 (bug 36677) changed cocoa_test_helper.mm to allow more scalable
timeouts for valgrind.
BUG=36736
TEST=valgrind bots keep trucking.
Review URL: http://codereview.chromium.org/660389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread might still be inside its Signal() method.
TEST=none
BUG=32023
Review URL: http://codereview.chromium.org/661382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33329
TEST=try it out on linux!!
Review URL: http://codereview.chromium.org/661331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
now. The mac no longer needs 2 flags in order to load .nexes, it is only
behind the --internal-nacl flag like everyone else.
BUG=328 (tracked in the Native Client project)
TEST=Run Chrome on a Mac without the --enable-nacl-on-mac flag, and load a
.nexe. It should work.
Review URL: http://codereview.chromium.org/661370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reflect its relation to the Autocomplete feature.
BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/661323
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The only functional change should be that the app panel close button width is now its preferred width, not its preferred width + 4.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views: refactor out the "Alt" TableView feature.
BUG=34181
TEST=open bookmarks manager, type something in the search text-field, see if a
message is showed when there is no match and see if everything still works as
before.
Review URL: http://codereview.chromium.org/660380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37109
TEST=None
TBR=nsylvain
Review URL: http://codereview.chromium.org/661383
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a warning to the incognito new tab page that your extensions are
disabled in that mode.
- Toggling an extension in incognito will reload the extension, fixing a bug
where browser actions in existing incognito windows would not get updated.
BUG=36292
BUG=32365
TEST=run chrome with --enable-experimental-extension-apis and some extensions loaded, and open an incognito window. Enable some extensions in incognito and make sure things work.
Review URL: http://codereview.chromium.org/660220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151
Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.
Review URL: http://codereview.chromium.org/661290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37138
TEST=Valgrind reports no errors
Review URL: http://codereview.chromium.org/660322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14774
TEST=AutoamtedUITestBase.FLAKY_CloseTab stops being flaky?
Review URL: http://codereview.chromium.org/660324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
TBR=mmoss
Review URL: http://codereview.chromium.org/661374
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Keychain.
BUG=34607
TEST=KeygenHandlerTest.SmokeTest
Review URL: http://codereview.chromium.org/652137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=27365
TEST=none
Review URL: http://codereview.chromium.org/661187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37117
TEST=as in comment 2 of bug.
Review URL: http://codereview.chromium.org/661310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37077
TEST=as in bug; drag off a tab and it should stay themed
Review URL: http://codereview.chromium.org/660302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37078
TEST=as in bug
Review URL: http://codereview.chromium.org/660307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/36794
TEST=as in bug
Review URL: http://codereview.chromium.org/660305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkBubbleControllerTest needs _three_ passes. I believe it's
because the bubble is a child window.
BUG=none
TEST=allows test to run on tsan bots.
Review URL: http://codereview.chromium.org/661347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
message without calling DefWindowProc we don't get OnSize notification.
BUG=36280
TEST=See steps to reproduce in the bug.
Review URL: http://codereview.chromium.org/660087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces one more dependency on chrome/browser,
but it seems simpler to move gtk_util first and then fix it.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
replacement preceeds ? sign.
BUG=19718
Patch by glotov@chromium.org
Original review http://codereview.chromium.org/601004
TEST=Verify that slash is escaped as stated in description; example: create
search engine en.wikipedia.org/%s and search it with parameters wiki/hi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix an unrelated TODO in this area.
xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView.
BUG=36949
TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected.
Review URL: http://codereview.chromium.org/661354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Including some changes to make things testable, including adding WebDatabase* to the ctor of the MA and PC, plus making some methods virtual on WebDatabase.
Review URL: http://codereview.chromium.org/661316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This forces implementations to consider each case, and avoids subtle bugs that can happen by using the default no-op implementation (like bug 36964).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/661236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enabling the tests that were disabled in the first pass.
Also changing how we substitute localization values (using direct method that avoids flashing __MSG__const while the page is loading).
Also made some minor fixes after testing various locales.
BUG=37109
TEST=This CL is about enabling automated tests.
Review URL: http://codereview.chromium.org/660328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40354 0039d316-1c4b-4281-b951-d872f2087c98
|