| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The observer requires that message loop stays up and same through
its lifetime. This is not true during testing.
TEST=none
http://crbug.com/12187
Review URL: http://codereview.chromium.org/113824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=visit an IDN URL, and open the "Basics" tab of the "Options"
dialog, select "Open the following pages", press "Add..." button,
select the IDN URL, and confirm that the URL field is shown in
Unicode, or
paste a Punycode URL to the URL field of the "Add page" dialog,
press "Add" button, and confirm that the "Open the followig pages"
list shows the Unicode URL.
http://crbug.com/3991
Patch by tkent
Original review: http://codereview.chromium.org/115759
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of Punycode host name.
http://crbug.com/4008
TEST="Copy link address" copies Unicode host name for both of <a href="punycode
URL"> and <a href="Unicode URL"> if Accept-Language preference is matched.
Patch by tkent
Original review: http://codereview.chromium.org/115752
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113886
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
data_len can be greater.
TBR=evan
BUG=none
TEST=should work on window managers that support the wm-spec.
Review URL: http://codereview.chromium.org/113884
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
reverted.
Review URL: http://codereview.chromium.org/113885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be heightened just a bit.
BUG=11487
TEST=Open Clear Data Dialog on XP with Classic Theme and the button should not overlap the combo box.
Review URL: http://codereview.chromium.org/113880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115778
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes another large fonts issue.
BUG=12573
TEST=toolbar should look like it does on windows (where there is spacing, the size of it, etc.)
Review URL: http://codereview.chromium.org/115792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/11824
TEST=Run CHrome with '--lang=ta' with Firefox runing. Try to import bookmarks and settings
from Firefox into Chrome. The dialog box alerting that Firefox is running should not be truncated.
Review URL: http://codereview.chromium.org/113516
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in an incognito window is in sync with all other download managers.
BUG=11514
TEST=Open a download manager (Ctrl+J) and an incognito window with a
download manager (Ctrl+Shift+N followed by Ctrl+J). Then start to download a
file and note that both download managers should get updated. Try pausing and
eventually click "Remove all" in either DM and all downloads should get removed
from both DMs.
Review URL: http://codereview.chromium.org/115804
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/113879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/115806
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1) We shouldn't use CHECK for situations that can reasonably occur.
2) We need to recover from the case where this WORKAREA property isn't
available.
Review URL: http://codereview.chromium.org/113877
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following errors when building unit_tests:
undefined reference to `google_breakpad::WriteMinidump(char const*, int, void const*, unsigned int)'
undefined reference to `UploadCrashDump(char const*, char const*, unsigned int)'
Review URL: http://codereview.chromium.org/113876
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
window_sizer to the Linux build.
Review URL: http://codereview.chromium.org/115803
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9607
TEST=Download a large file and go to the download manager (Ctrl+J). The
remaining time of your current downloads should decreasen as the download is
getting closer to being done.
Review URL: http://codereview.chromium.org/115797
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
Requires:
- making SetOpacity a cross platform method on Widget, replacing SetLayeredAlpha.
- moving Window::SetBounds to Widget
- replacing usage of MoveWindow in StatusBubbleViews with call to new SetBounds method.
BUG=none
TEST=make sure transparency still works for floating widgets like - status bubble, full screen exit bubble, dragged tabs
Review URL: http://codereview.chromium.org/113846
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the chrome window closes content popups.
We need to grab all X mouse events using gdk_pointer_grab. This
prevents other windows from getting focus.
We no longer need the focus-out-event signal handler because we'll
get the mouse down outside the browser window, forward it to the
renderer, and it will tell us to close.
I verified manually that killing the renderer while the popup is
showing results in gdk_display_pointer_ungrab getting called. If the renderer hangs, the user just needs to click outside the popup.
Review URL: http://codereview.chromium.org/112052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113873
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
its own window. This change also removes code that was overriding the requested size as a temporary workaround.
BUG=none
TEST=Open a browser window with two tabs. Drag one of the tabs out of the tabstrip. A new window should be created where the mouse is positioned.
Review URL: http://codereview.chromium.org/113874
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We currently register gears in JS-land, despite it not working in
browser-land. We should disable it everywhere until it works.
BUG=12529
Review URL: http://codereview.chromium.org/113870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10005
Review URL: http://codereview.chromium.org/115723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(For reference, it was committed with the wrong message: "Patch to make
password patch build.")
This reverts commit r16708.
Review URL: http://codereview.chromium.org/113871
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115801
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115802
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for resource loading for media file has
a problem in determining the wait condition that it
waited for one extra cycle (about ~5s) to know that
the resource loading has completed, it is fixed in
this patch. Also made clear about the logic in it.
Review URL: http://codereview.chromium.org/113861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
cross-platform.
Review URL: http://codereview.chromium.org/115799
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were crashing while trying to load fonts. Your patch for font
fallback fixes the crash.
Review URL: http://codereview.chromium.org/112061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 071e95bcdcefcd2cb86c9aed5cb073bbcaa7f2a7.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113863
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
previous change that used the wrong parent variable when showing HTML dialogs.
Review URL: http://codereview.chromium.org/113864
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This checkin adds gmock, and a small example of how to write a gmock-based unittest.
Review URL: http://codereview.chromium.org/113807
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
first-run dialogs.
Review URL: http://codereview.chromium.org/113858
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash handler should not print garbage to the console following the crash id.
Review URL: http://codereview.chromium.org/115796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r16889 triggered some warnings with GCC 4.3: http://pastebin.com/m3a9415af
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115784
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/12555
TEST=Browse to a page. Bring up a new tab (Command-t), should be able to start typing in autocomplete.
http://crbug.com/12556
TEST=With a partial URL entered, switch tabs, and switch back. Should be able to type to replace autocomplete. This does not fix the entire bug.
Review URL: http://codereview.chromium.org/115734
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ever receiving a drag-motion signal. In this case we'd crash because dragged_tab_ isn't created yet.
BUG=12473
TEST=Open a browser with three tabs. Rapidly click on the first and third tabs. This should not cause the browser to crash.
Review URL: http://codereview.chromium.org/113854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's still used by the unit test.
TBR=erg
Review URL: http://codereview.chromium.org/115791
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16904 0039d316-1c4b-4281-b951-d872f2087c98
|