| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=right click on a tab and see a context menu popup (i.e. no regression). Also, right click, hold, drag, release to select an item.
Review URL: http://codereview.chromium.org/118023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/115935
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
also improve the look of the instructions label.
Review URL: http://codereview.chromium.org/112070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This didn't appear to prevent Visual Studio from building, but did trip up Incredibuild.
Review URL: http://codereview.chromium.org/118006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115905
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
variable for the 'OS=="win"' targets that use it, to work around
an apparent problem in the gyp variable expansion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It also makes sure that engines which have been removed from Firefox
are not imported into Chrome.
BUG= http://crbug.com/12245
TEST= Install firefox, and do not change the default search engines.
Start Chrome, and import search engines from Firefox. Default Firefox
engines should now be part of Chrome.
Review URL: http://codereview.chromium.org/115895
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/118009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115929
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/114063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115924
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file.
BUG=none
TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance.
Review URL: http://codereview.chromium.org/112065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
Review URL: http://codereview.chromium.org/115870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- miscellanous cleanups (whitespace, explicit deps)
Review URL: http://codereview.chromium.org/113945
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
would allow to select dispatcher wothout parsing the message argument.
Review URL: http://codereview.chromium.org/115862
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and clean up some things:
* Make <(grit_out_dir) a top-level variable, used by multiple targets.
* Add precompiled.{cc,h} to various targets: common and plugin.
* Add precompiled_wtl.{cc,h} to various targets: renderer, unit_tests,
and url_fetch_test.
* Add browser/net/test_url_fetcher_factory.cc to unit_tests.
* Add dependencies on net_resources and webkit_resources to unit_tests
and interactive_ui_tests.
* Add a dependency on test_support_common to page_cycler_tests.
* Add a dependency on net to url_fetch_test.
* Pull in all of the installer/installer.gyp targets.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/112068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115914
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls the base class impl first.
Fix compile bustage by not compiling windows-specific code on other platforms.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/114059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=visit about:crash, no dump file left over in /tmp.
Review URL: http://codereview.chromium.org/113984
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unneeded methods from NativeTabContentsContainerWin.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115903
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a quick hack, that will be replaced once we have the rest of prefs
implemented.
BUG=12736
Review URL: http://codereview.chromium.org/113977
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
accept the user's text.
Review URL: http://codereview.chromium.org/114058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vista without hebrew support
the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093)
the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least
BUG=12093
TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl".
Review URL: http://codereview.chromium.org/115849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the buildbot archive hermetic for package building, rather than
pulling files from the package builder's source tree (e.g. BRANDING) and system
(e.g. lib32 stuff).
Note, this currently only applies to official builds since that's all we package.
This depends on:
http://codereview.chromium.org/115842
http://codereview.chromium.org/113966
Review URL: http://codereview.chromium.org/115843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page. This allows faster prototyping (F5) of the NNTP.
TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should
show the file. Make a visible change in the file and reload the tab page and
the change should be visible immidiately.
BUG=None
Review URL: http://codereview.chromium.org/113927
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
One visible change: new tab page has Google icon, not Chromium.
Gyp doesn't have a set environment variable facility; hence the
addition of a command line option to grit.
Review URL: http://codereview.chromium.org/113974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/115879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately.
BUG=10558
Review URL: http://codereview.chromium.org/115885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ignore these keypresses.
BUG=6992
TEST=Type a letter so the omnibox dropdown shows. Press alt-down. If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear). If you used the standalone arrow keys, the selection should move down one row.
Review URL: http://codereview.chromium.org/115891
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It mostly confuses the press.
Review URL: http://codereview.chromium.org/113978
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12174
Review URL: http://codereview.chromium.org/115893
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12844
TEST=Install Chromium and make sure gears.dll is present.
Review URL: http://codereview.chromium.org/113976
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
too.
BUG=5372
TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7. You should navigate to your home page (by default, the new tab page).
Review URL: http://codereview.chromium.org/113971
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space.
Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton).
BUG=12829
TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior.
Review URL: http://codereview.chromium.org/113970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should have been in my earlier CL, but I had a gcl fail.
TBR=darin
BUG=None
TEST=No behavior change
Review URL: http://codereview.chromium.org/112067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux first run dialog should be properly styled?
Review URL: http://codereview.chromium.org/115890
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.
This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.
This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496
bug=12850
r=raman
Review URL: http://codereview.chromium.org/113473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115878
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115869
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Custom start urls and default search options widgets aren't hooked up.
Home page settings work, but are overridden by the linux start page settings.
Default browser checking/setting functions are not implemented, so the option
isn't useful yet.
Refactors some common code out of browser/views/options/options_page_view.*
into browser/options_page_base.{cc,h}
BUG=11507
Patch by Matt Mueller (mattm@google.com).
Review URL: http://codereview.chromium.org/113967
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113965
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17113 0039d316-1c4b-4281-b951-d872f2087c98
|