| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 52072 - Pass notifications to the browser on access to the appcache main resource manifest.
BUG=45230
TEST=browser_tests
Review URL: http://codereview.chromium.org/2808046
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/2925008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
manifest.
BUG=45230
TEST=browser_tests
Review URL: http://codereview.chromium.org/2808046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicate the tab being dragged is getting deleted between the time we
detach from the model and update the DraggedTabView. This could happen
if the animation were canceled (as could happen if a layout
happened). I don't see how that could happen though. None-the-less
it's easy to deal with the tab going away as it isn't needed when
dragging. This may end up shifting the crash around though, we'll see.
I'm also removing some dead code in the DraggedTabView that is no
longer needed as we only used DraggedTabView for the detached state.
BUG=48365
TEST=make sure tab dragging on windows still works.
Review URL: http://codereview.chromium.org/2924003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, never show bookmarks bar on app tabs.
BUG=45540
TBR=erg
original review: http://codereview.chromium.org/2854038/show
Review URL: http://codereview.chromium.org/2955006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
their status.
BUG=disabled test
TEST=green bots
Review URL: http://codereview.chromium.org/2903005
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/2891010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=disabled test
TEST=green bots
Review URL: http://codereview.chromium.org/2903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 52054 - Refactor json automation interface for pyauto hooks.
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.
Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.
Review URL: http://codereview.chromium.org/2898001
TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/2977001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method is not called by anyone. We use StatusTray::CreateStatusIcon instead
to create a new icon.
BUG=37375
TEST=manually and trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2975002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test is disabled for now since we don't have a fix yet. The point
of checkin in this CL is to make it easier for us to test alternate
approaches to fixing.
BUG=43448
TEST=RenderProcessHostTest.ProcessOverflow
Review URL: http://codereview.chromium.org/2928004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We know that on certain machines the Seatbelt library is borked and even a simple test program that initializes the sandbox fails.
There is already a CHECK() in chrome_dll_main() that fires if the Sandbox didn't initialize correctly. This CL changes all sandbox failures to LOG(FATAL)s so we get different stack signatures when we crash.
BUG=44761
TEST=Browser & Unit tests should continue to function correctly.
Review URL: http://codereview.chromium.org/2861046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reduces the number of lines you need to add per new automation hook. Shaves
off several lines of code.
Refactor pyauto.py to obviate raising exception in case the json interfaces produces an error string.
Review URL: http://codereview.chromium.org/2898001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
scripts from 1 to 4.
Also adds a command line flag to override the default: --num-pac-threads=X
BUG=11079
Review URL: http://codereview.chromium.org/2893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2898005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2898006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extension.
BUG=40745
TEST=none
Review URL: http://codereview.chromium.org/1098005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
called with zero downloads.
CID=9160
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/2934002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to implement 3605. I created separate notification as we're planning to port to other platfrom.
BUG=chromium-os:3605
TEST=added browser test
Review URL: http://codereview.chromium.org/2913001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
never get read from again.
r=jar
Review URL: http://codereview.chromium.org/2925006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48690
Review URL: http://codereview.chromium.org/2896007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add automation hooks to:
- install a given theme
- fetch info about the current theme
- reset to default theme
Add a test exercising the above.
BUG=36215
TEST=python chrome/test/functional/themes.py
Review URL: http://codereview.chromium.org/2827048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51494
Review URL: http://codereview.chromium.org/2822044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process to the browser process.
BUG=38736
TEST=unittest added
Review URL: http://codereview.chromium.org/2805029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34647
TEST=built on all platforms
Review URL: http://codereview.chromium.org/2970001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change detects if there is a chance that a proxy MIGHT
be used to perform a connection, and if so, it avoids doing
any speculative preconnections, or speculative DNS
pre-resolution.
For testing purposes, a flag is provided to avoid this
probe for proxy status. If you enable --preconnect-despite-proxy
then preconnection will take place (as appropriate) even
if there is a chance that a proxy might be used
for connections to some hosts.
BUG=47906
r=eroman
Review URL: http://codereview.chromium.org/2871038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to add an AudioInputController for audio recording in subsequent changes.
BUG=none
TEST=no functional change
Review URL: http://codereview.chromium.org/2964005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2956002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests. The VerifyHistoryLength3
was broken during refactoring as it needs navigation to page1 followed by navigation to page 2, etc.
The length checks were also broken in the test pages.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=39785
Bug=39785
Review URL: http://codereview.chromium.org/2923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is just the HTML and CSS and the skeleton of some of the JavaScript. Only the checkbox for the Home button currently works. Remaining functionality will be added over time.
BUG=48713
TEST=Basics page in options should show options; "Show Home button" should work.
Review URL: http://codereview.chromium.org/2972001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
exclude conditionally, rather than including conditionally. This way, functions like MSVC's "search in entire project" will still catch the excluded file content.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2907008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
run after it.
BUG=48717
TEST=none
TBR=dmazzoni
Review URL: http://codereview.chromium.org/2923004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48712
TBR=jrg
Review URL: http://codereview.chromium.org/2971001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previously disabled in ChromeOS.
BUG=chrome-os:4073
TEST=open about:system, right mouse click and pick Save As menu item
Review URL: http://codereview.chromium.org/2880009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Forward declare printing::PrintViewManager in TabContents
- tab_contents.h shouldn't depend on autocomplete_edit.h
- Pull logging out of Browser through PageTransitionTypes
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4659
TEST=none
Review URL: http://codereview.chromium.org/2957005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to run the sync integration tests on the chromium
buildbots, we need a way to load the GAIA credentials from a local password file
instead of via command line parameters.
This changelist implements a new command line parameter called
"--password-file-for-test" for this purpose.
==================================================
NOTE: This code was originally checked in as http://codereview.chromium.org/2899001, but checkin http://codereview.chromium.org/2850042 broke it, resulting in the original checkin being reverted with http://codereview.chromium.org/2905004.
This is a new attempt at checking in the code, where password_file_ is a FilePath instead of a wstring.
BUG=48525
TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file
Review URL: http://codereview.chromium.org/2899006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=45510
Review URL: http://codereview.chromium.org/2918003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46528
TEST=mini_installer.exe --installerdata=<file_path>
Review URL: http://codereview.chromium.org/2962004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the root view Layout code which does not give
the child views a chance to process the layout if a layout manager existed for the root view. The default layout manager for
the root view is the FillView.
Fix is to handle layout correctly in the ExternalTabContainer in the InfoBarSizeChanged notification by maintaining the current
grid view in a member and invoking layout on it.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=48569
Bug=48569
Review URL: http://codereview.chromium.org/2963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2836046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan,estade
BUG=51974
TEST=went green locally.
Review URL: http://codereview.chromium.org/2900004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
away from the default theme. This is to avoid the server-wins logic from
overwriting custom themes for new sync clients. With this patch, the first
non-default theme that gets synced will be propagated to all clients.
BUG=48155
TEST=manually tested
Review URL: http://codereview.chromium.org/2946001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm having a hard time reproing this hang locally -- I ran the test for several days on windows with no hangs. So this change should prevent any individual test in this test from hanging and hopefully help provide some helpful info when it hangs again.
And since the tests won't hang anymore, I believe we can make them FLAKY.
BUG=39070
Review URL: http://codereview.chromium.org/2864043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The heuristic should catch these. Keeping the list just makes it harder to find problems
with the heuristic.
BUG=none
TEST=Still no infobars for single-word queries on any networks.
Review URL: http://codereview.chromium.org/2917007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being used until the maximum size is reached.
BUG=48494
TEST=create notifications of various sizes, watch for jitter
Review URL: http://codereview.chromium.org/2941003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and scripts to run on the Chrome Extensions Gallery site. There are
security concerns in enabling this and so it remains off by default,
but this is needed for automation testing of the gallery.
Cleanup: Have UserScriptSlave::InjectScripts() return void instead of a bogus bool.
TEST=Visit http://chrome.google.com/extensions, check that content scripts work when the command-line switch is given, and are not injected when the switch is not given.
BUG=none
Review URL: http://codereview.chromium.org/2912002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ThemeChangeProcessor, since the error will clear the profile_ without returning, and the profile is accessed later. Since the code discusses how to process deletes, I think this is the correct fix.
BUG=none
TEST=sync themes and then delete it
Review URL: http://codereview.chromium.org/2913006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51976 0039d316-1c4b-4281-b951-d872f2087c98
|