| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the preference to persist IDs.
NOTE that we need to save the file the first time with IDs
since existing bookmark files won't have IDs and the file
won't be saved until something changes in the bookmark model.
So we need to explicitly save once when we assign ids for the
first time.
TEST=NONE
BUG=16068
Review URL: http://codereview.chromium.org/149310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and replace it with a pump for null events on the plugin thread. This removes
a deadlock that the previous code inadvertently created, and is a much more
focused solution to the problem.
BUG=10809
TEST=none
Review URL: http://codereview.chromium.org/155439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16634
TEST=not yet
Review URL: http://codereview.chromium.org/149544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Please try not to use SolutionDir when you mean ProjectDir -- it prevents
building the project from any directory other than the solution directory.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed the way port IDs work internally to reduce confusion. Each end of the port has its own ID, not the ID of its opposite end.
BUG=13706
TEST=no
Review URL: http://codereview.chromium.org/155381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
supposed to point at the build output directory, not the intermediate obj directory.
TBR=slightlyoff, stoyan
Review URL: http://codereview.chromium.org/155436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Checking in on a closed tree because Brett thinks it'll fix layout tests.)
Review URL: http://codereview.chromium.org/149557
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
until we get the new process hooked into the testing harness.
Review URL: http://codereview.chromium.org/149551
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15811
TEST=Browse to www.google.com. Focus is in document. Click Go. No more crash.
Review URL: http://codereview.chromium.org/149487
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous version was perhaps too optimal. This should be reasonable
for now since it only happens at the pace the user can enter input.
http://crbug.com/14628
TEST=Browse to www.google.com. Copy/paste the entire URL. Should be styled.
Review URL: http://codereview.chromium.org/149489
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I went auditing around, and AFAICT all remaining callers should be
fine with selecting everything.
http://crbug.com/12246
TEST=Type some stuff in address bar. With cursor in bar, Command-l should select all.
Review URL: http://codereview.chromium.org/149492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none (no functional change).
Review URL: http://codereview.chromium.org/149410
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This metadata request just returns a dummy string for the "metadata" scheme.
This doesn't do anything yet.
Review URL: http://codereview.chromium.org/149490
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
print a TabContents.
This is on the same lines as the existing sync message AutomationMsg_PrintNow
Review URL: http://codereview.chromium.org/149468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
it easier to add new constants.
Review URL: http://codereview.chromium.org/155407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
attempt.
BUG=16606
Review URL: http://codereview.chromium.org/149529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Memory Leak: (40 bytes, 1 blocks) AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char) [unit_tests.exe]
Alloc Location
...
media/audio/win/audio_output_win.cc:126 AudioManagerWin::MakeAudioStream(Format::AudioManager,int,int,char)
chrome/browser/renderer_host/audio_renderer_host.cc:118 AudioRendererHost::IPCAudioSource::CreateIPCAudioSource(AudioRendererHost *,int,int,int,void *,Format::AudioManager,int,int,char,UINT,UINT)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:161 AudioRendererHostTest::CreateAudioStream(Format::AudioManager)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:174 AudioRendererHostTest::CreateMockStream(void)
chrome/browser/renderer_host/audio_renderer_host_unittest.cc:191 AudioRendererHostTest_MockStreamDataConversation_Test::TestBody(void)
testing/gtest/src/gtest.cc:2031 testing::Test::Run(void)
^^^
Review URL: http://codereview.chromium.org/149536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155060
This patch changes the behavior of clear search button in cookies_view to work
as in firefox.
When the dialog is launched the clear search button in the old cookie_view the
state of this button is enabled,
but the text field is empty, so the correct behavior is make the button
disabled. Only when the user start typing
in the text field, the clear button will be enabled.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155059
A patch to make the grid column (table_view) of the passwords_page_view and
exceptions_page_view have the same size.
Without this, the table_view of exceptions_page_view has a width bigger than the
passwords_page_view.
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL:
http://codereview.chromium.org/155076
Add the menus copy, cut and paste to BookmarkBar and BookmarkMenu.
BUG=5354
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platform aspects.
BUG=10809
TEST=none
Review URL: http://codereview.chromium.org/113637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
disk cache experiment.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
E.g. plugin<->renderer channel can go down, causing SIGPIPE instead of a
normal error.
Review URL: http://codereview.chromium.org/155390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
not, use the stubs. We already use the stubs on unittests, so this just makes the same thing apply to the app. This gets breakpad's slow steps out of the google chrome mac rolling build.
TEST=breakpad still works in official builds
BUG=none
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/149499
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
off of WebDataService. The methods are unimplemented on the Mac for the
moment, and do passthroughs to WDS on Windows as with the rest of the Windows
PasswordStore interface.
BUG=none
TEST=Saving, viewing, and deleting password should still work on Windows.
Review URL: http://codereview.chromium.org/155259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149465
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we're in the middle of a drag originating from the tab.
The problem is that the tab gets deleted out from under the
drag operation which is happening in a nested message loop.
To work around this, if we're in the middle of a drag and
we get a tab close request, delay the tab close until after
the drag operation is finished.
BUG=16280
Review URL: http://codereview.chromium.org/149466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16006
TEST=none
Review URL: http://codereview.chromium.org/149445
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We may need to make a few changes before we're ready for this to be live,
so we're disabling for now.
BUG=12117
TEST=none
Review URL: http://codereview.chromium.org/155388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When saving a page with no title, such as a text file, attempt to
use a sane value for the save name by retrieving the last component
of the URL (if one exists).
This prevents the case where a page http://www.foo.com/a/path/name.txt
is saved as file "http www" with extension type "foo.com a path name.txt".
This change also makes the SavePackage code a little more flexible
and simpler to test.
BUG=none
TEST=Covered by unittest.
Review URL: http://codereview.chromium.org/155266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/149484
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16444
TEST=none
Review URL: http://codereview.chromium.org/149479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As spotted by the valgrind ui_tests buildbot.
BUG=16473
Review URL: http://codereview.chromium.org/149486
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to be "view linux splash page".
Thus users can still use the home button until we get rid of the splash page.
BUG=16308
TEST=none.
Review URL: http://codereview.chromium.org/149481
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149485
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=double click on an unselected item, it should be activated
Review URL: http://codereview.chromium.org/155368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=MediaTest.VideoBearSilentTheora
BUG=16012
Review URL: http://codereview.chromium.org/155375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20423 0039d316-1c4b-4281-b951-d872f2087c98
|