| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
breaking NPAPI tests on Vista due to an erroneuous commented line).
TBR=darin
Review URL: http://codereview.chromium.org/39309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
glass frames).
Our windows don't have WS_CAPTION. It's remarkable to me that we've made it this far without noticing this glaring oversight. I guess I fixed a bug with my frame changes earlier in the week that resulted in AdjustWindowRectEx getting called correctly for the first time, and it was not providing correct offsets because of the absence of this flag.
http://crbug.com/8445
Review URL: http://codereview.chromium.org/39300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting CL as plugin UI tests fail on Vista
Review URL: http://codereview.chromium.org/40260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=tony
Review URL: http://codereview.chromium.org/40259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* RenderViewContextMenu is now cross platform. Each platform needs to implement an inheritor that fills in the virtual methods.
* RenderViewContextMenuController was deleted. Platform agnostic elements from it were added to RenderViewContextMenu, while the Menu::Delegate implemenation was moved to RenderViewContextMenuWin.
* Some more (minor) refactoring may need to be performed as the rest of the menu actions are ported.
* include clipboard_service.h on all platforms (not sure why it wasn't included before)
Review URL: http://codereview.chromium.org/40249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes a gyp Linux build error because gyp expects all _posix files to actually
build on all posix platforms.
Review URL: http://codereview.chromium.org/39290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
using TimeoutServer has a leak because the threads don't get to run for enough time.
BUG=8469
Review URL: http://codereview.chromium.org/39294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
available in the encoding menu. Make windows-1255 come before
ISO-8859-8* both in the full encoding list and in Hebew Chrome's
static list.
BUG=2927
Review URL: http://codereview.chromium.org/39248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows to tag a request on the renderer side with its security info. It is useful for the "frame info" dialog.
When showing that dialog for blocked frames, the security info can be retrieved and users can see the cert details for the blocked frame.
TEST=Open a page containing a frame served over bad HTTPS. The frame is blocked (replaced with a warning message). Right-click, select "Frame info". The dialog should have a "show cert" button which when pressed should show the frame's bad cert.
BUG=2853
Review URL: http://codereview.chromium.org/7276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are still problems with this patch, as acknowledging the interstitial page often fails to load a new page. Instead, it just displays a blank gray page. This appears to be somewhat timing related.
Nonetheless, this changelist is strictly an improvement over what we have right now. So, I would still like to commit it.
Ideally, I'd like to remove the special-case Windows code. But I don't have a Windows machine to check whether the new code is actually a full superset of the old Windows code.
Review URL: http://codereview.chromium.org/40095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The character encoding menu is still broken in that it doesn't load the
encoding names (sub-menu items), but auto detect might work.
Review URL: http://codereview.chromium.org/39286
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added google_update and install utils.
Review URL: http://codereview.chromium.org/39204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
running already. Otherwise there's no point in running ui_tests!
Review URL: http://codereview.chromium.org/39282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/39283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- UMR was caused by stubbing out GetHistoryListCount, which RenderViewHost
expected to initialize its out params.
- MLK was (I think) caused by the IPC reply message to the javascript alert
never getting freed.
BUG=8364
Review URL: http://codereview.chromium.org/39157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds accelerators to all the menu items that had them on windows.
- Adds accelerators to back (Alt+left), forward (Alt+right), reload
(Ctr+R) and focus the URL box (Ctr+L).
Review URL: http://codereview.chromium.org/39278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any lang (currently using --lang=ar or whatever).
Also remove app/resources/SConscript since it's filled with
windows specific code.
BUG=8125
Review URL: http://codereview.chromium.org/40246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Automation clients can now find out the url navigated to
instead of just index in the history.
Review URL: http://codereview.chromium.org/39205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
copy of the native os event.
Only the WebKeyboardEvent is sent over the IPC barrier, but the full structure passed to the unhandled key event handler.
BUG=4772
Review URL: http://codereview.chromium.org/40065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds a placeholder condition for building branded 'chrome.exe'
vs. 'chromium.exe', which can be updated to build 'chromium.exe' by
default whenever we update the infrastructure (buildbots, developer
instructions, etc.) to use -Dbranding=Chrome.
Review URL: http://codereview.chromium.org/40233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
audio. A unit test accompanies the change.
Note that one minor other change was snuck in with this change. The data_source_impl.cc had a TODO to set a more specific error
when a read failed. Because I was already updating the pipeline error enum, I added the error code, changed the call to
host_->Error(), and removed the TODO.
Review URL: http://codereview.chromium.org/39170
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in place of the default user scripts location. This eases development of
userscripts since you can simply point the browser at your SCM checkout location
instead of needing to try to sync things into your local userscripts directory.
Code review URL: http://codereview.chromium.org/37011
Checking in for slightlyoff
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
synchronous XHR requests is closed. Currently we cancel all the pending URLRequestJobs, however at that point it doesn't have a pointer to get to the SyncResourceHandler object.
BUG=1575301
Review URL: http://codereview.chromium.org/39246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Automated the steps listed at:
https://sites.google.com/a/google.com/chrome-pmo/standalone-installers/testing-standalone-installers
Review URL: http://codereview.chromium.org/39150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/40240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit).
Review URL: http://codereview.chromium.org/40192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the filesystem and avoid the need for processing of Info.plist.
Dup of svn log since rietveld doesn't like A+D:
A + chrome/app/theme/chromium/app.icns
D chrome/app/theme/chromium/chromium.icns
M chrome/app/app-Info.plist
M chrome/chrome.gyp
Review URL: http://codereview.chromium.org/40238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/39267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation is similar to the one we have TestShell, which is to say
that we don't support visited links in the Worker process.
TBR=dglazkov
Review URL: http://codereview.chromium.org/40230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/39240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Serve Web Inspector JS files from chrom-ui://devtools/ domain in addition to chrom-ui://inspector/. We cannot simply reuse "inspector" domain for now as we need different tab content types for console debugger and new developer tools front-end. When developer tools support all console debugger and web inspector features we will remove "inspector" domain from the source list.
Review URL: http://codereview.chromium.org/40222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
now the browser thread waits for the renderer thread on shutdown.
Review URL: http://codereview.chromium.org/39245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on a handle that we already closed.
BUG=8070
Review URL: http://codereview.chromium.org/40195
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
called in RendererMainThread's dtor, not Thread's, otherwise the vtable lookup won't use RendererMainThread's CleanUp function.
Review URL: http://codereview.chromium.org/40199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Delete DownloadDestinationContextMenu, which is not used anywhere.
* Delete the unused download menu item types from the ContextMenuCommands enum.
* Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc}
* Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate.
Review URL: http://codereview.chromium.org/40184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I downloaded the test data "no-ads.pac" from <http://ap.coova.org/wpad.dat>.
BUG=2764
Review URL: http://codereview.chromium.org/40149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) If the Find textfield is populated when the Find box is shown, the FindPrevious and FindNext buttons should also be enabled. (issue 8369)
2) If you search for something that is not on the page, you get "0 of 0" in red. Press Esc and Ctrl+F and the label is gone but the red background color for the label remains (no bug on file, found during testing).
BUG=8369
TEST=Open about:blank in Chrome. Press Ctrl+F, search for 'e' (get 0 of 0), close the Find box, reopen the Find box. Observe 'e' is in box, it is highlighted and no red is visible. Also, FindPrevious and FindNext buttons should be enabled.
Review URL: http://codereview.chromium.org/39233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39231
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
too often. I filed bug 8444.
Review URL: http://codereview.chromium.org/39226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
p13n related features.
Review URL: http://codereview.chromium.org/39029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make them get destructed after browser shutdown, make them a member variable of BrowserRenderProcessHost.
Review URL: http://codereview.chromium.org/39218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
have already impacted Window itself, but a NULL check was already inserted in that code.
http://crbug.com/4355
Review URL: http://codereview.chromium.org/40183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/39147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11046 0039d316-1c4b-4281-b951-d872f2087c98
|