summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Do some header file cleanup of RenderWidgetHost. I moved everything to bebrettw@chromium.org2009-01-247-483/+476
| | | | | | | | private except the few functions that actually are overridden by RenderViewHost. Review URL: http://codereview.chromium.org/18739 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8608 0039d316-1c4b-4281-b951-d872f2087c98
* Two things:ben@chromium.org2009-01-2426-84/+136
| | | | | | | | | - remove views dependencies from browser by moving profile related dialog actions into BrowserWindow. - simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate. Review URL: http://codereview.chromium.org/18736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8606 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8603rvargas@google.com2009-01-2433-215/+128
| | | | | | Review URL: http://codereview.chromium.org/18576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8605 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dialog box for the about:network view and kill the tab type.brettw@chromium.org2009-01-2411-454/+481
| | | | | | | | | This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Review URL: http://codereview.chromium.org/18728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
* Change URLRequest to use a ref-counted buffer for actual IO.The ref-counting ↵rvargas@google.com2009-01-2433-128/+215
| | | | | | | | will prevent the deletion / reuse of memorywhile the buffer is actually being used by pending IO.This seems a very intrusive change, but at least we will be ableto make sure that it works without having to chase every singledestruction of an URLRequest to make sure that any pending IOwas cancelled, and also allows us to avoid blocking onthe object destruction.BUG=5325 Review URL: http://codereview.chromium.org/18390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8603 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of CertStore on shutdown.sky@google.com2009-01-233-22/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18568 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8599 0039d316-1c4b-4281-b951-d872f2087c98
* Pull toolbar importer from trunk.brg@chromium.com2009-01-236-1251/+0
| | | | | | | This change was requested by personalization. Review URL: http://codereview.chromium.org/18550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8598 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file from last checkin.brettw@chromium.org2009-01-231-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8595 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out the backing store from the RenderWidgetHost into its own file tobrettw@chromium.org2009-01-238-366/+505
| | | | | | | | | | | | | make porting easier. I also did some cleanup in the scrolling and painting areas, collapsing the confusing ScrollRect call inside OnMsgScrollRect to just be inside the function and call a new function on the backing store to scroll it. Same for painting. This also moves plugin window moving to the view. Review URL: http://codereview.chromium.org/18702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8594 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-2314-37/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* I'm relanding the UserDataManager leak fix. I didn't realize we hadsky@google.com2009-01-235-6/+9
| | | | | | | | | | | | | stubs for mac which needed to be updated too. This time I'll wait for the bots to finish compiling before committing. BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8587 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my user data manager change as it breaks the mac buildbot.sky@google.com2009-01-233-6/+4
| | | | | | | | | | BUG=none TEST=none TBR=munjal Review URL: http://codereview.chromium.org/18564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8584 0039d316-1c4b-4281-b951-d872f2087c98
* Build image_diff tool on the Mac. Fix up a few other things that had becomemark@chromium.org2009-01-231-86/+269
| | | | | | | strange in chrome.xcodeproj. Review URL: http://codereview.chromium.org/18562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8583 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of UserDataManager on shutdown.sky@google.com2009-01-233-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8581 0039d316-1c4b-4281-b951-d872f2087c98
* Adds switch to ui tests that enable dialogs in slave process. I'msky@google.com2009-01-231-3/+9
| | | | | | | | | | | adding this to make it easier to attach to a failing ui test. BUG=none TEST=none Review URL: http://codereview.chromium.org/18725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8580 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage by disabling testsben@chromium.org2009-01-231-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8579 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the safe browsing interstitial page support multiple unsafe ↵jcampan@chromium.org2009-01-2313-192/+662
| | | | | | | | | | | | | | | | | | | | | | | resources in one page. We had a bug when an interstitial was showing and another unsafe resource was detected. We would show another interstitial on top of the original one, causing the DontProceed method to be invoked several times. That would cause us to remove more than once an entry from the navigation controller and cause crashers. With this new CL, if an interstitial shows and a new resource is flagged as bad, the SafeBrowsingBlockingPage will queue that notification. If the user decides to proceed through the interstitial, we'll create another interstitial warning about all the unsafe resources we have received so far. This CL also contains a fix for a crasher that would happen when closing a tab with a safe browsing interstitial. BUG=5916,6207,6306 TEST=Test all actions in the interstitial you get when opening pages with the followin scenarios: - Main page is malware - Main page is fishing - Main page is OK contains resources (images,iframes...) which are malware - Main page is OK contains resources (images,iframes...) which are phishing - Main page is OK contains resources (images,iframes...) some of them phishing, some of then malware. Note that when there are more than one bad resource, it is normal to see a 1st interstitial, then another one listing all the other bad resources. (ex of malware site http://ianfette.org, phishing site http://cvisit.tripod.com) Review URL: http://codereview.chromium.org/18346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8578 0039d316-1c4b-4281-b951-d872f2087c98
* Prep for generated .vcproj files:sgk@google.com2009-01-238-50/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Review URL: http://codereview.chromium.org/18555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8577 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r8486, which updates the manifestaa@chromium.org2009-01-2314-227/+449
| | | | | | | | | | | | | | | | | | | | | | | parsing in the Extension class to also parse out user script details. The problem was that extension_protocols.cc appears to link OK if you don't refer to anything in it, but as soon as you try to use something defined in it, a bunch of other symbols it refers to turn up undefined. To avoid this problem in the future, I stopped compiling extensions_protocol.cc so that we would realize if we tried to use it. Also in this change, I absolutified paths in ExtensionsService before creating Extension instances. On Linux, the path that PathService was giving us was not absolute. Review URL: http://codereview.chromium.org/18704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8576 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose the go and star button views directly through the BrowserWindow ↵ben@chromium.org2009-01-2313-114/+102
| | | | | | | | interface (for porting). Review URL: http://codereview.chromium.org/18540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8572 0039d316-1c4b-4281-b951-d872f2087c98
* ui refresh from cole. make it look chromey and get the basic framework for ↵pinkerton@google.com2009-01-2321-446/+8067
| | | | | | | | the views we'll need. Review URL: http://codereview.chromium.org/18720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8571 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-238-58/+55
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug when saving web pages that have a period in their title.paulg@google.com2009-01-234-5/+19
| | | | | | | | | | | | | | | | | | | | | | The save dialog code attempts to generate a file extension based on the suggested name provided to it, which in the case of saving a web page is the title. If that title contains a '.' character, it treats anything that follows as the file extension and appends it to the name the user selects. For example, saving a page with the title "Google Inc. - A search engine" and the user choosing the save name as "Google" will result in the saved file being named "Google. - A search engine.htm" when it should be "Google.htm". In the case of saving a web page, we can ignore trying to figure out the file extension since we already know it will be ".htm". BUG=6105 (http://crbug.com/6105) Review URL: http://codereview.chromium.org/18699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8569 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 8565.brettw@chromium.org2009-01-232-59/+32
| | | | | | Review URL: http://codereview.chromium.org/18718 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8566 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of unnecessary region code from spellcheck language/locale codessidchat@google.com2009-01-232-32/+59
| | | | | | | Issue=6329 Review URL: http://codereview.chromium.org/18694 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8565 0039d316-1c4b-4281-b951-d872f2087c98
* Move security style into the tab_contents directory. This is the last part ofbrettw@chromium.org2009-01-236-18/+11
| | | | | | | the "Tab Contents (old)" group! Review URL: http://codereview.chromium.org/18686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8564 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing include in scoped_ole_initializer. Without this includesky@google.com2009-01-231-0/+2
| | | | | | | | | | | someone can't just include scoped_ole_initializer and have it work. BUG=none TEST=none Review URL: http://codereview.chromium.org/18536 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8563 0039d316-1c4b-4281-b951-d872f2087c98
* Adds call to unload plugins on shutdown.sky@google.com2009-01-231-1/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8562 0039d316-1c4b-4281-b951-d872f2087c98
* Add a PNGEncoder helper function that takes an SkBitmap,nick@chromium.org2009-01-235-29/+6
| | | | | | | | | | | | which is how PNGEncode is used almost everywhere. This should be strictly no functional change, except for the ImageFilterPeer::DataReady case, where we now take an SkAutoLockPixels where previously we did not. Review URL: http://codereview.chromium.org/18347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8561 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-238-55/+58
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* When the server says "nosniff" but then doesn't give us a Content-Type we ↵abarth@chromium.org2009-01-231-1/+10
| | | | | | | | | | now treat the response as "text/plain". Before, we treated the response as a download. This behavior is (a) safer and (b) matches what we expect in IE8. R=darin Review URL: http://codereview.chromium.org/18549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8559 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak of shutdown event in BrowserProcess.sky@google.com2009-01-232-4/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/18534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8555 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out 8523 in hopes of a greener tree.sky@google.com2009-01-238-300/+26
| | | | | | | | | | BUG=none TEST=none TBR=brg Review URL: http://codereview.chromium.org/18548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8548 0039d316-1c4b-4281-b951-d872f2087c98
* Relands 8521, it isn't the culprit. Sorry John.sky@google.com2009-01-231-0/+1
| | | | | | | | | BUG=none TEST=none TBR=jam Review URL: http://codereview.chromium.org/18706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8547 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out r8521 in hopes of greener trees.sky@google.com2009-01-231-1/+0
| | | | | | | | | BUG=none TEST=none TBR=jam Review URL: http://codereview.chromium.org/18545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8546 0039d316-1c4b-4281-b951-d872f2087c98
* 159.0mal@chromium.org2009-01-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8545 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=1007hclam@chromium.org2009-01-237-6/+381
| | | | | | | | | Added a dialog for removing exceptions of password manager Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog. Review URL: http://codereview.chromium.org/18494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8544 0039d316-1c4b-4281-b951-d872f2087c98
* Change histogram for eviction to get details of long tailjar@google.com2009-01-231-1/+1
| | | | | | | r=petersont Review URL: http://codereview.chromium.org/18705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8543 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: get bits of renderer_glue compilingagl@chromium.org2009-01-233-22/+36
| | | | | | | Review URL: http://codereview.chromium.org/16817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix strings in url_fixer_upper.estade@chromium.org2009-01-238-229/+305
| | | | | | | | | | * change URLs from wstring to string * change filenames from wstring to FilePath * url_fixer_upper{_unittest}.cc building on posix Review URL: http://codereview.chromium.org/18525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8536 0039d316-1c4b-4281-b951-d872f2087c98
* Handle race between deleting a low use referrer acruing valuejar@chromium.org2009-01-232-14/+21
| | | | | | | | | | | | | | | | | | Prevent a DCHECK from firing. As we adaptively learn about referrers to enhance DNS pre-resolution, we are forced to evict some entries to prevent accidentally getting really large lists (when we make mistakes). Sometimes we evict a referred item from a list *while* that item is being resolved (because it was in teh list). In that case, we have to be careful when we try to acrue credit (latency savings). r=paulg Review URL: http://codereview.chromium.org/18527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8531 0039d316-1c4b-4281-b951-d872f2087c98
* Add q-values to languages in Accept-Language HTTP header to be compatible ↵jungshik@google.com2009-01-231-7/+8
| | | | | | | | | | | | | | with Apache. Add q-values to charsets in Accept-Charset header in the same way as Firefox does. BUG=5899 TEST=HttpUtilTest.Accept* (net_unittest) Review URL: http://codereview.chromium.org/17340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8527 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to insure that when in app-mode, links open in the default browser. ↵brg@chromium.com2009-01-238-26/+300
| | | | | | | | This change should have no affect on Chrome when not in app-mode.Tested against Gmail. UITests added as app_mode_navigation_uitest. Review URL: http://codereview.chromium.org/18093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8523 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reloading a page with a pdf not working. The problem was that we were ↵jam@chromium.org2009-01-221-0/+1
| | | | | | | | sending an invalid window to DeferWindowPos (the previous window as it's going away). But we didn't really need to override setParentVisible since overriding setParent is enough. Review URL: http://codereview.chromium.org/18519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8521 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2009-01-221-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8517 0039d316-1c4b-4281-b951-d872f2087c98
* Make the browser talk to the status bubble through an abstract interface to ↵ben@chromium.org2009-01-228-78/+100
| | | | | | | | remove the views dependency. Review URL: http://codereview.chromium.org/18487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8515 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable this test now that I've properly initialized the result member ↵ben@chromium.org2009-01-221-1/+3
| | | | | | | | | variable. TBR=tc Review URL: http://codereview.chromium.org/18602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8514 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser render process host to the mac build. It compiles already.brettw@google.com2009-01-221-0/+6
| | | | | | Review URL: http://codereview.chromium.org/18516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8502 0039d316-1c4b-4281-b951-d872f2087c98
* (1) If you create tabs and manage to resize the window before themaruel@chromium.org2009-01-221-1/+12
| | | | | | | | | | | | | | | | | pending layout occurs, you get truncated tabs (As described in issue 6505). Upon resize therefore we reset the reserved width for tabs. (2) When inserting a tab as the second-to-last tab, the size of tabs was incorrect. This lead to shriking tabs in multiple cases (as described in issue 3258). BUG=6505 BUG=3258 Patch contributed by Itai Danan <idanana@google.com> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8496 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Parse more user script info out of the manifest and expose"aa@chromium.org2009-01-2211-433/+224
| | | | | | | | This reverts commit fc3fd1062c06f803775c16d11f742d85d540e415. Review URL: http://codereview.chromium.org/18681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8494 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-20 00:56:55 +0000