summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Refactoring some of the NativeViewHost and NativeControl focus management so ↵jcampan@chromium.org2009-09-2410-25/+24
| | | | | | | | | | | their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Review URL: http://codereview.chromium.org/214029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27113 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fixes to enable link dependent objects.maruel@chromium.org2009-09-241-2/+0
| | | | | | | | BUG=22926 TEST=still builds Review URL: http://codereview.chromium.org/231020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27112 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the remaining members of HistoryContentsProvider.jhawkins@chromium.org2009-09-241-0/+6
| | | | | | | | | CID=1633 BUG=none TEST=none Review URL: http://codereview.chromium.org/223025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27111 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize the remaining members of AutocompleteEditModel.jhawkins@chromium.org2009-09-241-0/+5
| | | | | | | | | CID=1646 BUG=none TEST=none Review URL: http://codereview.chromium.org/231007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27109 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize pending_buf_size_ in the constructor.jhawkins@chromium.org2009-09-241-1/+4
| | | | | | | | | CID=1639 BUG=none TEST=none Review URL: http://codereview.chromium.org/218011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27108 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused tab_contents variable.mattm@chromium.org2009-09-241-1/+0
| | | | | | | | | | CID=6204 BUG=none TEST=none Review URL: http://codereview.chromium.org/227013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27106 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize user_gesture_observed_ in NavigationController constructor.mattm@chromium.org2009-09-242-1/+46
| | | | | | | | | BUG=18268 TEST=run the included test under valgrind without the navigation_controller.cc change, then with. The memcheck condititional jump error shouldn't fire with the fix. Review URL: http://codereview.chromium.org/220002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27105 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crasher on toast UIcpu@chromium.org2009-09-241-1/+1
| | | | | | | | | | | | | | | | | | | - The order of: radio_button = new views::RadioButton(..) layout->AddView(radio_button) radio_button->SetChecked(true); Matters, if the last two statements are inverted we crash (??) BUG=none TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast Review URL: http://codereview.chromium.org/225019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27101 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Worker*.WorkerFastLayoutTests for now.jshin@chromium.org2009-09-241-5/+2
| | | | | | | | | BUG=22942 TEST=Buildbots are green. TBR=dglazkov Review URL: http://codereview.chromium.org/220034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27099 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable BrowserCloseBeforeUnload* tests while I am working on ↵dglazkov@chromium.org2009-09-241-2/+2
| | | | | | | | | | | | fixing them. TBR=thomasvl TEST=none BUG=none Review URL: http://codereview.chromium.org/222023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27097 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize remaining_payload_length_ in the constructor.jhawkins@chromium.org2009-09-241-0/+1
| | | | | | | | | CID=2286 BUG=none TEST=none Review URL: http://codereview.chromium.org/220020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27088 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rewrite Omnibox field-editor frame-changing tests.shess@chromium.org2009-09-241-56/+115
| | | | | | | | | | | | | The previous tests mostly replicated autocomplete_text_field_cell_unittest.mm cases. Reworked them to test that the field editor placement is the same whether -resetFieldEditorFrameIfNeeded is doing the placement, or the regular Cocoa focusing machinery. That's more relevant to what that method is doing. Review URL: http://codereview.chromium.org/219003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27085 0039d316-1c4b-4281-b951-d872f2087c98
* Add UnloadTest.BrowserCloseInfiniteBeforeUnload to the disabled test list on ↵jshin@chromium.org2009-09-241-0/+2
| | | | | | | | | | | valgrind bot. BUG=22927 TEST=Linux valgrind bot does not time out any more. TBR=paul Review URL: http://codereview.chromium.org/224019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27084 0039d316-1c4b-4281-b951-d872f2087c98
* Enable and rebaseline worker-close.html after the upstream fix ↵jianli@chromium.org2009-09-241-3/+1
| | | | | | | | | | | (http://trac.webkit.org/changeset/48610) is landed. BUG=20953 TEST=worker-close.html Review URL: http://codereview.chromium.org/208069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27083 0039d316-1c4b-4281-b951-d872f2087c98
* Fix perfcoldcomplextheme startup test for mac and linux.mirandac@chromium.org2009-09-241-1/+1
| | | | | | | | | | BUG= http://crbug.com/22801 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26971 Review URL: http://codereview.chromium.org/218006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27082 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove paste-and-go from omnibox context menu in popup windows.shess@chromium.org2009-09-242-13/+39
| | | | | | | | | | | | The field is not editable, and this is an editing item. http://crbug.com/20246 TEST=www.popuptest.com, test #2, right-click in the popup's omnibox. Should not have paste-and-go/paste-and-search menu item. Review URL: http://codereview.chromium.org/219018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27079 0039d316-1c4b-4281-b951-d872f2087c98
* Fix coding style violation.thakis@chromium.org2009-09-241-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/235002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27076 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/231008 for Charlie:sky@chromium.org2009-09-241-5/+5
| | | | | | | | | | | | | Make vertical edge scroll false by default. Fixed sensitivity parameter values and inverted the relationship between touch sensitivity preference and synclient parameter value. TEST=none BUG=22848 Review URL: http://codereview.chromium.org/236002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27075 0039d316-1c4b-4281-b951-d872f2087c98
* Regression: Shift modifier on Find was reversed.finnur@chromium.org2009-09-241-1/+1
| | | | | | | | We were also not using GetKeyState correctly in win_util, as the documentation mentions. We should be looking at the high-order bit (&-ing with 0x8000, not 0x80). BUG=22849TEST=Try to use Enter during FindInPage. Notice it should search forwards when Shift key is not pressed and backwards when Shift is pressed. Review URL: http://codereview.chromium.org/218009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27074 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DCHECK to get more info about flaky NPAPIVisiblePluginTester failures.phajdan.jr@chromium.org2009-09-241-0/+1
| | | | | | | | | | | | | Example failure: [FATAL:render_widget_host_view_win.cc(399)] Check failed: parent. TEST=none BUG=none Review URL: http://codereview.chromium.org/220021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27073 0039d316-1c4b-4281-b951-d872f2087c98
* Changes from listening to focus-out/focus-in for active status tosky@chromium.org2009-09-242-12/+5
| | | | | | | | | | | listening for is-active. BUG=none TEST=none Review URL: http://codereview.chromium.org/219016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27071 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: autoresume execution on parse errors.yurys@google.com2009-09-242-0/+18
| | | | | | | | | BUG=22852 TEST=DevToolsSanityTest.TestAutoContinueOnSyntaxError Review URL: http://codereview.chromium.org/218026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27067 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a strikethrough through insecure url schemes.rohitrao@chromium.org2009-09-241-0/+4
| | | | | | | | BUG=http://crbug.com/22558 TEST=Go to https://www.twitter.com/. See the cert mismatch warning. Check that "https://" in the omnibox is red with a strikethrough. Review URL: http://codereview.chromium.org/215038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27064 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27062 since "DevTools: repair on linux and reenable breakpoint ↵yurys@google.com2009-09-241-2/+2
| | | | | | | | | | | tests" revision 27060 was not the cause of regression on Webkit Mac10.5 and Webkit Linux (dbg)(3) TBR=maruel TEST=none BUG=none Review URL: http://codereview.chromium.org/231016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: repair on linux and reenable breakpoint tests" revision 27060.maruel@chromium.org2009-09-241-2/+2
| | | | | | | | | | | | Caused regression on Webkit Mac10.5 and Webkit Linux (dbg)(3) TBR=yurys TEST=none BUG=none Review URL: http://codereview.chromium.org/225027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27062 0039d316-1c4b-4281-b951-d872f2087c98
* Enable disabled autocomplete edit view tests.suzhe@chromium.org2009-09-241-3/+3
| | | | | | | | | | | | | This CL enables those disabled autocomplete edit view tests, as the flaky and failing issue were already solved. BUG=20422: Autocomplete edit view needs automated testing BUG=21846: AutocompleteEditViewTest.AltEnter is failing BUG=21849: AutocompleteEditViewTest.EnterToSearch is flaky TEST=none Review URL: http://codereview.chromium.org/223021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27061 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: repair on linux and reenable breakpoint testsyurys@google.com2009-09-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/231001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27060 0039d316-1c4b-4281-b951-d872f2087c98
* Crash the renderer not the browser when we see a storage area ID or namespace IDjorlow@chromium.org2009-09-244-19/+72
| | | | | | | | | | | that we didn't expect. TEST=Changed the code to pass in an invalid ID. The tab became sad as expected. BUG=20055 Review URL: http://codereview.chromium.org/217001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27055 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more methods from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-243-21/+28
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/224010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27054 0039d316-1c4b-4281-b951-d872f2087c98
* WorkerFastLayoutTests works fine on the Linux try bots, but fails on the ↵atwilson@chromium.org2009-09-241-0/+4
| | | | | | | | | | | | | Linux build bots. Disabling for now. TBR=levin BUG=22898 TEST=none Review URL: http://codereview.chromium.org/218022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27051 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix valgrind.thakis@chromium.org2009-09-241-7/+12
| | | | | | | TBR: mark@chromium.org (Since this looks like something you've dealt with before) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27050 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the comment above the Firefox30Importer test which indicated that ↵ananta@chromium.org2009-09-241-1/+0
| | | | | | | | | | | | the test was disabled, etc as we fixed the underlying cause of the test failure. TBR=nsylvain Review URL: http://codereview.chromium.org/219027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27048 0039d316-1c4b-4281-b951-d872f2087c98
* The Firefox3XImporter test was incorrectly deleting a ref counted object ↵ananta@chromium.org2009-09-241-6/+7
| | | | | | | | | | | | | | | | causing an ASSERT to fire resulting in this test to randomly fail on the Vista dbg builder. Fix is to get rid of the delete and wrap the allocated Firefox3Observer object in a scoped_refptr. This fixes http://code.google.com/p/chromium/issues/detail?id=22884 Bug=22884 Review URL: http://codereview.chromium.org/231012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27045 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore extra properties on schemas or instances that comesaa@chromium.org2009-09-241-0/+13
| | | | | | | | from prototypes. Review URL: http://codereview.chromium.org/215057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27044 0039d316-1c4b-4281-b951-d872f2087c98
* Un-reverting 26919, and disabling worker-cloneports since it is flaky.atwilson@chromium.org2009-09-244-2/+71
| | | | | | | | | | | | | | Added missing layout tests along with associated rebaselinings. Updated DEPS to include common resource files needed by tests, and add APIs to ui_layout_test to allow specifying resource files to copy. Disabled non-working tests so we can enable worker_uitests on Mac/Linux. BUG=22174 TEST=worker_uitest Review URL: http://codereview.chromium.org/232001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27043 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't ellipsize the Other Bookmarks button.estade@chromium.org2009-09-241-2/+7
| | | | | | | | BUG=22788 Review URL: http://codereview.chromium.org/225014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27041 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the firefox importer test because it fails on thensylvain@chromium.org2009-09-241-1/+2
| | | | | | | | | buildbot. BUG:22884 Review URL: http://codereview.chromium.org/219026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27037 0039d316-1c4b-4281-b951-d872f2087c98
* Change the manifest so VS2008 does not get confusedcpu@chromium.org2009-09-242-4/+2
| | | | | | | | | | | | | - setup.exe or mini_installer.exe don't run if compiled in VS2008 - VS2008 is repeating the 'as_invoker' element. BUG=none TEST=compile setup.exe or ministaller with vs2008, now you can run them. Review URL: http://codereview.chromium.org/220023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27034 0039d316-1c4b-4281-b951-d872f2087c98
* Inactive user toast: pass the experiment flavor to chrome execpu@chromium.org2009-09-241-7/+8
| | | | | | | | | | | | | | - Pointed in previous CL. Forgot to act on it - Change some printf specifiers to have 'l' prefix BUG=none TEST=launch setup.exe --inactive-user-toast=3 observe toast, then launch with --inactive-user-toast=1 and observe a different dialog Review URL: http://codereview.chromium.org/225021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27032 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-2421-141/+135
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 218.0 to 219.0jon@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27026 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 217.0 to 218.0eblake@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27024 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 216.0 to 217.0eblake@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27022 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 215.0 to 216.0eblake@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27020 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 214.0 to 215.0eblake@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27017 0039d316-1c4b-4281-b951-d872f2087c98
* Let cmd-f/cmd-g use the findboard.thakis@chromium.org2009-09-2311-21/+354
| | | | | | | | | | | | | | | | In a nutshell, this means that the find bars honor the global find pasteboard, which is like a clipboard, but for searches. See the TEST section below for consequences, and also see the bug for more information. BUG=14562 TEST= * Select some text, hit cmd-e, cmd-g. This should search for the marked text and open the find bar if it's not open. * Open TextEdit, hit cmd-f. Enter some text, hit enter. Switch back to Chrome with an open find bar. The find bar should now contain the text you entered in TextEdit * Enter different text into chrome's find bar, switch back to TextEdit. Its find window should now contain the new text. * Search for something in one tab, switch to another tab. It should contain the same text in the findbar as the first one. * Open the findbar, select some text, hit cmd-e. The find bar should be updated with the selected text and this text should be highlighted in the web page. Find bars in other tabs should be updated with that text as well. Review URL: http://codereview.chromium.org/206035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27015 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize SavePackageParam::save_type to SAVE_TYPE_UNKNOWN in the ↵jhawkins@chromium.org2009-09-231-1/+3
| | | | | | | | | | | constructor. CID=2275 BUG=none TEST=none Review URL: http://codereview.chromium.org/219020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27014 0039d316-1c4b-4281-b951-d872f2087c98
* A refactor broke the find bar...characters like ! and ( davemoore@google.com2009-09-234-4/+23
| | | | | | | | | | | became unsearchable BUG=10509 TEST=Open nytimes.com, search for "new". Then type "!". It should appear in the search box but not be found (unless the the text "new!" is really in the page. Confirm you can search for ( and & as well. Review URL: http://codereview.chromium.org/220019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27012 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 213.0 to 214.0eblake@chromium.org2009-09-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27010 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Hook up the page menu's "Encoding" submenu.erg@chromium.org2009-09-237-38/+54
| | | | | | | | | | | | | Hook the NSMenu's delegate up to the ToolbarController in the nib and generalize EncodingMenuControllerDelegate to work with a NSMenu object instead of grabbing the app menu. BUG=22639 TEST=ToolbarControllerTest.PopulateEncodingMenu Review URL: http://codereview.chromium.org/225016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27008 0039d316-1c4b-4281-b951-d872f2087c98