summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add pyauto hook for HTML5 notifications, tests, and helpers.kkania@chromium.org2010-10-2610-0/+670
| | | | | | | | | BUG=55125 TEST=none Review URL: http://codereview.chromium.org/3822001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63935 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Clear the credit card select options when setting the default selectjhawkins@chromium.org2010-10-261-0/+3
| | | | | | | | | | | | options. This is a speculative fix for a bug where the dates are added twice. BUG=60578 TEST=none Review URL: http://codereview.chromium.org/4181003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63927 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use IO thread to talk to dbus.oshima@chromium.org2010-10-261-37/+0
| | | | | | | | | | | | | dbus uses glib message loop which is driven by UI thread. It is correct to use UI thread to talk to dbus (for now) It's not proven but this may be a source of obscure race bugs, or at least, we can exclude this from the potential source. BUG=chromium-os:7490. TEST=screen locker works as before. Review URL: http://codereview.chromium.org/4024005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63926 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r63919 "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-2637-465/+458
| | | | | | | | | | | | Compile failure on Linux x64. BUG=56558 TEST=no functional change TBR=aa Review URL: http://codereview.chromium.org/4156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we display 'undefined is unsupported' when tryingaa@chromium.org2010-10-261-3/+7
| | | | | | | | | | | | | to use unsuported Greasemonkey APIs. Classic JavaScript bug :( BUG= TEST= Review URL: http://codereview.chromium.org/4119003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63920 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of immutable Extension refactor.mpcomplete@chromium.org2010-10-2637-458/+465
| | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/3982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
* Make clang build work again.aa@chromium.org2010-10-261-0/+9
| | | | | | TBR=evan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63917 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-262-0/+17
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI prefs: Fix missing unload listener on the homepage fieldstuartmorgan@chromium.org2010-10-261-2/+9
| | | | | | | | | | | We used to get this for free as part of the pref-linking object decoration, but after the fixes for managed preferences the URL field is no longer a pref-linked field, so we need to add the unload handler directly. BUG=60636 TEST=Change the homepage in DOMUI prefs, and close the tab without changing focus. Review URL: http://codereview.chromium.org/4119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63915 0039d316-1c4b-4281-b951-d872f2087c98
* Add experimental option for TCP FastOpen.mbelshe@chromium.org2010-10-263-0/+10
| | | | | | | | | | | Use chrome.exe --enable-tcp-fastopen BUG=none TEST=none yet Review URL: http://codereview.chromium.org/4039003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63913 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix several pass-by-values.jhawkins@chromium.org2010-10-2616-34/+40
| | | | | | | | | | CID=12543,12544,12758,12878,12879,12918,13252,13285,13301,13391 BUG=none TEST=none Review URL: http://codereview.chromium.org/4040003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63910 0039d316-1c4b-4281-b951-d872f2087c98
* Fix excessive IPCs by audio renderer.sergeyu@chromium.org2010-10-263-6/+7
| | | | | | | | | BUG=60353 TEST=see repro steps in the bug. Review URL: http://codereview.chromium.org/3973008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63909 0039d316-1c4b-4281-b951-d872f2087c98
* Printing: Refactor PrintSettings::Init into a PrintSettingsFactory classjhawkins@chromium.org2010-10-261-2/+2
| | | | | | | | | | | per-platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/4040001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63907 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring select popup on Mac.jcivelli@google.com2010-10-2638-157/+583
| | | | | | | | | | | | | | The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection. BUG=None TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups). Original review: http://codereview.chromium.org/3795006/show Review URL: http://codereview.chromium.org/4078003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
* Add comment to newly disabled tests.dglazkov@chromium.org2010-10-261-0/+2
| | | | | | | | | | TBR=thakis TEST=none BUG=60532 Review URL: http://codereview.chromium.org/4157003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63904 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Added some switches for testing/debugging.akalin@chromium.org2010-10-266-9/+37
| | | | | | | | | | | | | | | | Added back in --sync-invalidate-xmpp-login (now, not only in debug mode!). Added --sync-allow-insecure-xmpp-connection, which enables sync to connect to insecure XMPP servers (e.g., a local one). Changed --use-ssl-tcp to --sync-try-ssltcp-first-for-xmpp. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/4158001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63903 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable tests failing after WebKit Roll 70513:70527.dglazkov@chromium.org2010-10-261-2/+2
| | | | | | | | | | TBR=jorlow TEST=none BUG=60532 Review URL: http://codereview.chromium.org/4128005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63901 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the title field from the SectionInfo struct. It is unused.finnur@chromium.org2010-10-265-29/+5
| | | | | | | | BUG=59030 TEST=None Review URL: http://codereview.chromium.org/3850003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63897 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Update sync.proto to match the server's and handle new error codes.albertb@chromium.org2010-10-263-15/+36
| | | | | | | | | BUG=b/17777403 TEST=none Review URL: http://codereview.chromium.org/4017004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserTest.OtherRedirectsDontForkProcess to not hard-code port 1337.skerner@chromium.org2010-10-261-5/+10
| | | | | | | | | BUG=None TEST=BrowserTest.OtherRedirectsDontForkProcess Review URL: http://codereview.chromium.org/4088001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63892 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to parse multiple recognition results and send them to WebKit.satish@chromium.org2010-10-2618-52/+158
| | | | | | | | | | | | The relevant Webkit change was submitted earlier: http://bugs.webkit.org/show_bug.cgi?id=48068 The unit tests have been updated for the multi-results case as well. BUG=none TEST=unit_tests --gtest_filter=Speech* Review URL: http://codereview.chromium.org/4119004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63891 0039d316-1c4b-4281-b951-d872f2087c98
* Open tab at the correct location.bryeung@google.com2010-10-261-0/+1
| | | | | | | | | | | Patch by: Sadrul Chowdhury <sadrul@chromium.org> BUG=59146 TEST=see bug Review URL: http://codereview.chromium.org/4039007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63890 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile with chromeos=1.bryeung@google.com2010-10-261-0/+2
| | | | | | | | | | | | | | | | | | | The error (with dynamic linking) is: SOLINK(target) out/Debug/obj.target/chrome/libbrowser.so out/Debug/obj.target/browser/chrome/browser/geolocation/wifi_data_provider_linux.o: In function `DeviceDataProvider<WifiData>::DefaultFactoryFunction()': /home/sadrul/devel/c/src/chrome/browser/geolocation/wifi_data_provider_linux.cc:355: multiple definition of `DeviceDataProvider<WifiData>::DefaultFactoryFunction()' out/Debug/obj.target/browser/chrome/browser/geolocation/wifi_data_provider_chromeos.o:/home/sadrul/devel/c/src/chrome/browser/geolocation/wifi_data_provider_chromeos.cc:71: first defined here collect2: ld returned 1 exit status make: *** [out/Debug/obj.target/chrome/libbrowser.so] Error 1 Patch by: Sadrul Chowdhury <sadrul@chromium.org> BUG=None TEST=Build completes with dynamic linking enabled and GYP_DEFINES='chromeos=1'. Review URL: http://codereview.chromium.org/4019009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63889 0039d316-1c4b-4281-b951-d872f2087c98
* Update installer error strings to include Chrome Frame specific branding ↵robertshield@chromium.org2010-10-265-4/+28
| | | | | | | | | | | | | when running in Chrome Frame mode. Also fix the installer_util_strings target that had a broken dependency on a file that has since been moved. BUG=46013 TEST=Google Chrome Frame is correctly displayed when the installer is run in Chrome Frame mode. Review URL: http://codereview.chromium.org/3968005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63888 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: block ability to stat arbitrary files in the Sandbox.jeremy@chromium.org2010-10-265-43/+150
| | | | | | | | | | | | | | | | | | | | | | | This change removes the ability to stat any file on disk and instead only allows stating files to which we have read access. The complication with removing the ability to stat an arbitrary path is that without extra work you get into a situation where you can stat a leaf directory, but not it's parent. e.g. stat("/foo/bar") succeeds while stat("/foo") fails with errno == EPERM. The only place we currently run into this is the utility process where the file system is off limits except for one directory. This causes problems in 2 places: 1) DirectoryExists() works it's way from / down to the leaf directory stating each directory as it goes. 2) The extension installation code calls realpath() which fails if it can't stat parent directories. The fix for the above is to explictly allow stating parent directories. We achieve this in the sandbox code by adding a function which generates the appropriate sandbox syntax. This CL also contains unit tests for the above functionality and re-enables it [bug 56765, the underlying issue appears to be unrelated to the test and previously fixed]. BUG=42989, 56765 TEST=Chrome should continue to render web pages correctly, installing extensions and themes should continue to work on OS X. Review URL: http://codereview.chromium.org/4044002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63884 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to rlz library r26:30 to get the latest fixes for base library ↵tfarina@chromium.org2010-10-261-13/+12
| | | | | | | | | | | | | changes. Also remove the Registry class stub implementations in base/registry.h BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4166001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63880 0039d316-1c4b-4281-b951-d872f2087c98
* Remove failure_count_ to simplify the code.yusukes@chromium.org2010-10-261-23/+6
| | | | | | | | | | | | | Since |timer_| is one-shot, it seems that the failure counter is reset to zero almost every time and unlikely exceeds kMaxRetries (see issue 8096.) I don't think we should implement another type of limiter since the on-demand ibus loading code is stable. Let's just remove failure_count_ and related logic. BUG=none TEST=manually tested that the flush function works fine without the counter. Review URL: http://codereview.chromium.org/4102002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63876 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 564.0 to 565.0chrome-release@google.com2010-10-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63872 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable AutocompleteBrowserTest.Basicisherman@chromium.org2010-10-261-9/+1
| | | | | | | | | BUG=49324 TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.Basic --gtest_repeat=10000 --gtest_break_on_failure Review URL: http://codereview.chromium.org/3436027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63870 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way to change the current input method in FlushImeConfig() so ↵yusukes@chromium.org2010-10-261-13/+39
| | | | | | | | | | | that the flush function does not call chromeos::ChangeInputMethod() too often. BUG=chromium-os:8096 TEST=see the bug (comment #2 and 3) Review URL: http://codereview.chromium.org/4129002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63868 0039d316-1c4b-4281-b951-d872f2087c98
* Close overlays when the user hits ESC key.satorux@chromium.org2010-10-261-0/+18
| | | | | | | | | BUG=chromium-os:7024 TEST=manually closing overlays by hitting ESC key. Review URL: http://codereview.chromium.org/4076004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63861 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame network tests were broken since the change to honor the ↵ananta@chromium.org2010-10-262-2/+9
| | | | | | | | | | | | | | | | | | | | | | automation protocol version in ChromeFrame which basically breaks the automation connection if the protocols don't match. While this is fine when chrome is the automation client, it breaks chrome frame net tests because when the automation channel is established the automation provider sends over the version of the current module in the hello message. In the case when the current module is chrome the version goes over correctly. For chrome frame net tests there is no version string. Hence the channel never gets established. Fix is to retrieve the protocol version via a virtual protected function in the automation provider. The testing automation provider overrides this function in the network tests and returns the version of chrome.dll TBR=amit,robertshield Review URL: http://codereview.chromium.org/4160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63860 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-2623-35/+41
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* In short, break out the SearchEngineType enum into its own header file.levin@chromium.org2010-10-269-225/+235
| | | | | | | | | | | Longer explanation: This enum is needed by the template_url.h header, so it currently includes template_url_prepopulate_data.h to get it. Since template_url.h is a frequently used header file, a lot of other files get the prepopulate data header file even though they don't (and shouldn't) use its functionality. BUG=None TEST=unit_tests -gtest_filter=Temp*:Sea*:Key* Review URL: http://codereview.chromium.org/4039008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63856 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate a few failing sync integration tests.rsimha@chromium.org2010-10-261-3/+7
| | | | | | | | | | | | | | | | | Marking a few of failing sync integration tests with the FAILS_prefix until the associated bug is fixed. TwoClientLiveAutofillSyncTest.AddMultipleProfiles TwoClientLiveAutofillSyncTest.ProfileSameLabelOnClient1 TwoClientLiveAutofillSyncTest.ProfileSteady TBR=lipalani@chromium.org BUG=60368 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/4167002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63851 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Do not allow dbclick in list view when the AutoFill is disabled.tfarina@chromium.org2010-10-261-1/+2
| | | | | | | | | | BUG=None TEST=disable the autofill feature, double click on an item in the list view. Nothing should happen. Review URL: http://codereview.chromium.org/4055003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63848 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Add GetCreditCardById to PersonalDataManager.tfarina@chromium.org2010-10-263-10/+14
| | | | | | | | | BUG=None TEST=crl --enable-tabbed-options. The AutoFill options should works as before. Review URL: http://codereview.chromium.org/4012005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63843 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in PYAUTO_TESTSnirnimesh@chromium.org2010-10-261-3/+3
| | | | | | | | | | | | There was a missing , Also, moving some lines to fall in lexicographic order. TBR=kkania BUG= TEST= TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63837 0039d316-1c4b-4281-b951-d872f2087c98
* Allow URLPatterns to omit trailing slash.aa@chromium.org2010-10-2611-70/+136
| | | | | | | | | | | Also, a regression had been introduced in earlier changes. Added explicit error codes to Parse(), and removed default constructor, to avoid making the same mistake again. BUG=49969 TEST=n/a Review URL: http://codereview.chromium.org/3978007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63836 0039d316-1c4b-4281-b951-d872f2087c98
* Create a symlink to Release/lib.target/_pyautolib.so in Release/ on Linuxnirnimesh@google.com2010-10-261-0/+18
| | | | | | | | | | | Shared libs on linux get created in lib.target. Create a symlink from the product directory (out/Release) to the built shared library, so that pyauto can be run on the bots after building. BUG= TEST= Review URL: http://codereview.chromium.org/4136001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63834 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Some cleanup of sync_listen_notifications toolakalin@chromium.org2010-10-263-67/+64
| | | | | | | | | | | | | | | | | | Removed sync_listen_notification-only switches from chrome_switches.{h,cc}. Renamed "cache invalidation" to "server notifier". Made the server notifier be the default notifier. Added option to send an initial notification for the legacy notifier (helpful when debugging the python XMPP server). BUG=None TEST=Manually Review URL: http://codereview.chromium.org/3826006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63831 0039d316-1c4b-4281-b951-d872f2087c98
* Pass --use-gl command line argument to renderer process for use withkbr@chromium.org2010-10-261-0/+3
| | | | | | | | | | | | --in-process-webgl. This is a partial fix mostly for Windows. Tested manually with WebGL content. BUG=55152 TEST=none Review URL: http://codereview.chromium.org/4127002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63829 0039d316-1c4b-4281-b951-d872f2087c98
* Add 2 find_in_page testsnirnimesh@chromium.org2010-10-262-0/+34
| | | | | | | | | | | | | | | testFindIsNotCaseSensitive testLocalizationAndCaseOrder (Tests by Deepak. Origianlly reviewed and LGTMed at: http://codereview.chromium.org/3994003/show) BUG= TEST= Review URL: http://codereview.chromium.org/4144001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63818 0039d316-1c4b-4281-b951-d872f2087c98
* [linux] instant search/browsing first cutestade@chromium.org2010-10-267-81/+179
| | | | | | | | | | | Implements the tab contents switching stuff (but not the suggestion text bit). BUG=58937 TEST=manual (must be enabled in about:flags) Review URL: http://codereview.chromium.org/4049002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63815 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: Fix file selector moving up one dir each time you use it.mattm@chromium.org2010-10-251-8/+18
| | | | | | | | | | | If default_path is a directory, start the file open dialog in that dir, rather than in the parent with that dir selected. BUG=49081 TEST=see #2 on bug Review URL: http://codereview.chromium.org/4121001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63807 0039d316-1c4b-4281-b951-d872f2087c98
* Never allow empty preview entries. As some data is always present (we drop ↵georgey@chromium.org2010-10-2510-106/+74
| | | | | | | | | | | completely empty profiles), display this data in preview if name and first line of address is not available. TEST=in the bug + unit-test BUG=50320 Review URL: http://codereview.chromium.org/3806008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63806 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure save-as right click menu obeys content restrictions.jam@chromium.org2010-10-251-0/+6
| | | | | | | BUG=60347 Review URL: http://codereview.chromium.org/4089001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63804 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Avoid assert if WM tells us to select invalid tab.derat@chromium.org2010-10-252-1/+6
| | | | | | | | | | | | | | | | The window manager gets notified asynchronously when the number of tabs in a window changes, so there's no guarantee that the select-tab messages that the WM sends will always have a valid index in them. This change makes us ignore invalid messages instead of CHECK()-ing when we receive them. BUG=chromium-os:8103 TEST=built an evil window manager that always sends index -1 and checked that chrome stops crashing with this change Review URL: http://codereview.chromium.org/4089002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63803 0039d316-1c4b-4281-b951-d872f2087c98
* Fix heap leak with scoped_ptr.tessamac@google.com2010-10-251-1/+1
| | | | | | | | | BUG=60617 TEST=tools/heapcheck/chrome_tests.sh -t unit Review URL: http://codereview.chromium.org/4115001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63802 0039d316-1c4b-4281-b951-d872f2087c98
* Autofilled values should match previewed values for previously autofilled forms.isherman@chromium.org2010-10-253-11/+24
| | | | | | | | | | | | | It is possible to autofill a form more than once, e.g. by autofilling it and then clearing some of the fields. We used to show different values for previewing vs. filling the form. This patch makes those values consistent. The behavior is far from perfect for yucky edge cases, but the whole approach to autfilling a single form multiple times is being rethought, so this should be fine in the interim. BUG=60399 TEST=Manually inspected (again, this interaction is being reconsidered, so not going to add temporary tests). Review URL: http://codereview.chromium.org/4030003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63800 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 11:35:49 +0000