| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHost so that we can get rid of the pass-throughs in WebContents.
I removed some redundant checks in WebContents when calling view() for
render_view_host() since that internally checks the null-ness of
render_view_host().
BUG=1323267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rahulk
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Frames.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
settings.
BUG=1296800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
etc.) from jstemplate comments.
Do a little trivial code compaction (strip // comments) in compile.sh.
BUG=1325652
TEST=make sure about:memory and other about: pages work and don't show bad
stuff in their source (ctrl-U or View Source from the Developer menu)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
night).
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. TabContentsWasDestroyed wasn't removing from the collector map,
resulting.
. The collector map wasn't cleared in Destroy when it should have
been.
This was the cause of random ui failures.
BUG=1324555
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
and /MAP in the target lists for setup.exe and mini_installer.exe.
TBR: tc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
The Chrome debugger tests use mjsunit.js from the V8 test framework. In the transition to a new structure for V8 on code.google.com the location of this file will change. A local copy is added temporaly to the debugger tests directory which can be removed when Chrome starts to use V8 from code.google.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shell sample.
Removed the v8_shell project from the Chrome solution and added
v8_shell_sample instead.
Changed the Chrome JavaScript debugger tests to use v8_shell_sample instead
of v8_shell.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR= tc@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
store as this hurts performance.
Bug=1314407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR= tc@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- remove call from MessageWindow::~MessageWindow()
- fix bug in zombie killer so it recognizes own childs
BUG=1323601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't really believe this will solve anything (in terms
of the bug), but it did remove some needless complexity
above the crash site in the stack. There is a tiny chance
that there is a shutdown race, where the destruction of the
containing object raced ahead of the execution (and
resulting destruction) of a task. I think the destruction
of the task by the containing object would probably be
bad anyway, and I doubt that it even happens... so this
is all about being cleaner.
bug=1318039
r=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to avoid the rietveld 1mb diff limit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
output target of .exe files on Windows. Change all the callers to
only pass in the basename of the target (e.g., 'base_unittests').
The only exception is chrome.exe which uses chrome_exe.pdb.
This lets us remove a "if env['PLATFORM'] == 'win32'" condition from
base/SConscript and these other files going forward.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
schemes.
BUG=1323921,1323917
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=1324185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bookmark_editor_view_unittest.cc file.
Overlooked adding browser_views.lib to link of unit_tests.exe.
TBR: sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1324185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
use set_default_width, but that gives you a size based on the average font size, so if you pass in 15 you might only fit ie. 11 chars, depending on what the text is.
I'd like to just say, take up all the width you have available - up to the icon in the dialog, that is, but the icon is part of a background image, so I just define a set width for the text field.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
won't need this separate class.
B=1031852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1323423
TEST=this is some tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
CHROME_BUILD_TYPE=_official.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SessionService. There were already some notifications that could be used to
tell what's going on, and I filled out the rest. I moved some notifications from
various places to the NavigationController.
In ssl_blocking_page, I removed a notification because it also calls
DidNavigateToEntry which does the notification (we got duplicate calls before).
In browser.cc I removed the tab parented notification since this is already
called by NavigationController::SetWindowID.
I removed some obsolete notifications and associated structures, especially in
history (like HOST_DELETED that was never issued).
I renamed the window_map_ in the MetricsService becuase it was actually a map
of controllers and Windows.
This also reorders the navigation_types header file to try to bring some order
to it.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with a test.
BUG=none
TEST=none; just make sure context menu for bookmark bar still works
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
2000
and add debugging information to know how SavePageTest.SaveCompleteHTML is failing.
TBR=rocking
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
disabled). Also disable PrintingLayoutTest.IFrame, it's still flaky.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adds a timeout in waiting for a tab to be restored.
2. Adds a bunch of printfs that will hopefully let me figure out where
the test is failing.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and browser_views.lib(65 source files, 30 megs).
This will hopefully improve link time (well, not as much as I'd like) and will definitely help non-IB compilation parallelization.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
distributed tests. The goal is to make a test run of all combinations of 4 (as opposed to 5 now) for a total of 34^4 commands (as opposed to 17^5) and see what comes out of it. We won't be running any random keypresses in this run (except in the Dialog fuzzers), only explicit actions.
There were also some discrepancies in how we were using the HTML elements, which I have fixed (Import is now ImportSettings, EditKeywords is now EditSearchEngines and ClearBrowserData is now ClearBrowsingData). I also reordered some functions to match .h file (alphabetical order).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
the IDC handler for ViewSource. If Navigate is not called before ViewSource we get a crash when trying to use the output from GetLastCommittedEntry(). To facilitate automatic testing We should instead just check it for null and only do something if a URL is available to us.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
account the width of the Go button when sizing the location bar so that the last button on the toolbar (the app menu) spilled off the end.
TBR=glen
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
-remove reply_lock_ since received_replies_ was only being used on the IPC thread
-stop using nested locks
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rather than creating a frankenstein separate window type for popups, this just uses BrowserView2, and the regular BrowserToolbarView, but hides all the irrelevant controls.
B=1031854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
get crash reports.
- Added env_vars to exe project instead of keep duplicating the strings.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the listener thread. I've fixed the renderer crashes which were happening because
SyncChannel was going away before the listener thread.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@762 0039d316-1c4b-4281-b951-d872f2087c98
|