summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* back out CLs 21367, 21366 - no idea why these keep breakingdpranke@google.com2009-07-232-0/+376
| | | | | | Review URL: http://codereview.chromium.org/155983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21371 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ipc_tests.exe is not getting built for Windows release.agl@chromium.org2009-07-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | (Broke in r21342) <jamesr> agl: chromium XP release builder builds chrome.sln and then tries to run ipc_tests.exe. nothing in chrome.gyp depends on ipc_tests now so the executable doesn't exist on that builder <jamesr> agl/jrg: adding a dependency on ../ipc/ipc.gyp:ipc_tests to the 'coverage' target would solve both issues <jrg> jamesr: agl's change will only impact the coverage bots. Sounds like that't not what you want, right? <jamesr> jrg: i think it's correct but won't resolve the chromium XP issue. coverage should run for those tests either way <agl> jamesr: how about I tie it to unit_tests? <agl> jamesr: there's a long term solution and then there's getting the builder green. <jamesr> agl: yeah. trying to check super fast if getting that builder to not run ipc_tests.exe is easy http://codereview.chromium.org/155977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21369 0039d316-1c4b-4281-b951-d872f2087c98
* re-do CL 21252 - move image_diff to tools, add deps to test_shelldpranke@google.com2009-07-232-376/+0
| | | | | | | | | | | | | | | CL 21252 seems to have had some svn brokenness (not sure why). I've recreated it and resubmitted it. The changes are to move image_diff from chrome/tools/test to tools/, and to make test_shell depend on image_diff and npapi_layout_test_plugin (and test_worker, where applicable) R=nsylvain@chromium.org TEST=none BUG=none Review URL: http://codereview.chromium.org/155959 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21366 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak thumbnail sizes a bit so it the NNTP looks better side by side onarv@google.com2009-07-235-21/+23
| | | | | | | | | | | | | | | | | | a 1920x1200 screen. Also, tweak the default size of new windows slightly. In case we decide to use side by side windows size the window in such a way that 2 windows fit on the screen and have the kWindowTilePixels spacing between each other and the screen edges. BUG=None TEST=Show two windows side. On a 1920x1200 screen they should both be showing the thumbnails in normal size. Review URL: http://codereview.chromium.org/155930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21364 0039d316-1c4b-4281-b951-d872f2087c98
* Fix undefined object properties showing up in reference pages.rafaelw@chromium.org2009-07-231-4/+7
| | | | | | Review URL: http://codereview.chromium.org/159231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21362 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the first thread in a child process to be the main thread, and make ↵jam@chromium.org2009-07-2326-353/+208
| | | | | | | | theIO thread be the second thread. The change is needed for plugins on mac. Review URL: http://codereview.chromium.org/155944 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the NOTIMPLEMENTED from IsDefaultPluginEnabled for Macstuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=17392 TEST=Less console spew on test bots. Review URL: http://codereview.chromium.org/155881 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21351 0039d316-1c4b-4281-b951-d872f2087c98
* Populate the Linux extension shelf with placeholder labels containing each ↵phajdan.jr@chromium.org2009-07-232-22/+108
| | | | | | | | | | | extension's name. TEST=none http://crbug.com/16759 Review URL: http://codereview.chromium.org/155957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21350 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a regression from r21320 which caused a crash when dragging a tab ↵jhawkins@chromium.org2009-07-232-1/+11
| | | | | | | | | | out of the browser. We must wrap the tab renderer widget in a GtkFixed in order to maintain the size we request for the widget; otherwise, the widget will fill the entire window. BUG=none TEST=Drag a tab out of the window. This should not crash. Review URL: http://codereview.chromium.org/155965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21348 0039d316-1c4b-4281-b951-d872f2087c98
* Flip on crashed plugin name lookup on the Mac.stuartmorgan@google.com2009-07-231-1/+1
| | | | | | | | | BUG=none TEST=Running with --enable-plugins on, go to a page with a plugin and kill the plugin process. The info bar should list the name of the plugin rather than its path. Review URL: http://codereview.chromium.org/155952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21347 0039d316-1c4b-4281-b951-d872f2087c98
* One part of many for enabling DOM Storage.jorlow@chromium.org2009-07-237-22/+536
| | | | | | | | | | | | | | Add browser-process IPC code + tweak the WebKit Thread. Note that this code can't possibly be called/run yet. WebKitThread now has a PostIOThreadTask methods that can safely post back to the IO thread. This should be used for all WebKit thread -> the rest of the world communication. There are many TODOs in this code that should be resolved before this is shipped without a --enable-local-storage flag. BUG=4360 TEST=none Review URL: http://codereview.chromium.org/155845 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21346 0039d316-1c4b-4281-b951-d872f2087c98
* Show bookmark manager context menu on mouse down, not up.estade@chromium.org2009-07-232-4/+56
| | | | | | | | | | | If the mouse down occurs over an unselected row, let the default handler run before we show the context menu (so that row will be selected when we show the menu). If the mouse down occurs over a selected row, don't let the default handler run (because if multiple rows are selected the rest of the selection would get clobbered). BUG=http://crbug.com/17388 TEST=see bug Review URL: http://codereview.chromium.org/159179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21344 0039d316-1c4b-4281-b951-d872f2087c98
* Split the IPC code into ipc/agl@chromium.org2009-07-22118-9734/+368
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This splits the ipc code from the common project. The 'common' project pulls in all of webkit, the v8 bindings, skia, googleurl, and a number of other projects which makes it very difficult to deal with especially for external projects wanting just to use some of Chromium's infrastructure. This puts the ipc code into its top-level ipc/ directory with a dependency only on base. The common project depends on the new ipc/ipc.gyp:ipc target so that all projects currently pulling common in to get the IPC code still have it available. This mostly follows agl's pre-gyp attempt to do this which was r13062. Known issues: - Currently a number of projects depend on chrome/chrome.gyp:common in order to use the IPC infrastructure. Rather than fixing all of these dependencies I have made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules section of DEPS so that checkdeps.py doesn't complain. Over time projects that need IPC should depend on the IPC project themselves and dependencies on common removed, although I don't think many projects that need IPC will be able to get away without common currently. - ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve this since it's really an IDE bug - the named pipe name (windows+linux) and the logging event name (all) + env variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion of ipc/ being an independent library. I think this should be examined in a subsequent, much smaller patch. - I've eliminated the IPC.SendMsgCount counter since it was implemented in a way to create a dependency from ipc/ to chrome/common/chrome_counters. This is the same approach that r13062 took. http://codereview.chromium.org/155905 (Patch from James Robinson) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
* Fix my previous revert. Merge issues.mpcomplete@chromium.org2009-07-221-3/+0
| | | | | | TBR: aa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix an issue with unregistering content script contexts."mpcomplete@chromium.org2009-07-224-38/+27
| | | | | | | | | | | | browser_tests are not happy. TBR=aa BUG=no TEST=no Review URL: http://codereview.chromium.org/159243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21340 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/155945 which was erroneously reverted.rafaelw@chromium.org2009-07-227-341/+576
| | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/159240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21338 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 2 extension messaging browsertests until I can figure out why they arempcomplete@chromium.org2009-07-221-0/+4
| | | | | | | | | | | | failing on the buildbot. TBR=aa BUG=no TEST=no Review URL: http://codereview.chromium.org/159235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21336 0039d316-1c4b-4281-b951-d872f2087c98
* revert r21327, which broke MessagingExtensionTabestade@chromium.org2009-07-227-576/+341
| | | | | | | | | | <http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests> tbr=rafaelw Review URL: http://codereview.chromium.org/155955 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21334 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent omnibox autocomplete from stealing the primary X selection.estade@chromium.org2009-07-222-31/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly accomplished by decoupling autocomplete (and the auto-select-all when first clicking in the omnibox to focus it) from GTK's clipboard code. Before we update the selection marks, I unregister the clipboard and block the signal from reaching my handler. Afterwards, I restore things. This creates the possibly-odd effect that text can be highlighted both in the omnibox and in Webkit, assuming that the omnibox text isn't actually the primary selection. I think that this is reasonable, but let me know if you can think of a better way that it should be handled. To test, I confirmed that all of the cases listed in http://codereview.chromium.org/151006's description still work, along with the following new ones: 1. Highlight text in an xterm to make it the primary selection. Start typing an autocomplete-able URL into Chrome's omnibox. Middle-click in the xterm and check that the xterm's text, rather than the autocompleted text from the omnibox, is pasted. 2. Now switch to a different tab and middle-click in the xterm again. The xterm's text should still be pasted. 3. Switch to the original tab and check that the xterm's text is still the primary selection. 4. Highlight text in an xterm. Click in Webkit to make sure that the omnibox doesn't have the focus. Left-click in the omnibox. Its text should be highlighted but not made the primary selection (middle-clicking in the xterm should still paste the xterm's text). EDIT: I've changed this behavior -- clicking in the omnibox to focus it now sets its text as the primary selection. 5. Now triple-left-click in the omnibox to highlight all of its text. This time, the URL should become the primary selection. EDIT: This is no longer relevant. I noticed the following annoying behavior, but it's also present in the official build without this change, so I don't think it's a regression (there's probably something going on in GTK that I don't understand): Highlight some text in the omnibox to make it the primary selection. Now double-left-click to highlight a word in an xterm. The word flashes in the xterm, but Chrome automatically grabs the selection again. Double-clicking in the xterm again lets it hang on to the selection. Patch by Dan Erat <derat [at] google> original review url: <http://codereview.chromium.org/159185> Review URL: http://codereview.chromium.org/159230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21329 0039d316-1c4b-4281-b951-d872f2087c98
* Made the title of panels show focused state with black textdavemoore@chromium.org2009-07-224-6/+62
| | | | | | | (as opposed to grey text in unfocused panels) Review URL: http://codereview.chromium.org/159176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21328 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions Doc:rafaelw@chromium.org2009-07-227-341/+576
| | | | | | | | | | | | | | | | Expand complex types in reference pages. Support $ref for types in docs. Added Kathyw's template changes including leftNav and header. Remove old api files. R=aa Review URL: http://codereview.chromium.org/155945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21327 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to provide asynchronous read in data source:hclam@chromium.org2009-07-224-997/+3
| | | | | | | | | | | | | 1. FFmpegGlue now taks a FFmpegProtocol instead of DataSource as input 2. FFmpegDemuxr implements FFmpegProtocol and does the blocking read and submit asynchronous read request to DataSource (with unit tests) 3. Changed SimpleDataSource to work with asynchronous read (with unit tests) 4. Reimplemented BufferedDataSource to work with asynchronous read (with unit tests) 5. Moved BufferedDataSource from chrome/renderer/media to webkit/glue/media (for faster build/debug and better coverage in automated testing) TEST=BufferedDataSourceTest.*, SimpleDataSourceTest.*, FFmpegDemuxerTest.* Review URL: http://codereview.chromium.org/149567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue with unregistering content script contexts.mpcomplete@chromium.org2009-07-224-28/+38
| | | | | | | | | | | Reenable content script messaging test. BUG=no TEST=no Review URL: http://codereview.chromium.org/155887 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21324 0039d316-1c4b-4281-b951-d872f2087c98
* Make UtilityProcessHost destructor virtual.mattm@chromium.org2009-07-221-1/+1
| | | | | | | | BUG=17129 Review URL: http://codereview.chromium.org/155946 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21323 0039d316-1c4b-4281-b951-d872f2087c98
* Try and improve result coalescing/display in the omnibox popup.pkasting@chromium.org2009-07-224-144/+66
| | | | | | | | | | | | | | | | | | | | | | | | This eliminates the delay timer in the popup view, and also eliminates the coalesce timer in the controller. Instead, we simply coalesce until we're done, we have at least as many results as we're already showing, or the "maximum delay timeout" (300 ms) fires, indicating we've gone too long without updating. Additionally, in order to be more responsive when typing rapidly, the controller updates observers immediately with the available results from a previous query if one is still running when a new query is started. While in theory this seems like it might produce flicker, in practice _not_ having it also results in flicker (just less-predictable flicker) since the 300 ms timeout starts kicking in at random times relative to when new keys are pressed. I also fixed a few small problems with leaving 1-pixel high white rows at the bottom of the popup during rapid typing (which weren't visible before this change since the popup would never shrink during rapid typing). After eliminating the timeout in the popup view, I was able to refactor the code to be shorter since a few members and helper functions could all be inlined. Then I added some long comments and made things not much shorter after all :/. I also changed two other (self-contained) unrelated spots in the popup to be shorter. Please patch this in locally and try how it feels. Things to test with this change vs. the old code vs. the old, old (original omnibox) code: * Type one letter at a time with long pauses in between; see how flickery the popup is * Type one letter (e.g. "a") and then type rapidly for a while; see how responsive the popup is * Type words like "amazon", "compusa" and "comcast" at various different speeds and observe the flicker vs. responsiveness tradeoff * Type or paste some long series of letters (that default to searching), then rapidly press and release the ctrl key My hope is that this hits a good balance (it's very difficult to be both flicker-free and responsive, I view the previous two sets of code as being off first one side of the scale and then the other). Possible tweaks include the animation tweening mechanism and timing (I experimented with various different speeds and linear tweening, nothing felt significantly better to me but my machine sucks w.r.t. animation quality) and tweaking the controller "max timeout" value and notification behavior upon starting a new query (I tried notifying only if two keys had been typed since the last notification, it didn't feel better). BUG=none TEST=see above Review URL: http://codereview.chromium.org/149659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21322 0039d316-1c4b-4281-b951-d872f2087c98
* Nasty short-term hack to special case display of dialogaa@chromium.org2009-07-225-31/+65
| | | | | | | | | | | | | | | on theme installation. It should not be displayed if the theme was installed from our gallery URL. I intend to fix this very soon, but I wanted it to make this coming build, so I did this quick thing for now. Also, I found another bug in ExtensionsService install logic. There was a test, it was ensuring the wrong behavior :(. Review URL: http://codereview.chromium.org/155936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21321 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Keep track of the tab bounds using the size-allocate signal. ↵jhawkins@chromium.org2009-07-222-7/+29
| | | | | | | | | | Previously we assumed that the tab was immediately sized as requested, which was not always happening. This fixes a problem seen in RTL layout where the close button would be incorrectly positioned. BUG=16756 TEST=Open the browser in a RTL language. Notice that the close buttons on tabs are positioned correctly. Review URL: http://codereview.chromium.org/155942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21320 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore errors about creating audio output streamhclam@chromium.org2009-07-222-5/+7
| | | | | | | | | | | | | | | Instead of failing the media playback pipeline completely, this change will ignores all errors reported by the browser about audio output streams. This is the first step towards handling audio hardware errors. TEST=MediaTest.VideoBearTheora Review URL: http://codereview.chromium.org/159205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21318 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 1px of grey at the bottom of the render view.phajdan.jr@chromium.org2009-07-221-2/+7
| | | | | | | | | | | It was a part of extension shelf not hiding fully. TEST=On Linux, open any website with links and mouse hover over any link. There should be no gap between the status bubble and the bottom of the window. http://crbug.com/17324 Review URL: http://codereview.chromium.org/155934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21314 0039d316-1c4b-4281-b951-d872f2087c98
* Step 2 in abstracting Extension APIs to shared "IDL".rafaelw@chromium.org2009-07-2216-484/+743
| | | | | | | | | | In this step, all "normal" async extension apis have been pulled out into extension_api.json which is loaded in the renderer, and dynamic bindings are created for extension functions & events in extension_process_bindings.js. R=aa Review URL: http://codereview.chromium.org/155741 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21313 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 2780 -- RTL: Omnibar - message "Press Tab to search ↵xji@chromium.org2009-07-222-35/+38
| | | | | | | | | | | | | | | | | Google" doesn't show correctly in a "New Tab" for RTL locales Because of the bug in PosFromChar() (see bug report for detailed information), we actually calculate the width of the string ourselves using font.GetStringWidth(). BUG=http://crbug.com/2780 TEST= 1 Start Chrome with a *new user data directory* and make sure the UI language is Hebrew. 2 Type www.google.com in the omnibox and press Enter. 3 Close and re-open the browser. 4 Type character "h" in Ominibox 5 Message "Press Tab to search Google" should show correctly, not only "Tab" is displayed Review URL: http://codereview.chromium.org/155789 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21312 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add support for tm_zone to localtime via the sandbox.agl@chromium.org2009-07-222-8/+21
| | | | | | | | | | | | | | | | Glibc adds a field to struct tm, tm_zone, which contains a pointer to a string for the current time zone. Since this makes struct tm a non-POD data type, it only works for the non-thread-safe localtime() call, not localtime_r(). However, V8 relies on it so this patch adds support for passing it through our sandbox. BUG=17458 http://codereview.chromium.org/159216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21311 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't handle up/down-arrow unless popup is visible.shess@chromium.org2009-07-222-8/+18
| | | | | | | | | | http://crbug.com/17013 TEST=Browse to www.google.com. Click in the field. Up-arrow should go to beginning of line, down-arrow to end. Review URL: http://codereview.chromium.org/155871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21310 0039d316-1c4b-4281-b951-d872f2087c98
* Make double-clicking on the tab strip minimize (i.e., "miniaturize") thepinkerton@chromium.org2009-07-222-13/+49
| | | | | | | | window. Patch from viettrungluu@gmail.com (Viet-Trung Luu). BUG=12286 TEST=double-clicking tab strip and anything that may have regressed in bug 12505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21308 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk cookie manager part 1.mattm@chromium.org2009-07-227-228/+776
| | | | | | | | | | | | (Doesn't display cookie details, otherwise working.) BUG=11507 TEST=All cookie manager functions should work as expected, other than viewing the cookie details. Review URL: http://codereview.chromium.org/159187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21307 0039d316-1c4b-4281-b951-d872f2087c98
* Load Mac download shelf icons asynchronously.paul@chromium.org2009-07-225-11/+61
| | | | | | | | | BUG=16226 (http://crbug.com/16226) TEST=none. Review URL: http://codereview.chromium.org/155831 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21305 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Only accept text/uri-list drops in the tab strip. We were accepting ↵jhawkins@chromium.org2009-07-221-4/+2
| | | | | | | | | | text/plain before, which was giving us the html for a dragged image instead of the url of the image. BUG=16165 TEST=Go to google.com. Drag the Google logo into the tabstrip. The image should open up in a new tab (or the current tab, depending on the drop). Review URL: http://codereview.chromium.org/159212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21304 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make --renderer-startup-dialog work on Linux.agl@chromium.org2009-07-221-2/+14
| | | | | | | | | | | | | | | | This is needed, along with --enable-sandbox-debugging, to debug SUID sandboxed renderers. With this patch, one can run: ./out/Debug/chrome --enable-sandbox-debugging --renderer-startup-dialog Then, in GDB, attach to the PID which is printed to stderr and continue. Then send SIGUSR1 to the PID to resume the renderer. http://codereview.chromium.org/159211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21303 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generate a manpageevan@chromium.org2009-07-223-0/+106
| | | | | | | | This is not intended to be complete; hopefully we can iterate from here. Review URL: http://codereview.chromium.org/159198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21298 0039d316-1c4b-4281-b951-d872f2087c98
* Only check --lang and the app language pref on Windows. Theytc@google.com2009-07-221-6/+46
| | | | | | | | | | | | | | | | don't make sense on Linux/Mac so disable them. I think we don't want to have a app language option on Linux since the standard way to do this is to use LANG or LC_ALL. Update the locale ui test to set LC_ALL on Linux. BUG=15359 Review URL: http://codereview.chromium.org/155819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21295 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Bar Add Folder / Rename Folder dialog and controller.jrg@chromium.org2009-07-229-20/+671
| | | | | | | | | | | | TEST=Right click on bar --> Add Folder... Type a name and it shows up as a folder in the bookmark bar. (You can't do anything with it yet; sorry). Right click on folder name --> Edit... Make sure you can rename the folder. Review URL: http://codereview.chromium.org/159183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21293 0039d316-1c4b-4281-b951-d872f2087c98
* The ExternalTabContainer object which implements the TabContentsDelegate ↵ananta@chromium.org2009-07-222-1/+27
| | | | | | | | | | | | | | interface now implements the ShowHtmlDialog function which is needed to support HTML dialog popups like those displayed by Gears.' Fixes http://b/issue?id=1963582 Bug=1963582 Review URL: http://codereview.chromium.org/159162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21289 0039d316-1c4b-4281-b951-d872f2087c98
* Fix line endings doc files.rafaelw@chromium.org2009-07-227-486/+486
| | | | | | | | TBR Review URL: http://codereview.chromium.org/155927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21288 0039d316-1c4b-4281-b951-d872f2087c98
* Make DND use the anchor name.arv@google.com2009-07-221-1/+2
| | | | | | | | | | | | BUG=17408 TEST=Drag a thumbnail from the NNTP to your desktop of your bookmakrs bar. The title should be used. Review URL: http://codereview.chromium.org/159184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21286 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix a regression from r20404 which keeps a drag into the tabstrip from ↵jhawkins@chromium.org2009-07-222-27/+34
| | | | | | | | | | working. Only destroy the container widget and not the drop info itself when the drag leaves the tab strip; otherwise, we'll lose the drop information used to open the link. BUG=none TEST=Drag a link into the tab strip. The drop arrow should appear and disappear as the mouse enters and leaves the tab strip. Drop the link into the tab strip. The link should be opened in the new tab (or the current tab). Review URL: http://codereview.chromium.org/159178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21285 0039d316-1c4b-4281-b951-d872f2087c98
* Make scrollbars and other controls tint/untint upon main window gainingthakis@chromium.org2009-07-2211-1/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | focus on Mac. This entails the following: - getting notifications that the main window has become or lost key window status (in BrowserWindowController) [new] - ... which tells the RenderWidgetHostView(Mac) to (de)activate [new] - ... which tells the RenderWidgetHost to (de)activate [new] - ... which sends a ViewMsg_SetActive message [new message] to the RenderView [new] - ... which tells the WebView(Impl) to (de)activate [new] - ... which tells its page()'s FocusController to (de)activate [new] - ... which is now in WebKit-land. N.B.: "Activate" is the nomenclature used in WebKit; "focus"/"blur" can sometimes (kind of) mean the same thing, but is ambiguous, since "focus" has a more specific meaning. Added a WebView unit test, which currently only tests to make sure that SetActive() (and IsActive() [also new]) work correctly. The changes to the other classes aren't very testable since they don't actually do anything (other than pass things along). BUG=12507 TEST=webkit/glue/webkit_unittest.cc Patch by viettrungluu@gmail.com (see http://codereview.chromium.org/159048 ), r=avi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21284 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure installer_util_string is always built beforensylvain@chromium.org2009-07-221-6/+15
| | | | | | | | | | | | | installer_util. It was triggering a bug in Incredibuild. By making one of the dependent of install_util a dummy_executable, and making this dummy_executable depends on installer_utils_strings, the odds that it triggers a bug is a lot smaller. I tried 6 clobber builds so far and none of them failed. Review URL: http://codereview.chromium.org/155923 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21283 0039d316-1c4b-4281-b951-d872f2087c98
* Add a custom subclass of GTMUILocalizer that skips the bundle work so we can ↵thomasvl@chromium.org2009-07-222-0/+53
| | | | | | | | | | | | directly use these from nib files without some extra overhead. Updated the generator to make things based off this subclass. TEST=none BUG=16764 Review URL: http://codereview.chromium.org/159197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21280 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: generate a manpage"evan@chromium.org2009-07-222-90/+0
| | | | | | | This reverts commit r21277, since it failed on the scons build for reasons totally opaque to me. :~( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21278 0039d316-1c4b-4281-b951-d872f2087c98
* linux: generate a manpageevan@chromium.org2009-07-222-0/+90
| | | | | | | | This is not intended to be complete; hopefully we can iterate from here. Review URL: http://codereview.chromium.org/159198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21277 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 23:04:13 +0000