summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Switching in new gyp version (which changes 'none' back to how it was before).bradnelson@chromium.org2009-07-101-1/+1
| | | | | | | | | | | Updating installer_util_strings to use dummy_executable. BUG=None TEST=None Review URL: http://codereview.chromium.org/155371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20408 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable property from some more files that don't need it.thestig@chromium.org2009-07-1052-95/+95
| | | | | | | TBR=evmar Review URL: http://codereview.chromium.org/149471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20406 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few issues with the drop arrow in the Linux tab strip:jhawkins@chromium.org2009-07-102-26/+19
| | | | | | | | | | | | | * Reset the drop info when completing a drag (successful or otherwise). * Reset the drop info when the drag leaves the tab strip zone. * Report success or failure of the drop back to the source widget. * Move and resize the drop arrow container before showing it to reduce visual jank. BUG=none TEST=Drag a image into the tab strip so that the drop arrow appears. Release the drop over the tab strip and then move the window and repeat the process. The drop arrow should be in the correct position. Notice that there is no visual jank when the drop arrow is shown. Review URL: http://codereview.chromium.org/149426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20404 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Set bg/text colors for the download shelf.erg@google.com2009-07-106-20/+95
| | | | | | | | (This does not change the button image.) Review URL: http://codereview.chromium.org/155365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add button tinting to the toolbar buttons.""tc@google.com2009-07-106-38/+121
| | | | | | | | | | | | | This reverts commit r20399 and re-applies the button tinting code. There's a fix for the go button gtk unittest by checking to see if the browser is non-NULL before getting the theme provider. TBR=erg Review URL: http://codereview.chromium.org/155369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20402 0039d316-1c4b-4281-b951-d872f2087c98
* Only enable breakpad and keystone for official branded builds so the rolling ↵thomasvl@chromium.org2009-07-101-22/+32
| | | | | | | | | | google chrome build doesn't spend the time doing the work for these things. BUG=none TEST=Official builds still auto update and have breakpad. Review URL: http://codereview.chromium.org/155364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20401 0039d316-1c4b-4281-b951-d872f2087c98
* Convert JavascriptAlertActivatesTab to browser_tests framework.phajdan.jr@chromium.org2009-07-107-22/+98
| | | | | | | | | | | | This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can wait for AppModalDialog to appear and close it. TEST=Covered by browser_tests. http://crbug.com/16062 Review URL: http://codereview.chromium.org/149460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20400 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add button tinting to the toolbar buttons."tc@google.com2009-07-106-121/+38
| | | | | | | | | | | This reverts commit r20396. TBR=erg Review URL: http://codereview.chromium.org/155367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20399 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: don't bother passing the chroot directory fd to the zygote.agl@chromium.org2009-07-101-16/+2
| | | | | | | | | | | | | Markus pointed out that the cwd was already shared between the chroot helper process and the zygote, therefore we could avoid some complexity in passing the file descriptor so, also, we could then make the directory mode 0000. http://codereview.chromium.org/155366 BUG=16363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20398 0039d316-1c4b-4281-b951-d872f2087c98
* Add button tinting to the toolbar buttons.tc@google.com2009-07-106-38/+121
| | | | | | | | | | | | | | | | Make CustomDrawButtonBase aware of the ThemeProvider. If the theme changes, we reload new pixbufs from the ThemeProvider. This breaks RTL of the toolbar buttons, I'll add that back in a follow up change to BrowserThemeProvider. BUG=15506 TEST=Change themes or set the GTK+ theme. The star button and go button should be tinted according to the theme (other buttons as well if not using GTK+ buttons). Review URL: http://codereview.chromium.org/149432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when clicking a popup entry while composing in the Microsoft IME ↵pkasting@chromium.org2009-07-102-1/+26
| | | | | | | | | | | | on XP. We were forcing the IME to close during the process of updating the edit, which in turn caused us to try and handle "changes to the edit", leading to us (wrongly) rerunning autocomplete and blowing away our result set. BUG=13500 TEST=On XP, open a new tab, set the (Microsoft) IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate, not crash. Review URL: http://codereview.chromium.org/155330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20395 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'version' text field in About Box selectable.jrg@chromium.org2009-07-101-3/+3
| | | | | | | | | BUG=crbug.com/15642 TEST=select version in about box; copy/paste it somewhere. Review URL: http://codereview.chromium.org/155361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20394 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable unit tests with leaks until I can check in a fix for them.asargent@chromium.org2009-07-101-5/+5
| | | | | | | | | | | BUG=http://crbug.com/16444 TEST=none TBR=eroman Review URL: http://codereview.chromium.org/155362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20393 0039d316-1c4b-4281-b951-d872f2087c98
* Test video files for test_shell_tests and ui_testshclam@chromium.org2009-07-104-0/+0
| | | | | | Review URL: http://codereview.chromium.org/155356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20392 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/155360tejasshah@google.com2009-07-102-4/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20391 0039d316-1c4b-4281-b951-d872f2087c98
* Add 16276 to crash known list.huanr@chromium.org2009-07-101-0/+3
| | | | | | Review URL: http://codereview.chromium.org/155357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20390 0039d316-1c4b-4281-b951-d872f2087c98
* A little bit of bookmark bar cleanup, a little bit of padding improvement.estade@chromium.org2009-07-105-56/+40
| | | | | | | | | | | | | | | | | | The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically). The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open). The code for packing bookmark bar buttons is now all in one place. Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal. BUG=15870 TEST=things look marginally better, theming still works properly Review URL: http://codereview.chromium.org/155342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20389 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use a temp directory for the chroot.agl@chromium.org2009-07-102-14/+28
| | | | | | | | | | | | | | | Ubuntu systems (at least) wipe /var/run at boot time, which is deleting our sandbox directory. Instead, we have the SUID helper create a temp directory in /tmp, unlink it and use that for the chroot directory. A file descriptor is passed to the zygote process for it to fchdir into. (Thanks to fta for discussions on this.) BUG=16363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20388 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionBrowserEventRouter now observes TAB_CONTENTS_DESTROYED. This became ↵rafaelw@chromium.org2009-07-101-14/+18
| | | | | | | | | | necessary with the addition of dockable devtools TabContents. It is now possible for Tab contents to close after having been detached without being re-attached to a browser (as in the case of docking). TBR=pfeldman Review URL: http://codereview.chromium.org/149429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20387 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flakiness-inducing part of AutomationProxyTest.NavigateToURLWithTimeout1.phajdan.jr@chromium.org2009-07-101-4/+0
| | | | | | | | | | | | | | | | | It was loading an URL with big timeout and expecting it not to timeout (ok-ish), but then it loaded the *same* URL with a small timeout and expecting it to timeout. It turns out that reloading same URL can be really quick, especially on Linux. And we're testing the scenario when it doesn't timeout in NavigateToURLWithTimeout2. It just doesn't "preload" the page. TEST=none BUG=none Review URL: http://codereview.chromium.org/149461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20386 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: all the binary to be readable with the SUID sandbox.agl@chromium.org2009-07-101-9/+13
| | | | | | | | | | | | | | | | | | | Previously, we required that the binary be non-readable. This causes the kernel to mark the process as non-dumpable at startup. The thinking was that, although we were putting the renderers into a PID namespace (with the SUID sandbox), they would none the less be in the /same/ PID namespace. So they could ptrace each other unless they were non-dumpable. If the binary was readable, then there would be a window between process startup and the point where we set the non-dumpable flag in which a compromised renderer could ptrace attach. However, now that we have a zygote model, only the (trusted) zygote exists at this point and we can set the non-dumpable flag which is inherited by all our renderer children. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20383 0039d316-1c4b-4281-b951-d872f2087c98
* Packaging changes to incorporate Linux default browser selection. mdm@chromium.org2009-07-101-0/+2
| | | | | | | | | BUG=11972 TEST=none Review URL: http://codereview.chromium.org/149419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20382 0039d316-1c4b-4281-b951-d872f2087c98
* Broke my own unittest. The expected behavior when callingrohitrao@chromium.org2009-07-101-3/+8
| | | | | | | | | | | clearResults: is to not delete the existing find text, which seems strange but matches the other platforms. BUG=None TEST=Fixes the build Review URL: http://codereview.chromium.org/149463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20381 0039d316-1c4b-4281-b951-d872f2087c98
* Add default browser checking and setting on Linux.mdm@chromium.org2009-07-104-15/+145
| | | | | | | | | BUG=11972 TEST=none Review URL: http://codereview.chromium.org/155100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20380 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of Extension Updater.asargent@chromium.org2009-07-1010-38/+1273
| | | | | | | | | | | | This also contains changes to the ExtensionsService to hook up the ExtensionUpdater. BUG=http://crbug.com/12117 TEST=Extensions still work Review URL: http://codereview.chromium.org/149213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20379 0039d316-1c4b-4281-b951-d872f2087c98
* Add getLanguage function to tab extension.sidchat@google.com2009-07-1023-9/+265
| | | | | | | | BUG=none TEST=enable extensions using the toolstip.html code (added with this CL) and load pages in different languages. The corresponding language should appear in the bottom left after the page is loadedm or when the button is clicked, or when you navigate back to that tab after visiting some other tab. Review URL: http://codereview.chromium.org/150062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20378 0039d316-1c4b-4281-b951-d872f2087c98
* Enables find in page match counts on Mac.rohitrao@chromium.org2009-07-101-11/+10
| | | | | | | | BUG=http://crbug.com/16148 TEST=Find in page should report match counts correctly. Review URL: http://codereview.chromium.org/155353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20377 0039d316-1c4b-4281-b951-d872f2087c98
* Properly restart extensions with no visible UI.phajdan.jr@chromium.org2009-07-101-1/+7
| | | | | | | | http://crbug.com/16070 Review URL: http://codereview.chromium.org/149416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20376 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 15971.hbono@chromium.org2009-07-101-3/+4
| | | | | | | | | | | | This is another my stupid mistake that my r19238 sends a Char event even when its text[] member does not contains any characters. I mis-understoold I needed to send a Char event every time when gtk_keyval_to_unicode() returns 0 to avoid Issue 15024. But this is wrong. (Page Down, Page Up, Arrow Keys work without Char events. Only return keys need Char events.) BUG=15971 "drop down list moves 2 positions when using the keyboard". TEST=Open the attached test-case Review URL: http://codereview.chromium.org/155207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20370 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the width of the font and language dialog in Arabic Chrome.jshin@chromium.org2009-07-101-1/+1
| | | | | | | | | | | BUG=9015 (http://crbug.com/9015) TEST=Launch CHrome with '--lang=ar'. In options - Advanced tab, open up 'Fonts and Languages' dialog and select 'Languages' tab. The string above 'Chrome UI language combobox' should not be truncated. TBR=finnur Review URL: http://codereview.chromium.org/126009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20361 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "plugins: use OnChannelError to detect when the channel goes away"evan@chromium.org2009-07-104-15/+31
| | | | | | | This reverts commit r20349. Unit test failure. I suspect the test, but let's keep the tree green. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20354 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Revert "Linux: add LOG(FATAL) to try and catch an error."""agl@chromium.org2009-07-101-8/+0
| | | | | | | Accidently reverted the anti-revert. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20353 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Linux: add LOG(FATAL) to try and catch an error.""agl@chromium.org2009-07-101-0/+8
| | | | | | | This reverts commit 4d74c3b46aeb8c7e3a05087d3b1f05f6906fd6e2. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20350 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: use OnChannelError to detect when the channel goes awayevan@chromium.org2009-07-104-31/+15
| | | | | | | | | | | | | | | Previously we used a special Watcher object to watch the process, but that is not portable to POSIX and this is simpler anyway. With this change, I now see ~PluginProcessHost() running when a plugin crashes. If you recall all the way back to http://codereview.chromium.org/16814 we did a similar thing to the renderer host. Review URL: http://codereview.chromium.org/155331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another string conversion with UTF16ToWideHackben@chromium.org2009-07-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another string conversion with UTF16ToWideHackben@chromium.org2009-07-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20345 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Provide the correct inactive frame tint color.erg@google.com2009-07-102-4/+2
| | | | | | Review URL: http://codereview.chromium.org/149435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20344 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac compile bustage - use a different string conversion function for ↵ben@chromium.org2009-07-101-1/+1
| | | | | | GetCurrentPageTitle. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20343 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some stuff to string16 so the toolkit_views build can build againben@chromium.org2009-07-109-35/+37
| | | | | | Review URL: http://codereview.chromium.org/155334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
* linux: move gtk_init to the right threadpiman@google.com2009-07-102-16/+21
| | | | | | | | | In the plugin process, gtk_init needs to be called from the UI thread (PluginThread) not the main thread (PluginMain) which is an IO thread. Review URL: http://codereview.chromium.org/149424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20340 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.close() not working for modal dialogs.jam@chromium.org2009-07-103-1/+10
| | | | | | | | BUG=16374 TEST=added regression test Review URL: http://codereview.chromium.org/149412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20339 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-092-9/+9
| | | | | | | | | | | More cleanup relating to pipeline cleanup. BUG=16008 TEST=no real code chage, nothing should change Review URL: http://codereview.chromium.org/155230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20338 0039d316-1c4b-4281-b951-d872f2087c98
* linux/mac: Fix return status of OpenChannelToPlugin message in case of failurepiman@google.com2009-07-091-0/+7
| | | | | | | | | | | Currently on linux if the plugin process dies, the PluginProcessHost is not destroyed. A side effect of that is that if a renderer tries to create a new plugin, the OpenChannelToPlugin message returns success with an empty handle, which is interpreted as the host channel, to which the renderer tries to connect to a second time, causing DCHECKs and havok in the browser process. This CL fixes that particular problem, returning failure if the browser can't connect to the plugin process. Review URL: http://codereview.chromium.org/155313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Made MediaFilter::host_ and MediaFilter::message_loop_ private."scherkus@chromium.org2009-07-092-9/+9
| | | | | | | | | | TEST=none BUG=none TBR=evmar Review URL: http://codereview.chromium.org/155333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20336 0039d316-1c4b-4281-b951-d872f2087c98
* Made MediaFilter::host_ and MediaFilter::message_loop_ private.scherkus@chromium.org2009-07-092-9/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20335 0039d316-1c4b-4281-b951-d872f2087c98
* Improve performance of dragged tab renderering.estade@chromium.org2009-07-094-91/+117
| | | | | | | | | | | | | | | Do as much as possible server side. I suspect the main factors that made our previous implementation slow were blitting from client to server, several unnecessary copies of the entire image, and doing an in-memory rgba->bgra swap. Now, even in debug mode with a 30" chrome window, the performance is very fast. BUG=16257,15869 TEST=drag a tab out of the tabstrip, with and without compositing Review URL: http://codereview.chromium.org/155321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20333 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate new Linux common files after deb packaging refactoring.thestig@chromium.org2009-07-091-5/+8
| | | | | | Review URL: http://codereview.chromium.org/149422 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20329 0039d316-1c4b-4281-b951-d872f2087c98
* Always let other handlers run for render area mouse clicks.estade@chromium.org2009-07-091-1/+3
| | | | | | | | | BUG=none TEST=context menu shows when you right click (and doesn't immediately disappear) Review URL: http://codereview.chromium.org/149417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20326 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more interfaces on RenderViewHostDelegate to separate classes. Thebrettw@chromium.org2009-07-0918-236/+276
| | | | | | | | ones in the patch are those that are implemented by other classes, avoiding TabContents pass-throughs. Review URL: http://codereview.chromium.org/149373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20324 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code in RWHV Gtk.estade@chromium.org2009-07-091-10/+0
| | | | | | | | | | | The code was introduced in r13044 and should have been removed in r13396 (when the majority of r13044 was undone). BUG=16195 TEST=selection clipboard still works in render view, memory leak is gone Review URL: http://codereview.chromium.org/149358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20321 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 13:22:53 +0000