| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
to ~400.
Review URL: http://codereview.chromium.org/46039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting for now. Will try again later
Review URL: http://codereview.chromium.org/46046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we create with gtk_text_buffer_create_tag:
"""
The returned tag is owned by the buffer's tag table, so the ref count will be equal to one.
"""
We do not own the tags, only the table.
Review URL: http://codereview.chromium.org/46044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting for now. Will try again later
Review URL: http://codereview.chromium.org/46045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reverting for now. Will try again later
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Paint a border around the input widget, which makes it fit better into the
toolbar. A bordered widget is also very nice to have for debugging, so I
abstracted a small helper for making a bordered bin.
- Improve the results popup by painting with some Pango attributes. Sort of
looks awful over NX, but I'm hoping it looks better on a real session.
BUG=8236
Review URL: http://codereview.chromium.org/46035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/46040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evanm
Review URL: http://codereview.chromium.org/46038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RTL languages on "Bookmark Manager"
(http://crbug.com/8684)
The problem is canvas.DrawStringWithHalo() within BookmarkTableView::PaintAltText() always use left alignment.
The fix is to pass the correct canvas text alignment when DrawStringWithHalo().
Test:
1. Run Hebrew Chrome
2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog
3. Select "Search"
4. Observe
Without the fix:
Text "Enter a query in the text field above to search your bookmarks" is
left aligned
With the fix:
The above text is right aligned Hebrew
Review URL: http://codereview.chromium.org/43146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
has disabled purify runs for the relevant tests.
Review URL: http://codereview.chromium.org/42162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If DOMUIContents::InitCurrentUI returns true then current_ui_
should always be valid. Changed logic inside to make sure that
this is the case.
Review URL: http://codereview.chromium.org/46009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=6627&r2=6626&pathrev=6627
line 236
We are appending the pid to the name of the shared memory object,
which causes each renderer to get its own uninitialized copy of the
stats counters, breaking the sharing. So then the about:stats code
can't find the counters created and updated by these processes. This
includes all the V8 counters and timers.
Original issue: http://codereview.chromium.org/40012/show
Review URL: http://codereview.chromium.org/42130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code ended up destroying the BrowserWindow (removing it from BrowserList) while BrowserList was in the middle of iterating. Push the deletion onto the message loop (using DeleteSoon) to emulate what I'm guessing happens on Windows (the message is queue instead of processed right away).
This fixes a second bug involving re-entrancy issues with Close() and window_, we now make sure to set window_ to NULL before any events might fire.
BUG=8712
Review URL: http://codereview.chromium.org/43135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This should give input methods the proper chance to handle enter and escape.
Review URL: http://codereview.chromium.org/43149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
598 to 511.
Review URL: http://codereview.chromium.org/42165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6317
Review URL: http://codereview.chromium.org/46022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8388
R=brettw
Review URL: http://codereview.chromium.org/42114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Feedback from ddorwin:
1- Use the right set of permisions for the reg key
2- Only touch the key if user acepted the eula
BUG=1594565
Review URL: http://codereview.chromium.org/42168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SetWindowPos call
can fail on Vista if the caller is running under low IL.
Review URL: http://codereview.chromium.org/42150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cleanup in how resource dispatching happens in a future cl.
Review URL: http://codereview.chromium.org/42158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Only the Save As file selection dialog is implemented for now.
Review URL: http://codereview.chromium.org/42152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If chrome tab is hosted in an external tab and 'inspect
element' is invoked via GUI (as opposed to sending an
automation request for AutomationMsg_InspectElement),
we get a crash in AutomationProvider::ReceivedInspectElementResponse
BUG=1694650
Review URL: http://codereview.chromium.org/43102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ChildThread so that the same code is used by the plugin process (and soon, workers).
Review URL: http://codereview.chromium.org/42108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image.
Review URL: http://codereview.chromium.org/43144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is admitedly a little hacky, but I don't care as much since it's single-process mode and I don't think there's another way to solve it. The problem is that SiteInstance::GetProcess should always reuse an existing renderer "process", but GetExistingProcessHost() won't return the in-process renderer until RenderProcessHost::Init is called, which is after the second GetProcess call. So since we generate the in-process 'pid', I do it in the constructor instead of in Init.
Review URL: http://codereview.chromium.org/42144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Changed InProcessBrowserTest to restore the original CommandLine after it
tears down.
Review URL: http://codereview.chromium.org/42084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether we should turn on the reporting of upload progress updates.
This CL adds plumbing in the SimpleResourceLoader for reporting upload progress updates, as is already done in ResourceDispatcherHost.
This makes 3 layout tests (XMLHttpRequest related) pass.
BUG=None
TEST=Run the layout tests.
Review URL: http://codereview.chromium.org/28341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that isn't tied to the bookmark bar. Removes some dead code from the
bookmark bar, and fixes a UMR in chrome_menu that I found when running
under purify. There isn't any behavior change in this patch.
BUG=none
TEST=this is a large refactoring of how bookmark menus are
shown. Please thoroughly test menus on the bookmark bar to make sure I
didn't screw anything up.
Review URL: http://codereview.chromium.org/42128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/42125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
means of various crazy hacks.
Review URL: http://codereview.chromium.org/42106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
Review URL: http://codereview.chromium.org/42135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DISALLOW_COPY_AND_ASSIGN
TBR=finnur
Review URL: http://codereview.chromium.org/43140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we can share code across platforms.
See http://code.google.com/p/chromium/wiki/FindBarRefactoring for
more information about the design.
Review URL: http://codereview.chromium.org/42057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Rewrite strip controller to create and manage TabControllers instead of NSButtons.
Review URL: http://codereview.chromium.org/43137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
trying to autoupdate, it looks like this was not the
cause of the failure.
Review URL: http://codereview.chromium.org/42126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11538 0039d316-1c4b-4281-b951-d872f2087c98
|