| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the alpha channel sometimes.
This change introduces another buffer which holds the background image for transparent plugins. Before
painting these plugins, their backing store is overwritten with the background data.
This change also uses an ACK from the renderer to figure out when it can paint, similar to how the
renderer does it, which gives us throttling and also doesn't lead to painting when the tab is hidden.
Review URL: http://codereview.chromium.org/5040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Google Chrome version number.
Review URL: http://codereview.chromium.org/6022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use the configuration options of the webkit SCons build itself
to build a v8.lib with snapshot=off.
* Move the build of v8_snapshot.lib (renamed from snapshotv8.lib)
from chrome\SConscript to build\SConscript.v8.
* Use the libraries{,-empty}.obj and snapshot{,-empty}.obj
files from the v8 build itself instead of rolling our own.
* Re-order thing in build/SConscript.v8 for readability (I hope).
Review URL: http://codereview.chromium.org/5615
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This test has been passing on the buildbot for a long time
and also passes locally.
Review URL: http://codereview.chromium.org/5612
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from Gaetano Mendola <mendola@gmail.com>
Original review: http://codereview.chromium.org/4273
I added some additions on my part and two unit test fix due to the added DCHECK. Reduced atl header inclusion.
Review URL: http://codereview.chromium.org/5009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://code.google.com/p/chromium/issues/detail?id=3011
Looks like we are trying to access the HWND of a window during teardown of the window.
Review URL: http://codereview.chromium.org/6015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal
Review URL: http://codereview.chromium.org/6014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=2965
Review URL: http://codereview.chromium.org/5035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move chrome/common/env_util to base/sys_info
- Move chrome/common/rand_util to base/rand_util (new), simplify its public
interface, and fix its implementation
Patch by Paweł Hajdan, Jr. <phajdan.jr@gmail.com>
http://codereview.chromium.org/4079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test/chrome_plugin/test_chrome_plugin.cc:26: warning: comparison between signed and unsigned integer expressions
test/chrome_plugin/test_chrome_plugin.cc:73: warning: 'ResponseStream::request_' will be initialized after
test/chrome_plugin/test_chrome_plugin.cc:72: warning: 'int ResponseStream::ready_state_'
test/chrome_plugin/test_chrome_plugin.cc:77: warning: when initialized here
test/chrome_plugin/test_chrome_plugin.cc:105: warning: unused variable 'status'
Review URL: http://codereview.chromium.org/5034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
patch by abarth@chromium.org
R=darin
BUG=2879
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
only navigation in tab was an interstitial.
BUG=2964
TEST=Drag the following URL into
Review URL: http://codereview.chromium.org/4337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a request from the link doctor team.
Add a UI test that verifies that no link doctor page is loaded.
Review URL: http://codereview.chromium.org/5032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=2954
TBR=erikkay
Review URL: http://codereview.chromium.org/4333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
assumed selection was always contiguous.
BUG=2949
TEST=Go to options->Under the hood->Cookies and make sure sorting the
columns works. Also make sure deleting deletes the appropriate rows.
Review URL: http://codereview.chromium.org/4328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
renamed RemoveCertInternal to stress the fact that it should
be called with the lock held.
Fix miscellaneous nits complained by cpplint.
R=jcampan
Review URL: http://codereview.chromium.org/5024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a .h file. :(
Review URL: http://codereview.chromium.org/5201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code did not end up needing the use of interlocked operations.
All the initialization is called on one thread (the main thread).
bug=1311434
r=deanm
Review URL: http://codereview.chromium.org/4076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
issues in Debug and is flaky.
Remove the Any Cpu configuration. It's really unnecessary.
Review URL: http://codereview.chromium.org/4308
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
with the Linux and Mac SCons-based builds.
Also, indent a set of Windows-specific flags under a Windows-only block.
Review URL: http://codereview.chromium.org/4314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* New browser\download\ subdirectory.
* New browser\importer\ subdirectory.
* New browser\views\old_frames subdirectory.
* Add common/notification_registrar.cc.
* Remove title_chomper{,_unittest}.cc.
* Link against sdch where empirically necessary.
* No libevent.lib on Windows, comment out until Linux hits the .dll logic.
Review URL: http://codereview.chromium.org/4310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch by abarth@chromium.org
R=ben
BUG=2632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not libicuuc. Add a new $ICU_LIBS construction variable to allow
different platforms to link with different sets of ICU libraries.
Use it in the LIBS lists of the various construction environments
used to build the things that link with it.
Review URL: http://codereview.chromium.org/4312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- RenderWidget was not unit testable as it was
- Adding the first ever RederWidget unit tests
It is possible to do more. Taking it step by step.
Review URL: http://codereview.chromium.org/4271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
after you close the Find box.
Review URL: http://codereview.chromium.org/4283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The URL in the About box was added as a last minute string addition. I have now made it clickable. I also converted the TextField for the main label into a regular label, since there is no need to copy anything anylonger.
Review URL: http://codereview.chromium.org/5013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
interactions with the UI.
Review URL: http://codereview.chromium.org/5011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Null deref in GetDefaultSearchEngineName
- This is a stopgap fix
Issue = 2573
Review URL: http://codereview.chromium.org/4304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tab contents and web contents. Reorder the derived classes overrides to match, and reorder the definitions of the functions to match the order in the header file.
This doesn't actually change any code. I removed a few functions that were declared but never implemented (!) as well as some that were marked vitual but were never overridden. I renamed some things to make them more consistent.
Review URL: http://codereview.chromium.org/5005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add extra check on received dictionary status before saving it for use
r=kmixter,openvcdiff
Review URL: http://codereview.chromium.org/4285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the other day I ended up doing the sorting in tableview. This makes it
a heck of lot easier than having every model have to deal with it. As
part of this I removed the optional non-caching logic from TableView,
which was never used. Sadly though, this means there are coordinate
transformations.
I've only enabled sorting in the keyword editor, I have to make sure
all the other places that use TableView can deal with it. For example,
task manager can't deal with it currently as it expects the getters to
be called only once where as when sorting they may be called multiple
times.
BUG=2790
TEST=This enables sorting ONLY in the keyword editor. Make sure there
aren't any problems in adding/removing/changing entries in the
keyword editor after this.
Review URL: http://codereview.chromium.org/4276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to one that doesn't support replacement. Also changed uniquing to
consider invalid OSDD urls. Need this to pick up Windows Live Search.
I also changed the ff importer to return out early on if it couldn't
find the value for the search provider. I encountered this do to
hitting a NOTREACHED.
BUG=1507
TEST=In IE set your default search to Live Search. Import from IE and
make sure Chrome sets the default search to Live Search. Also make
sure this didn't break keyword importing.
Review URL: http://codereview.chromium.org/4281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
convert the response to UTF-8 before
sending over to JSON deserializer. (previously this issue was tracked internally as issue 1293145)
BUG=2806
TEST=In French Chrome, set your default search engine to Voila and begin to type a word with an accented letters and see
if 'Search Voila for ' contains the word (it's not a bullet-proof test).
In Korean chrome, set the default search engine to Daum and begin to type a Korean word (with Korean IME on, type 'qk').
Review URL: http://codereview.chromium.org/4287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=b/1340170
TEST=unittest
Review URL: http://codereview.chromium.org/4077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise.
I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it.
Review URL: http://codereview.chromium.org/4088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=mbelshe
BUG=2693
Review URL: http://codereview.chromium.org/4262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
bottom of the First Run dialogs and be opt-out. Therefore I moved it from the FirstRunCustomizeView view to the FirstRunViewBase.
I also moved the override function for GetDialogButtonLabel to the base class (since both dialogs should have the same label for the OK button) and aligned the "Import" label vertically to the "Import" combobox.
Review URL: http://codereview.chromium.org/4244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I added additional information to the regular load commit notification so all
interested parties can listen for that instead.
I removed the old navigation type enum, and replaced it with the enum from
the NavigationController, so it's now public.
Review URL: http://codereview.chromium.org/3112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
comes back in ISO-8859-1.
Change the encoding for voila to ISO-8859-1. The front page of Voila.fr is in UTF-8 but the search result pages are
in ISO-8859-1 and voila.fr expects a query to be in ISO-8859-1.
BUG=2722
TEST=Set your default search engine to voila (in French Chrome) and type a keyword with accented letters. It should come back correctly in the search result page.
Review URL: http://codereview.chromium.org/4068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Webcore has no custom build step so it can be bypassed.
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue
Glue
KJSBindings_prebuild
KJSConfig
localized_strings
WebCore
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port
Port
KJSBindings_prebuild
KJSConfig
WebCore
To
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln glue
Glue
KJSBindings_prebuild
KJSConfig
libxml_config
libxslt_config
localized_strings
src\chrome>python tools\build\win\sln_deps.py chrome_kjs.sln port
Port
KJSBindings_prebuild
KJSConfig
Review URL: http://codereview.chromium.org/4252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2563 0039d316-1c4b-4281-b951-d872f2087c98
|