summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* block sad tab controller unittest that have leakages for now.kuan@chromium.org2009-12-161-0/+4
| | | | | | | BUG=27212 Review URL: http://codereview.chromium.org/500035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34628 0039d316-1c4b-4281-b951-d872f2087c98
* Add offline mode selection for ChromeOSchocobo@chromium.org2009-12-165-39/+93
| | | | | | | | BUG=568 TEST=none Review URL: http://codereview.chromium.org/504008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34627 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/469009 for Thiago:sky@chromium.org2009-12-163-13/+13
| | | | | | | | | | | | bookmarks: Update parent (folder) modified time when we create a new bookmark node. BUG=none TEST=none Review URL: http://codereview.chromium.org/500005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34626 0039d316-1c4b-4281-b951-d872f2087c98
* Flip: Comma delimit the various flip options. Redo the fixed testing server ↵willchan@chromium.org2009-12-154-9/+28
| | | | | | | | | | flags. Renames --testing-fixed-server to --testing-fixed-host. Adds --testing-fixed-http-port and --testing-fixed-https-port. Review URL: http://codereview.chromium.org/501032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34624 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the AsyncSlowStart experimentmbelshe@google.com2009-12-152-14/+0
| | | | | | | | | BUG=30144 TEST=none Review URL: http://codereview.chromium.org/491056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34620 0039d316-1c4b-4281-b951-d872f2087c98
* The benchmark was broken in multi-process mode.mbelshe@google.com2009-12-151-3/+4
| | | | | | | | | | | | | | Turns out that the extension API changed such that scripts don't run in pages which are hosted in the extension process (like this one). Switch from window.open to the chrome.tab.create() API. BUG=none TEST=none Review URL: http://codereview.chromium.org/501036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34617 0039d316-1c4b-4281-b951-d872f2087c98
* Implement AddressField, a FormField that matches a set of address fields in ↵jhawkins@chromium.org2009-12-154-2/+405
| | | | | | | | | | a form. BUG=none TEST=none Review URL: http://codereview.chromium.org/492022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34614 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for a chrome browser crash which occurs with ChromeFrame. ↵ananta@chromium.org2009-12-155-18/+23
| | | | | | | | | | | | | | | | | | | | Based on the crash dump, the crash occurs when the external tab container is being destroyed which in turn takes down the automation provider and the channel, etc. All this occurs in the context of OleUninitialize, which executes after BrowserMain returns, i.e. the message loop is now invalid, thus causing a crash while attempting to post a task to it. Based on this call stack it looks like it happens due to the enable-renderer-accessisibility flag. Fix is to move the OleInitialize/OleUnitialize calls to Platform::WillInitializeMainMessageLoop and Platform::DidEndMainMessageLoop. The Platform::DidEndMainMessageLoop function now executes as a task which is posted to the message loop prior to quitting it. This would ensure that the cleanup happens correctly. Fixes http://code.google.com/p/chromium/issues/detail?id=30383 Bug=30383 Review URL: http://codereview.chromium.org/501011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34611 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom Linux version strings (e.g. release channel, downstream ↵mmoss@google.com2009-12-156-14/+19
| | | | | | | | | | | vendor name, etc.). Also reformat the Mac/Win version strings as per comments in http://codereview.chromium.org/506007. Review URL: http://codereview.chromium.org/506016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34609 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "Bookmark sync" menu itemarv@chromium.org2009-12-153-33/+6
| | | | | | | | | | | | This also cleans up the states. BUG=28419 TEST=The menu item should be gone but we should still see errors from bookmark sync on the NTP Review URL: http://codereview.chromium.org/501029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34608 0039d316-1c4b-4281-b951-d872f2087c98
* Deal with themes that don't provide certain sections. Fixes crasher in new ↵erg@google.com2009-12-152-8/+39
| | | | | | | | | | | themes system. BUG=30453 TEST=Installing https://chrome.google.com/extensions/detail/immljcnndlfdiajkpggdjbikmnibdhhi doesn't crash chrome. Review URL: http://codereview.chromium.org/506014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34602 0039d316-1c4b-4281-b951-d872f2087c98
* Remove -lGL from chrome.gyp which I accidentally checked in.brettw@chromium.org2009-12-151-1/+0
| | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34601 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a very silly leak in FindBarViewTest.rohitrao@chromium.org2009-12-152-8/+6
| | | | | | | | BUG=http://crbug.com/30391 TEST=Valgrind passes. Review URL: http://codereview.chromium.org/507012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34599 0039d316-1c4b-4281-b951-d872f2087c98
* Move the utility process messages to their own file now that we have more thanbrettw@chromium.org2009-12-157-95/+138
| | | | | | | | | | 16 message types. BUG=none TEST=none Review URL: http://codereview.chromium.org/460119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34597 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized variable if ENABLE_GPU is not setpiman@chromium.org2009-12-151-0/+2
| | | | | | Review URL: http://codereview.chromium.org/500013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34596 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Debug crasher in safe browsing updater.mirandac@chromium.org2009-12-151-11/+20
| | | | | | | | | BUG= 20411 TEST= none Review URL: http://codereview.chromium.org/463047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34594 0039d316-1c4b-4281-b951-d872f2087c98
* mac: totally revamp "Aw Snap" page, implement new "Learn more" link, add ↵kuan@chromium.org2009-12-1512-77/+874
| | | | | | | | | | | | | | | | | | | | unittests. - totally revamp "Aw Snap" page to use xib resource, to reduce initialization code - new SadTabController: - controls SadTabView, via xib - uses TabContents in init, so as to launch url for link; used to use BrowserList::GetLastActive but that's null in chrome-frame release - if TabContents is nil, remove link in view - encapsulates the setting up and removing of its SadTabView within and shield them from TabContentsView, which only access the controller - SadTabView repositions and resizes subviews when browser window is resized, including (un)wrapping of message. - action for link is decoupled from target to facilitate unittesting - new SadTabControllerTest that tests initing controller with and without TabContents, and clicking on link BUG=27212 TEST=Verify that "Aw Snap" page shows up correctly, with the new "Learn more" link centered beneath the message. Contents should be centered in window when the latter resizes. If necessary, message should be wrapped, or unwrapped if previously wrapped and new width can accommodate. Review URL: http://codereview.chromium.org/432015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34585 0039d316-1c4b-4281-b951-d872f2087c98
* Move channel (beta,dev,stable) determination code to a common location.jrg@chromium.org2009-12-158-85/+123
| | | | | | | | | | | | | | | | | | | | Add channel info to about:version. Linux about box work not done. Linux channel determination code still a stub. BUG=30444 How to verify: - on both Mac and Win, with a branded build: - confirm the About Box and about:version have channel info after the version number. Channel for PC comes from the registry so it'll be the channel of your official install, not this build. Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined. Review URL: http://codereview.chromium.org/506007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34583 0039d316-1c4b-4281-b951-d872f2087c98
* Reattempt at r465143. The UI tests rely too heavily on the current behavior ↵andybons@chromium.org2009-12-154-7/+36
| | | | | | | | | | | | | of closing the last window indicating exiting the entire app, so that is left alone for now with a TODO added. From the old description: Mac: Fixes bug where extension background hosts were being cleared when the last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown. TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window. BUG=28666 Review URL: http://codereview.chromium.org/502012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34580 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented OS X version of NetworkStatusDetectorTaskMac.akalin@chromium.org2009-12-155-3/+516
| | | | | | | | | BUG=none TEST=trybots,manual testing Review URL: http://codereview.chromium.org/485004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34578 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Hide the notifier when restoring all removed thumbnails.arv@chromium.org2009-12-151-0/+4
| | | | | | | | | | BUG=29952 TEST=Blacklist a thumbanil. This shows the notifier. Then restore all remove thumbnails. The notifier should be hidden now. Review URL: http://codereview.chromium.org/494013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34576 0039d316-1c4b-4281-b951-d872f2087c98
* Disable MultipleWorkers on Linux as it is failing sporadically.atwilson@chromium.org2009-12-151-0/+6
| | | | | | | | | BUG=30353 TEST=non Review URL: http://codereview.chromium.org/503001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34571 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix warnings for TabView.xib.viettrungluu@chromium.org2009-12-151-7/+7
| | | | | | | | | | | I told IB to reload class files and then saved. IB isn't so bright. BUG=none TEST=no warnings about "'HoverCloseButton' is not a kind of 'CloseButton'" Review URL: http://codereview.chromium.org/500025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34567 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix regression where we don't build tinted buttons in GTK theme mode.erg@google.com2009-12-156-40/+69
| | | | | | | | | | (Caused by my r34486) TEST=Use GTK+ mode. page/app menu button should have same tint as title bar. BUG=NONE Review URL: http://codereview.chromium.org/507002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34566 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-1514-761/+261
| | | | | | | | | | NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
* Add link to new themes page on the Chromium wiki.kathyw@google.com2009-12-152-3/+28
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/501010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a ConditionVariable in place of WaitableEvent in BookmarkModelWorker.tim@chromium.org2009-12-152-18/+23
| | | | | | | | | | | | | | | This is to ensure future changes to the code don't introduce harmful races that could arise in presence of compiler optimizations due to the lack of a barrier permitting instruction re-ordering. The theoretical race that exists now isn't causing any real malfunction today, but is causing ThreadSanitizer warnings. BUG=25915 TEST=BookmarkModelWorkerTest Review URL: http://codereview.chromium.org/488012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34558 0039d316-1c4b-4281-b951-d872f2087c98
* Commit issue 464079 for feldstein: limit the clear browsing data window to ↵mirandac@chromium.org2009-12-156-19/+69
| | | | | | | | | | only pop up once. BUG= 24980 TEST= see http://codereview.chromium.org/464079/show Review URL: http://codereview.chromium.org/501001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34557 0039d316-1c4b-4281-b951-d872f2087c98
* Committing issue 484006 for feldstein.mirandac@chromium.org2009-12-1511-193/+2293
| | | | | | | | | | | Refactor close button to its own class. BUG= 23641 TEST= see http://codereview.chromium.org/484006 Review URL: http://codereview.chromium.org/501003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34556 0039d316-1c4b-4281-b951-d872f2087c98
* Handle unexpected connection close during SSL handshake on Mackinuko@chromium.org2009-12-151-8/+1
| | | | | | | | | | | | | | | SSLHandlshake may return errSSLClosedGraceful error code which is interpreted as net::OK by NetErrorFromOSStatus, but the caller code sometimes do not check status!=noErr cases if net_error==OK, and this can lead unexpected status in the handshake sequence (and causes ExtensionApiTest.CrossOriginXHR failure on Mac). BUG=29711 TEST=ExtensionApiTest.CrossOriginXHR Review URL: http://codereview.chromium.org/500018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34555 0039d316-1c4b-4281-b951-d872f2087c98
* Enable/disable "next/previous tab" commands when there is only 1 tab.pinkerton@chromium.org2009-12-151-0/+4
| | | | | | | BUG=26951 TEST=make sure next/previous tab menu items are correctly enabled/disabled based on the number of tabs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34554 0039d316-1c4b-4281-b951-d872f2087c98
* Make ProcessWatcher use kqueues on Mac.jeremy@chromium.org2009-12-157-8/+182
| | | | | | | | | | | | | * Port ProcessWatcher::EnsureProcessTerminated() to kqueue() APIs on OS X. * Make ProcessWatcher::EnsureProcessGetsReaped() Linux-only, since it's only used there. * Add a unit test. BUG=12731 TEST=Open Chrome/Mac, open and close a few tabs. Processes shouldn't stay around. Review URL: http://codereview.chromium.org/496007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34547 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 271.0 to 272.0chrome-bot@google.com2009-12-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34546 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: repair DevToolsExtensionDebugTest.TestContentScriptIsPresentyurys@chromium.org2009-12-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/500020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34545 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Restore sanity tests tests.pfeldman@chromium.org2009-12-151-16/+16
| | | | | | | | BUG=30418 Review URL: http://codereview.chromium.org/505005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34543 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Language Switcher" for Chromium OS. This change enables users to ↵yusukes@google.com2009-12-157-2/+515
| | | | | | | | | | | | | | | | | switch their IME (input method) by clicking a menu button on the status area. Basic structure of the code is almost the same as power_menu_button and power_library. Demo: http://dev.chromium.org/chromium-os/chromiumos-design-docs/text-input/demos language_library.{cc,h}: UI-libcros glue. boilerplate code. language_menu_button.{cc,h}: A button on the status area and its drop-down menu. Implements app/menus/menu_model.h interface. status_area_view.{cc,h}: Put the language button on the status area. BUG=494 TEST=Start Chromium OS. Click the menu button on the status area. Then verify that all IMEs you configured (via ibus-setup command, for now) is listed in the drop down menu. Review URL: http://codereview.chromium.org/449050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34540 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fix to get browser/extensions/page_action_apitest.cc building on Mackinuko@chromium.org2009-12-152-11/+11
| | | | | | | | | BUG=29895 TEST=build and run browser_tests, and see if it succeeds Review URL: http://codereview.chromium.org/487026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34539 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: make it even less likely that the renderer+Breakpad leaks Mach ports.viettrungluu@chromium.org2009-12-152-1/+18
| | | | | | | | | | | | | SuicideOnChannelErrorFilter::OnChannelError() does get called under certain (unknown) circumstances, with some regularity. This causes a leak of a Mach port when used with Breakpad. BUG=28547 TEST=See bug. Review URL: http://codereview.chromium.org/500010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34534 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Close the font panel when closing the font settings sheet.rsesek@chromium.org2009-12-151-0/+2
| | | | | | | BUG=29885 TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings. Open a font panel by pressing Change then close the settings sheet by pressing Cancel. Font panel should not remain open. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak added in r34510. We need to delete old ChangeProcessors.tony@chromium.org2009-12-151-0/+1
| | | | | | | | TBR=albertb Review URL: http://codereview.chromium.org/503008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34524 0039d316-1c4b-4281-b951-d872f2087c98
* Disable anther DevTools sanity test that was missed in r34516.tony@chromium.org2009-12-151-1/+1
| | | | | | | | | BUG=30418 TBR=pfeldman Review URL: http://codereview.chromium.org/500007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34522 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevTools sanity tests pending investigation.dglazkov@chromium.org2009-12-151-15/+15
| | | | | | | | | | | TBR=pfeldman TEST=none BUG=30418 Review URL: http://codereview.chromium.org/506005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34516 0039d316-1c4b-4281-b951-d872f2087c98
* Fix badge center-alignment logic.estade@chromium.org2009-12-141-1/+2
| | | | | | | | | | | This was initially fixed in r29152. It regressed in r30994. BUG=27648 TEST=see bug Review URL: http://codereview.chromium.org/506003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34513 0039d316-1c4b-4281-b951-d872f2087c98
* I refactored ChangeProcessor so that the common stuff can be reused by otheralbertb@google.com2009-12-1413-887/+1062
| | | | | | | | | | | | | | | | | | | | data types. For ModelAssociator, I just extracted an interface. There's probably more that can be reused, but I thought we would get to it once we know more about what kind of associations the other data types will require. In particular, I didn't use templates because none of the methods that ProfileSyncService calls on ModelAssociator require a data-type specific type. I didn't invest too much time refactoring the unit tests, so they're pretty hacky. I believe the right thing to do would be to test PSS, CP and MA seperately instead of having a giant PSS test that assumes we only care about bookmarks. BUG=29831,29832 TEST=Unit test Review URL: http://codereview.chromium.org/477007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34510 0039d316-1c4b-4281-b951-d872f2087c98
* First steps toward page actions on Mac. Page action icons shold show andpamg@google.com2009-12-147-67/+551
| | | | | | | | | | | | | | | | | | | | | perform their click actions when clicked. This is very rough, being committed in an early form so more people can contribute to the effort. Includes some early work from andybons too, toward making popups work. Known issues: * Icons don't refresh properly when an extension is installed or removed. Switching windows, then back again, updates the location bar properly. * Right- and middle-clicks do nothing * No tooltips, badges, installation previews, or popups yet * No unit tests yet BUG=12281 TEST=none yet Review URL: http://codereview.chromium.org/427009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34509 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for http://crbug.com/29473estade@chromium.org2009-12-141-2/+32
| | | | | | | | | BUG=29473 TEST=it passes Review URL: http://codereview.chromium.org/486037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34504 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few languages: sync dialog box was cutting off the cancel button.chron@google.com2009-12-1439-44/+44
| | | | | | | | | | | | Add padding to throbber. Fix merge and sync cutoff. BUG=27770, 29767, 29788, 29782, 29647 TEST=manually checked all languages, Review URL: http://codereview.chromium.org/460123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34502 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor browser action apitest and port for mac.kkania@chromium.org2009-12-1413-155/+254
| | | | | | | | BUG=29709 TEST=none Review URL: http://codereview.chromium.org/443013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 30244xiyuan@chromium.org2009-12-141-2/+3
| | | | | | | | | | | | Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew IME generated Shift+Ctrl does not pass through and triggers RTL. BUG=30244 TEST=Verify fix for 30244 and issue 24888 does not regress. Review URL: http://codereview.chromium.org/497010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34497 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "open in incognito window" for incognito windows.avi@chromium.org2009-12-141-0/+8
| | | | | | | | | BUG=http://crbug.com/24637 TEST=as in bug Review URL: http://codereview.chromium.org/488018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34496 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 12:46:14 +0000