summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* We have a bunch of new ui_tests failures. I wantnsylvain@chromium.org2008-12-0210-317/+71
| | | | | | | | | | to check if this change (6181) was the cause. I'm reverting. TBR:jeremy Review URL: http://codereview.chromium.org/12856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6199 0039d316-1c4b-4281-b951-d872f2087c98
* We have a bunch of new ui tests failure that startednsylvain@chromium.org2008-12-021-1/+1
| | | | | | | | | | approximatively at this revision. I'm reverting to make sure. tbr: wtc Review URL: http://codereview.chromium.org/12855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when hiding the find bar due to a NULL window_delegate_.ben@chromium.org2008-12-021-1/+3
| | | | | | Review URL: http://codereview.chromium.org/12854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SSL info bars to use the new system.ben@chromium.org2008-12-023-128/+56
| | | | | | | | http://crbug.com/4620 Review URL: http://codereview.chromium.org/12847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6196 0039d316-1c4b-4281-b951-d872f2087c98
* Add instrumentation to and tighten SDCH implementationjar@google.com2008-12-021-0/+8
| | | | | | | r=huanr,kmixter,openvcdiff Review URL: http://codereview.chromium.org/12699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6193 0039d316-1c4b-4281-b951-d872f2087c98
* Change a DCHECK to CHECK to help debug a crash inwtc@google.com2008-12-021-1/+1
| | | | | | | | | | release builds. R=eroman BUG=4749 Review URL: http://codereview.chromium.org/12465 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6189 0039d316-1c4b-4281-b951-d872f2087c98
* Don't close tabs on middle-click when the release happens off the tab. ↵pkasting@chromium.org2008-12-011-1/+5
| | | | | | | | Patch by Mohamed Mansour, r=ben. See http://codereview.chromium.org/12816/ . BUG=1062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6184 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ipc_tests unittest target to xcode project.jeremy@chromium.org2008-12-0110-71/+317
| | | | | | | | * Stub out ipc_channel_posix.cc to allow other code that depends on it to be compiled. * Cleanup some ipc code a bit to compile on gcc. * Remove unused IPC::Channel::ProcessPendingMessages() git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6181 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 4898: File extension wrong for saved filesfinnur@google.com2008-12-011-0/+1
| | | | | | | | | | | | When the user specifies a filename without an extension, such as "foo" instead of "foo.gif", we would append "gif" to the filename instead of ".gif" (so the user ends up with a file named "foogif"). I'm not confident this is the only thing wrong with this function. For example if the user specifies "foo." and the filter says "*.gif" shouldn't we add ".gif" to the filename instead of deleting the dot? Also, we seem to be ignoring the default_extension parameter passed in when we figure out what extension to tack on and instead get the file extension from GetFileExtensionFromPath... :s Review URL: http://codereview.chromium.org/12838 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6174 0039d316-1c4b-4281-b951-d872f2087c98
* <esc> in the AutocompleteEdit should select all the text when reverting to ↵pkasting@chromium.org2008-12-012-27/+36
| | | | | | | | the permanent text. Only pass it through as an accelerator if we don't end up changing anything. Patch by Mohamed Mansour, r=me. See http://codereview.chromium.org/10800 . BUG=4203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6168 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for some trivial issues (remove unneeded constants, int->size_t in a ↵pkasting@chromium.org2008-12-014-8/+5
| | | | | | few cases). Patch by phajdan.jr@gmail.com, r=me. See http://codereview.chromium.org/11586 . git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.open()/window.close() regression by disabling window.close() ↵erg@google.com2008-12-0110-7/+60
| | | | | | | | | | | until a message comes back from the Browser thread saying that it's OK to allow javascript close calls. ISSUE=http://crbug.com/4007 Review URL: http://codereview.chromium.org/12691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6165 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create the default download directory just because we ask for its ↵pkasting@chromium.org2008-12-011-14/+11
| | | | | | | | location. This is a first step toward not creating _any_ directories when we merely ask for their locations. Patch by Marc-André Decoste, r=cpu. See http://codereview.chromium.org/11586 . Bug=4575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6164 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new submenu in the context menu for a text box. This submenu displays ↵sidchat@google.com2008-12-018-41/+215
| | | | | | | | some spell check languages that Chrome supports, derived from the accept languages list and the current spell check language. The spell check language which is currently set is shown to be selected. The user can click on some other spell check language, and it will become effective immediately (this part of the code was addressed in a previous CL, and has been checked in). Review URL: http://codereview.chromium.org/12614 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6162 0039d316-1c4b-4281-b951-d872f2087c98
* Add F1 as an accelerator for "Help". Original patch by Alex Mendes da ↵pkasting@chromium.org2008-12-013-0/+7
| | | | | | | | Costa, r=ben, see http://codereview.chromium.org/10796 . BUG=851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6158 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 6149 because it broke the unit tests on windows.nsylvain@chromium.org2008-12-0113-217/+47
| | | | | | Review URL: http://codereview.chromium.org/12834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6155 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/12502 for sverrir:sky@google.com2008-12-011-8/+15
| | | | | | | | | | | Fix selection after deleting cookies. The selection was seemingly random because the model to view mapping changed when deleting items. BUG=3692 TEST=Try deleting items in cookies view and make sure selection doesn't jump around unexpectedly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6150 0039d316-1c4b-4281-b951-d872f2087c98
* browser porting, part 2 - importeragl@chromium.org2008-12-0113-47/+217
| | | | | | | | Review URL: http://codereview.chromium.org/12688 Patch from Pawel Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6149 0039d316-1c4b-4281-b951-d872f2087c98
* Changes filter used when importing in bookmark manager to includesky@google.com2008-12-011-1/+1
| | | | | | | | | | | | | *.htm. BUG=4388 TEST=Create a file name foo.htm. Go to bookmark manager, choose import, navigate to directory with foo.htm and make sure the the open dialog shows foo.htm. Review URL: http://codereview.chromium.org/12459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6144 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 5971 which was reverted in 5974. The unit test wasn't unregistering ↵maruel@chromium.org2008-12-016-2/+145
| | | | | | | | the observer correctly. Review URL: http://codereview.chromium.org/12474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6142 0039d316-1c4b-4281-b951-d872f2087c98
* Added the printing of a warning when we get an Exception while trying to ↵maruel@chromium.org2008-12-011-4/+8
| | | | | | | | | import our google.* python packages so that the user can tell why it happens, and how to fix it. Patch from mad@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6140 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the painting problem with Stree View and Flash 10. After the size of ↵jam@chromium.org2008-12-012-14/+9
| | | | | | | | | | | the plugin changes, we generate a new backing store. Flash 9 invalidates the rectangle, but Flash 10 doesn't. As a result we paint from a blank backing store. The fix is to keep track of which part of the backing store has been painted into by the plugin, and if the renderer tries to paint an area that falls outside of it, do a synchronous paint. Also get rid of first_paint_, as it was introduced during a failed attempt to make plugin loading asynchronous. Review URL: http://codereview.chromium.org/10792 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6128 0039d316-1c4b-4281-b951-d872f2087c98
* Rollbackmbelshe@google.com2008-12-0114-100/+152
| | | | | | Review URL: http://codereview.chromium.org/13009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6127 0039d316-1c4b-4281-b951-d872f2087c98
* A new copy of the old system monitor changelist.mbelshe@google.com2008-11-3014-152/+100
| | | | | | Review URL: http://codereview.chromium.org/12817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6126 0039d316-1c4b-4281-b951-d872f2087c98
* Remove file_util::kPathSeparator from posix.estade@chromium.org2008-11-271-9/+9
| | | | | | Review URL: http://codereview.chromium.org/12489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6099 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5927 as John has a better fix for this issue.ananta@chromium.org2008-11-271-4/+0
| | | | | | | | | | | | | was as below:- R=jam Bug=4582 Review URL: http://codereview.chromium.org/12402 Review URL: http://codereview.chromium.org/10787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6094 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling a DCHECK that was causing the ui tests to hang on the dbg build ↵jcampan@chromium.org2008-11-271-3/+1
| | | | | | | | | | | bots, which I could not reproduce locally. I'll try to investigate on the bots. TBR=nsylvain Review URL: http://codereview.chromium.org/10979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6091 0039d316-1c4b-4281-b951-d872f2087c98
* * Don't do an idle check in StartLogTransmissionTimer(). This check makes ↵pkasting@chromium.org2008-11-271-71/+51
| | | | | | | | | | us never re-set timers after sending logs. The check in TryToStartTransmission() is sufficient to halt uploading and timers after a user has been idle. * Various small style fixes to comply with style guide, around args alignment and indentation. Review URL: http://codereview.chromium.org/11452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6083 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webKit merge 38653:38729ojan@google.com2008-11-272-2/+2
| | | | | | Review URL: http://codereview.chromium.org/12708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6081 0039d316-1c4b-4281-b951-d872f2087c98
* We never bumped the trunk minor version when we bumped the branch. Go ↵pkasting@chromium.org2008-11-261-1/+1
| | | | | | | | straight to 0.5 as the branch is working its way through 0.4. Review URL: http://codereview.chromium.org/12490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6076 0039d316-1c4b-4281-b951-d872f2087c98
* * Check in criteria checker project for Chrome bundle deals.kuchhal@chromium.org2008-11-265-0/+187
| | | | | | | | | | Already reviewed at - http://codereview.chromium.org/6347/ BUG=1380504 Review URL: http://codereview.chromium.org/12702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6074 0039d316-1c4b-4281-b951-d872f2087c98
* Rev stats file name to handle backwards incompatibilityjar@google.com2008-11-261-2/+2
| | | | | | | | | | | | | | | | There was a format change to this shared-memory file. Mike realized that changing the file name would avoid cross-version conflicts, allowing both new and old versions to run on one machine. Credit for diagnosis and repair goes to Mike (his build is currently horked, so I'm landing for him). bug=4767 r=mbelshe Review URL: http://codereview.chromium.org/12698 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6071 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux opt buildtc@google.com2008-11-261-2/+2
| | | | | | | | | | | Set initial values to 0. TBR=jar Review URL: http://codereview.chromium.org/12507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6070 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding docus manager crasher work-around.jcampan@chromium.org2008-11-263-3/+22
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/12685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6050 0039d316-1c4b-4281-b951-d872f2087c98
* Add the command line switch (--enable-video) for enabling HTML5 Video/Audio taghclam@chromium.org2008-11-262-1/+5
| | | | | | Review URL: http://codereview.chromium.org/12487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6047 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed two simple compilations that stopped browser/net/referrer.cctc@google.com2008-11-263-10/+11
| | | | | | | | | | | | from compiling on linux. Patch by Kunal Thakar <kunalt@gmail.com>, original CL: http://codereview.chromium.org/10773 Review URL: http://codereview.chromium.org/12674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix black flash when doing fast animations - our fix was previously ↵glen@chromium.org2008-11-261-6/+5
| | | | | | | | | | Vista-only, but now we have cross platform goodness. BUG=3676 Review URL: http://codereview.chromium.org/12670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6033 0039d316-1c4b-4281-b951-d872f2087c98
* Add client parameter to the RLZ pingcpu@google.com2008-11-265-3/+15
| | | | | | | | | | | | - Does nothing on regular chrome or chromium installs - up to google_update to put data in 'client' BUG=1503035 Review URL: http://codereview.chromium.org/12657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6030 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test that started failing with the merge.ojan@google.com2008-11-261-1/+2
| | | | | | | TBR to greenify build. Review URL: http://codereview.chromium.org/12669 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6028 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my previous commit, it seems to be breaking the UI tests in debug ↵jcampan@chromium.org2008-11-263-20/+3
| | | | | | | | mode. Review URL: http://codereview.chromium.org/12666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6020 0039d316-1c4b-4281-b951-d872f2087c98
* Changes keyword editor to map all input in the keyword field to lowersky@google.com2008-11-264-21/+33
| | | | | | | | | | | | case. BUG=4520 TEST=bring up the keyword editor, type some text and make sure it gets mapped to lower case. Review URL: http://codereview.chromium.org/12452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6018 0039d316-1c4b-4281-b951-d872f2087c98
* Attempted fix for some wheel/touchpad scrolling errors.pkasting@chromium.org2008-11-261-1/+1
| | | | | | | | | | | The nTrackPos member of SCROLLINFO is not actually the scroll position, and can't be set by a SetScrollInfo() call. Thus the SetScrollInfo() calls were actually setting the scroll position of the fake scroll bars to the upper left corner. This change sets the scroll position to the center of each scrollbar, in the hopes that some mouse drivers were querying the scroll position or thumb position and not sending scroll left/up messages when they found the page was already scrolled all the way left/up. This change may not help, but it won't hurt, and the old code was definitely wrong. Review URL: http://codereview.chromium.org/12415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6016 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on the new SafeBrowsing by default. To use the olderpaulg@google.com2008-11-265-11/+10
| | | | | | | | implemenation, use the command line flag: --old-safe-browsing Review URL: http://codereview.chromium.org/12448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6015 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create separate SiteInstances for pages from the same domain and schemecreis@google.com2008-11-263-14/+32
| | | | | | | | | | | | | | | | but from different ports. (These pages can still access each other.) (This is copied from http://codereview.chromium.org/12443, which has already been reviewed by darin and abarth. Just had to commit from a different checked out codebase.) BUG=4792 R=darin,abarth Review URL: http://codereview.chromium.org/12451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up paths now that test_file_util has moved.deanm@chromium.org2008-11-254-8/+3
| | | | | | Review URL: http://codereview.chromium.org/12453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6008 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/ - part 1.deanm@chromium.org2008-11-259-35/+60
| | | | | | | Review URL: http://codereview.chromium.org/11402 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6007 0039d316-1c4b-4281-b951-d872f2087c98
* Un-duplicate EvictFileFromSystemCache.deanm@chromium.org2008-11-2527-208/+1
| | | | | | | | | Change required for http://codereview.chromium.org/9639 . Review URL: http://codereview.chromium.org/12407 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6006 0039d316-1c4b-4281-b951-d872f2087c98
* Port base/watchdog to Linux.deanm@chromium.org2008-11-251-2/+2
| | | | | | | | | BUG=4632 Review URL: http://codereview.chromium.org/11326 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6004 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tab restore service to handle restoring closed windows as asky@google.com2008-11-259-213/+361
| | | | | | | | | | | | | | single unit. Sadly I've written another ui test. Lets hope it isn't flakey. Glen is going to change the NTP to deal with this appropriately. BUG=4686 TEST=Try closing a window (with more than one window open), hitting control-shift-t, and make sure the window and all it's tabs comes back. Review URL: http://codereview.chromium.org/11377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6003 0039d316-1c4b-4281-b951-d872f2087c98
* Some crashes reported from the field seems to indicate that whenjcampan@chromium.org2008-11-253-3/+20
| | | | | | | | | | | | | | | | | storing/restoring the focused view on a tab, the focus manager or focused view is garbage. I have not been able to repro any of these crashers and was not able to discover much from the mini-dumps. This is a simple work-around that just prevents the storing/restoring of focus when closing a tab, to avoid the cases reported in the crasher. Note this is the equivalent of CL 12622 (which is on the release branck), which was reviewed by Ben. BUG=4633 Review URL: http://codereview.chromium.org/12652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6000 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 23:54:55 +0000