summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* a few minor tweaks the bookmarks API:erikkay@google.com2009-06-296-28/+71
| | | | | | | | | | | | | | | | * change name "childrenIds" to "children" * add dateAdded and dateGroupModified properties * add id to onRemoved BUG=13994 BUG=14581 BUG=12217 TEST=load sample bookmarks extension and play around with Dump Bookmarks Review URL: http://codereview.chromium.org/151032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19536 0039d316-1c4b-4281-b951-d872f2087c98
* Corrects RWHVCocoa to convert from flipped to unflippedrohitrao@chromium.org2009-06-291-11/+34
| | | | | | | | | | coordinates before whiting out unpainted areas. BUG=None TEST=Resize newly-created window, check for black areas. Review URL: http://codereview.chromium.org/147232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in tips handler.finnur@chromium.org2009-06-291-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19533 0039d316-1c4b-4281-b951-d872f2087c98
* - Added a new time marker for loadtimes: first_paint_after_load_time. ↵davemoore@chromium.org2009-06-293-60/+120
| | | | | | | | | | | Created new histograms to expose it. Also made some new histograms that use a derived time: begin_time. This is the request_time if the page was requested by a user action, start time otherwise. Review URL: http://codereview.chromium.org/150010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19532 0039d316-1c4b-4281-b951-d872f2087c98
* Deletes now-unused growbox code.rohitrao@chromium.org2009-06-294-166/+0
| | | | | | | BUG=None TEST=None. No visible impact. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a comment.ericroman@google.com2009-06-291-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19524 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-293-22/+16
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing: DataSource is used before null check in GetLoadTimes.finnur@chromium.org2009-06-291-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19518 0039d316-1c4b-4281-b951-d872f2087c98
* Change to use encodeURIComponent to encode the UTF8 character in the returnedjianli@chromium.org2009-06-294-34/+2
| | | | | | | | | | | | | result. This is to make text-encoding.html work in UI test. Also removed a couple files forgot to remove during last commit. BUG=none TEST=none Review URL: http://codereview.chromium.org/150035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for ui_tests - accidental change went in.dimich@google.com2009-06-291-1/+1
| | | | | | | TBR=jianli Review URL: http://codereview.chromium.org/150043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19515 0039d316-1c4b-4281-b951-d872f2087c98
* Don't shutdown non-popup render views on clicks outside their bounds.estade@chromium.org2009-06-291-1/+5
| | | | | | Review URL: http://codereview.chromium.org/151031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19514 0039d316-1c4b-4281-b951-d872f2087c98
* Add three basic test items to RenderViewHostManagerTest:brettw@chromium.org2009-06-292-2/+134
| | | | | | | | | | | - Init - Navigate - DOMUI Original review: http://codereview.chromium.org/126060 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19513 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --enable-web-workers command-line switch.dimich@google.com2009-06-296-13/+1
| | | | | | | | BUG=4361 TEST=many ui/layout tests. Review URL: http://codereview.chromium.org/149114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where all clicks in app mode windows would result in a window move.tc@google.com2009-06-291-4/+10
| | | | | | | | | | | Also update the comment to properly describe the code. It was referring to the tab strip, but the code was using the toolbar. BUG=15576 Review URL: http://codereview.chromium.org/150037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19511 0039d316-1c4b-4281-b951-d872f2087c98
* Added Repair testcases. Also, currently installer tests are failing on ↵anantha@chromium.org2009-06-295-220/+416
| | | | | | | | official builds because the build location changed on filer. So added logic to handle it. Review URL: http://codereview.chromium.org/141058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19510 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Drags from bookmark menus to the bookmark bar.erg@google.com2009-06-296-130/+244
| | | | | | Review URL: http://codereview.chromium.org/147241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19505 0039d316-1c4b-4281-b951-d872f2087c98
* update dnd registry enum to work properly with bitmaskestade@chromium.org2009-06-291-4/+4
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/150033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19503 0039d316-1c4b-4281-b951-d872f2087c98
* Support running http layout tests for workers in UI test framework.jianli@chromium.org2009-06-291-36/+107
| | | | | | | | | | | | | | | BUG=none TEST=This is a UI test. Nicolas, could you please review DEPS? I added a couple of new lines to DEPS in order to fetch a copy the following directory into UI test data directory: LayoutTests/http/tests/resources LayoutTests/http/tests/workers LayoutTests/http/tests/xmlhttprequest Review URL: http://codereview.chromium.org/147125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19502 0039d316-1c4b-4281-b951-d872f2087c98
* Removes our homespun grow box and replaces it with therohitrao@chromium.org2009-06-298-101/+38
| | | | | | | | | | | standard widget. This may also fix some of our resizing issues. BUG=http://crbug.com/14663 TEST=The resizer widget should still work as expected. Review URL: http://codereview.chromium.org/149094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
* Use C99 standard format macros for 64-bit values.agl@chromium.org2009-06-291-3/+4
| | | | | | | | | | | | | | | | | | | Currently we have several uses of %I64d in format strings to indicate a 64-bit value. This does not work on Mac or Linux, where 'I' indicates the use of locale specific digits. Instead, we introduce base/format_macros.h which mimic the C99 standard macros for 64-bit values in a cross-platform manner. Dean pointed out that V8 is handling this themselves rather than use inttypes.h. Maybe we'll end up going down the same path but, for the moment, we'll try and do it the 'correct' way and see how it works out. http://codereview.chromium.org/147154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member view_ to NULL in constructor.finnur@chromium.org2009-06-291-1/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19499 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes for tab dragging in gtk:jhawkins@chromium.org2009-06-292-2/+10
| | | | | | | | | | | * Check that backing_store_ is non-NULL before using it. A drag can be initiated before the backing store has been created. * Don't read a size greater than the size of the backing store image. BUG=15387 TEST=Hard to reproduce. Quickly initiate a tab drag after opening a new tab. Review URL: http://codereview.chromium.org/150008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19496 0039d316-1c4b-4281-b951-d872f2087c98
* GTK DND:estade@chromium.org2009-06-2910-79/+148
| | | | | | | | | | | | | | - Rearrange DND constants, create convenience functions - (partially) implement drag onto home button Note that the homepage is still hard-wired to the dev build splash page, so that it seems like this isn't working, but via debugging I ascertained that dragging a random file from the desktop onto the home button should successfully set that file as the homepage. TEST=drag a lot of stuff all over the place (tabs, bookmarks, what have you), make sure nothing crashes BUG=none Review URL: http://codereview.chromium.org/147256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19495 0039d316-1c4b-4281-b951-d872f2087c98
* Let RenderProcessHost provide a method HasConnection() instead of exposingbrettw@chromium.org2009-06-2912-17/+41
| | | | | | | | | | | | | | | | | | | | | | | | channel(). Motivation: Currently, components that are using RenderProcessHost are checking its liveness by null testing on channel(). I'd like to write unittests for those components, but to mock out RenderProcessHost instances, I have to also mock out the instance returned by RenderProcessHost::channel(), but there's no interface class prepared. SyncChannel is directly used in RenderProcessHost. Instead of dependency injection, I can let mock objects return invalid pointer such as 0x1, but its bad test design. Rather than that, I'd like to introduce HasConnection() method and override it to return true. In fact, most of those components are not accessing channel()'s methods directry. They're just checking channel() is null or not, and to issue IPCs, they are calling Send method. So, it's OK to hide channel pointer from users, I think. Original review: http://codereview.chromium.org/147077 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up the create browser window.sky@chromium.org2009-06-293-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
* Replace DeleteSoon with PostTask(DeleteTask) in browser_window_gtk for ↵pfeldman@chromium.org2009-06-291-1/+5
| | | | | | | | | | | | browser to be closed while in ui tests. DevToolsSanityTests are running various scenarios including the ones that are waiting for browser to be closed. Tests are closing all the tabs in the browser and are running nested message loop until the BROWSER_CLOSE message arrives. The browser close logic on Linux was using DeleteSoon on the window object, but DeleteSoon was never executed since the task was non-nestable. This change simply posts DeleteTask instead of DeleteSoon and hence browser close logic is working fine on a nested loop. Review URL: http://codereview.chromium.org/151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19487 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL icon padding in Location Bar in Gtk.ukai@chromium.org2009-06-292-32/+59
| | | | | | | | | | | | | | | | | | When no ssl icon/ev text shown show 4px|location_entry|4px only When ssl icon/no ev text show 4px|location_entry|4px + 2px|ssl_icon|8px When ssl icon and ev text shown show 4px|location_entry|4px + 2px|ssl_icon|8px + |ev_text|4px BUG=none TEST=none Review URL: http://codereview.chromium.org/151017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19485 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 13432.hbono@chromium.org2009-06-292-1/+6
| | | | | | | | | | | This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087. I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue. BUG=13432 "Any word of 13 or 14 characters is not spellcheck" TEST=run unit_test.exe. Review URL: http://codereview.chromium.org/146074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19482 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_manager* and site_instance* from tab_contents to ↵brettw@chromium.org2009-06-2921-33/+33
| | | | | | | | renderer_host. Review URL: http://codereview.chromium.org/150011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
* Another go at switching mini_installer to gyp.bradnelson@google.com2009-06-291-3/+0
| | | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19480 0039d316-1c4b-4281-b951-d872f2087c98
* Added stub native web worker support, including build support in preparationsehr@google.com2009-06-2910-3/+353
| | | | | | | for integrating the native client build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19479 0039d316-1c4b-4281-b951-d872f2087c98
* Add 15547 to known crash.huanr@chromium.org2009-06-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/151008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19478 0039d316-1c4b-4281-b951-d872f2087c98
* Switching gyp off for mini_installer.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | | | | | There still seem to be some issues. (Odd it worked locally...) BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19477 0039d316-1c4b-4281-b951-d872f2087c98
* Switching mini_installer to be gyp generated.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19476 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change 19472.bradnelson@chromium.org2009-06-283-175/+146
| | | | | | | | | | | | Broke the tree.... :-( BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19473 0039d316-1c4b-4281-b951-d872f2087c98
* Switching over mini_installer to gyp.bradnelson@chromium.org2009-06-283-146/+175
| | | | | | | | | | | | | | Ended up moving it to a separate gyp file so that msvs_use_common_release gets applied at the right time (has to be before the include gets evaluated). BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19472 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot an include.tim@chromium.org2009-06-272-1/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/151001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19470 0039d316-1c4b-4281-b951-d872f2087c98
* Make members protected so they can be set in an overloadedtim@chromium.org2009-06-271-0/+12
| | | | | | | | SetUp method. Review URL: http://codereview.chromium.org/149039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19469 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the forgotten renames of recommendations to tips.arv@google.com2009-06-272-8/+8
| | | | | | | | | | BUG=15491 TEST=Open the options menu and there should be no "null" in the UI Review URL: http://codereview.chromium.org/147249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for reverted cl http://codereview.chromium.org/147123davemoore@chromium.org2009-06-277-38/+93
| | | | | | | | | | | | | A recent change broke the load times. It also revealed some deficiencies. This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/149099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19465 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DNS A/B experient, and add test of congestion time limitsjar@chromium.org2009-06-276-78/+126
| | | | | | | | | | | | | | | | I added another option in the DNS experiment: user 2 seconds or 500ms for the congestion limit (that causes pre-resolutions to be discarded from the queue. The code in browser_main.cc was getting toooo large, so I pulled all the experiment code into dns_global.cc. BUG=15479 r=eroman Review URL: http://codereview.chromium.org/147215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19464 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that even if the HostResolver outlives the IO thread, its jobs will ↵ericroman@google.com2009-06-271-0/+3
| | | | | | | | | | | | | not try to complete on the IO thread. This is an experiment for http://crbug.com/15513 BUG=15513 TBR=willchan Review URL: http://codereview.chromium.org/150001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19463 0039d316-1c4b-4281-b951-d872f2087c98
* Need to temporarily flip this back to gfx::NativeView since the other ↵ben@chromium.org2009-06-272-3/+4
| | | | | | | | | | platforms don't like it as window. Will fix later. TBR=sky BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19461 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustage by using ALLOW_THIS_IN_INITIALIZER_LISTben@chromium.org2009-06-271-5/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19460 0039d316-1c4b-4281-b951-d872f2087c98
* gcl error, this file belonged in last changesetben@chromium.org2009-06-271-0/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19459 0039d316-1c4b-4281-b951-d872f2087c98
* First part of bookmark context menu reorg.ben@chromium.org2009-06-2710-681/+662
| | | | | | | | | | | BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu. BUG=none TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus. Review URL: http://codereview.chromium.org/149055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19458 0039d316-1c4b-4281-b951-d872f2087c98
* A first implementation of the SSL client auth UI.This uses the Windows API ↵jcampan@chromium.org2009-06-278-16/+192
| | | | | | | | that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Review URL: http://codereview.chromium.org/147233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19447.ericroman@google.com2009-06-271-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was causing interactive ui tests to fail with a crash: kernel32.dll!_InterlockedDecrement@4() > interactive_ui_tests.exe!sk_atomic_dec() Line 40 C++ interactive_ui_tests.exe!SkBitmap::MipMap::unref() Line 76 C++ interactive_ui_tests.exe!SkBitmap::freeMipMap() Line 367 C++ interactive_ui_tests.exe!SkBitmap::freePixels() Line 346 C++ interactive_ui_tests.exe!SkBitmap::~SkBitmap() Line 100 C++ interactive_ui_tests.exe!SkBitmap::`scalar deleting destructor'() C++ interactive_ui_tests.exe!BrowserThemeProvider::FreeImages() Line 744 C++ interactive_ui_tests.exe!BrowserThemeProvider::~BrowserThemeProvider() Line 141 C++ interactive_ui_tests.exe!BrowserThemeProvider::`scalar deleting destructor'() C++ interactive_ui_tests.exe!base::RefCounted<BrowserThemeProvider>::Release() Line 80 C++ interactive_ui_tests.exe!scoped_refptr<BrowserThemeProvider>::operator=() Line 209 C++ interactive_ui_tests.exe!ProfileImpl::~ProfileImpl() Line 584 C++ interactive_ui_tests.exe!ProfileImpl::`scalar deleting destructor'() C++ interactive_ui_tests.exe!ProfileManager::~ProfileManager() Line 57 C++ interactive_ui_tests.exe!ProfileManager::`scalar deleting destructor'() C++ interactive_ui_tests.exe!scoped_ptr<ProfileManager>::reset() Line 81 C++ interactive_ui_tests.exe!BrowserProcessImpl::~BrowserProcessImpl() Line 164 C++ interactive_ui_tests.exe!BrowserProcessImpl::`scalar deleting destructor'() C++ interactive_ui_tests.exe!browser_shutdown::Shutdown() Line 135 C++ interactive_ui_tests.exe!BrowserMain() Line 826 C++ interactive_ui_tests.exe!InProcessBrowserTest::SetUp() Line 129 C++ interactive_ui_tests.exe!testing::Test::Run() Line 2021 C++ interactive_ui_tests.exe!testing::internal::TestInfoImpl::Run() Line 2291 C++ interactive_ui_tests.exe!testing::internal::TestInfoImpl::RunTest() Line 656 C++ Review URL: http://codereview.chromium.org/147259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mistake on spwaning setup againcpu@google.com2009-06-271-2/+1
| | | | | | | | | | | | - I mean to spawn setup.exe --flag but it does setup.exe --uninstall - sweet overloaded functions also let you shoot yourself in the foot BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/147253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19452 0039d316-1c4b-4281-b951-d872f2087c98
* Make net::HostResolver refcounted.ericroman@google.com2009-06-275-34/+26
| | | | | | | | | | | This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer. BUG=http://crbug.com/14664 TEST=existing unit tests. Review URL: http://codereview.chromium.org/149053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19451 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 16:59:26 +0000