summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Let checkdeps ignore #if 0 blocks. Also strip lines of leading/trailing ↵thestig@chromium.org2009-03-181-3/+0
| | | | | | | | whitespaces before checking. Review URL: http://codereview.chromium.org/42316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11986 0039d316-1c4b-4281-b951-d872f2087c98
* Fix underflow that would cause either an access violation or an infinite ↵robertshield@google.com2009-03-181-2/+3
| | | | | | | | loop if we were ever to get a "chrome_config" node back in metrics response data. Review URL: http://codereview.chromium.org/42335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-187-111/+99
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors detected by coverity.paulg@google.com2009-03-181-6/+6
| | | | | | Review URL: http://codereview.chromium.org/48136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11981 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Get(Root)WindowRect handlers for the Mac.avi@google.com2009-03-188-65/+120
| | | | | | | | Fixes http://crbug.com/8829 . Review URL: http://codereview.chromium.org/42336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11980 0039d316-1c4b-4281-b951-d872f2087c98
* Reland the changes to use command line switch to turn on worker feature.jianli@chromium.org2009-03-184-0/+10
| | | | | | Review URL: http://codereview.chromium.org/48106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11975 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-1810-10/+5
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dragging a Chrome window which has a single tab by the tab itself.idanan@chromium.org2009-03-181-7/+1
| | | | | | | | | | | | | | | | | | | A change in 9953 made a tab of a single chrome-window with a single tab part of the client area so that double-clicks on it are not treated as non-client double-clicks and that the tab context-menu appears instead of the system context menu (see issue 3787). That change also solved issue 2827 (which is not restructed to the close button of the right-most tab). Change 10929 reverted 9953 partially, keeping the sinle-tab of a single-window as part of the client area but removed the double-click swallowing code that was needed to fix 2827. In doing so, dragging a single-tabbed single chrome window by the tab (not the tabstrip) no longer worked. This small changes only fixes that behavior. It turns out that there was a use case where some users want double-clicks to be considered as two single-clicks (see issue 8287) and swallowing the double-click breaks this. Review URL: http://codereview.chromium.org/46033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11973 0039d316-1c4b-4281-b951-d872f2087c98
* Style issues:patrick@chromium.org2009-03-181-4/+6
| | | | | | | | | - Fix indentation. - Reorder typedefs according to style guide. - Add DISALLOW_COPY_AND_ASSIGN. Review URL: http://codereview.chromium.org/42322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11971 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an assertion I added in my DOM UI change. It looks like this happens inbrettw@chromium.org2009-03-181-5/+0
| | | | | | | some cases and doesn't represent an actual problem. Review URL: http://codereview.chromium.org/48134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11966 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a few minor issues found during static analysis of the Chromium codebase.finnur@chromium.org2009-03-183-6/+6
| | | | | | | | | | | | | | | | | | | | | | find_bar_controller.cc: Unused local variable created. hwnd_view.cc: The local definition of parent overshadows param passed in. google_update.cc: Uninitialized member variable. webframe_impl.cc: The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change. Review URL: http://codereview.chromium.org/42321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests print results on Linux.phajdan.jr@chromium.org2009-03-187-160/+161
| | | | | | | | Switch from wstring to string where needed. Review URL: http://codereview.chromium.org/42303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11963 0039d316-1c4b-4281-b951-d872f2087c98
* Port DirectoryWatcher to Linux using inotify.phajdan.jr@chromium.org2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 11946 since it is causing a build breakage on full rebuild. The maruel@chromium.org2009-03-181-1/+1
| | | | | | | | | | sandbox project wasn't copying wow_helper.exe anymore, causing a build breakage on x64 platforms only. TBR=bnelson Review URL: http://codereview.chromium.org/42328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11955 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11953.hbono@chromium.org2009-03-189-179/+1
| | | | | | Review URL: http://codereview.chromium.org/48121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
* A tricky fix for Issue 1845.hbono@chromium.org2009-03-189-1/+179
| | | | | | | | | | | | | | | | | This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below. 1. Emulating the implementation of Safari that changes the text-direction of an input element. Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction. 2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys. This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys. BUG=1845 Review URL: http://codereview.chromium.org/39252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix to prevent double launch of chrome at install.cpu@google.com2009-03-181-1/+3
| | | | | | | | | | | - According to docs we should not be writing InstallerSuccessLaunchCmdLine - Might affect gcapi BUG=1719600 Review URL: http://codereview.chromium.org/48120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11950 0039d316-1c4b-4281-b951-d872f2087c98
* Moving sbox to gyp on windows.bradnelson@google.com2009-03-181-1/+1
| | | | | | | | | (Also fixing missing property on sdch.) Review URL: http://codereview.chromium.org/42317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11946 0039d316-1c4b-4281-b951-d872f2087c98
* - Modify DOM checker automation to use DOM Automation Controller instead ofpatrick@chromium.org2009-03-1810-143/+737
| | | | | | | | | | | | | | | | | cookie values to get results back to the test executable. This fixes an issue where the test could not be automated to run from local disk - that required file cookies, which causes the DOM checker test to fail. This is also a cleaner approach. - Add test to run DOM checker automation from local disk. - Add code to optionally disable file cookies in UI tests. Disable them in the DOM checker tests. - Add a function to the UITest class that allows a test to wait for a JavaScript condition in the test page. BUG=6274 Review URL: http://codereview.chromium.org/48055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11945 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing subtle dependency on client name on my last change to chrome.sln.bradnelson@google.com2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/48119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11944 0039d316-1c4b-4281-b951-d872f2087c98
* Switching net over to use gyp on windows.bradnelson@google.com2009-03-184-1297/+1321
| | | | | | Review URL: http://codereview.chromium.org/48108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus DCHECKabarth@chromium.org2009-03-181-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11938 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 8.abarth@chromium.org2009-03-184-144/+267
| | | | | | | | | | | Cleanup the SSLPolicy API. This should be the last reorganization patch. The next step should be the substantive changes. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11937 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-1832-240/+815
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/hash_tables.h.thestig@chromium.org2009-03-174-4/+0
| | | | | | Review URL: http://codereview.chromium.org/48098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where an extension toolstrip would sometimes get added twice to thempcomplete@google.com2009-03-171-3/+11
| | | | | | | | | bookmark bar. The problem was that sometimes the EXTENSIONS_LOADED notification would get sent before we initialized the bookmark view (which adds the initial extension toolstrips). Review URL: http://codereview.chromium.org/42252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11927 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DOMUIContents into WebContents.brettw@chromium.org2009-03-1748-1226/+1189
| | | | | | | I did a lot of cleanup of the DOM UI system as part of this. Review URL: http://codereview.chromium.org/42227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on showing info bubble.sky@google.com2009-03-171-6/+4
| | | | | | | | | BUG=8854 TEST=see bug Review URL: http://codereview.chromium.org/42302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11924 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in WebMediaPlayerDelegateImpl that stalls video playbackhclam@chromium.org2009-03-171-8/+8
| | | | | | | | | | NotifyWebMediaPlayerTask is not calling WebMediaPlayerDelegateImpl::DidTask so new tasks are never scheduled. Also Changed NotifyWebMediaPlayerTask a bit so it can call DidTask. Review URL: http://codereview.chromium.org/48093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11918 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes build breakage on Linux.klink@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=estade (fixing broken Linux build) Review URL: http://codereview.chromium.org/42307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11915 0039d316-1c4b-4281-b951-d872f2087c98
* Renames AccessibleWrapper to ViewAccessibilityWrapper for clarity. klink@chromium.org2009-03-179-295/+434
| | | | | | | | Reorders the functions in ViewAccessibility to match the order used in BrowserAccessibility, accessibility.h and in Glue/WebKit. Review URL: http://codereview.chromium.org/46011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11914 0039d316-1c4b-4281-b951-d872f2087c98
* Find the 32-bit libs in the right place on 32-bit buildbot.mmoss@chromium.org2009-03-171-15/+20
| | | | | | | Review URL: http://codereview.chromium.org/42300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11912 0039d316-1c4b-4281-b951-d872f2087c98
* Some upstream code assumes that the executable path from the path service isthomasvl@chromium.org2009-03-171-3/+17
| | | | | | | | | | | | | | | | standardized, but NSBundle makes not such promise, so we standardize it ourselves. While here, remove the app data dir support since it seems the installer and windows sandbox are the only things that need it. Moved that code upstream to the chrome paths... Directly handle the user data dir w/in the chrome path service call back, return different things for chrome vs. chromium. Review URL: http://codereview.chromium.org/48089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11910 0039d316-1c4b-4281-b951-d872f2087c98
* Second stab at applying http://codereview.chromium.org/43138/show.robertshield@google.com2009-03-1716-11/+387
| | | | | | | | Removing the (not really needed) dependency on chrome\VERSION which works on the try server but breaks on buildbot. Review URL: http://codereview.chromium.org/42289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11909 0039d316-1c4b-4281-b951-d872f2087c98
* Revert tree bustage cause by r11904.hclam@chromium.org2009-03-171-7/+8
| | | | | | TBR=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11906 0039d316-1c4b-4281-b951-d872f2087c98
* andrew's patchhclam@chromium.org2009-03-171-8/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11904 0039d316-1c4b-4281-b951-d872f2087c98
* Use anonymous shared memory for VisitedLinks.agl@chromium.org2009-03-172-20/+4
| | | | | | | | | | | | | | We already pass a handle to the shared memory via IPC but, when we create it, we create a named segment. These segments are not garbage collected on POSIX. Since nobody actually uses the name of the segment, use an anonymous segment instead and remove the functions. Review URL: http://codereview.chromium.org/48087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11900 0039d316-1c4b-4281-b951-d872f2087c98
* This test only passed if RLZTracker::InitRlz hadn't been called, levin@chromium.org2009-03-171-3/+11
| | | | | | | | | | so it failed when the test run order happened to change. This change fixes that. Review URL: http://codereview.chromium.org/42283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11899 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at Mac status bubble.avi@google.com2009-03-176-3/+304
| | | | | | Review URL: http://codereview.chromium.org/48070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11895 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 7.abarth@chromium.org2009-03-172-263/+103
| | | | | | | | | | | Simplify SSLPolicy to prepare for changing its algorithm. This change should not change the SSLPolicy behavior at all. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11892 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 6.abarth@chromium.org2009-03-173-17/+69
| | | | | | | | | | | | | Merge in changes to SSLHostState. We now can store whether a specific origin is "broken," which is the key new bit of state that we need to share between tabs. Currently, there is a naming inconsistency between the SSLManager names and the SSLHostState names. I'll clear this up when I merge in the new SSLManager. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/42274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11891 0039d316-1c4b-4281-b951-d872f2087c98
* Add v8::internal::Invoke (sqrt) crash to known crashes.patrick@chromium.org2009-03-171-0/+3
| | | | | | Review URL: http://codereview.chromium.org/48076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11881 0039d316-1c4b-4281-b951-d872f2087c98
* Don't initialize members from themselves, especially when they're uninitialized.mark@chromium.org2009-03-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11880 0039d316-1c4b-4281-b951-d872f2087c98
* Move v8::internal::SweepSpace to the mysterious crash section.patrick@chromium.org2009-03-171-3/+3
| | | | | | | The V8 team believes this may be due to random memory corruption. Review URL: http://codereview.chromium.org/46090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11879 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where favicons wouldn't always show up in history page. Thissky@google.com2009-03-171-1/+8
| | | | | | | | | | | | | | would happen for an URLs that contained parens. These need to be escaped when using in CSS. BUG=none TEST=Go to a page that has parens in it (such as http://en.wikipedia.org/wiki/The_Wire_(season_5) ). Then open up history and make sure you get a favicon for the site. Review URL: http://codereview.chromium.org/48043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11876 0039d316-1c4b-4281-b951-d872f2087c98
* Register more prefs on linux/mac.tc@google.com2009-03-171-6/+5
| | | | | | | Review URL: http://codereview.chromium.org/48052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11875 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API.deanm@chromium.org2009-03-172-17/+6
| | | | | | | | | | | | | Move away from the deprecated GtkTooltips API, instead using the preferred methods on GtkWidget. Add missing tooltips to the back and forward buttons. This also fixes a memory leak of the old tooltips object which is no longer needed. BUG=8868 Review URL: http://codereview.chromium.org/48068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11873 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that MenuGtks are destroyed before their accelerator group.deanm@chromium.org2009-03-173-30/+26
| | | | | | | | | | | | | When a MenuGtk is created, it is passed a GtkAccelGroup. Previously the GtkMenu widgets were destroyed after the browser window, which was the owner of the GtkAccelGroup. Make the toolbar own a reference to the GtkAccelGroup, and teardown all GtkMenus that reference it beforehand. Some MenuGtk cleanup while debugging the problem. BUG=8866 Review URL: http://codereview.chromium.org/48065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Enable building worker and use command line switch to turn on ..."agl@chromium.org2009-03-174-10/+0
| | | | | | | This reverts commit 11870. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11871 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building worker and use command line switch to turn on this feature.jianli@chromium.org2009-03-174-0/+10
| | | | | | Review URL: http://codereview.chromium.org/41029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11870 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 20:55:52 +0000