summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Let RenderProcessHost provide a method HasConnection() instead of exposingbrettw@chromium.org2009-06-2912-17/+41
| | | | | | | | | | | | | | | | | | | | | | | | channel(). Motivation: Currently, components that are using RenderProcessHost are checking its liveness by null testing on channel(). I'd like to write unittests for those components, but to mock out RenderProcessHost instances, I have to also mock out the instance returned by RenderProcessHost::channel(), but there's no interface class prepared. SyncChannel is directly used in RenderProcessHost. Instead of dependency injection, I can let mock objects return invalid pointer such as 0x1, but its bad test design. Rather than that, I'd like to introduce HasConnection() method and override it to return true. In fact, most of those components are not accessing channel()'s methods directry. They're just checking channel() is null or not, and to issue IPCs, they are calling Send method. So, it's OK to hide channel pointer from users, I think. Original review: http://codereview.chromium.org/147077 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up the create browser window.sky@chromium.org2009-06-293-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
* Replace DeleteSoon with PostTask(DeleteTask) in browser_window_gtk for ↵pfeldman@chromium.org2009-06-291-1/+5
| | | | | | | | | | | | browser to be closed while in ui tests. DevToolsSanityTests are running various scenarios including the ones that are waiting for browser to be closed. Tests are closing all the tabs in the browser and are running nested message loop until the BROWSER_CLOSE message arrives. The browser close logic on Linux was using DeleteSoon on the window object, but DeleteSoon was never executed since the task was non-nestable. This change simply posts DeleteTask instead of DeleteSoon and hence browser close logic is working fine on a nested loop. Review URL: http://codereview.chromium.org/151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19487 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL icon padding in Location Bar in Gtk.ukai@chromium.org2009-06-292-32/+59
| | | | | | | | | | | | | | | | | | When no ssl icon/ev text shown show 4px|location_entry|4px only When ssl icon/no ev text show 4px|location_entry|4px + 2px|ssl_icon|8px When ssl icon and ev text shown show 4px|location_entry|4px + 2px|ssl_icon|8px + |ev_text|4px BUG=none TEST=none Review URL: http://codereview.chromium.org/151017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19485 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 13432.hbono@chromium.org2009-06-292-1/+6
| | | | | | | | | | | This is caused by my bonehead mistake that I forgot filtering out U_STRING_NOT_TERMINATED_WARNING while checking the return value in SpellCheckWordIterator::Normalize() in my change r10087. I have added code that checks if the result value is U_STRING_NOT_TERMINATED_WARNING and added a couple of test cases which verify this issue. BUG=13432 "Any word of 13 or 14 characters is not spellcheck" TEST=run unit_test.exe. Review URL: http://codereview.chromium.org/146074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19482 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_manager* and site_instance* from tab_contents to ↵brettw@chromium.org2009-06-2921-33/+33
| | | | | | | | renderer_host. Review URL: http://codereview.chromium.org/150011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
* Another go at switching mini_installer to gyp.bradnelson@google.com2009-06-291-3/+0
| | | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19480 0039d316-1c4b-4281-b951-d872f2087c98
* Added stub native web worker support, including build support in preparationsehr@google.com2009-06-2910-3/+353
| | | | | | | for integrating the native client build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19479 0039d316-1c4b-4281-b951-d872f2087c98
* Add 15547 to known crash.huanr@chromium.org2009-06-281-0/+3
| | | | | | Review URL: http://codereview.chromium.org/151008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19478 0039d316-1c4b-4281-b951-d872f2087c98
* Switching gyp off for mini_installer.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | | | | | There still seem to be some issues. (Odd it worked locally...) BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19477 0039d316-1c4b-4281-b951-d872f2087c98
* Switching mini_installer to be gyp generated.bradnelson@chromium.org2009-06-281-1/+2
| | | | | | | | | | BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19476 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change 19472.bradnelson@chromium.org2009-06-283-175/+146
| | | | | | | | | | | | Broke the tree.... :-( BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19473 0039d316-1c4b-4281-b951-d872f2087c98
* Switching over mini_installer to gyp.bradnelson@chromium.org2009-06-283-146/+175
| | | | | | | | | | | | | | Ended up moving it to a separate gyp file so that msvs_use_common_release gets applied at the right time (has to be before the include gets evaluated). BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19472 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot an include.tim@chromium.org2009-06-272-1/+1
| | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/151001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19470 0039d316-1c4b-4281-b951-d872f2087c98
* Make members protected so they can be set in an overloadedtim@chromium.org2009-06-271-0/+12
| | | | | | | | SetUp method. Review URL: http://codereview.chromium.org/149039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19469 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the forgotten renames of recommendations to tips.arv@google.com2009-06-272-8/+8
| | | | | | | | | | BUG=15491 TEST=Open the options menu and there should be no "null" in the UI Review URL: http://codereview.chromium.org/147249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for reverted cl http://codereview.chromium.org/147123davemoore@chromium.org2009-06-277-38/+93
| | | | | | | | | | | | | A recent change broke the load times. It also revealed some deficiencies. This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/149099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19465 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DNS A/B experient, and add test of congestion time limitsjar@chromium.org2009-06-276-78/+126
| | | | | | | | | | | | | | | | I added another option in the DNS experiment: user 2 seconds or 500ms for the congestion limit (that causes pre-resolutions to be discarded from the queue. The code in browser_main.cc was getting toooo large, so I pulled all the experiment code into dns_global.cc. BUG=15479 r=eroman Review URL: http://codereview.chromium.org/147215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19464 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that even if the HostResolver outlives the IO thread, its jobs will ↵ericroman@google.com2009-06-271-0/+3
| | | | | | | | | | | | | not try to complete on the IO thread. This is an experiment for http://crbug.com/15513 BUG=15513 TBR=willchan Review URL: http://codereview.chromium.org/150001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19463 0039d316-1c4b-4281-b951-d872f2087c98
* Need to temporarily flip this back to gfx::NativeView since the other ↵ben@chromium.org2009-06-272-3/+4
| | | | | | | | | | platforms don't like it as window. Will fix later. TBR=sky BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19461 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustage by using ALLOW_THIS_IN_INITIALIZER_LISTben@chromium.org2009-06-271-5/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19460 0039d316-1c4b-4281-b951-d872f2087c98
* gcl error, this file belonged in last changesetben@chromium.org2009-06-271-0/+53
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19459 0039d316-1c4b-4281-b951-d872f2087c98
* First part of bookmark context menu reorg.ben@chromium.org2009-06-2710-681/+662
| | | | | | | | | | | BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu. BUG=none TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus. Review URL: http://codereview.chromium.org/149055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19458 0039d316-1c4b-4281-b951-d872f2087c98
* A first implementation of the SSL client auth UI.This uses the Windows API ↵jcampan@chromium.org2009-06-278-16/+192
| | | | | | | | that prompts the user for a cert.R=wtcBUG=http://crbug.com/318TEST=Visit a site that requires client auth. A dialog to select a certificate should be shown. Try selecting no cert. Try again this time select a cert. Review URL: http://codereview.chromium.org/147233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19456 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19447.ericroman@google.com2009-06-271-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was causing interactive ui tests to fail with a crash: kernel32.dll!_InterlockedDecrement@4() > interactive_ui_tests.exe!sk_atomic_dec() Line 40 C++ interactive_ui_tests.exe!SkBitmap::MipMap::unref() Line 76 C++ interactive_ui_tests.exe!SkBitmap::freeMipMap() Line 367 C++ interactive_ui_tests.exe!SkBitmap::freePixels() Line 346 C++ interactive_ui_tests.exe!SkBitmap::~SkBitmap() Line 100 C++ interactive_ui_tests.exe!SkBitmap::`scalar deleting destructor'() C++ interactive_ui_tests.exe!BrowserThemeProvider::FreeImages() Line 744 C++ interactive_ui_tests.exe!BrowserThemeProvider::~BrowserThemeProvider() Line 141 C++ interactive_ui_tests.exe!BrowserThemeProvider::`scalar deleting destructor'() C++ interactive_ui_tests.exe!base::RefCounted<BrowserThemeProvider>::Release() Line 80 C++ interactive_ui_tests.exe!scoped_refptr<BrowserThemeProvider>::operator=() Line 209 C++ interactive_ui_tests.exe!ProfileImpl::~ProfileImpl() Line 584 C++ interactive_ui_tests.exe!ProfileImpl::`scalar deleting destructor'() C++ interactive_ui_tests.exe!ProfileManager::~ProfileManager() Line 57 C++ interactive_ui_tests.exe!ProfileManager::`scalar deleting destructor'() C++ interactive_ui_tests.exe!scoped_ptr<ProfileManager>::reset() Line 81 C++ interactive_ui_tests.exe!BrowserProcessImpl::~BrowserProcessImpl() Line 164 C++ interactive_ui_tests.exe!BrowserProcessImpl::`scalar deleting destructor'() C++ interactive_ui_tests.exe!browser_shutdown::Shutdown() Line 135 C++ interactive_ui_tests.exe!BrowserMain() Line 826 C++ interactive_ui_tests.exe!InProcessBrowserTest::SetUp() Line 129 C++ interactive_ui_tests.exe!testing::Test::Run() Line 2021 C++ interactive_ui_tests.exe!testing::internal::TestInfoImpl::Run() Line 2291 C++ interactive_ui_tests.exe!testing::internal::TestInfoImpl::RunTest() Line 656 C++ Review URL: http://codereview.chromium.org/147259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mistake on spwaning setup againcpu@google.com2009-06-271-2/+1
| | | | | | | | | | | | - I mean to spawn setup.exe --flag but it does setup.exe --uninstall - sweet overloaded functions also let you shoot yourself in the foot BUG=b/1484308 TEST=see the bug Review URL: http://codereview.chromium.org/147253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19452 0039d316-1c4b-4281-b951-d872f2087c98
* Make net::HostResolver refcounted.ericroman@google.com2009-06-275-34/+26
| | | | | | | | | | | This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer. BUG=http://crbug.com/14664 TEST=existing unit tests. Review URL: http://codereview.chromium.org/149053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19451 0039d316-1c4b-4281-b951-d872f2087c98
* Finish the gtk search engine manager.mattm@chromium.org2009-06-272-23/+353
| | | | | | | | | BUG=13326 TEST=Open options, click search engines manage button, try adding, removing, making default, etc. Review URL: http://codereview.chromium.org/147243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19449 0039d316-1c4b-4281-b951-d872f2087c98
* mac/linux: rework plugin channel file descriptor creationevan@chromium.org2009-06-278-72/+69
| | | | | | | | | | | | This CL fixes a bug where the same renderer could open several channels to the same plugin process, which end up having the same name. This CL makes it that there is only one channel for each (plugin, renderer) pair, just like on Windows. The socketpair is created in the plugin process (which can ensure that only one channel per renderer gets created), and sends the renderer side through the browser process. Note: this should essentially be a noop on Windows. Review URL: http://codereview.chromium.org/149062 Patch from Antoine Labour <piman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19448 0039d316-1c4b-4281-b951-d872f2087c98
* We're leaking almost all the theme bitmaps. Properly delete imagestc@google.com2009-06-271-6/+11
| | | | | | | | | | | | | | | when we create them. We have to copy images that come from ResourceBundle because ResourceBundle owns them. Valgrind still sees more leaks in this area, but I need to investigate some more and these are the biggies. Review URL: http://codereview.chromium.org/149112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19447 0039d316-1c4b-4281-b951-d872f2087c98
* Add more privacy prefsmattm@chromium.org2009-06-271-24/+222
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/149118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19446 0039d316-1c4b-4281-b951-d872f2087c98
* Linux web drag first cut.estade@chromium.org2009-06-272-7/+61
| | | | | | | | | | | You can only drag out of the web contents, and can only drag text. http://crbug.com/15429 TEST=try dragging some text into gedit Review URL: http://codereview.chromium.org/147245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19445 0039d316-1c4b-4281-b951-d872f2087c98
* revert cl 19438rvargas@google.com2009-06-279-195/+1566
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19444 0039d316-1c4b-4281-b951-d872f2087c98
* Simple clean-up of the ssl_manager.h includes.jcampan@chromium.org2009-06-263-20/+7
| | | | | | | | | R=wtc BUG=None TEST=None Review URL: http://codereview.chromium.org/147234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19442 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line switch to allow setting the max sizervargas@google.com2009-06-265-28/+66
| | | | | | | | | | | | | | of the disk cache. This switch is intended for troubleshooting, not to add another supported configuration. BUG=15117 TEST=none Review URL: http://codereview.chromium.org/146136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19439 0039d316-1c4b-4281-b951-d872f2087c98
* Make the new new tab page the default new tab page.arv@google.com2009-06-269-1566/+195
| | | | | | | | | | | | | I changed the command line switch "--new-new-tab-page" to "-new-tab-page=<path>" so we can continue to iterate. BUG=13362 TEST=The new new tab page should be on by default. Review URL: http://codereview.chromium.org/147226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19438 0039d316-1c4b-4281-b951-d872f2087c98
* Do not write magic string to registry for non Google Chrome builds.kuchhal@chromium.org2009-06-261-1/+3
| | | | | | | | BUG=15410 Review URL: http://codereview.chromium.org/147216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19436 0039d316-1c4b-4281-b951-d872f2087c98
* WriteThumbnailToDisk runs on a bg thread so it cannot access the cache_ ↵meelapshah@chromium.org2009-06-263-6/+15
| | | | | | | | | | directly. Instead, pass the data to be written to disk so no cache_ lookups are necessary. Review URL: http://codereview.chromium.org/149105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19435 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19425.ericroman@google.com2009-06-265-19/+31
| | | | | | Review URL: http://codereview.chromium.org/147242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19432 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-2684-1084/+1196
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens when changing themes.tc@google.com2009-06-263-22/+55
| | | | | | | | | | | | | | | | | | We were holding references to images that got deleted when themes changed. These all happen to be in a NineBox, so have NineBox reload images when the theme change notification is sent. Also fix an expose bug that wasn't noticeable in the original theme. We need to always place the image at 0, 0 for the background and paint it all the way across the window (should get clipped by cairo). BUG=15366 Review URL: http://codereview.chromium.org/149102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19426 0039d316-1c4b-4281-b951-d872f2087c98
* Make net::HostResolver refcounted.ericroman@google.com2009-06-265-31/+19
| | | | | | | | | | | This way it can be properly shared between the url request contexts, and the dns prefetcher, and dns observer. BUG=http://crbug.com/14664 TEST=existing unit tests. Review URL: http://codereview.chromium.org/149053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19425 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications for when V8Proxy creates or destroys a V8 Context.mpcomplete@chromium.org2009-06-264-0/+33
| | | | | | | | | | BUG=no TEST=no Review URL: http://codereview.chromium.org/147124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19424 0039d316-1c4b-4281-b951-d872f2087c98
* Missed a test that needed to be updated with r19418.mark@chromium.org2009-06-261-7/+15
| | | | | | | | BUG=15462 TEST=unit_tests --gtest_filter=JSONValueSerializerTest.Roundtrip Review URL: http://codereview.chromium.org/149103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19422 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the win KeywordEditorView for cross platform friendliness.mattm@chromium.org2009-06-268-561/+706
| | | | | | | | | | | The TableModel is moved to search_engines/template_url_table_model.* The shared logic, and ownership of the url_model_ and table_model_, is moved to search_engines/keyword_editor_controller.* BUG=13326 Review URL: http://codereview.chromium.org/146138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19421 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform-appropriate newlines in JSON output.mark@chromium.org2009-06-265-39/+41
| | | | | | | | BUG=15462 TEST=base_unittests, unit_tests, check newlines in bookmarks file Review URL: http://codereview.chromium.org/147220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19418 0039d316-1c4b-4281-b951-d872f2087c98
* Do some minor cleanup I noticed in SiteInstance. Before, we would parse andbrettw@chromium.org2009-06-263-19/+24
| | | | | | | | | | | | canonicalize the three about URLs every time this function was called (I think for every page transition). This is unnecessary, so I just added a string comparison. TEST=none BUG=none Review URL: http://codereview.chromium.org/149084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19416 0039d316-1c4b-4281-b951-d872f2087c98
* Validates links which are to be passed on to the NTP by ensuring that they ↵mirandac@chromium.org2009-06-262-8/+14
| | | | | | | | | | | start with "http://" or "https://". BUG= http://crbug.com/15457 TEST= Change cached tip link in preferences file to be invalid. Note that this tip will not be included on the NTP. Review URL: http://codereview.chromium.org/149083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19415 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular notifications for theme changes.tc@google.com2009-06-263-4/+15
| | | | | | | | | | | | | This should have no impact on the current behavior. On linux, we'll want to get these notifications in a few places other than just the root browser windows so having it as a regular notification makes it easier for us to just listen for the event. Review URL: http://codereview.chromium.org/149032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19414 0039d316-1c4b-4281-b951-d872f2087c98
* Create a webkit thread for use within the browser process. This patch also ↵jorlow@chromium.org2009-06-2619-5/+539
| | | | | | | | | | | includes some (soon to be fleshed out in another CL) code to demonstrate how it'll be used in DOM Storage. BUG=None TEST=None Review URL: http://codereview.chromium.org/139003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19413 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 22:09:56 +0000