| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=46662
TBR=alokp
Review URL: http://codereview.chromium.org/2858007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
seem like it ever would have passed in the first place.
BUG=46663
TEST=none
Review URL: http://codereview.chromium.org/2802006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make loops use {} instead of a ';' to make it clear there is no body to the loop.
- Remove checks of unsigned values for <0
- coordinates should be CGFloat, not NSUInteger.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2865003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
Test=RenderWidgetHostTest.CoalescesWheelEvents (existing)
Review URL: http://codereview.chromium.org/2679003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looking at changes around the time the failure started (r49912), I see nothing related to this test.
BUG=46662
TEST=none
TBR=alokp
Review URL: http://codereview.chromium.org/2865004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Augment ProxyConfig to fetch its configuration from preferences that are initialized by settings and policy (rather than getting its config directly from settings). Add policies for everything that is needed to configure a ProxyConfig and wire the policies up to the corresponding preferences.
Also remove CookieMode policy, it's harder to get right than we naively thought.
BUG=43458
TEST=ChromeUrlRequestContextTest*:ConfigurationPolicyPrefStoreTest*
Review URL: http://codereview.chromium.org/2459001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The original CL: http://codereview.chromium.org/577020
Review URL: http://codereview.chromium.org/2449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calls to SQLiteFileSystem::deleteDatabaseFile() end up here. So far, this
functionality does not seem to have been used, but it is needed for deleting
empty local storage databases as per the bug below.
BUG=39067
TEST=None. Will be covered by test for the bug in question.
Review URL: http://codereview.chromium.org/2846004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for the most part by the extension api tests.
BUG=34994,43775,46217,22248
Review URL: http://codereview.chromium.org/2847008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=43441, 44548
Review URL: http://codereview.chromium.org/2833007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=phajdan.jr
BUG=46643
Review URL: http://codereview.chromium.org/2822012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29587,45562,46211
TBR=glider,estade,phajdan.jr
Review URL: http://codereview.chromium.org/2839004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=timurrrr
BUG=46639
Review URL: http://codereview.chromium.org/2852007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39222
TEST=See bug
Review URL: http://codereview.chromium.org/2822001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move non-View portions of code into LanguageConfigModel.
The patch just moves code around (i.e. no change in the logic)
To minimize the amount of diffs, functions are not moved.
We'll do more cleanup in the upcoming changes.
TEST=manually
BUG=chromium-os:4063
Review URL: http://codereview.chromium.org/2868001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a bug in our fts3 code that caused some tests to fail.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2838006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
loop so we can now enforce that there is only one pending Flush at a time.
Also removes the ability to have multiple flushes pending at the same time.
TEST=covered by ppapi unit test
BUG=none
Review URL: http://codereview.chromium.org/2862002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
path, as that'll fail in the sandbox and we don't care about the result then.
Review URL: http://codereview.chromium.org/2799009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2860001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When users downgrade, they may get a chrome binary that doesn't respect --product-version; don't allow chrome binaries launched with this flag to open new windows in existing chrome processes.
BUG=46547
TEST=manual
Review URL: http://codereview.chromium.org/2814007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
also include the port number.
This helps when debugging situations where the port has been changed.
Review URL: http://codereview.chromium.org/2808008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/2812004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual, trybots
Review URL: http://codereview.chromium.org/2835003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RunnableMethods easier.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2830006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45946
R=jar@chromium.org, jcivelli@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/2729022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus.
Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty.
BUG=32932
TEST=none
Review URL: http://codereview.chromium.org/2778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=42894
TEST=out/Debug/chrome --diagnostics
Review URL: http://codereview.chromium.org/2856004
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2827010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if_modified_since, etc to pass through the host network
stack. Filtering out these issues causes POST requests issued by buzz to fail.
Fixes bug http://b/issue?id=2321282
Bug=2321282
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/2846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2869003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42894
TEST=out/Debug/chrome --diagnostics
Review URL: http://codereview.chromium.org/2856004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bottom-aligned.
Technically this does not center the icon like the bug asks; it
bottom-aligns it. However, the image in the icon itself is
top-aligned (has whitespace on the bottom). This change makes the
chevron line up with the center of bookmark button text next to it so
it looks correct.
BUG=http://crbug.com/45740
Review URL: http://codereview.chromium.org/2870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading.
BUG=44129
TEST=none
Review URL: http://codereview.chromium.org/2559001
TBR=pathorn@chromium.org
Review URL: http://codereview.chromium.org/2813010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=create unofficial build or build with version string modifier equal to "dev".
start syncing.
Review URL: http://codereview.chromium.org/2847006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When a page was closed, a pending task on the TranslationHelper was accessing the WebView that would be NULL.
BUG=46584
TEST=None
Review URL: http://codereview.chromium.org/2852005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a new set of ui tests to load several tabs, and look at how long it takes for a subset to finish loading.
BUG=44129
TEST=none
Review URL: http://codereview.chromium.org/2559001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=46616
TEST=Greener Windows bots
Review URL: http://codereview.chromium.org/2816008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=46614
TEST=Greener Linux bots
Review URL: http://codereview.chromium.org/2818007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we don't add observers twice.
BUG=46596
TEST=on a debug / unofficial build, re-login to sync (e.g. using --invalidate-sync-login). browser shouldn't crash.
Review URL: http://codereview.chromium.org/2799007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The cleanup removes ny row with a string field larger than a reasonable size. The string fields examined here are precisely the ones that were subject to corruption by the original bug.
BUG=38364
TEST=Manually created autofill profile entries with sizes greater and less than the limit. Restarted browser and forced the migration code to trigger. Verified that all the statements execute successfully, and that the too-large profiles were deleted.
Review URL: http://codereview.chromium.org/2805006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bubble object which implements WidgetWin).
TEST=none
BUG=9601
Review URL: http://codereview.chromium.org/2338001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: That was a TODO for Matt).
BUG=None
TEST=open the Certificate Manager window, select a tab, close it, open again, it
should opens in the tab you viewed last.
Review URL: http://codereview.chromium.org/2730016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No explanation was given for what exactly was wrong when it was disabled, and it passes on the try bots.
BUG=None
TEST=SlowTermination should run and pass on Windows and Linux
Review URL: http://codereview.chromium.org/2825004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=46601
TBR=mpcomplete
Review URL: http://codereview.chromium.org/2868003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
In particular fullscreen_controller.mm:402:29: error: 'NSAnimation' may not respond to 'endFraction'
Review URL: http://codereview.chromium.org/2836002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Relax the check to ensure that we just do substring match for "google.com" when testing inline autocomplete in the omnibox.
Review URL: http://codereview.chromium.org/2814002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2860002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SubjectAltName IDNs
Remove extraneous '\n' from ProcessGeneralNames.
BUG=43966
TEST=manual
Review URL: http://codereview.chromium.org/2733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib updates:
Toolbar.xib: Removed page menu and moved everything over to accomodate.
Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate.
BUG=45756
TEST=migration from having the pref hidden. It should become visible.
Review URL: http://codereview.chromium.org/2828005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49830 0039d316-1c4b-4281-b951-d872f2087c98
|