summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Unit test -[AutocompleteTextField mouseDown:].shess@chromium.org2009-10-011-1/+96
| | | | | | | | | | | | Breaking this off of the change to single-click because this is definitely a keeper, that one might be contencious. http://crbug.com/22980 TEST=Unit test only. Review URL: http://codereview.chromium.org/242103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27774 0039d316-1c4b-4281-b951-d872f2087c98
* The "Copy URL" link is always greyed out in the Chrome menu on popups ↵ericu@google.com2009-10-016-39/+24
| | | | | | | | | | | | | | [crbug.com/13488]. This turns out to be because it was never implemented. Tested manually on Windows; I'll test on Linux before submitting. BUG=13488 TEST=Tested manually on Windows and added a unit test for the new Clipboard function. Review URL: http://codereview.chromium.org/210042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't crash when selecting closed window from Dock menu.shess@chromium.org2009-10-011-0/+25
| | | | | | | | | | | | | | | The Dock menu contains an automagic section where you can select amongst open windows. This is wired up to send to the window as a target, but if JavaScript closes the window in the meanwhile, it messages a freed object. This short-circuits the specific selector if the window is no longer valid. http://crbug.com/14003 TEST=Bug contains instructions and an example html file to help. Review URL: http://codereview.chromium.org/259001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27769 0039d316-1c4b-4281-b951-d872f2087c98
* Revert tree bustage.aa@chromium.org2009-10-014-124/+4
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27764 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check return value of GetInteger.mattm@chromium.org2009-10-011-2/+1
| | | | | | | | | | CID=6192 BUG=none TEST=none Review URL: http://codereview.chromium.org/257013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27763 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at badge implementation. Right now it just uses staticaa@chromium.org2009-10-014-4/+124
| | | | | | | | | | | | | data. A subsequent change will hook it up to the extension APIs. See http://dl.getdropbox.com/u/124107/badges.png for a picture of what this looks like. BUG=23268 Review URL: http://codereview.chromium.org/259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27761 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize lock_, semaphore_, and test_socket_ in the constructor.jhawkins@chromium.org2009-10-011-2/+5
| | | | | | | | | CID=2297 BUG=none TEST=none Review URL: http://codereview.chromium.org/255007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27760 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27756.jorlow@chromium.org2009-10-0114-232/+39
| | | | | | Review URL: http://codereview.chromium.org/249058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix the AcceleratorPressed override to match the declaration in ↵jhawkins@chromium.org2009-10-012-6/+9
| | | | | | | | | | | WidgetWin. CID=4190 BUG=none TEST=none Review URL: http://codereview.chromium.org/255031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27758 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. The WebKit side can be ↵jorlow@chromium.org2009-10-0114-39/+232
| | | | | | | | | | | found here: https://bugs.webkit.org/show_bug.cgi?id=29655 TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Review URL: http://codereview.chromium.org/223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several issues around fullscreen Mac plugins:amanda@chromium.org2009-10-018-0/+180
| | | | | | | | | | * Keystrokes are now properly sent to plugins in fullscreen mode * When a plugin creates a fullscreen window, we hide the menu bar and restore it when the window is closed BUG=19534,21020 TEST=Open a page with plugins that can go full screen (example: flash video players). Enter full screen mode and verify that esc, arrow keys, spacebar, etc. work as expected. Verify that the menu bar is hidden when the plugin goes fullscreen and is restored when it exits fullscreen mode. Review URL: http://codereview.chromium.org/257008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27755 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a circular dependency for chrome Linux symbols. Make it possible to ↵thestig@chromium.org2009-10-011-28/+30
| | | | | | | | | | force Linux symbol dumping. BUG=none TEST=none Review URL: http://codereview.chromium.org/243056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27752 0039d316-1c4b-4281-b951-d872f2087c98
* Add framework of MemoryPurger, a class to dump memory from everywhere ↵pkasting@chromium.org2009-10-017-5/+146
| | | | | | | | | | | | possible. Currently does nothing. This also adds a "Purge memory" button to the task manager when run with --purge-memory-button, which can be used to test the functionality. BUG=23400 TEST=Run with --purge-memory-button, open the task manager and see a new button. Click it to toggle it to "Reset purge", and click again to toggle back. Review URL: http://codereview.chromium.org/259003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27751 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't hard code status bubble border.erg@google.com2009-10-011-8/+5
| | | | | | Review URL: http://codereview.chromium.org/255040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27744 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.browserAction.setName and .setIcon.mpcomplete@chromium.org2009-10-0115-11/+207
| | | | | | | | | BUG=23379 TEST=Load the print_browser_action extension from the samples test dir and click it. The icon and name should update. Review URL: http://codereview.chromium.org/242081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27741 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the PowerObserver API by removing unneeded args and providing ↵pkasting@chromium.org2009-10-014-29/+18
| | | | | | | | | | | | default implementations. This also makes all the subclasses use the same code to add/remove observers. BUG=none TEST=none Review URL: http://codereview.chromium.org/244054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27740 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 220.2 to 221.0jon@chromium.org2009-10-011-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27739 0039d316-1c4b-4281-b951-d872f2087c98
* Download shelf menus in title case.thomasvl@chromium.org2009-10-011-40/+118
| | | | | | | | | | | Make the show_in_folder menu and link "Show in Finder" on the Mac as requested by Cole. BUG=22647 BUG=23548 TEST=Download shelf menus (for inprogress download and completed download) should be in title case. Mac should say "Finder" instead of "Folder" Review URL: http://codereview.chromium.org/246065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27735 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't call MemoryDetails::Release() from AboutMemoryHandler's constructor.shess@chromium.org2009-10-011-6/+5
| | | | | | Review URL: http://codereview.chromium.org/252008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27731 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a comment.pkasting@chromium.org2009-10-011-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/244053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the indenting in chrome_switches.cc to be consistent.pkasting@chromium.org2009-10-011-51/+52
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/249053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27727 0039d316-1c4b-4281-b951-d872f2087c98
* Make the no bookmarks text a small control so it doesn't stick out, this ↵thomasvl@chromium.org2009-10-011-8/+8
| | | | | | | | | | makes it more inline with windows and with the buttons when they do have bookmarks. TEST=Show bookmark bar with no bookmarks, font should be closer to the font bookmark buttons use. BUG=none Review URL: http://codereview.chromium.org/242094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27721 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in determining if we can paste from the clipboard. Need tosky@chromium.org2009-10-012-1/+40
| | | | | | | | | | | use IsFormatAvailableByString rather than IsFormatAvailable. BUG=21106 TEST=see bug, also covered by unit test now. Review URL: http://codereview.chromium.org/256016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27720 0039d316-1c4b-4281-b951-d872f2087c98
* Privacy Blacklist Unblockidanan@google.com2009-10-015-24/+115
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ------- Mostly implemented the unblocking for visual resources for the Privacy Blacklist. Merging now before I leave. Eveything here only has effect if the --privacy-blacklist flag specifies a Privacy Blacklist. Detailed Changes ---------------- [chrome/browser/resources/privacy_blacklist.html] - Replaced the about:blank place-holder with variable to set the unblock link. - Open the Privacy Blacklist provider page in a new tab. This works around an issue where such request for a full-page (rather than a sub-resource) gets blocked indefinitely. [chrome/browser/render_host/resource_dispatcher_host.h] - Added a BlockedResponse member which is now a class rather than a namespace, see below for more information. [chrome/browser/render_host/resource_dispatcher_host.cc] - Generate headers for the blocked response to redirect to the chrome-blocked URL which prevents an enclosing page from reading the URL of the unblock link. This was suggested by Darin to avoid scripted bypassing of blocked contents. - Recover the original URL for blocked content, in order to fetch it during unblocking. - Do not create CrossSiteResourceHandler when an unblocked link is requested. Otherwise the request never resumes as the blocked page never gets closed since it is not a real page. [chrome/browser/privacy_blacklist/blocked_response.cc] - Defined chrome-block and chrome-unblock URL schemes. The block scheme is used to return the blocked response. The unblock scheme is used request a blocked resource's URL without being intercepted by the Privacy Blacklist. - Defined a hash function for a blocked resource as its address in memory. Function to reverse the hash is therefore trivial. - Added a function to return headers for a blocked response. - Added a function to generate a block URL from a requested one. - Added a function to get an unblock URL from a requested one. - Added a function to return the original URL for a blocked one. [chrome/browser/privacy_blacklist/blocked_response.h] - Made the BlockedResponse namespace into a class. - Created a member set to keep all the blocked resources URL. BUG=16932 TEST=none TBR=darin Review URL: http://codereview.chromium.org/252001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27719 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling WorkerTest.MessagePorts as the upstream regression was fixed:hamaji@chromium.org2009-10-011-1/+1
| | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=29798 BUG=23320 TEST=none Review URL: http://codereview.chromium.org/249055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27715 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 220.1 to 220.2laforge@chromium.org2009-10-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27714 0039d316-1c4b-4281-b951-d872f2087c98
* Add EscapeURL to the ASCII escape methods.EscapeURL escapes all forbidden ↵brg@chromium.com2009-10-011-1/+1
| | | | | | | | | | ascii characters in an URL and repalces spaces with '+'. Test=Escape.EscapeUrl BUG=23029 Review URL: http://codereview.chromium.org/244056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27713 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.hmal@chromium.org2009-10-013-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/246060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.hdarin@chromium.org2009-10-013-16/+11
| | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: *Correctly* fill file extension as drag source.viettrungluu@chromium.org2009-10-011-12/+15
| | | | | | | | | | | (We have to strip the '.' from the file extension.) BUG=23431 TEST=Make sure images can still be dragged to, e.g., the desktop; make sure images can be dragged to Acorn <http://www.flyingmeat.com/acorn/>. Review URL: http://codereview.chromium.org/255035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27704 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedits to packaging to provide better context.kathyw@google.com2009-10-012-12/+22
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/255033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27701 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve app mode .desktop file creation.estade@chromium.org2009-10-013-24/+41
| | | | | | | | | | | 1) pass --user-data-dir when appropriate 2) don't overwrite old .desktop files that share the same name. BUG=23353 Review URL: http://codereview.chromium.org/255016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27700 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Allow window/app. to be closed when tab modal sheets are showing.viettrungluu@chromium.org2009-10-013-49/+0
| | | | | | | | | | | | | | | | | | This patch consists only of code deletions. Despite the comments in the deleted code, it's all okay since sheets are closed: |TabContents::~TabContents()| calls |ConstrainedWindowMac::CloseConstrainedWindow()|, which calls |ConstrainedWindowMacDelegate::DeleteDelegate()|, which should close the sheet if it's still open. This code path has been in use for quite some time, since we've allowed (or failed to disallow!) tabs containing sheets to be closed via the close tab button. BUG=19427 TEST=Open some tabs (possibly in multiple windows) with some tab modal sheet (e.g., by navigating to <http://www.pagetutor.com/keeper/mystash/secretstuff.html>); close a window containing such a tab, with a tab modal sheet visible or not; quit application while a tab modal sheet is active (not nec. visible). Review URL: http://codereview.chromium.org/242059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27699 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables showing crashed info bar on chrome os.sky@chromium.org2009-10-013-7/+1
| | | | | | | | | BUG=23502 TEST=none Review URL: http://codereview.chromium.org/249050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27698 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make sure download shelf items and download items don't share names.rsesek@chromium.org2009-10-011-2/+2
| | | | | | | | | | Mac side of http://codereview.chromium.org/242082 BUG=23046 Review URL: http://codereview.chromium.org/246054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27697 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure download shelf items and download items don't share names.mhm@chromium.org2009-10-013-3/+7
| | | | | | | | | BUG=23046 TEST=Compiled and ran on Windows Review URL: http://codereview.chromium.org/242082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27696 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback Scavenge implemetation and rely on existing functionality to freejar@chromium.org2009-10-012-3/+3
| | | | | | | | | | | | | | This is a landing of a patch provided by antonm. See: http://codereview.chromium.org/235022 Also included change to browser_about_handler.cc to fix build, and I set TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this was an inadvertent rollback element). r=antonm Review URL: http://codereview.chromium.org/257009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
* Add "copy" to context menu on bookmark button.jrg@chromium.org2009-09-303-38/+550
| | | | | | | | | | BUG=http://crbug.com/16941 TEST=Right-click on bookmark button; pick copy. Go to any other app and paste. Make sure you got URL. Review URL: http://codereview.chromium.org/249048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27690 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix memory leak from r27666.estade@chromium.org2009-09-304-3/+8
| | | | | | | | | | | Make MenuGtk take ownership of submenus. BUG=none TEST=valgrind doesn't complain Review URL: http://codereview.chromium.org/251053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27689 0039d316-1c4b-4281-b951-d872f2087c98
* Set the initial enabledness state of any browser actions whenaa@chromium.org2009-09-301-0/+12
| | | | | | | | | | | | | the window first comes up. BUG=23380 TEST=Install an extension that has a browser action. Open a new window. Browser action menu item should be disabled in wrench menu. Review URL: http://codereview.chromium.org/242083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27686 0039d316-1c4b-4281-b951-d872f2087c98
* Turn extension script injection histograms into uma histograms.asargent@chromium.org2009-09-301-8/+11
| | | | | | | | | | | | | | | -Switch to UMA_HISTOGRAM_* macros. -Rename to reflect that extensions are subsuming content scripts, and better fit the common style of histogram names. -Count css and scripts separately, and fix script count to account for multiple scripts per extension. BUG=none TEST=none Review URL: http://codereview.chromium.org/244038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27685 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize dialog_ in the constructor.jhawkins@chromium.org2009-09-301-1/+3
| | | | | | | | | CID=5060 BUG=none TEST=none Review URL: http://codereview.chromium.org/243039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27683 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check for >= 0 because it is always true. Type is ↵jhawkins@chromium.org2009-09-301-1/+1
| | | | | | | | | | | unsigned int. CID=573 BUG=none TEST=none Review URL: http://codereview.chromium.org/256019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27682 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak constants used by sync setup wizard unittest. Reviewed by nick.tim@chromium.org2009-09-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27677 0039d316-1c4b-4281-b951-d872f2087c98
* Look for sync_password under %USERPROFILE% in addition to alongside the script,tim@chromium.org2009-09-301-398/+404
| | | | | | | | | | | under src/. TEST=TwoClientLiveBookmarksSyncTest BUG=23478 Review URL: http://codereview.chromium.org/242085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27667 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement popup favicon menu.estade@chromium.org2009-09-306-69/+154
| | | | | | | | BUG=18181 Review URL: http://codereview.chromium.org/244029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27666 0039d316-1c4b-4281-b951-d872f2087c98
* Stops the throbber from spinning if the user cancels a beforeunload dialog,creis@google.com2009-09-303-0/+37
| | | | | | | | | | | if the dialog is triggered by a reload or location bar entry. BUG=22004 TEST=BrowserTest.ReloadThenCancelBeforeUnload Review URL: http://codereview.chromium.org/256015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27663 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: tips_cache_->GetSize() returns an unsigned int so the comparison ↵jhawkins@chromium.org2009-09-301-1/+3
| | | | | | | | | | | >= 0 is always true. Change the check to != 0 to actually have an effect. CID=6044 BUG=none TEST=none Review URL: http://codereview.chromium.org/255030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27662 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rewrite and renable a badly-written unittest.rohitrao@chromium.org2009-09-301-59/+37
| | | | | | | | BUG=None TEST=Test should pass. Review URL: http://codereview.chromium.org/255029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27661 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IdleTimer, which no one uses.pkasting@chromium.org2009-09-301-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/244049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27658 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 23:13:44 +0000