| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will slowly auto-opt-in people as their machines are wiped and/or preferences are reset.
BUG=none
TEST=install fresh copy of Chrome OS, Talk labs should be enabled by default
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later.
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3563004
Review URL: http://codereview.chromium.org/3621003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Frame should handle.
TEST=This adds a new policy list for Chrome Frame, "ChromeFrameContentTypes", which can be used to specify a list of content types that should always be rendered in Chrome Frame.
BUG=56543
Review URL: http://codereview.chromium.org/3611002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also need to be passed to the zygote process since logging is initialized before forking renderers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3597006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
Fixed logging error in Linux version of Launch On Startup support. Specifically, this corrects the handling of the result returned by WriteFile when generating the autostart .desktop file.
Review URL: http://codereview.chromium.org/3565004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move size based disposition override for ChromeOS from tab_container to browser.
* TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels.
* Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls.
* Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'.
* Added size limiting code to PanelBrowserView.
* Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166
TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps
More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I
!!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e
Review URL: http://codereview.chromium.org/3449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
line flag '--no-pings'.
BUG=21589
TEST=none
R=darin
Review URL: http://codereview.chromium.org/3555007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=173
TEST=none
Review URL: http://codereview.chromium.org/3516010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes the original code plus changes to 2 new files to fix a test that
was failing:
chrome/browser/resources/webstore_app/manifest.json
chrome/test/data/extensions/api_test/extension_gallery_install/test.html
Original review url was:
http://codereview.chromium.org/3537010
BUG=56399
TEST=You should be able to write an extension using the management API.
TBR=aa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
services are needed. If not, it shuts down. Also the ShutdownIfNeeded method checks to see if clients are connected before shutting down. And we only try to recreate the channel if we were previously connected to a client.
BUG=None.
TEST=Run the service process without any enabled services. It should die within a minute.
Review URL: http://codereview.chromium.org/3562004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When replacing a placeholder in a localized string, make sure the correct number of placeholders were found (i.e. the same number of strings that the calling code passed).
BUG=none
TEST=running/testing the browser in debug doesn't cause errors
Review URL: http://codereview.chromium.org/3396025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test was failing on the bots because the extensions get different ids
on different bots, since the paths are different. I've changed the test to
load the extensions first and then query their id, instead of relying on
the id they get on my computer.
BUG=36275
TEST=AllUrlsApiTest (2 new ones)
Review URL: http://codereview.chromium.org/3610006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Weird scenarios can lead to windows retaining a handle to a downloaded file
such that it cannot be removed. This leads to failures every once a while.
Mark all such files and delete them only after the browser has shut down.
Incorporated this in all the downloads tests.
BUG=
TEST=downloads.py
Review URL: http://codereview.chromium.org/3530008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=greener tree
Review URL: http://codereview.chromium.org/3612003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57884
TEST=no
Review URL: http://codereview.chromium.org/3555013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50760
TEST=interactive_ui_tests --gtest_filter=KeyboardAccessTest.ReserveKeyboardAccelerator
Review URL: http://codereview.chromium.org/3527007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works with the following caveat: the view does not update as the model does. The view does update the model (when pressing remove), but not vice versa (the view is only updated once, when it is first opened). This is actually also true of the native dialog version. To fix this I will need to add an observer interface to the Geolocation settings map similar to the one in HostContentSettingsMap.
I didn't use the GeolocationExceptionsTableModel because it doesn't seem helpful in this case, although I did copy some code from it. If we move to dom ui completely on all platforms, we can delete that file completely and the relevant parts will have migrated into ContentSettingsHandler. The GeolocationExceptionsTableModel allows for sorting, but I don't know if we care to keep that functionality as the mocks don't cover it, and if so it should probably be pageside.
content_settings_handler is getting more unwieldy and will continue to do so, which motivated me to refactor a little and in particular to add better (or rather, any) comments to the header. I may eventually want to factor out even more functionality as new, special content types get added (plugins, notifications, geolocation, etc? are all non-standard).
BUG=57457
TEST=manual
Review URL: http://codereview.chromium.org/3520012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=interactive_ui_tests --gtest_filter=AutofillTest.*
Review URL: http://codereview.chromium.org/3492009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for the case where the overlay is small.
BUG=53609
TEST=none
Review URL: http://codereview.chromium.org/3556011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CL began its life under rdsmith (http://codereview.chromium.org/3548001/show).
BUG=55728
TEST=Run chrome with invalid proxy server and examine navigation error message.
Review URL: http://codereview.chromium.org/3521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=57875
TEST=
Review URL: http://codereview.chromium.org/3552007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3560008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51345
Review URL: http://codereview.chromium.org/3617003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49381
Review URL: http://codereview.chromium.org/3617004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5860
TEST=Remove user from home screen. Ensure that directory in /home/.shadow
is also removed. Can also check if non-synced data no longer appears when
same user is recreated. Downloads are an example of this.
Review URL: http://codereview.chromium.org/3290023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=PhishingClassifierTest
Review URL: http://codereview.chromium.org/3572008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none.
TEST=All build bots should still be happy.
Review URL: http://codereview.chromium.org/3619001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57608
TEST=Existing background mode tests suffice
Review URL: http://codereview.chromium.org/3541009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55148
TEST=Minimize apps section. Install an app. Apps section should no longer be minimized.
Review URL: http://codereview.chromium.org/3555010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Linux, the sort ordering in the task manager is incorrect, as in when you
click on a column header to sort the values the first time, it shows a triangle
with the pointy head downwards, i.e. it should show the values from larger to
smaller. But currently, the values are shown smaller to larger. So this small
patch is a fix for that. This is also consistent with the behaviour on Windows.
Also, this makes more sense. When a user is sorting, for example, the memory or
the cpu column, it is more likely he is interested on the pages that are taking
the most memory/cpu, so they should be at the top for the first sort.
BUG=none
TEST=after opening multiple tabs, bring up the task manager, then click on the
memory column header. It should show the page using the most memory on top.
patch by Sadrul Chowdhury <sadrul [at] chromium [dot] org>
original review: http://codereview.chromium.org/3590009
Review URL: http://codereview.chromium.org/3615006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Many of the tests are failing, but these are taking 40 seconds to
fail.
BUG=existing bugs that these tests are failing
Review URL: http://codereview.chromium.org/3533009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56589
TEST=go to a non-existent page in a packaged app. standard built-in 404 should show rather than the new pretty page.
Review URL: http://codereview.chromium.org/3524003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also return one value per reference.
BUG=None
TEST=None
TBR=finnur
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=57832
Review URL: http://codereview.chromium.org/3534009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test times out regularly in the vista build bots and infrequently in others.
I'm add some logs earlier and making progress, so adding more logs to narrow down the issue.
BUG=51337
TEST=waterfall doesn't go read due to this test.
TBR=bulach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=phajdan.jr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
There is some other Windows-specific (?) flake, http://crbug.com/47228
TBR=bauerb
BUG=56401
TEST=none
Review URL: http://codereview.chromium.org/3574007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Requested by jeffrecy.
BUG=None
TEST=Go to about:labs, read text. Should've made you roll your eyes.
Review URL: http://codereview.chromium.org/3521009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3606007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3534008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, explicitly test NavigateToURL's return value instead of treating it like a boolean.
BUG=56670
TEST=ui_tests --gtest_filter="*LoginPromptTest*"
Review URL: http://codereview.chromium.org/3618001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think I'm getting close to figuring out why the test fails only on the bots.
TBR=aa
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3578009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=aa
Review URL: http://codereview.chromium.org/3533012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were already LGed here...
http://codereview.chromium.org/3440027
... but once checked in they failed on the build bots (despite working locally).
I have added some temporary tracing to try to track down the cause. Will remove, after a run on the bots.
TBR=aa
BUG=36275
TEST=AllUrlsApiTest (two new)
Review URL: http://codereview.chromium.org/3598007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Menu position offset was implemented for menu button and language menu.
So 2 magic number were used to position the menu. This CL removes offset
handling from the language menu class, since this is not common for
menu.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3610005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages.
The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time.
This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc.
BUG=36275
TEST=Working on it right now.
Review URL: http://codereview.chromium.org/3585009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The test which times out can be seen at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SpeechInputBrowserTest.TestBasicRecognition&testType=browser_tests
BUG=none
TEST=none, since we are just adding more logging.
TBR=bulach
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
account on Chrome OS.
We should probably disable/hide "Set up sync..." button in Personal Stuff,
but for now, let's fix the crash bug first.
TEST=On Chrome OS netbook, login as guest, go to chrome:options, and confirmed that chrome didn't crash.
BUG=chromium-os:7313
Review URL: http://codereview.chromium.org/3621001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61351 0039d316-1c4b-4281-b951-d872f2087c98
|