summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-21129-431/+421
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+17
| | | | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72095 Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72105 0039d316-1c4b-4281-b951-d872f2087c98
* Add Throbber control for DOMUI. Use it everywhere in options and in Sync ↵sergeyu@chromium.org2011-01-2112-90/+37
| | | | | | | | | | | setup UI. BUG=69755 TEST=Throbber works properly when settings page is scaled. Review URL: http://codereview.chromium.org/6378006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72095 - Attribute orphaned or anonymous network usage to the Browser ↵thakis@chromium.org2011-01-211-16/+13
| | | | | | | | | | | | | | | resources. BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6341006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72096 0039d316-1c4b-4281-b951-d872f2087c98
* Attribute orphaned or anonymous network usage to the Browser resources.thakis@chromium.org2011-01-211-13/+16
| | | | | | | | | | BUG=47955,69883 TEST=When a tab is closed with a download in-progress and Task Manager displayed, the network activity is reflected in the Browser resource's Network total. Review URL: http://codereview.chromium.org/6383002 Patch from James Weatherall <wez@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72095 0039d316-1c4b-4281-b951-d872f2087c98
* DCHECK(result) keeps firing in ↵dhollowa@chromium.org2011-01-211-0/+8
| | | | | | | | | | | | | AutocompleteHistoryManager::OnWebDataServiceRequestDone() A NULL |result| should DCHECK, but not crash. This is a short term solution to the top-crasher, will still DCHECK for devs while a longer term fix is determined. BUG=68783, 69833 TEST=none Review URL: http://codereview.chromium.org/6275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72094 0039d316-1c4b-4281-b951-d872f2087c98
* Added one testcase: testFindInCanDismissInstantnirnimesh@chromium.org2011-01-211-0/+10
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6352003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72093 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Cancel pending queries to the PasswordStore on destruction to avoidjhawkins@chromium.org2011-01-212-12/+24
| | | | | | | | | | | being notified after the object has been destroyed. BUG=69441 TEST=none Review URL: http://codereview.chromium.org/6299014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72092 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Show Mac address book checkbox.csilv@chromium.org2011-01-211-1/+1
| | | | | | | | BUG=64800 TEST=Verify that the checkbox for the Mac address book appears in autofill options. Review URL: http://codereview.chromium.org/6278012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72089 0039d316-1c4b-4281-b951-d872f2087c98
* Fix instant test on Mac: use cgi.parse_qs() instead of urlparse.urlparse()nirnimesh@chromium.org2011-01-211-2/+2
| | | | | | Review URL: http://codereview.chromium.org/6264007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72088 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency on non-existent librarythakis@chromium.org2011-01-211-2/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72087 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: enable languages & spell checker settings for all platforms.csilv@chromium.org2011-01-2115-220/+458
| | | | | | | | BUG=56415,43716 TEST=Verify language & settings panel functionality on dom-ui settings window. Review URL: http://codereview.chromium.org/6296017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72085 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in PluginService if the keys are null. It's still unclear why ↵jam@chromium.org2011-01-211-2/+4
| | | | | | | | | this is happening now as opposed to before. This change just fixes the crash in the meantime. BUG=70317 Review URL: http://codereview.chromium.org/6313007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72083 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_utils::GetNameForURL return a string16.evan@chromium.org2011-01-214-8/+8
| | | | | | | | | | | It is returning Unicode so it should be a string16. The callers want a string16 anyway. TEST=compiles Review URL: http://codereview.chromium.org/6306006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72073 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Gracefully a handle a NULL profile in the Autofill editor handler. Thisjhawkins@chromium.org2011-01-211-2/+16
| | | | | | | | | | | | can happen if we try to edit a profile that is in the process of being removed, but for which we haven't been notified that it's removed yet. BUG=69327 TEST=none Review URL: http://codereview.chromium.org/6323012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72071 0039d316-1c4b-4281-b951-d872f2087c98
* Force patches that touch sync code to use the sync trybotsrsimha@chromium.org2011-01-211-0/+13
| | | | | | | | | | | | | | | | | | | | | As of today, we have dedicated chromium trybots that can run the sync integration tests, but it requires developers to explicitly send try jobs to these bots via the --bot switch. Now that the sync trybots are stable, it is time to make this process automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that adds the sync trybots in addition to win, mac and linux to the list of preferred trybots. This patch adds such a PRESUBMIT.py file, that includes win_sync, mac_sync and linux_sync to the list of preferred trybots. BUG=70311 TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try" Review URL: http://codereview.chromium.org/6275010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS files to autofill, notifications and speech subdirs.tfarina@chromium.org2011-01-213-0/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6380006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72062 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Hide the Downloads section for ChromeOS.tfarina@chromium.org2011-01-211-2/+2
| | | | | | | | | BUG=70149 TEST=None Review URL: http://codereview.chromium.org/6349007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72061 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS files for accessibility directories.dmazzoni@chromium.org2011-01-211-0/+3
| | | | | | Review URL: http://codereview.chromium.org/6272013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72058 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Use a styled button instead of an image for the password list show/hidejhawkins@chromium.org2011-01-218-83/+83
| | | | | | | | | | | button. BUG=69145 TEST=none Review URL: http://codereview.chromium.org/6241010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72057 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Delay loading the password lists until the password manager is shown.jhawkins@chromium.org2011-01-211-0/+6
| | | | | | | | | BUG=67716 TEST=none Review URL: http://codereview.chromium.org/6269014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72056 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor and improve gpu_info_collector: collect information on linux;zmo@google.com2011-01-2119-303/+604
| | | | | | | | | | | | | collect extra information (driver_vendor, gl_renderer, etc.) on Mac/linux. Note that this CL takes some code from rlp's long outstandingCL (with her permission). BUG=49579 TEST=unittest Review URL: http://codereview.chromium.org/6346007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72055 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Merge common code in RenderView::OnPrintPages and ↵thestig@chromium.org2011-01-212-18/+17
| | | | | | | | | | RenderView::OnPrintPreview. BUG=none TEST=none Review URL: http://codereview.chromium.org/6296018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72054 0039d316-1c4b-4281-b951-d872f2087c98
* Slightly better docs for the convert_dict tool.estade@chromium.org2011-01-211-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6339007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72051 0039d316-1c4b-4281-b951-d872f2087c98
* Adding instant tests for popup handling and search query length 100 ↵nirnimesh@chromium.org2011-01-201-0/+36
| | | | | | | | characters limit. Review URL: http://codereview.chromium.org/6340008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72045 0039d316-1c4b-4281-b951-d872f2087c98
* Move the TestSink for doing IPC tests from chrome/common into IPC and create ↵brettw@google.com2011-01-207-156/+5
| | | | | | | | | | | | a new IPC test_support project that references it. This is necessary because I want to make a test that uses the sink outside of chrome. TEST=this is a test BUG=none Review URL: http://codereview.chromium.org/6290008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72044 0039d316-1c4b-4281-b951-d872f2087c98
* Update another include pathben@chromium.org2011-01-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by updating header includes.ben@chromium.org2011-01-201-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72041 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-20292-317/+335
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Code to send diagnostic messages about cloud print proxy. Currently ↵sanjeevr@chromium.org2011-01-2018-58/+253
| | | | | | | | | | | diagnostic messages are sent if the print system fails to initialize (this can happen on Windows if the XPS Framework is not installed on XP) as well when printer registration fails because we could not get the capabilities for the printer. BUG=None TEST=None Review URL: http://codereview.chromium.org/6245005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72037 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Merge single-function file about_ipc_dialog.{h,mm} and ↵rsesek@chromium.org2011-01-206-64/+40
| | | | | | | | | | | | about_ipc_bridge.{h,mm}. BUG=none TEST=everything works as before (note, about:ipc only works in Debug builds) R=jrg Review URL: http://codereview.chromium.org/6265015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72035 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui settings: Don't allow click sub-page closing when an overlay is visible.csilv@chromium.org2011-01-201-0/+4
| | | | | | | | BUG=none TEST=Verify clicks don't close sub-pages when an overlay is visible. Review URL: http://codereview.chromium.org/6375006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72028 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup about:flags for remoting and enable for all platforms.ajwong@chromium.org2011-01-202-16/+4
| | | | | | | | | BUG=none TEST=compiled and viewed under linux. Review URL: http://codereview.chromium.org/6222004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72027 0039d316-1c4b-4281-b951-d872f2087c98
* fix cookie info table width for certain localesestade@chromium.org2011-01-201-1/+2
| | | | | | | | | | | Long cookie contents will now wrap earlier than they need to. CSS really doesn't want to do what we want (wrap the text at the inherited width, or anything except a hardcoded width). So I set the width to be narrower (300 instead of 520) and also set the table's layout to fixed, so that even if 300 is too wide the whole table won't overflow. BUG=69447 TEST=LANGUAGE=fr_FR ./out/Release/chrome Review URL: http://codereview.chromium.org/6327013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72026 0039d316-1c4b-4281-b951-d872f2087c98
* Gpu process restart fix.amarinichev@google.com2011-01-203-1/+13
| | | | | | | | | | | If the gpu process dies, CommandBufferProxy might be the first one to find out about it. When the context is being created, GpuChannelHost still thinks there is no error. It will send CreateViewCommandBuffer message to establish a communication channel, which will fail, and GPU process will not restart. To prevent that, we set GpuChannelHost state to lost as soon as CommandBufferProxy finds out about it. BUG=58785 TEST=open a composited tab, in another tab go to about:gpucrash Review URL: http://codereview.chromium.org/6384003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72023 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto test translate.TranslateTest.testSeveralLanguagessunandt@chromium.org2011-01-201-0/+2
| | | | | | | | | BUG=70280 TEST=none Review URL: http://codereview.chromium.org/6338012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72021 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a warning in themes.pynirnimesh@chromium.org2011-01-201-2/+2
| | | | | | | | | | Fix for: themes.py:106: SyntaxWarning: assertion is always true, perhaps remove parentheses? Review URL: http://codereview.chromium.org/6309009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72016 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Notify window manager earlier about signout.derat@chromium.org2011-01-204-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | We were previously doing this pretty late in Chrome's shutdown process, which resulted in the closing of individual browser windows often being visible onscreen. This change makes us send the message before closing any windows (at least in the no-beforeunload-handlers-or-downloads case) and flushes the Xlib request queue to make sure that the message won't sit around until the next time that we process events. Note that there are still cases where beforeunload handlers aren't registered but we still won't close the window without warning and hence still show the flip through the windows. See RenderViewHost::sudden_termination_allowed_. BUG=chromium-os:9915 TEST=opened a bunch of windows and checked that we fade to black and hide the cursor immediately on ctrl-shift-q and wrench->sign out. also tested that we don't fade out until the dialog is closed with an affirmative response when http://goo.gl/gzMdN is open Review URL: http://codereview.chromium.org/6353001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72014 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing pyauto plugins testsunandt@chromium.org2011-01-201-5/+7
| | | | | | | | | | | | | Fixing test testBlockPluginException Sometimes we fail to retrieve the shockwave flash process id. BUG=none TEST=none Review URL: http://codereview.chromium.org/6260015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72011 0039d316-1c4b-4281-b951-d872f2087c98
* Printing: Rename some variables in the two different PrintPages() to be more ↵thestig@chromium.org2011-01-202-10/+13
| | | | | | | | | | consistent. BUG=none TEST=none Review URL: http://codereview.chromium.org/6352001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72010 0039d316-1c4b-4281-b951-d872f2087c98
* Don't register cookie access on empty cookie list.jochen@chromium.org2011-01-202-1/+20
| | | | | | | | | BUG=none TEST=TabSpecificContentSettingsTest.EmptyCookieList Review URL: http://codereview.chromium.org/6352005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72009 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of upload, form saving, and UMA logging.dhollowa@chromium.org2011-01-205-68/+67
| | | | | | | | | BUG=none TEST=PersonalDataManagerTest.*, AutoFillManagerTest.* Review URL: http://codereview.chromium.org/6286003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72004 0039d316-1c4b-4281-b951-d872f2087c98
* Accept keyword by pressing space.suzhe@google.com2011-01-208-192/+220
| | | | | | | | | | | | | This CL disables implicit keyword accepting completely. The user can only accept a keyword by pressing Tab or space explicitly while the keyword hint UI is visible. BUG=60972 TEST=interactive_ui_tests --gtest_filter=AutocompleteEditViewTest.AcceptKeywordBySpace Review URL: http://codereview.chromium.org/6252003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72003 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Allow grabbing/ungrabbing touch devices for XInput2.sadrul@chromium.org2011-01-201-1/+1
| | | | | | | | | | | | | | | This allows touch devices to be grabbed when events from the mouse/keyboard are grabbed. This also exposes TouchFactory, which will eventually be used in more places. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71879 Review URL: http://codereview.chromium.org/6300007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72002 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stray externs in .cc codeisherman@chromium.org2011-01-201-4/+4
| | | | | | | | | | | | Fix build! BUG=none TEST=none TBR= alekseys@chromium.org Review URL: http://codereview.chromium.org/6269013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72001 0039d316-1c4b-4281-b951-d872f2087c98
* Keep visibility state in sync between the native window and viewasanka@chromium.org2011-01-201-0/+7
| | | | | | | | | | | | Native ConstrainedWindows are invisible upon creation on Windows. Mark the associated NonClientView as hidden to keep the visibility state in sync. BUG=69673 TEST=none Review URL: http://codereview.chromium.org/6261015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71999 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Request focus when a touch-sequence starts.sadrul@chromium.org2011-01-201-0/+3
| | | | | | | | | | BUG=focusing the omnibox, then touching a textfield in a webpage shows the keyboard, but keys don't go to the textfield. TEST=see bug Review URL: http://codereview.chromium.org/6312009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential assert in SpeechRecognizer dtor.satish@chromium.org2011-01-201-3/+6
| | | | | | | | | | | | | | When StopRecognition is invoked and no data was recorded, there is a possibility that the delegate might release the recognizer within the DidCompleteRecognition callback. So we now perform cleanup tasks such as freeing the encoder_ object before invoking the delegate. Without this change there would be an assert in the SpeechRecognizer dtor about encoder_ remaining valid. BUG=none TEST=Manual, double-click on the speech button quickly a few times and verify no assert pops up in the dtor. Review URL: http://codereview.chromium.org/6381004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71994 0039d316-1c4b-4281-b951-d872f2087c98
* Add "sidebar" section to extension manifest:alekseys@chromium.org2011-01-2027-64/+549
| | | | | | | | | | | | | | | | | "sidebar": { "default_url": "", "default_title": "", "default_icon": "" } Allow extension to access experimental.sidebar API only in presence of this section. BUG=51084 TEST=unit_tests, ExtensionManifestTest.Sidebar Review URL: http://codereview.chromium.org/6321006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71993 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load plugins on prerendered pages until the pages are displayed.mmenke@chromium.org2011-01-2011-12/+89
| | | | | | | | | BUG=61745 TEST=in progress Review URL: http://codereview.chromium.org/6247013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71992 0039d316-1c4b-4281-b951-d872f2087c98