summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Use the correct g_free instead of free when freeing memory passed to us from ↵jhawkins@chromium.org2009-03-251-1/+1
| | | | | | | | gtk. Review URL: http://codereview.chromium.org/53072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12510 0039d316-1c4b-4281-b951-d872f2087c98
* Add an exception to DownloadManager::GenerateExtension() for .tar.gz files ↵thestig@chromium.org2009-03-252-1/+21
| | | | | | | | | with mime_type "application/x-tar". BUG=5772 Review URL: http://codereview.chromium.org/42622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12509 0039d316-1c4b-4281-b951-d872f2087c98
* Restore revision 12329, which I accidentally clobbered whenaa@chromium.org2009-03-251-5/+17
| | | | | | | | | | | | I moved this file. See: http://codereview.chromium.org/49011 http://codereview.chromium.org/42435 Review URL: http://codereview.chromium.org/42585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12508 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark menu work. Notes:jrg@chromium.org2009-03-2517-65/+333
| | | | | | | | | | | | | - "add bookmark" menu item enable state (e.g. disabled if no windows) - bookmark menus built dynamically (like before) - bookmark menus rebuild when a bookmark is added/removed - bookmark menus take the current browser to where you want to go - works with multiple windows (main window goes to bookmark location) - works with no windows (bookmarks open a new window) Review URL: http://codereview.chromium.org/49005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12501 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12498.jcampan@chromium.org2009-03-257-179/+115
| | | | | | Review URL: http://codereview.chromium.org/53073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12500 0039d316-1c4b-4281-b951-d872f2087c98
* Wire the alternate desktop shortcut textcpu@google.com2009-03-2514-24/+76
| | | | | | | | | | | | | - second set of changes, one small one to come - adds a parameter on the desktop shortcut creator function that indicate the text to use - plumbs the master preference and the command line parameter BUG=1522969 Review URL: http://codereview.chromium.org/42586 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12499 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the mouse-wheel message rerouting code out of the focus manager.jcampan@chromium.org2009-03-257-115/+179
| | | | | | | | | | This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. Review URL: http://codereview.chromium.org/53037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher due to improperly initializing variables.avi@google.com2009-03-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/45060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12497 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix/punt on a bunch of NOTIMPLEMENTEDs."evan@chromium.org2009-03-255-20/+10
| | | | | | This reverts commit r12489. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12492 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the black line from the bottom of the status bubble.brettw@chromium.org2009-03-251-2/+3
| | | | | | | | | | TEST=Make the Chrome window on top of a white window with a link at the very bottom of the window. Hover over the link so that the status bubble moves outside the chrome window and over the background. The bottom line should be consistent and not have the part under the text be black. Review URL: http://codereview.chromium.org/53068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12491 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12479 which reverted 12470.willchan@chromium.org2009-03-252-7/+29
| | | | | | | This change is the same as 12470, except with HttpRequestInfo::priority initialized in the initializer list, which should fix the purify errors. Review URL: http://codereview.chromium.org/53066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12490 0039d316-1c4b-4281-b951-d872f2087c98
* Fix/punt on a bunch of NOTIMPLEMENTEDs.evan@chromium.org2009-03-255-10/+20
| | | | | | Review URL: http://codereview.chromium.org/53065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12489 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes to support cached form submissions.darin@chromium.org2009-03-253-21/+65
| | | | | | | | | | | | | | | | | | | | | | The solution is to add a user-defined identifier to UploadData. If that identifier is set, and if the request method is POST, then HttpCache will enable caching for the response. (The cache key will be a composition of the identifier and the URL.) A subsequent POST request to the same URL with the same identifier will "hit" the previously generated cache entry. Reuse from the cache is subject to all of the standard rules. For reference, here are the corresponding net changes: http://codereview.chromium.org/52028 Here are the corresponding WebKit changes: http://trac.webkit.org/changeset/41919 BUG=2636 R=sky Review URL: http://codereview.chromium.org/52040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12485 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some widget creation code in web_contents_view and ↵estade@chromium.org2009-03-2516-145/+86
| | | | | | | | | | render_widget_host_view. This only affects popups. The advantages of this refactoring are to get rid of a TODO and allow some unforking of web_contents_view_*. Review URL: http://codereview.chromium.org/48103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12483 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: write images to clipboard.estade@chromium.org2009-03-251-5/+5
| | | | | | | | Writing a bitmap to the clipboard is a rather slow operation, as it involves piping it over IPC and then converting it to a PNG. Review URL: http://codereview.chromium.org/42592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12482 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash that occurred because we weren't correctly disposing of thesky@google.com2009-03-251-0/+8
| | | | | | | | | | | native HWND for buttons. BUG=9301 TEST=see bug Review URL: http://codereview.chromium.org/42609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12481 0039d316-1c4b-4281-b951-d872f2087c98
* When a native button was getting focused we were calling the View::Focus() ↵jcampan@chromium.org2009-03-251-1/+3
| | | | | | | | | | | | method which would focus the RootView HWND confusing the button and the click would not trigger WM_COMMAND. When the button was already focused, we were not setting the focus and the WM_COMMAND was sent correctly. BUG=9273 TEST=Open the option dialog, click the Manage button in the "Default search" section. This should bring up the dialog. Close the dialog, the focus should be on the Manage button. Review URL: http://codereview.chromium.org/42616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12480 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12470.willchan@chromium.org2009-03-252-29/+7
| | | | | | | caused purify errors Review URL: http://codereview.chromium.org/45055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12479 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12469.brettw@chromium.org2009-03-258-291/+80
| | | | | | Review URL: http://codereview.chromium.org/53062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12476 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in chrome/browserphajdan.jr@chromium.org2009-03-2510-56/+55
| | | | | | | | | | - make more things const - remove unreferenced declaration of GetGoButton - fix indentation in one place Review URL: http://codereview.chromium.org/53053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12475 0039d316-1c4b-4281-b951-d872f2087c98
* Don't override user's default cursor with GDK_ARROW.estade@chromium.org2009-03-251-2/+6
| | | | | | | | BUG=8786 Review URL: http://codereview.chromium.org/42587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12474 0039d316-1c4b-4281-b951-d872f2087c98
* The native button's visible and enabled state were not working.jcampan@chromium.org2009-03-255-0/+17
| | | | | | | | BUG=9261 TEST=See bug. Review URL: http://codereview.chromium.org/42582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12473 0039d316-1c4b-4281-b951-d872f2087c98
* Prioritize which HTTP requests get a socket first by adding a priority level ↵willchan@chromium.org2009-03-252-7/+29
| | | | | | | | | | to various methods and classes. Fix lint errors along the way. R=darin,wtc BUG=8993 Review URL: http://codereview.chromium.org/42541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12470 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmarks bar disappear when the load after the new tab page commitsbrettw@chromium.org2009-03-258-80/+291
| | | | | | | | | | | | | | rather than when it is pending. This makes it change at the same time the page changes. To support this, we now have to keep track of both a pending and a committed DOMUI object. This is tracked by the RenderManager, which does a similar swapping between pending and committed RenderViewHosts. BUG=8963 Review URL: http://codereview.chromium.org/42512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12469 0039d316-1c4b-4281-b951-d872f2087c98
* - Add UI test for SunSpider.patrick@chromium.org2009-03-257-0/+721
| | | | | | | | | - Modify SunSpider to work with the UI test framework. BUG=8785 Review URL: http://codereview.chromium.org/42581 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12465 0039d316-1c4b-4281-b951-d872f2087c98
* Removes bogus DCHECK in ConfirmInfoBar::ButtonPressed. The DCHECK issky@google.com2009-03-251-2/+0
| | | | | | | | | | | bogus as InfoBar adds a button that invokes this method as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/53034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12450 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark menu to be before other menus.sky@google.com2009-03-251-7/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/42568 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12449 0039d316-1c4b-4281-b951-d872f2087c98
* Add convert_dict and flush_cache targets.sgk@google.com2009-03-251-0/+31
| | | | | | Review URL: http://codereview.chromium.org/45050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12436 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite GetTextDirection() to call GetTextDirectionForLocale(locale_name), whichjungshik@google.com2009-03-253-23/+61
| | | | | | | | | | | in turn calls uscript_getCode() to get the script code and compare it against Hebrew and Arabic scripts (as opposed to languages). TEST=L10n*.GetTextDirection Review URL: http://codereview.chromium.org/40125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12435 0039d316-1c4b-4281-b951-d872f2087c98
* A tricky fix for Issue 1845 (Take 2).hbono@chromium.org2009-03-258-1/+151
| | | | | | | | | | This is almost the same change as <http://codereview.chromium.org/39252/show>, which caused a build break on a Linux buildbot while compiling my new template function in "chrome/common/render_messages.h". Even though I was not able to reproduce the build errors on my Linux box, I removed this function and use the int type in my IPC message 'ViewMsg_SetTextDirection'. BUG=1845 Review URL: http://codereview.chromium.org/42495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12434 0039d316-1c4b-4281-b951-d872f2087c98
* Wire the shortcut (Ctrl+Shift+Del) for Clear Browsing Data.finnur@chromium.org2009-03-251-0/+1
| | | | | | | | | | | | | Firefox has had this shortcut for a long time and I am told IE8+ added it as well. In any case, we should match Firefox. BUG=8458 TEST=Press Ctrl+Shift+Del and the Clear Browsing Data dialog should show up. Review URL: http://codereview.chromium.org/42540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12432 0039d316-1c4b-4281-b951-d872f2087c98
* A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookmarkjungshik@google.com2009-03-252-5/+11
| | | | | | | | | | | | | | s.html' file. Update the unit test to match the change in bookmark_html_writer.cc The initial CL got reverted because the unittest failed. This CL changes the unittest. BUG=6957 Review URL: http://codereview.chromium.org/48042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12426 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try to paint tabs if there are no tabs to paint.tc@google.com2009-03-251-0/+3
| | | | | | | | | BUG=9214 Review URL: http://codereview.chromium.org/53033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix branding problemjrg@chromium.org2009-03-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/53023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12422 0039d316-1c4b-4281-b951-d872f2087c98
* Focusing a native button through a RequestFocus call would not result in the ↵jcampan@chromium.org2009-03-255-3/+29
| | | | | | | | | | | | | | actual button showing as focused. This is because the NativeButton is the one getting focused not the NativeControl wrapper. This CL adds forwarding the focus to the NativeControl so the HWND really gets focused. It also associates the NativeButton view with the NativeControl, so that when the HWND is focused (through a click for example), the focus manager has the NativeButton as the focused view (not the NativeControl wrapper). BUG=9253 TEST=Open the option panel. Press tab several times. The focus should move as expected to the different buttons and views in the page. Review URL: http://codereview.chromium.org/45042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12420 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in RDH that it overlooked a resource messagehclam@chromium.org2009-03-251-0/+1
| | | | | | | | | | | | TBR=darin ViewHostMsg_DownloadProgress_ACK is a resource message but it is overlooked by RDH and thus not processed. This patch adds the message to ResourceDispatcherHost::IsResourceDispatcherHostMessage to enable processing the message. Review URL: http://codereview.chromium.org/53030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12418 0039d316-1c4b-4281-b951-d872f2087c98
* Folder path was not set correctly for media cachehclam@chromium.org2009-03-251-2/+2
| | | | | | | | | | TBR=darin Fixed a bug in ProfileImpl and OffTheRecordProfileImpl that path to media cache folder was set incorrectly. Review URL: http://codereview.chromium.org/45046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12417 0039d316-1c4b-4281-b951-d872f2087c98
* Modifes the in-application EULA outer frame to take a parameter ↵gwilson@google.com2009-03-2443-42/+50
| | | | | | | | | | ('innerframe') and set its inner iframe src to the value of that parameter. BUG=8894 Review URL: http://codereview.chromium.org/50039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12415 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the eula innerframe param parsingcpu@google.com2009-03-241-2/+10
| | | | | | | | | | | - eula inner frame is supplied by chrome - removes fat from the installer (1M) - depends on another review (50039) from glen Review URL: http://codereview.chromium.org/42572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12413 0039d316-1c4b-4281-b951-d872f2087c98
* Updating test log inputs to include accumulative test duration at different ↵ace@chromium.org2009-03-241-10/+18
| | | | | | | | steps in testing. Review URL: http://codereview.chromium.org/52038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12411 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent data read errors from crashing the browser.thestig@chromium.org2009-03-241-0/+7
| | | | | | | | | | | In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error, it calls OnResponseCompleted(). For a download, this hits the NOTREACHED() in DownloadThrottlingResourceHandler::OnResponseCompleted(). This patch checks for the error status, and returns false, which causes the download to finish, which saves an empty file of size 0. BUG=8170 Review URL: http://codereview.chromium.org/42573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12410 0039d316-1c4b-4281-b951-d872f2087c98
* Implement default css for toolstrips.aa@chromium.org2009-03-2411-36/+75
| | | | | | Review URL: http://codereview.chromium.org/42435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12408 0039d316-1c4b-4281-b951-d872f2087c98
* Use '.' instead of 'source' because sh on the buildbots (dash) doesn't like ↵mmoss@chromium.org2009-03-241-1/+1
| | | | | | | | | 'source'. Review URL: http://codereview.chromium.org/53025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12404 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-2415-43/+110
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* SHARED_INTERMEDIATE_DIR is a better place for generated headers.mmoss@chromium.org2009-03-241-1/+1
| | | | | | | | | | Also, use chrome path calculated relative to version.sh, since the passed-in path isn't correct on the buildbot. Review URL: http://codereview.chromium.org/42574 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12401 0039d316-1c4b-4281-b951-d872f2087c98
* fix win buildestade@chromium.org2009-03-241-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12397 0039d316-1c4b-4281-b951-d872f2087c98
* fix win buildestade@chromium.org2009-03-241-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12396 0039d316-1c4b-4281-b951-d872f2087c98
* Implement basic ShowItemInFolder for linux.estade@chromium.org2009-03-2411-86/+163
| | | | | | | | | Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future. Review URL: http://codereview.chromium.org/52034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
* Switch some more ASCII locale code wstrings to strings.estade@chromium.org2009-03-249-260/+233
| | | | | | | | Also, don't alphabetize available spellchecker locale codes. Review URL: http://codereview.chromium.org/42531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12388 0039d316-1c4b-4281-b951-d872f2087c98
* Include version information in Linux chrome.mmoss@chromium.org2009-03-241-1/+16
| | | | | | | | | | | This makes use of, and scons-enables, the Linux version header in Issue 45028. BUG=8132 Review URL: http://codereview.chromium.org/42542 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12387 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 08:07:35 +0000