| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Allow (current + new == max) case.
BUG=20673
TEST=none
Review URL: http://codereview.chromium.org/176037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20228,20513
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/182034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18442
TEST=none
Review URL: http://codereview.chromium.org/174633
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
but we repainted the whole pinned tab so it wasn't as obvious. With
this change, the throbber is placed where the favicon will go.
BUG=20626
Review URL: http://codereview.chromium.org/175038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
don't show up in the task bar.
Review URL: http://codereview.chromium.org/177046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14756
TEST=Ran valgrind and unit_tests for SpellCheckTest and all passed successfully.
Review URL: http://codereview.chromium.org/176046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run unit_tests --gtest_filter=ExtensionUpdaterTest.*, make sure there's no extra temporary files after the test finishes.
Review URL: http://codereview.chromium.org/173635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Everything is still currently disabled under compile-time flag.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/174104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/175041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
should just exit, rather go through rest of the code.
Review URL: http://codereview.chromium.org/183022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/179052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(based on http://code.google.com/p/chromium/issues/detail?id=16251)
Add about:memory support to Linux. Rather than try and copy the
Windows output, we use a couple of metrics which make more sense on
Linux: USS and PSS.
http://codereview.chromium.org/177024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't have a body.
BUG=16873
TEST=unittests
Review URL: http://codereview.chromium.org/173536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/175039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a long-time bug (mentioned at the end of my description
in http://codereview.chromium.org/159185 but reported more recently)
where Chrome would steal back the PRIMARY selection the first time
that another app takes it.
I tested by going through my test cases from the following earlier
changes and also confirming that the selection-stealing issue is also
fixed:
http://codereview.chromium.org/151006
http://codereview.chromium.org/155971
http://codereview.chromium.org/159185
http://codereview.chromium.org/164539
http://codereview.chromium.org/173098
BUG=20460
TESTED=see above
Review URL: http://codereview.chromium.org/176029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18429
Review URL: http://codereview.chromium.org/182037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before we were always defaulting to 301.
TEST=run automation tests.
BUG=none
Review URL: http://codereview.chromium.org/178041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20658
Review URL: http://codereview.chromium.org/173630
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable Apple Crash Reporter for Browser process in Non-Debug builds.
* Introduce mac_util::IsBackgroundProcess().
* Invert logic around Breakpad Enabling/Disabling to make it clearer.
* Honor the kDisableBreakpad switch.
Our new policy:
* Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed.
* Always disable Apple Crash in background processes (plug-in, renderer, etc).
* If Breakpad is enabled browser crashes will be passed to Crash Reporter.
* If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds.
Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace.
Review URL: http://codereview.chromium.org/180048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not sure what's happening, so I'm going to log that.
This should answer the question if the leftover processes are renderers,
or if it's the main browser process, etc.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/180046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal@chromium.org
Review URL: http://codereview.chromium.org/179050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/182036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
not been inserted into a window yet.
BUG=20009
TEST=tabs opened in the background should not be blank when you switch to them.
Review URL: http://codereview.chromium.org/175027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/20455
TEST=Enter "this" into address bar. Hold Control, should see
"www.this.com" as first item. Release, and it should go back to
"this" immediately.
Review URL: http://codereview.chromium.org/182021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are some crashers which show up as an objc_msgSend when posting
a notification. So I went around reviewing our observers looking for
places where it's possible that we weren't unregistering correctly.
These may have already been correct, but this change would seem to
make unregistration more reliable.
Review URL: http://codereview.chromium.org/174480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Option-return inserted a literal newline, did not want. Also fixed
Option-tab to not insert literal tab.
http://crbug.com/17914
TEST=Type text, option-tab should not insert literal tab,
option-return should not insert newline. Both should do nothing.
Review URL: http://codereview.chromium.org/181024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=aa
Review URL: http://codereview.chromium.org/178039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
deletion it's perfectly reasonable for the controller to be running a query when the popup is not open.
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor so that the dialog is shown by calling BrowserWindow::ShowRepostFormWarningDialog
BUG=19761
TEST=see bug
Review URL: http://codereview.chromium.org/174294
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome" from "Google Chrome."
BUG= none
TEST= Open NTP with clean profile. Note that title of first thumbnail is "Welcome to Chrome" or "Welcome to Chromium".
Review URL: http://codereview.chromium.org/177036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the compile.
TBR=mmoss
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/176043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=pkasting
Review URL: http://codereview.chromium.org/181023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Turn some DCHECKs into CHECKs (I don't think any of these will get hit)
* Ensure that URLsForDefaultMatch() doesn't leave any results lying around on the controller, since the popup isn't open (and those two states should be locked in step)
* Eliminate some old code in Move() that shouldn't have actually done anything anymore (since result() should already be in sync with the popup, and SetSelectedLine() is going to stop the controller)
* Use a pre-existing helper function at two places in the Edit for readability
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/180045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The too-short timeout was making it leak in valgrind.
BUG=20617
Review URL: http://codereview.chromium.org/180044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that the XID of the page window can change at arbitrary times
(e.g. when the tab is detached then reattached), so we need to be able to track
these changes, and let the PluginInstance know.
BUG=17110
TEST=go to www.nvidia.com, detach then reattach the tab, move the mouse, verify no crash
Review URL: http://codereview.chromium.org/180019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This disables ExtensionMessagingTab and ExtensionViews
TBR=estade
Review URL: http://codereview.chromium.org/173632
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pushed to listeners. r24290 made it possible for the controller to be "done" (in that all providers had finished) but have not yet sent the final results to listeners. This makes done() only return true when the controller has actually pushed the final results.
I'm not sure precisely what effects this discrepancy could have had but I suspect they were bad, given that callers assume done() means "results are stable".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/173631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Related bugs:
http://crbug.com/18337
http://crbug.com/20467
Review URL: http://codereview.chromium.org/175019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is just a performance optimization. Previously this code was added for closing bookmark bars as a bit of visual polish.Doing the same thing for opening bookmark bars should reduce CPU usage but it won't look any different (for fast computers anyway).
BUG=17133
Review URL: http://codereview.chromium.org/183011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Two reasons:
1. Compatibility with Safari.
2. Doesn't conflict with webapps that want to use cmd-u for e.g. underline.
Review URL: http://codereview.chromium.org/177030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=20575
TEST=On linux pin a tab. Right click on the tab and make sure you see
a check next to 'Pin Tab'.
Review URL: http://codereview.chromium.org/175028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
were using the actual tab widget for this purpose, but this is unreliable becauase we hide and detach the tab widget, which disturbs the drag operation.
BUG=19725,20513
TEST=Extensive tab dragging.
Review URL: http://codereview.chromium.org/176034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- wait for the second browser process to finish
- only initialize user dir once
Will it kill flakiness? Who knows.
TEST=none
http://crbug.com/20546
Review URL: http://codereview.chromium.org/181016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Thiago Farina. Original review: http://codereview.chromium.org/177031
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/173629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process ID with an internally-generated id() function. This allows us the
guarantee that the IDs are unique over the entire run of the application.
This also cleans up some code associated with managing the PID.
The main potentially interesting change is now the PID is set uniquely for
every creation of RenderProcessHost. It used to be set cleared if the process
went away, and re-set if the process was re-created. The ID generation is in
ChildProcesInfo so it is also unique between workers and plugins. I had to
change some significant things in resource_dispatcher_host_unittest to take
into account this new generation of IDs.
BUG=17828
TEST=none
Review URL: http://codereview.chromium.org/160203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20277
TEST= Open NTP, try out some themes, observe that links change color to keep up with theme, and are legible against background of page.
Review URL: http://codereview.chromium.org/176033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18442
TEST=ExtensionApiTest.*
Review URL: http://codereview.chromium.org/173622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20453
TEST=none
Review URL: http://codereview.chromium.org/180034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24890 0039d316-1c4b-4281-b951-d872f2087c98
|