| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14462
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
about:foo.
R=evanm
Review URL: http://codereview.chromium.org/14203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(client side).
This is the last patch. It can't go in until Evan and I test it.
Review URL: http://codereview.chromium.org/10666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(I found these while investigating bug 4749.)
R=eroman
Review URL: http://codereview.chromium.org/12974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Google Update LaunchCmdLine launches command with the callers token. To launch non-elevated we try to get the token of explorer.exe and impersonate it (same as what Google Update does in another place).
Also fix a bug in Compatibility check function. We should exit if we fail to load advapi32.dll and not if we succeed.
I am still doing testing with various builds of Google Update.
Review URL: http://codereview.chromium.org/12970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of the old Halo Frame. Trying to rip it out halfway results in problems, like the taskbar not un-auto-hiding when Chromium is maximized.
This should result in correct handling of maximized windows on multiple monitors with different resolutions, taskbar positions, and auto-hide settings (since we're just using the native Windows code to do everything).
BUG=943445
Review URL: http://codereview.chromium.org/14446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
other minor cleanups. The special casing for the OmniBox that used to live in the ViewAccessibility code could be removed due to the fact that the only assistive technologies depending on this case are now testing tools. The end-user tools will see no difference, and the testing tools can access the OmniBox IAccessible by directly giving it keyboard/mouse focus.
BUG=2237
Review URL: http://codereview.chromium.org/14036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- we now reuse the existing popup if there is one (instead of creating a new on with each key stoke), this prevents the flickering we used to see.
- we don't hide the popup on every key stroke, instead we rely on the client editor telling us the field is not being edited anymore.
TEST=Enter some text in a form's text field several times, the autofill should show and not flicker.
BUG=5258
Review URL: http://codereview.chromium.org/14100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
go away when you navigate to a new page.
Review URL: http://codereview.chromium.org/14130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Unify WatchSocket & WatchFileHandle.
* Better encapsulate libevent.
* Fix a bug with blocking writes in ipc_posix.cc
Review URL: http://codereview.chromium.org/13757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This time, we do everything programatically and extend the target area only when the window is maximized. After this patch, we don't actually get the left-most pixel to be targetable on XP because our frame code is borked, but this should work once we unbork that.
BUG=3484
R=beng
Review URL: http://codereview.chromium.org/13782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=cpu
Review URL: http://codereview.chromium.org/14417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields.
Review URL: http://codereview.chromium.org/13731
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
key. I broke this when I added an observer method for the deletion so
that overriding key down no longer works.
BUG=5472
TEST=see bug
Review URL: http://codereview.chromium.org/14430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
changes into my own.
BUG=5473
Review URL: http://codereview.chromium.org/14121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. We only apply edits when the bubble is closed (previously selecting
a different folder resulted in an immediate action).
. Hitting escape cancels any edits.
. When the bubble is shown for newly bookmarked items hitting escape
removes the bookmark.
. If you click 'Edit...' or select 'Choose another folder...' any
edits are applied immediately before the editor is shown.
BUG=5015
TEST=thorougly test the bookmark bubble to make sure I haven't broken
anything.
Review URL: http://codereview.chromium.org/14074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Add a delay to workaround bug 2953 for the moment.
* If a user-data-dir is specified, don't try to copy files.
* Add some logging on various failures.
Review URL: http://codereview.chromium.org/14416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BN,GU,KN,ML,MR,OR,TA and TE are still using the English translation (no translation available on our site).
HE is non-RTL, which we should fix upstream.
The JS contained is harmless code that we had previously manually stripped out, but as we're not someone more automated, I'm leaving it in.
Review URL: http://codereview.chromium.org/14104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12883
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
BUG=4749
Review URL: http://codereview.chromium.org/14108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12928
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
this failed UI tests catastrophically
Review URL: http://codereview.chromium.org/14103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also make ProxyService refcounted so the sharing between profiles is explicit.
Review URL: http://codereview.chromium.org/13701
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(i.e. reapply 6935, with fix)
Review URL: http://codereview.chromium.org/14087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
condition that could be false in the new HTTP stack.
R=rvargas
BUG=4749
Review URL: http://codereview.chromium.org/13799
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/13800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Joi has convinced me that GRIT should generate platform specific
resources files. This is easier than parsing .rc files because
GRIT effectively has an .rc parser. To that end, we need to
convert some existing .rc files to .grd files (e.g., net_resources.rc
and webkit_resources.rc). Rather than having every grd file output
to a different place and -I all the different paths, have GRIT
generate all files into one directory. This directory is
grit_derived_sources.
Review URL: http://codereview.chromium.org/13776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke compile
Review URL: http://codereview.chromium.org/14083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The translation console only knows how to handle CAPS and
underscores for placeholders. There's a check in the GRIT
code that verifies this when we generate the translation
console upload format. But we never go through this code
path when generating the .rc and .h files.
Review URL: http://codereview.chromium.org/14071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(but not all) base types.
Review URL: http://codereview.chromium.org/13726
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
concept. Add necessary const accessors to property bag.
BUG=5260
Review URL: http://codereview.chromium.org/13707
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Factor out windowisms from the spell checker.
Review URL: http://codereview.chromium.org/14041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Unify WatchSocket & WatchFileHandle.
* Better encapsulate libevent.
* Fix a bug with blocking writes in ipc_posix.cc
Review URL: http://codereview.chromium.org/13757
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to front after a delay. Also made docking to another window bring the
other window to front.
BUG=2038
TEST=Create two window with two tabs each. Drag a tab from one window
onto the other window (not the tab area), hold it for a second and
make sure the other window comes to front.
Review URL: http://codereview.chromium.org/14057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A previous commit duplicated chrome_canvas_win.cc from chrome_canvas.cc.
Delete the Windows specific functions from chrome_canvas.cc and
delete the generic functions from chrome_canvas.cc. Implement Skia
versions of the Windows specific functions in chrome_canvas_skia.cc.
Review URL: http://codereview.chromium.org/13779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
regressed in r5417.
ISSUE=http://crbug.com/4737
Review URL: http://codereview.chromium.org/13271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=agl
Review URL: http://codereview.chromium.org/13792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=4540
TEST=Right click on the bookmark bar (not over a button) and make sure
open all opens all the bookmarks on the bookmark bar.
Review URL: http://codereview.chromium.org/13790
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=5418
TEST=see bug
Review URL: http://codereview.chromium.org/14053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of type instead of *.html.
BUG=4479
TEST=Bring up the bookmark manager, click tools->import. Make sure the
import dialog 'files of type' has something like 'Chrome Document'
(although this depends upon your registry), and that selecting it
shows all html and htm files. Additionally make sure you have 'all
files' in the 'files of type' combobox too.
Review URL: http://codereview.chromium.org/14025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4160,4263
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6815
Review URL: http://codereview.chromium.org/9639
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/12688
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
empty file so that we don't later think that the same path doesn't exist.
BUG=3662
R=paulg
Review URL: http://codereview.chromium.org/13336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6878 0039d316-1c4b-4281-b951-d872f2087c98
|