summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Fixes painting bug in switching between ntp and non-ntp pages. Withoutsky@chromium.org2009-11-171-0/+17
| | | | | | | | | | | | | | | this code the bookmark bar's widget gets sized to 1x1 for a layout/painting step and we get all sorts of painting artifacts. I don't understand why that happens, but forcing a layout fixes it. I've scoped this just to chrome os for now. BUG=27898 TEST=make sure tab switching on chrome os doesn't result in any visual artifacts, especially when switching between ntp and non-ntp. Review URL: http://codereview.chromium.org/397018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32152 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Hide fullscreen bubble when kiosk mode is active.mhm@chromium.org2009-11-172-6/+10
| | | | | | | | | | | When chrome is ran in kiosk mode, the fullscreen bubble should be hidden. As well, I found a major variable name mixup in browerview. BUG=27308 TEST=None Review URL: http://codereview.chromium.org/385146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32151 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing test.thakis@chromium.org2009-11-171-0/+5
| | | | | | | BUG=27927 Review URL: http://codereview.chromium.org/400007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32149 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32137 - Revert 32121 Fix crash.laforge@chromium.org2009-11-171-1/+2
| | | | | | | | | | | | | | | BUG=27145,possibly others TEST=See bug. Review URL: http://codereview.chromium.org/399014 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/399021 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/399024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32143 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of DCHECK that was firing. The check itself is not dmaclach@chromium.org2009-11-171-1/+0
| | | | | | | | | | | | completely necessary, and as it turns out we don't always get matching exit/enter events. TEST=none BUG=none Review URL: http://codereview.chromium.org/395025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32142 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ToolbarControllerTest.Display which crashed 5 times today.erikkay@chromium.org2009-11-171-1/+2
| | | | | | | | | | BUG=27920 TEST=ToolbarControllerTest.Display TBR=dmaclach Review URL: http://codereview.chromium.org/399022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32121 - Fix crash.erikkay@chromium.org2009-11-171-2/+1
| | | | | | | | | | | | BUG=27145,possibly others TEST=See bug. Review URL: http://codereview.chromium.org/399014 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/399021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32137 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to close the Safe Browsing Service database and recreate it on ↵pkasting@chromium.org2009-11-172-33/+93
| | | | | | | | | | the fly. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/399006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32136 0039d316-1c4b-4281-b951-d872f2087c98
* Spellchecker: Always destruct url request context getter on io thread.estade@chromium.org2009-11-175-20/+78
| | | | | | | | | | To do this, we have to initiate downloads on the UI thread and don't hold onto a reference in the file thread. BUG=27667 Review URL: http://codereview.chromium.org/387055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32129 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bug 21054 from known list.huanr@chromium.org2009-11-171-4/+0
| | | | | | | | | BUG=21054 TEST=None Review URL: http://codereview.chromium.org/391081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32128 0039d316-1c4b-4281-b951-d872f2087c98
* amit, please review everything, jam please review the changes to the ↵ananta@chromium.org2009-11-1724-306/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | tab_contents and the renderer_host sources. Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab container, which hosts ChromeFrame. This object was used to carry a custom URL request context which was used to intercept HTTP requests and cookie requests issued by external tabs. However as the life time of the automation profile class depended on the lifetime of the external tab container object this caused a number of crashes in objects which held on to the automation profile pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser instance as the profile is deleted at the very end. We can associate the automation URL request context with the underlying tab_contents which would eventually percolate down to the resource message filter. Doing this would avoid the need for the AutomationProfile class. This CL achieves that. Bug=27695,27662 Review URL: http://codereview.chromium.org/385117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb through off the record state from the URL request to thetony@chromium.org2009-11-1723-34/+66
| | | | | | | | | | chrome url request data sources. This will allow me to merge IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean up DOMUIThemeSource, but those will be follow up changes. Review URL: http://codereview.chromium.org/397019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash.thakis@chromium.org2009-11-161-1/+2
| | | | | | | | | BUG=27145,possibly others TEST=See bug. Review URL: http://codereview.chromium.org/399014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32121 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of the chrome.experimental.popup API implementation to allow ↵twiz@google.com2009-11-1617-124/+757
| | | | | | | | | | | | | | | | display of pop-ups for extensions viewed through a tab-contents view.I added a new class, ExtensionPopupHost. This class implements the necessary environment for managing child popup windows from either an ExtensionHost, or an ExtensionDOMUI. Note that this class is added as a member to ExtensionHost and ExtensionDOMUI. I decided to take this approach to prevent multiple inheritance of the NotificationObserver class: Both ExtensionPopupHost and ExtensionHost must inherit from this class, and I was uncertain of how the system would behave wrt virtual inheritance. Please comment on if I should have used the inheritance approach. I also removed the customHandler tag (in extension_api.json) that I had added in the initial submission. The arguments in the schema are now those that users of the API see. The nodocs tags were also removed. The api experimental.popup.getAnchorWindow() has been renamed to popup.getParentWindow, as per a suggestion from Erik K. BUG=none TEST=extension_popup_apitest.cc Review URL: http://codereview.chromium.org/385061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32120 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Draw entire Bookmark Bar every time to match API expectations.erg@chromium.org2009-11-161-2/+12
| | | | | | | | | | | | | | NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw the entire bookmark bar on every expose; all of its internal math is based on the assumption that the incoming area is zero-based and is the whole bookmark bar area. TEST=(Repo instructions in bug) BUG=25655 Review URL: http://codereview.chromium.org/401005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32115 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the logging on history thread since the crashhuanr@chromium.org2009-11-166-214/+5
| | | | | | | | | | | is fixed. BUG=16591 TEST = none Review URL: http://codereview.chromium.org/384073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32113 0039d316-1c4b-4281-b951-d872f2087c98
* reland 31875. Revert was:estade@chromium.org2009-11-1613-82/+143
| | | | | | | | | | | | | | ------ Revert 31875 to see whether it fixes reliability bot. BUG=25677 TEST=None ------ TBR=huanr Review URL: http://codereview.chromium.org/397017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32112 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=27893erikkay@chromium.org2009-11-161-0/+4
| | | | | | | | | | | TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose TBR=idana disable test on Linux due to crashes Review URL: http://codereview.chromium.org/391080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32108 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix button text in extension uninstall dialog.derat@chromium.org2009-11-161-1/+3
| | | | | | | | BUG=27763 Review URL: http://codereview.chromium.org/400004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32106 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix uninit warnings when building -Os.agl@chromium.org2009-11-165-5/+5
| | | | | | http://codereview.chromium.org/401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32105 0039d316-1c4b-4281-b951-d872f2087c98
* Move NULLing of OCSP context from UI thread to IO thread, to avoid possible ↵eroman@chromium.org2009-11-162-8/+8
| | | | | | | | races. Review URL: http://codereview.chromium.org/391062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32104 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Make sure the notifier does not get focused after it was hidden.arv@chromium.org2009-11-161-0/+5
| | | | | | | | | | | BUG=27833 TEST=See bug Review URL: http://codereview.chromium.org/387064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32103 0039d316-1c4b-4281-b951-d872f2087c98
* add chromeos creditsdavemoore@chromium.org2009-11-163-1/+7597
| | | | | | Review URL: http://codereview.chromium.org/399012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32096 0039d316-1c4b-4281-b951-d872f2087c98
* Added few methods and a testcase to test Chrome Frame installation.anantha@chromium.org2009-11-168-91/+258
| | | | | | Review URL: http://codereview.chromium.org/389015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32095 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValuePath.evan@chromium.org2009-11-166-26/+18
| | | | | | | | | | BUG=24672 TEST=unit_tests Patch by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/375016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32093 0039d316-1c4b-4281-b951-d872f2087c98
* Fix intermittent DCHECK failure in BlacklistManagerTest.phajdan.jr@chromium.org2009-11-161-0/+1
| | | | | | | | | | | Ensure correct shutdown of threads. TEST=Covered by unit_tests. BUG=27726 Review URL: http://codereview.chromium.org/384149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32090 0039d316-1c4b-4281-b951-d872f2087c98
* Spellchecker: call init *after* constructor.estade@chromium.org2009-11-164-19/+15
| | | | | | | | | This fixes the error where PostTask would post the task to the file thread and release its reference before the constructor returned. credit for fix goes to jam@ and thestig@ Review URL: http://codereview.chromium.org/399011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32089 0039d316-1c4b-4281-b951-d872f2087c98
* Port most of browser action apitest to linux.estade@chromium.org2009-11-162-57/+150
| | | | | | | | BUG=27224 Review URL: http://codereview.chromium.org/385085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32085 0039d316-1c4b-4281-b951-d872f2087c98
* Update the benchmark to use the document.readyState to measure ↵mbelshe@google.com2009-11-161-8/+9
| | | | | | | | | | | | | | page-completedness rather than the onload event. Extensions were moved from the pre-onload state to running at document idle some time ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/397013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32076 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31875 to see whether it fixes reliability bot.huanr@chromium.org2009-11-1613-141/+80
| | | | | | | | | BUG=25677 TEST=None Review URL: http://codereview.chromium.org/397014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32074 0039d316-1c4b-4281-b951-d872f2087c98
* Update "Bookmark Sync" string in options dialog.derat@chromium.org2009-11-161-3/+10
| | | | | | | | | | | This should be sentence-case rather than title-case for non-Linux, and it shouldn't have a trailing colon on Linux. BUG=27766 Review URL: http://codereview.chromium.org/395019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32073 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: remove unused variable from setup_constants.kuchhal@chromium.org2009-11-162-4/+0
| | | | | | | | | | BUG=None TEST=compiles Review URL: http://codereview.chromium.org/384138 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32067 0039d316-1c4b-4281-b951-d872f2087c98
* Add Event Listeners sidebar pane manual testapavlov@chromium.org2009-11-161-0/+30
| | | | | | Review URL: http://codereview.chromium.org/391074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32066 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add 2 manual profiler tests.mnaganov@chromium.org2009-11-163-0/+129
| | | | | | Review URL: http://codereview.chromium.org/399002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32056 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add some devtools manual tests.pfeldman@chromium.org2009-11-1619-0/+445
| | | | | | Review URL: http://codereview.chromium.org/385134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32053 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 249.0 to 250.0chrome-bot@google.com2009-11-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32052 0039d316-1c4b-4281-b951-d872f2087c98
* Final copyedits for beta.kathyw@google.com2009-11-164-107/+22
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/395016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32048 0039d316-1c4b-4281-b951-d872f2087c98
* Update homepage's images.kathyw@google.com2009-11-162-0/+0
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/391071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32047 0039d316-1c4b-4281-b951-d872f2087c98
* New screenshots for many of the tutorial images.kathyw@google.com2009-11-1613-38/+45
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/384148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32046 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to follow the codesite L&F.kathyw@google.com2009-11-1647-1538/+4110
| | | | | | | | | | | | | | | | | | Also a bit of copyediting and cleanup. Future work: * improve these styles * make these styles work well in IE (the old styles didn't work well in IE, either) * separate the codesite styles from ours (for easier update) BUG=27434 TEST=none TBR=aa Review URL: http://codereview.chromium.org/398005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32043 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the old samples.kathyw@google.com2009-11-165-106/+0
| | | | | | | | | | | | | | These aren't necessary now that the debugging tutorial has been updated and the relevant examples are in the new examples directory. BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/387059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32039 0039d316-1c4b-4281-b951-d872f2087c98
* Speeds up display bookmark animation as requested by thakis.dmaclach@chromium.org2009-11-161-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/384139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32037 0039d316-1c4b-4281-b951-d872f2087c98
* Escape the feed url, otherwise the web based readers suchfinnur@chromium.org2009-11-162-2/+3
| | | | | | | | | | | | | as Googler Reader can't use it. BUG=27696 TEST=Go to news.googlecom, click the RSS icon in the Omnibox and subscribe with Google Reader. It should recognize the feed url and offer to subscribe. Review URL: http://codereview.chromium.org/385126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32036 0039d316-1c4b-4281-b951-d872f2087c98
* Minor text changes per Kathy's suggestions.aa@chromium.org2009-11-152-5/+5
| | | | | | TBR=kathyw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32034 0039d316-1c4b-4281-b951-d872f2087c98
* TEST=new Chrome with bookmark folders visible in bar.jrg@chromium.org2009-11-151-1/+5
| | | | | | | | | | Create new window (Cmd-N). Make sure folders there! BUG=http://crbug.com/27774 Review URL: http://codereview.chromium.org/385130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32032 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multi-window bookmark bubble problem.jrg@chromium.org2009-11-154-18/+36
| | | | | | | | | | | | | | | Also fix a "flash" where the bookmark bubble opened in the wrong spot before jumping to the correct spot (hard to see). BookmarkBubble.xib change: NOT initially visible. BUG=http://crbug.com/27545 TEST=see bug (it's clear). Review URL: http://codereview.chromium.org/391057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "open all" on a folder node to open only 'marks in that folder,jrg@chromium.org2009-11-1510-781/+308
| | | | | | | | | | | | | | | | | | | | | | | | | | not ALL all. Make Delete and Rename enabled for folder context menu (but disabled for "Other Bookmarks"). nib changes (related to the context menus): - Telegate is the bookmark bar controller. - Switched type from NSMenu to BookmarkMenu. TEST=New window. Create folder "empty" with nothing in it. Create folder "two" with 2 bookmarks in it. Create a final bookmark in the top level of the bar. Context menu (right click) over all folders. Make sure Delete and Rename enabled for folders but not "Other Bookmarks". Make sure "Open All" (and friends) disabled over "empty", enabled over "two". "Open All" on "two" --> see 2 opened. "Open All" on the bar itself --> see 3 opened. Ditto for "Open all in new window" and "open all in incognito window". Create a new window. In new window, make sure folders have context menus. BUG=http://crbug.com/27522, http://crbug.com/27529 Review URL: http://codereview.chromium.org/391046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32029 0039d316-1c4b-4281-b951-d872f2087c98
* Add message and image to NTP to promote extensions and bookmark sync.mirandac@chromium.org2009-11-1511-22/+141
| | | | | | | | | BUG= 27393, 26744 TEST= promotional messages should show up on NTP. Review URL: http://codereview.chromium.org/394005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NewTabUITest.HomePageLink under valgrind becausensylvain@chromium.org2009-11-151-0/+4
| | | | | | | | | | it makes it hang BUG:27764 Review URL: http://codereview.chromium.org/385128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32025 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 248.0 to 249.0chrome-bot@google.com2009-11-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32022 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 19:44:44 +0000