| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the Bloat HTTP page cycler regression, and allows me to remove the
hack I checked in to disable multiple-paints due to an observed DHTML page
cycler regression.
I added a new histogram, RW_IntermediatePaintRectCount, that would have shown
the problem clearly had it been there before.
I included some cleanup in PaintAggregator:
1- rename "r" to "existing_rect" for clarity
2- check for contained (i.e., redundant) invalidates up front
I also changed the opacity of the paint rects used when --show-paint-rects is
specified. I find myself dogfooding with this command line option enabled, and
I want it to be a little less annoying but still just as useful.
R=brettw
BUG=29477
TEST=none
Review URL: http://codereview.chromium.org/464057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rename tabView_ to tabStripView_. Fix indentation.
TEST=BUG=none
Review URL: http://codereview.chromium.org/465095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Google Mail checker sample extension.
BUG=29540
Review URL: http://codereview.chromium.org/465092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to make sure it doesn't happen again.
Also, re-enable a test nearby. The history has been lost of
why this was failing, so it may fail again, but at least
we'll have data.
Finally, fix a Greasemonkey compat issue.
BUG=29298
Review URL: http://codereview.chromium.org/466053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.
It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).
bug=16495 (repairs leak induced by the first landing)
bug=18840 (should make leaks less possible)
tbr=raman.tenneti
Review URL: http://codereview.chromium.org/462027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required for supporting NaCl on 64-bit Windows. 32-bit and 64-bit versions of the installer_util target are now defined in installer_util.gypi and share some of the settings.
TEST=none
BUG=28176
Review URL: http://codereview.chromium.org/460055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A.k.a. a present for pkasting. Eventually we'll probably want to do something more sophisticated (at the very least arrows should fade in/out), but for now this doesn't look (much?) worse than what's on Win/Chrome.
BUG=25405
TEST=Drag URLs to the tab strip, move around, make sure the ugly arrow appears in the right locations, dropping to confirm. Repeat with various themes to make sure arrow is reasonably visible.
Review URL: http://codereview.chromium.org/466051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29444
Review URL: http://codereview.chromium.org/469001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the bottom button.
BUG= 29447
TEST= sync bookmarks in a non-English locale; window should not be too short.
Review URL: http://codereview.chromium.org/467025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests over to ExternalTabUITest.
BUG=27326
TEST=ui_tests.exe
Review URL: http://codereview.chromium.org/468013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
including a new stylesheet from Glen for text+icon notifications, and little icons for the buttons.
Part of the CL includes new features for TextButton class to control icon placement and appearance on hover.
BUG=none
TEST=notifications
Review URL: http://codereview.chromium.org/450045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29279
http://codereview.chromium.org/467028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29459
TEST=see bug.
Review URL: http://codereview.chromium.org/465080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not yet implemented: visual feedback, dropping multiple URLs/files, perhaps key modifiers (?).
Doing the visual feedback right (making the tabs move around, etc.) will require a fairly hefty work on the tabs code, so I'm splitting up the work.
BUG=25405
TEST=Test dragging and dropping URLs/links, files, plain text (with a possibly-poorly-formed URL), etc. on the tab and on the empty part of the tab strip; web page should load in tab or in new tab, and that tab should be selected.
Review URL: http://codereview.chromium.org/337055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina <thiago.farina@gmail.com>
Original review: http://codereview.chromium.org/462038
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/459015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=567
TEST=Visit a page, zoom in or out, then navigate to a different host. The new page should not be zoomed. Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed.
Review URL: http://codereview.chromium.org/437077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
entire html control.
BUG=none
TEST=Enable sync and attempt to log in. The cancel button should be completely visible.
Review URL: http://codereview.chromium.org/464029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR= tc
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/463036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary change to fix the page cycler regressions.
TBR=brettw
BUG=25905
TEST=none
Review URL: http://codereview.chromium.org/460082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should make diagnosing OOM crashes a lot easier.
TEST=manually force OOM, check the stack
BUG=29351
Review URL: http://codereview.chromium.org/462030
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/460084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should make diagnosing OOM crashes a lot easier.
TEST=manually force OOM, check the stack
BUG=29351
Review URL: http://codereview.chromium.org/462030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
by Thiago Farina (see http://codereview.chromium.org/402095 ), r=me.
BUG=23787
TEST=Popup window system menus (right click the icon in the upper left corner) should not have Save Page, Duplicate Tab, and a few other things anymore.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org, thomasvl@chromium.org
Review URL: http://codereview.chromium.org/464046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The blocked popup container isn't themed, but it will need similar treatment.
BUG=29101 (sort of)
TEST=use a dark theme, the close button should be visible on the findbar
Review URL: http://codereview.chromium.org/465049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should probably help some folks that have very sensitive DNS
resolution systems, by at least assuring that the initial navigation
can't get stuck behind congestion induced by DNS prefetching.
There is a tiny chance that this used to be a bit less problematic, as
the DNS prefetch system used to use its own threads, which gave
the navigational resolution a "racing" chance to be handled first (or
at least sooner). With the centralized use of the resolver, the code
(as noted by eroman) actually started the sub-resource resolution
(in all cases) before the navigational resolution. This change
explicitly forces the clearly better ordering.
It won't "fix" bug 3041... but it may help some users with more
recent comments in that bug.
bug=3041
r=eroman
Review URL: http://codereview.chromium.org/464023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are new enough.
BUG=28028
Review URL: http://codereview.chromium.org/463034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
usage. (which shows 0 for me)
BUG=none
TEST=Task manager shows the interesting stats by default.
Review URL: http://codereview.chromium.org/468017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied. Modifying the interface to make this an option bloated the CL too much. I may do this as a follow-up.
Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues.
R=brettw
BUG=25905
TEST=none
Review URL: http://codereview.chromium.org/414016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28021
TEST=Mouseover should work in Silverlight
Review URL: http://codereview.chromium.org/460057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29377
Review URL: http://codereview.chromium.org/464041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28624
TEST= links from the chrome://extensions page should include locale information.
Review URL: http://codereview.chromium.org/467019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Top line of incognito text box is now at the same point as the top line of the thumbnails in the regular NTP.
This means that themed NTP backgrounds look the way the theme designers planned them to (for example, you can see the "Chrome comet" in Star Gazing, and the pattern swirl in OP), and the regular and incognito NTPs have a unified look.
Review URL: http://codereview.chromium.org/463030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/28717
TEST=as in bug
Review URL: http://codereview.chromium.org/465064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutocompleteTextField routes messages to AutocompleteEditViewMac via a
Cocoa-style delegate and also a C++ observer class. The Cocoa-style
delegate has been gradually being pruned down in favor of the
observer, this CL completes the transformation.
The noted bugs occur because some bit of Cocoa code was sending
spurious delegate notifications. Since this code no longer depends on
those notifications, the spurious notifications are no longer a
problem for this case.
BUG=19116, 17803
TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox).
Review URL: http://codereview.chromium.org/391025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do-nothing make.
TEST=manual browser test, trybots
BUG=none
Review URL: http://codereview.chromium.org/464031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ReloadThenCancelBeforeUnload, & SingleBeforeUnloadAfterWindowClose as disabled so they compile but don't run on the Mac
TEST=tree stays green
BUG=29424
Review URL: http://codereview.chromium.org/464039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadItem::Finished is wrong, as it causes a duplicate notification to fire when a download is complete.
BUG=http://crbug.com/3417
TEST=bug does not regress
Review URL: http://codereview.chromium.org/464043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
script also.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/464042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Got permission to check this in on a closed tree,
since this won't affect the tree).
BUG=24821
TEST=Manual inspection on XP should reveal no truncation in first
two tabs of the Options panel for locales listed in bug (see CL
for --lang=xx values).
Review URL: http://codereview.chromium.org/460076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Increased IPC message header type from 16 bits to 32 bits so it can accomodate more message classes.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/399013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SavePageBrowserTest.SaveHTMLOnly on the Mac.
BUG=16322
TEST=waterfall stays green
Review URL: http://codereview.chromium.org/463031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21468,22520
For the explanation why these are data races,
see http://code.google.com/p/data-race-test/wiki/PopularDataRaces
Review URL: http://codereview.chromium.org/251027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required to support Native Client on 64-bit Windows.
Native Client will use a small 64-bit executable to load NaCl modules on 64-bit Windows. This 64-bit executable will use Chrome code, but some functionality has to be removed to minimize dependencies. This functionality may be enabled later if we decide that it is necessary.
TEST=None
BUG=28176
Review URL: http://codereview.chromium.org/371073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crash.
BUG=19866
TEST=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/465034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33822 0039d316-1c4b-4281-b951-d872f2087c98
|