summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* First step in abstracting extension api to common/shared "IDL" files ↵rafaelw@chromium.org2009-07-1612-174/+158
| | | | | | | | | | | | | | (jsonschema). In this step, All "normal" api calls and events (those that arrive or originate from the browser process) are routed through a single v8::Extension API Call ("StartRequest"). Additionally, internal string names for methods and events now match the js namespace (i.e. "RemoveTab" -> "tabs.remove"), in anticipation of having names be implicit from their api module & name in the api "IDL". TBR=aa,mpcomplete Review URL: http://codereview.chromium.org/149730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20910 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the Mac download shelf crash when clearing all downloads.paul@chromium.org2009-07-166-4/+60
| | | | | | | | | | | | | We also now automatically hide the shelf when the downloads are cleared. BUG=15855,15893 TEST=Download a few things, clear all downloads and the shelf will empty and hide. Review URL: http://codereview.chromium.org/149732 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20907 0039d316-1c4b-4281-b951-d872f2087c98
* Implement batch deletion in PasswordStoreMac.stuartmorgan@google.com2009-07-164-29/+132
| | | | | | | | | | | Add a new keychain helper search and refactor a bit to support the deletion. BUG=15070 TEST=Deleting passwords in Clear Browsing Data... will now work per the design doc (which means we clear passwords we created, and our metadata, but leave passwords created by other browsers alone). Review URL: http://codereview.chromium.org/149759 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20900 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix bookmark manager crash on startup introduced by r20565estade@chromium.org2009-07-162-9/+11
| | | | | | | TBR=munjal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20899 0039d316-1c4b-4281-b951-d872f2087c98
* Show progress Window when importing profile from First Run dialog.kuchhal@chromium.org2009-07-162-5/+23
| | | | | | Review URL: http://codereview.chromium.org/149766 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20898 0039d316-1c4b-4281-b951-d872f2087c98
* Select correct default folder in bookmark editor gtk.estade@chromium.org2009-07-161-1/+1
| | | | | | | | | BUG=none TEST=right click in a dropdown from a folder on the bookmark bar, select add, you should see that the correct folder is seleted in the bookmark editor tree view. Add a bookmark, it should show up in the right place. Review URL: http://codereview.chromium.org/149725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20897 0039d316-1c4b-4281-b951-d872f2087c98
* r20591 broke themed buttons. Fixing.avi@chromium.org2009-07-161-0/+9
| | | | | | | | | BUG=none TEST=install theme, check to see that buttons are themed. Review URL: http://codereview.chromium.org/155646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20896 0039d316-1c4b-4281-b951-d872f2087c98
* Change getLanguage to detectLanguage, and incorporate corresponding changes, ↵sidchat@google.com2009-07-1611-27/+28
| | | | | | | | | | in tab extensions. Also, use ISO language (e.g. "fr" instead of "French") as return language. BUG=none TEST=Enable extensions, add the given toolstrip as extension. For a page, the language of the page should be returned as ISO language (e.g., "french" as "fr") Review URL: http://codereview.chromium.org/149627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Valgrind Linux leakidanan@chromium.org2009-07-161-0/+5
| | | | | | Review URL: http://codereview.chromium.org/155645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20894 0039d316-1c4b-4281-b951-d872f2087c98
* Clear the window delegate in dealloc. Just being safe, I don't think this ↵pinkerton@chromium.org2009-07-161-0/+4
| | | | | | | | | | fixes any known issues or breaks anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/149702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20891 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Handle RTL layout when rendering the dragged tab.jhawkins@chromium.org2009-07-161-2/+5
| | | | | | | | BUG=none TEST=Drag a tab out of the browser in a RTL language. The tab should be rendered on the right side of the container. Review URL: http://codereview.chromium.org/155643 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20890 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Move icon parsing to UI thread.estade@chromium.org2009-07-162-14/+47
| | | | | | | | | | | | | Loading the data from disk remains on the background thread. This fix is pseudo-speculative. BUG=14746,14745,15244,15416 TEST=UI tests stop flaking out. Review URL: http://codereview.chromium.org/149764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20888 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist API change for allowing multiple rule matchesidanan@chromium.org2009-07-166-49/+265
| | | | | | | | | | | | | | | The findMatch function now returns a Match object which aggregates multiple entries into one, in case (which is expected to be common) that multiple rules match a given URL. Since the set of matches is highly dependent on the URL, the Match class replaces the old RequestData object to be added to URLRequests. BUG=16932 TEST=Blacklist* Review URL: http://codereview.chromium.org/149737 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK() in FindInPageNotificationObserver::Observe that gets ↵robertshield@google.com2009-07-161-7/+8
| | | | | | | | | | | triggered when FindInPage automation messages come in too quickly. BUG=Multiple AutomationMsg_Find messages sent rapidly to Chrome (without waiting for the synchronous responses) will trigger this DCHECK(). TEST=Send many AutomationMsg_Find messages very quickly without waiting for responses. Ensure no DCHECKing. Review URL: http://codereview.chromium.org/155644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20885 0039d316-1c4b-4281-b951-d872f2087c98
* Enable isolated worlds for content scripts.abarth@chromium.org2009-07-162-2/+1
| | | | | | | | | | R=aa TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch) BUG=12218 Review URL: http://codereview.chromium.org/155626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20883 0039d316-1c4b-4281-b951-d872f2087c98
* Call the DragSource* API on the RenderViewHost during a drag.pinkerton@chromium.org2009-07-161-2/+36
| | | | | | | | BUG=16909 TEST=Dragging thumbs on the NTP Review URL: http://codereview.chromium.org/155640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20881 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where we would not create ExtensionFunctionDispatcheraa@chromium.org2009-07-165-0/+30
| | | | | | | | | | instances for ExtensionDOMUI if RenderView was reused. BUG=16853 TEST=Added browser test Review URL: http://codereview.chromium.org/155592 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20880 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bulk password lookup API in PasswordStoreMac.stuartmorgan@google.com2009-07-164-76/+241
| | | | | | | | | | | | Refactor password merge to support the new search. Rename the fill-targeted search on the adapter for better clarity about the distinction between it and the new search. BUG=16485 TEST=none yet; UI doesn't exist. Review URL: http://codereview.chromium.org/149708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20877 0039d316-1c4b-4281-b951-d872f2087c98
* Print only the focused frame. This makes more sense than trying to print ↵sverrir@chromium.org2009-07-168-243/+89
| | | | | | | | | | | | | | all frames since most of the time you end up with ugly clipping and scroll bars on the printed page. This also fixes printing issue with print selection since we don't pick up the currently selected text if's not in the main frame. Also did some refactoring of the printing test in render_view_unittest. Mainly to reuse the new Image class. BUG=http://crbug.com/15250 TEST=Print pages with frames. Print selection when using multiple frames (one example in bug). Review URL: http://codereview.chromium.org/149644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20876 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make 'toggle node search' mode work.pfeldman@chromium.org2009-07-167-1/+47
| | | | | | | BUG=16824 Review URL: http://codereview.chromium.org/155639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a strict-aliasing issue in BlacklistStoreInput::ReadUInt.craig.schlenter@chromium.org2009-07-161-3/+3
| | | | | | Review URL: http://codereview.chromium.org/155622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20869 0039d316-1c4b-4281-b951-d872f2087c98
* Linux omnibox suggestions, only force LTR on URLs.deanm@chromium.org2009-07-161-5/+15
| | | | | | | | | | | I had previously forced LTR on all match contents. These are usually URLs, but in the case of history they are the search query. Use the classification to only for LTR on match contents that are actually URLs. Review URL: http://codereview.chromium.org/155636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20867 0039d316-1c4b-4281-b951-d872f2087c98
* Implement theme resetavi@chromium.org2009-07-162-13/+15
| | | | | | | | | BUG=none TEST=try clicking the "reset to default theme" button in the prefs; it'll reset things Review URL: http://codereview.chromium.org/155633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20866 0039d316-1c4b-4281-b951-d872f2087c98
* Set theme immediately on change.avi@chromium.org2009-07-161-10/+15
| | | | | | | | | BUG=none TEST=reset theme; watch window immediately retheme Review URL: http://codereview.chromium.org/149752 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20865 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-166-27/+49
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Initial commit with docked devtools window support on Linux.pfeldman@chromium.org2009-07-164-13/+55
| | | | | | Review URL: http://codereview.chromium.org/149675 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20861 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20855.darin@chromium.org2009-07-1614-216/+264
| | | | | | Review URL: http://codereview.chromium.org/149744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20859 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround bogus GCC warningdarin@chromium.org2009-07-161-3/+4
| | | | | | | | | | | | | | | | | | | | | | I had a single parameter IPC message handler, which took an enumeration parameter. For some reason, GCC thought it was possible for the enum value to be used uninitialized: cc1plus: warnings being treated as errors /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h: In member function 'virtual void RenderWidget::OnMessageReceived(const IPC::Message&)': /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: warning: 'p.Tuple1<WebKit::WebTextDirection>::a' may be used uninitialized in this function /b/slave/sub-rel-linux/build/src/chrome/common/ipc_message_utils.h:1244: note: 'p.Tuple1<WebKit::WebTextDirection>::a' was declared here scons: *** [/b/slave/sub-rel-linux/build/src/sconsbuild/Release/obj/chrome/renderer/render_widget.o] Error 1 I am able to avoid this warning by adding an explicit branch. BUG=none TEST=none TBR=mpcomplete Review URL: http://codereview.chromium.org/155624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20857 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20854.darin@chromium.org2009-07-1614-264/+216
| | | | | | Review URL: http://codereview.chromium.org/155621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20855 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebWidget from the WebKit API. This change also makesdarin@chromium.org2009-07-1614-216/+264
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of WebKitClient (replacing WebWidgetDelegate from glue). The ripple effects of this change are rather large, but most of the impact is mechanical. The more interesting changes include: 1- Removing the WebWidget parameter from WebWidgetClient methods. This didn't matter at all to RenderWidget or RenderView, but it did cause some changes to be made to TestWebViewDelegate. Now, it is not possible to share a delegate implementation for both the WebView and a popup menu, so I have a second instance of the delegate owned by TestShell for use with popup menus. 2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was getting to be a pretty large change, so I stopped short of deleting WindowOpenDisposition. That way the Chrome side can remain mostly unmodified. I then added a mapping function to convert from WebNavigationPolicy to WindowOpenDisposition. 3- The IME methods on WebWidget were renamed (reviewed separately by hbono), and there is now an enum to specify the composition command (WebCompositionCommand). 4- I added IPC serialization for WebCompositionCommand and WebTextDirection, which cleaned up some code that was just using ints in IPC messages. R=jam BUG=16234 TEST=none Review URL: http://codereview.chromium.org/149620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-1617-81/+215
| | | | | | | | | | | LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the default for what to do on startup be restore last session onsky@chromium.org2009-07-167-42/+123
| | | | | | | | | | | | | | chrome os as well as changing autocomplete edit/popup font sizes on chrome os. As suggested by Evan I've moved these options into chrome/browser/defaults.h so that we don't have a ton of #ifdefs every where. BUG=none TEST=none Review URL: http://codereview.chromium.org/155576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
* When the unhandled accelerator messages come back from the external host, we ↵ananta@chromium.org2009-07-161-6/+1
| | | | | | | | | | | | | | should only DefProc the message. The current implementaton calls TranslateMessage and DispatchMessage which causes the whole cycle to repeat. This is the chrome side of the fix for http://b/viewIssue?id=1981454 Bug=1981454 Review URL: http://codereview.chromium.org/155562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20850 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gtk download options section.mattm@chromium.org2009-07-161-2/+165
| | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/155617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20848 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reap the sandbox helper process.agl@chromium.org2009-07-161-0/+4
| | | | | | | | | | | TEST=start chrome with a SUID sandbox and check that no zombies persist. http://codereview.chromium.org/149734 (Reland of r20838. Hopefully with the reaping in the correct place this time.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20845 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: update outdated comments about sandboxing.agl@chromium.org2009-07-161-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20844 0039d316-1c4b-4281-b951-d872f2087c98
* Pass Linux crash guid to renderers.thestig@chromium.org2009-07-162-1/+14
| | | | | | Review URL: http://codereview.chromium.org/149736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20843 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Linux: reap the sandbox helper process."agl@chromium.org2009-07-161-9/+0
| | | | | | | This reverts commit r20838: it broke unit tests on Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20842 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: reap the sandbox helper process.agl@chromium.org2009-07-161-0/+9
| | | | | | | | | TEST=start chrome with a SUID sandbox and check that no zombies persist. http://codereview.chromium.org/149734 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20838 0039d316-1c4b-4281-b951-d872f2087c98
* Align custom background tab images correctly.glen@chromium.org2009-07-161-3/+9
| | | | | | | | | BUG=16879 TEST=Install a theme with a background tab image and verify that the image is aligned to the top of the tab, and not to the top of the frame. Review URL: http://codereview.chromium.org/149727 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20837 0039d316-1c4b-4281-b951-d872f2087c98
* Adding callback support to media filter Initialize() and Seek().scherkus@chromium.org2009-07-162-14/+28
| | | | | | | | | | | | | Also includes unit tests for AudioRendererBase and VideoRendererBase. I had to rollback my first attempt at this change. Original review: http://codereview.chromium.org/155469 BUG=16014,16031 TEST=media_unittests, layout tests Review URL: http://codereview.chromium.org/155608 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20836 0039d316-1c4b-4281-b951-d872f2087c98
* GCC > 4.2 fix: check return values for freadagl@chromium.org2009-07-161-4/+5
| | | | | | | http://codereview.chromium.org/149731 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20833 0039d316-1c4b-4281-b951-d872f2087c98
* GetThemeProvider error in DownloadItemView. Just remove the offending line ↵glen@chromium.org2009-07-161-2/+0
| | | | | | | | | | | for now. BUG=16882 TEST=Reliability green TBR=agl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20829 0039d316-1c4b-4281-b951-d872f2087c98
* Disable running layout tests worker-constructor.html and ↵jianli@chromium.org2009-07-161-3/+2
| | | | | | | | | | | worker-redirect.html in UI test frameworker in preparation to checkin the fix for WebKit bug 25151 (https://bugs.webkit.org/show_bug.cgi?id=25151). I will reenable the tests once the corresponding V8 change is landed. BUG=none TEST=none Review URL: http://codereview.chromium.org/155544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20827 0039d316-1c4b-4281-b951-d872f2087c98
* Fix web contents drag corner case.estade@chromium.org2009-07-161-1/+5
| | | | | | | | | | | We heuristically use the last mouse down event the renderer got as the event that 'started' the drag, which is not entirely accurate. Since the context menu grabs input, we were in a situation where the last mouse down was a right click, so it wanted the drag to end by releasing the right mouse button. BUG=16793 TEST=see bug Review URL: http://codereview.chromium.org/155604 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20825 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Tint throbbers like we tint all other buttons in the interface.erg@google.com2009-07-159-51/+106
| | | | | | | | | | | | | | Relanding with fixes for unit tests. Run through trybot this time... http://crbug.com/13967 Original Review URL: http://codereview.chromium.org/155588 TBR=estade Review URL: http://codereview.chromium.org/155601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20809 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel icon load requests when we are getting shutdown.estade@chromium.org2009-07-151-0/+1
| | | | | | | | | | | | | Hopefully this will fix the download test flakiness. I was able to reproduce the crash manually by just mass-clicking on the same download link many times (thanks to DotA for improving my APM). With this patch I am no longer able to repro. BUG=14746,14745,15244,15416 TEST=download tests stop flaking out Review URL: http://codereview.chromium.org/149712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20807 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux crash death signal message constant sized.thestig@chromium.org2009-07-153-31/+48
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20803 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTK Themes: Tint throbbers like we tint all other buttons in the ↵erg@google.com2009-07-158-79/+42
| | | | | | | | | | | | interface." This reverts commit 3dfa509662e99282b5212490bfe19b32da357741 (r20799). TBR=estade Review URL: http://codereview.chromium.org/155598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20802 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move hardcoded paths to GYP variables.agl@chromium.org2009-07-152-9/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the hardcoded paths for the sandbox binary location and the chrome binary location for the sandbox. Instead, you can now set GYP variables for these things. Indeed, you have to set a GYP variable in order to use the sandbox now. GYP variables can be set on the command line, if you run gyp.py directly, with -D key=value. Or you can export GYP_DEFINES="key=value key2=value2". Now, in order to use the sandbox you should set: linux_sandbox_path=/opt/google/chrome/chrome-sandbox linux_sandbox_chrome_path=/opt/google/chrome/chrome (changing the paths as needed, of course). See the comments in build/common.gypi For development see http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment Because developers need to setup a special sandbox binary. http://codereview.chromium.org/149689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20801 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 01:16:18 +0000