| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
aren't checked out on the bots. We need to figure out how to deal with this
since we don't want to keep expectations downstream if we can avoid it.
BUG=none
R=none
TEST=bots stay green
Review URL: http://codereview.chromium.org/1253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots stay green
R=eroman@chromium.org
Review URL: http://codereview.chromium.org/1214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a conversation with Eric, we're not worried about attacker pages loading
down the local machine or network (because such pages would themselves be
candidates for being flagged).
The concern is users with slow network connections, or random network / server
jitter.
BUG=36774
TEST=NONE
Review URL: http://codereview.chromium.org/1242001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9606
TEST=Inspect32 has accessible names for those components.
Review URL: http://codereview.chromium.org/1110013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loading and extracting resources from the Chrome locale DLLs.
Add the Chrome Frame resource strings to the Chrome .grds so they get built directly into the Chrome locale dlls.
There is one remaining todo here, which is to load the dialog template into a grd + rc somewhere (probably in generated_resources.grd) and then get CF to load dialog templates from a different module. Will do that in another patch.
BUG=24305
TEST=Chrome Frame when loaded on machines whose locales are not US English will display strings appropriate to those locales.
Review URL: http://codereview.chromium.org/1240001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set of parens were missing, so the "not" operator only applied to the GetTabById() return value.
BUG=34778
Review URL: http://codereview.chromium.org/1238001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
causing the library to appear already loaded in a failed state.
Review URL: http://codereview.chromium.org/1251001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first two tests are from rohitbm and the rest from krisrs.
testUnicodeStrings -- test bookmarks with unicode strings
testSizes -- test bookmarks with different sized strings
testAddingBookmarksToBarAndOther - add bookmarks to diff locations
testAddingFoldersToBarAndOther -- add bookmark groups to diff locations
testAddingFoldersWithChildrenToBarAndOther -- add bookmarks and groups to
different locations
Review URL: http://codereview.chromium.org/1191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=38610
Review URL: http://codereview.chromium.org/1247001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last_sync_timestamp from the new_timestamp only, never from per-entry
timestamps. Use what the server sends us to know whether or not there
are more updates to fetch. Eliminate some unnecessarily complicated
logic having to do with the # of updates returned -- that's always a red
herring; with server-side filtering, it is indeed possible for 0 updates
to be returned along with a new timestamp.
BUG=37373
TEST=manual testing of 2 browser sync; unit tests.
Review URL: http://codereview.chromium.org/1161006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.
Review URL: http://codereview.chromium.org/1085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BMM was originally only checking for the control key on non-mac platforms.
BUG=39085
TEST=Select some non-contiguous bookmarks and copy and paste them, without the
elements in between
Review URL: http://codereview.chromium.org/1225001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39013
TEST=pyautolib bookmark_bar.py script will now work on Linux
Review URL: http://codereview.chromium.org/1227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Tested by loading on device and clicking fullscreen button. (needs most recent codebase)
Review URL: http://codereview.chromium.org/1034002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs.
BUG=chromium-os:2026
TEST=none
Review URL: http://codereview.chromium.org/1142005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications during the port to mac & linux and making behavior more consistent.
BUG=34826
TEST=notifications on each platform.
Review URL: http://codereview.chromium.org/1055005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the translation server without the user consent).
Also added unit-tests for prefs.
BUG=38107
TEST=Visit a page that triggers the translate infobar. Translate the
page. Select "Always translate <lang1> to <lang2>".
Open a page in lang1. The page should automatically be translated
to lang2.
Open an incognito window. Navigate to a page in lang1, the page
should not automcatically be translated, an infobar should ask
if the user wants to translate the page.
Review URL: http://codereview.chromium.org/1184001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1134009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Extension disabled infobar was being shown at startup.
- Crashed extensions were persisted as unpacked extensions, regardless of how
they were installed.
BUG=30116
BUG=38856
Review URL: http://codereview.chromium.org/1157005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by sergeyu@chromium.org
BUG=28100
TEST=Ran media_unittests
Review URL: http://codereview.chromium.org/1226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24477
TEST=manual
Review URL: http://codereview.chromium.org/1170001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_dll.gypi.
BUG=39083
TEST=Clobber build and try to open the tab-based bookmark manager. Don't get a 404.
Review URL: http://codereview.chromium.org/1222001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
type configuration. DTM::Start() has been replaced with DTM::Configure(). Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished.
I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process.
Review URL: http://codereview.chromium.org/1128012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Check that the app launcher is displayed correctly on ChromeOS
and Windows (when using the --app-launcher-new-tab)
Review URL: http://codereview.chromium.org/1171002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=38945
TEST=reloaded Pepper 3D plugins repeatedly
NOTE: encountered unrelated problems while testing. These changes
should be stress tested with CA plugins.
Review URL: http://codereview.chromium.org/1110011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are enabled.
Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936
Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/1205001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--gpu-startup-dialog command line option to allow debugging of GPU
process.
BUG=none
TEST=none (tested manually in development workspace)
Review URL: http://codereview.chromium.org/1095005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/38002
TEST=as in bug
Review URL: http://codereview.chromium.org/1105010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nick
Review URL: http://codereview.chromium.org/1192001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FLAKY :(
TBR=skrul
BUG=39070
Review URL: http://codereview.chromium.org/1189001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginHandler class. As pointed out by erg, it would be cleaner to use a
separate controller class, but this simple refactor should make that easier.
Originally submitted as 41739, however that patch had to be reverted because
I had accidentally changed an if (!...) { NOTREACHED(); } into a DCHECK(...) in
the LoginHandler ctor. That is fixed now.
BUG=14909
TEST=ui_tests --gtest_filter=LoginPromptTest*
Review URL: http://codereview.chromium.org/995004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936
Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1180001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31292
TEST=bookmark_bar_view_test and I also ran the test case. NTP and Bookmark manager also works.
Review URL: http://codereview.chromium.org/1084014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=39057
Review URL: http://codereview.chromium.org/1074010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37421
Review URL: http://codereview.chromium.org/1088007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes our Mac wmode hack--which prevents Flash from using "accelerated" QuickDraw mode, which is incredibly slow for us, but also prevents Flash 10.1 from using Core Animation in the same cases--conditional based on having both support for Core Animation mode in both Flash and Chromium, and on having a flag.
Once we are confident that there are no regressions preventing us from allowing Core Animation by default, the flag will be removed.
BUG=38932
TEST=Run with --enable-flash-core-animation and the current Flash 10.1 beta on 10.6; sites like YouTube should have negligable CPU usage.
Review URL: http://codereview.chromium.org/1115010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this in a
callback so that I can identify where the image is coming from.
[Reverter's note: There is nothing wrong with this CL per se, except that I'm going to
make it obsolete in my next checkin, so since noone is relying on this change yet, it
is better to revert it than to have a painful merge]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1167004
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1077011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL better maps C++ UITestSuite to python suite and C++ UITestBase
to python testcase. All one-time initializations go in the suite while
testcases are re-entrant now -- this is what fixes the crash.
Also:
- Cmdline flags to pyauto script (verbose, wait for attaching to debugger)
- Establish the setup of sys.path, so that it's setup correctly and tests
don't have to worry about it
- Create facitlites for PYAUTO_TESTS files inside script dirs (say
chrome/test/functional) which defines the tests to run.
- Restructure such that pyauto scripts can be run standalone as well as
using the pyauto.py script (like unittest.py). For example, a test could be
fired in any of the below ways:
# Run tests in a module ('bookmarks')
python pyauto_functional.py bookmarks
# Run tests in a test case ('bookmarks.BookmarksTest')
python pyauto_functional.py bookmarks.BookmarksTest
# Run a test ('bookmarks.BookmarksTest.testBasics')
python pyauto_functional.py bookmarks.BookmarksTest.testBasics
# Run directly from the test script
python bookmarks.py
python bookmarks.py bookmarks
python bookmarks.py bookmarks.BookmarksTest
python bookmarks.py bookmarks.BookmarksTest.testBasics
BUG=32292
TEST=python chrome/test/functional/bookmarks.py
Review URL: http://codereview.chromium.org/1126003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/1173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38522
TBR=maruel
Review URL: http://codereview.chromium.org/1081015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1092008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11246
TEST=browser_tests.exe --gtest_filter=Geol*
Review URL: http://codereview.chromium.org/1127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is the follow up to http://codereview.chromium.org/1037006 which added it on windows, and http://codereview.chromium.org/1127001 which added it to Mac.
BUG=11246
TEST=run browser with --enable-geolocation, open maps.google.com and click my location.
Review URL: http://codereview.chromium.org/1081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Revert "Update fast/workers/worker-script-error.html expectations in Chromium. Expected results of this test need update due to WebKit change http://trac.webkit.org/changeset/56329 and reenanle WorkerTest.WorkerScriptError"
TBR=pfeldman
Review URL: http://codereview.chromium.org/1174001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42330 0039d316-1c4b-4281-b951-d872f2087c98
|