| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Also did a bunch of cleanup of ExtensionMessageService. I converted it to
primarily UI-thread habitation, with one function that needs to be on the IO
thread so it can handle a synchronous IPC message.
TEST=N/A
Review URL: http://codereview.chromium.org/99261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r15025. Calling exit() on another thread meant
V8's destructor functions got called while another thread was still in
V8.
I might not have a better plan, but it's making a mess of the valgrind
builders so I'm reverting for now with an eye to landing again next
week.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
When the code was originally written, GetModel() was not required by AutocompletePopupView, now it's easy enough to use that instead.
Review URL: http://codereview.chromium.org/99278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initial files list for what to archive.
Review URL: http://codereview.chromium.org/100273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rest of the WebKit API, which is single threaded. Also a bunch of small fixes to make layout tests pass: the dll was being unloaded while its functions were still queued to be dispatched, and a string allocated in the dll was being GC'd in test shell.
BUG=11011
Review URL: http://codereview.chromium.org/102005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
http://crbug.com/9049
Review URL: http://codereview.chromium.org/100267
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this patch there's totally 5 measurements for audio IPC
1. Total round trip time
browser request a packet until it gets a packet
2. Browser receive latency
time for a packet to arrive browser from renderer
3. Browser process time
time for browser to process the packet
4. Renderer receive latency
time for a packet to arrive renderer from browser
5. Renderer process time
process time on a packet in renderer
They are all using low resolution timer with accuracy of ~1-15ms.
Since we have a budget of ~200ms (for now) without clicks, I think
the accuracy shouldn't be a big problem, unless for case 1 where
we want to measure exact amount of clicks.
Review URL: http://codereview.chromium.org/99213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be merged with 2.0 (172) branch.
BUG=http://crbug.com/11208
TBR=mal
Review URL: http://codereview.chromium.org/99260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically:
1) In webkit.gyp and test_shell.gyp, convert the rules to actions because of different grd outputs (localized grd files have locale in the .pak filename).
2) In chrome, make two targets each with a custom rule. One target is for localized resources, the other for non-localized resources. This is like the current windows build.
Review URL: http://codereview.chromium.org/100174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous and robust.
Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.
Review URL: http://codereview.chromium.org/99268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a bug where you would cycle through a background tab's links even after
selecting a different tab.
TEST=Open Chromium. Open a new tab. Press tab and verify that we are correctly
cycling through the links in the new tab.
Review URL: http://codereview.chromium.org/100233
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/10957
TEST=Verify that the AddSearchProvider logic still works. This dates back to an old bug http://b/1069781
Review URL: http://codereview.chromium.org/99168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
when a renderer is listening to an event.
Review URL: http://codereview.chromium.org/100214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* remove chrome\browser\views\find_bar_win_unittest.cc
* add Windows-only test targets:
** interactive_ui_tests
** plugin_tests
** selenium_tests
* Move from unit_tests to test_support_common:
** test/in_process_browser_test.{cc,h}
** test/ui_test_utils.{cc,h}
Review URL: http://codereview.chromium.org/100168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Calculate from the actual text width, not the allocated text width.
Review URL: http://codereview.chromium.org/99222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=thestig
BUG=10681
TEST=Start a long download. Try to quit the browser. Notice the spiffy title on the dialog box.
Review URL: http://codereview.chromium.org/100241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After discussing with various people, I think we're going to do this
in the short term at least. Currently we're calling into GTK from the
IO thread and Bad Things Happen when one does that.
We would like to write an Xlib, fully asynchronous system for dealing
with the clipboard (and to get the clipboard stuff out of base!). That
would let us avoid sending the selection over the IPC channel each
time it updates too.
However, that's going to be a lot of work and we have crashing
browsers happening /right now/. Also, Evan thinks that maybe we don't
have the deadlock situation on Linux that we do on Windows with
terminating sync requests from the renderer on the UI thread.
http://codereview.chromium.org/100238
BUG=9865
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
have %22 instead of \" (to match change in GURL canonicalization).
BUG=11142
TBR=evan
Review URL: http://codereview.chromium.org/100148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On POSIX one can install an unload handler which loops forever and
leave behind a renderer process which eats 100% CPU forever.
This is because the terminate signals (ViewMsg_ShouldClose and the
error from the IPC channel) are routed to the main message loop but
never processes (because that message loop is stuck in V8).
One could make the browser SIGKILL the renderers, but that leaves open
a large window where a browser failure (or a user, manually
terminating the browser because "it's stuck") will leave behind a
process eating all the CPU.
On Windows we don't have this issue because all the processes are in a
job so when the parent dies, all the children are killed too.
http://codereview.chromium.org/100222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the machine
to succeed. Disabling the MediaPlayerNew test as an ASSERT in Webkit is firing causing the
renderer to crash. Will debug this more and log a bug.
TBR=nsylvain
Review URL: http://codereview.chromium.org/100236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/102020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
site to another. To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen.
BUG=11157
TEST=Navigate from one HTTPS site to another and watch the location bar carefully. It shouln't flash anymore.
Review URL: http://codereview.chromium.org/99247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jar
Review URL: http://codereview.chromium.org/99020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Code coverage now works for Linux. Unit tests to run passed from
project to coverage_posix.py so deps are correct.
Review URL: http://codereview.chromium.org/100189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Add a dependency to the rule that copies the files.
2) Change the directories to have lower case names. This doesn't matter
on windows which is case insensitive and where some directories are already lower case (e.g., themes and locales). Mac will probably have to add
some gyp code to move the files to the right place in the bundle.
Review URL: http://codereview.chromium.org/100223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Most of the new code concerns shaping the widget to be non-rectangular.
Also, sprinkle some "const" qualifiers on NineBox functions.
Review URL: http://codereview.chromium.org/100224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Bookmark codec now takes in a ctor argument persist_ids
- If it's true, it will serialize IDs of bookmarks when encoding, and
deserialize already serialized IDs (if present) when decoding.
- During decoding, unique-ify the IDs if they are not unique.
- Add unit tests for all new code.
Coming up in a separate changelist:
- Move ID generation logic to bookmark model, and make it non-static.
Review URL: http://codereview.chromium.org/99217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Activex shim for media player along with their associated extensions.
This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source
URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime
and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the
mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin
from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message.
With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player
handling it in Chrome.
I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it.
Added plugin tests for the mp3 and mpe extensions.
Bug=11054
Review URL: http://codereview.chromium.org/100180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
overlap between tabs.
TEST=Open a few tabs, try clicking on the right half of the close button that's
to the left of the selected tab.
Review URL: http://codereview.chromium.org/99225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make_default_browser_for_user). make_default_browser_for_user will make Chrome default on the first run of Chrome instead of installer doing it. This will allow Chrome to import user profile data from current default browser, before making Chrome default.
BUG=9708,10912
Review URL: http://codereview.chromium.org/99165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7178
Review URL: http://codereview.chromium.org/99229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BrowserView from restoring focus to the tab if the window that contains it isn't visible. This prevents blur events from being fired incorrectly.
http://crbug.com/7991
Review URL: http://codereview.chromium.org/99248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Renderers should not use COM
TEST= existing tests suffice
BUG= 11205
Review URL: http://codereview.chromium.org/99230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/99161
TBR=hamami
Review URL: http://codereview.chromium.org/99228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11200
R=erikkay
Review URL: http://codereview.chromium.org/100213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This needs to be merged with 2.0 (172.x) branch.
TBR=mal
BUG=11198
Review URL: http://codereview.chromium.org/100218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Xiaomei, I just applied the code that you suggested in your email and it worked.
Review URL: http://codereview.chromium.org/99237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11190
Review URL: http://codereview.chromium.org/99243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= 11175
R= sidchat
TEST= See bug. Also check that the dictionary under Chrome\Application\Dictionaries
is lt-lt-1-3.bdic.
Review URL: http://codereview.chromium.org/99241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cleaned up properly in the app controller. Make the prefs window controller the window's delegate so it gets close notifications.
Review URL: http://codereview.chromium.org/99238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
nib to know the FileOwner is a NSWindowController and hook them together.
Review URL: http://codereview.chromium.org/102015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14958 0039d316-1c4b-4281-b951-d872f2087c98
|