summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Finish release (opt) builds on Windows, including the parallelsgk@google.com2008-11-203-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | build\*.scons structure (mirroring build\*.vsprops files): * Use env.ApplySConscript() instead of env.SConscript with a hand-crafted dictionary defining 'env'. * Move various CPPPATH, CCFLAGS, CPPDEFINES, LIBS and LIBPATH definitions from build/SConscript.main and target-specific *.scons files into the build\*.scons files that mirror the existing build\*.vsprops hierarchy. * Use the new build\{debug,release}.scons files to update the windows_dbg and windows_opt construction environments. * Mirror current support for CHROME_BUILD_TYPE and CHROMIUM_BUILD external environment variables. * Remove hard-coded /TP options. * Massage $CXXFLAGS to remove $CCFLAGS, avoiding duplication of options on command lines. Handle the ripple effect in $PCHCOM by adding $CCFLAGS back to that command line. * Delete hammer's default settings of {CC,LINK}FLAGS_{DEBUG,OPTIMIZED} so they don't pollute our construction environments. * Update chrome config to link against v8 for opt, v8_g for dbg. * Get rid of fragile by-hand order of using_net.scons before other using_*.scons files. We're now using --start-group and --end-group on Linux to deal with dependency cycles in libraries. Review URL: http://codereview.chromium.org/11478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5741 0039d316-1c4b-4281-b951-d872f2087c98
* Make the net resource interface use StringPiece instead of std::string. ↵deanm@chromium.org2008-11-201-3/+3
| | | | | | | | This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around. Review URL: http://codereview.chromium.org/11506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5740 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make the net resource interface use StringPiece instead oftc@google.com2008-11-201-3/+3
| | | | | | | | | | | | | | | std::string. This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around." This reverts commit r5735. TBR=deanm Review URL: http://codereview.chromium.org/11298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5736 0039d316-1c4b-4281-b951-d872f2087c98
* Make the net resource interface use StringPiece instead of std::string. ↵deanm@chromium.org2008-11-201-3/+3
| | | | | | | | This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around. Review URL: http://codereview.chromium.org/11296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5735 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor some windows specific initialization code intotc@google.com2008-11-202-31/+2
| | | | | | | | | | test_shell_win.cc. The sln change is to make test_shell_tests depend on breakpad. Review URL: http://codereview.chromium.org/11288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5734 0039d316-1c4b-4281-b951-d872f2087c98
* Don't execute a NOTREACHED in TabStrip::DestroyDraggedSourceTab if thesky@google.com2008-11-201-1/+2
| | | | | | | | | | | | | | | tab strip contains the tab but the model is closing all. Normally the end of the animation removes the tab, but if we're closing all tabs the animation isn't run. I was hitting this when I have more than one window open and drag a tab in a window with a single tab and release it. BUG=none TEST=none Review URL: http://codereview.chromium.org/11294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5733 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the generated html for directory listings. This will allow the net ↵deanm@chromium.org2008-11-191-7/+26
| | | | | | | | resource provider system to return direct pointers into the resources instead of copying. Review URL: http://codereview.chromium.org/11501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5729 0039d316-1c4b-4281-b951-d872f2087c98
* Use resource strings rather than hard-coded strings for namespatrick@chromium.org2008-11-191-15/+21
| | | | | | | in accessibility tests. Review URL: http://codereview.chromium.org/11292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5728 0039d316-1c4b-4281-b951-d872f2087c98
* Move creation of 'open with' registry keys to installer. We should place ↵kuchhal@chromium.org2008-11-196-101/+36
| | | | | | | | | | nice and not create these keys on every Chrome start just in case user wants a customized open with list. So now we only create these keys at installation or when user choses to make Chrome default browser. Also we clean them up on uninstall. BUG=1190855 Review URL: http://codereview.chromium.org/11491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5726 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-195-43/+124
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this change: http://codereview.chromium.org/10967/showben@chromium.org2008-11-1919-71/+44
| | | | | | | | | Now with two improvements: - no longer create WebContentsViews as WS_VISIBLE, to prevent them from showing up in the taskbar - make sure overridden CreateView in NativeUIContents and StatusView have the correct signature. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5723 0039d316-1c4b-4281-b951-d872f2087c98
* sort chrome.sln. no functional changes, I just rantc@google.com2008-11-191-1713/+1713
| | | | | | | | | | the sort_sln.py script. TBR=brettw Review URL: http://codereview.chromium.org/11291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5719 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome\browser\frame_util.cc from the SCons build.sgk@google.com2008-11-191-1/+0
| | | | | | Review URL: http://codereview.chromium.org/11485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5709 0039d316-1c4b-4281-b951-d872f2087c98
* Send the chrome.dll base address in the UMA initial log. This will help us ↵deanm@chromium.org2008-11-191-0/+9
| | | | | | | | detect address space collisions where chrome.dll is needing to be rebased, and it will help us choose a better base address. Review URL: http://codereview.chromium.org/6540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5705 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce httponly on cookies coming from the renderer. This prevents ↵deanm@chromium.org2008-11-191-1/+2
| | | | | | | | | javascript from setting a new httponly cookie, and more importantly from overwriting httponly cookies. Patch from Marius Schilder. Review URL: http://codereview.chromium.org/11275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5700 0039d316-1c4b-4281-b951-d872f2087c98
* Move PlatformCanvas and PlatformDevice from base/gfx to webkit/port. I left ↵brettw@google.com2008-11-191-1969/+1970
| | | | | | | | | | header files in the original locations that include the ones in the new location so I don't have to change all the includes in Chrome at once. These will be removed later. I kept the names, indenting, and the namespaces the same for now. I will also be cleaning this up in separate passes. Review URL: http://codereview.chromium.org/11244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5690 0039d316-1c4b-4281-b951-d872f2087c98
* Checkin of unmodified version of Mach IPC utility class.jeremy@chromium.org2008-11-192-0/+544
| | | | | | | | | This is the same version of the class present in the Gears tree, modifications are only the file & header guard names and the license. Review URL: http://codereview.chromium.org/11278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5687 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting for developer0420@gmail.comjoshia@google.com2008-11-192-7/+53
| | | | | | | | | | | | | | | | | | | | | The LPITEMIDLIST returned from SHBrowseForFolder might not get released if SHGetPathFromIDList fails Added in the comment changes Added GetDisplayNameOf for getting selection, using old way if STRRET Structure type does not equal STRRET_WSTR as I was unable to get complete code coverage. Added BrowseCallbackProc and listen to MSG so that we can highlight existing value Added in the comment changes ( changed to smart pointer for managing COM interface pointers.) Review URL: http://codereview.chromium.org/11481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5686 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code to using FilePath.evanm@google.com2008-11-191-2/+3
| | | | | | | Review URL: http://codereview.chromium.org/11252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5679 0039d316-1c4b-4281-b951-d872f2087c98
* Change by Alex Mendes da Costa <alexmdac@google.com>beng@google.com2008-11-193-4/+28
| | | | | | | | | | | | Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history. BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293) Review URL: http://codereview.chromium.org/10743 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5674 0039d316-1c4b-4281-b951-d872f2087c98
* Land this change again now I've fixed the crash.ben@chromium.org2008-11-1935-268/+196
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cf_html from webdropdata.h. This is windowstc@google.com2008-11-195-19/+50
| | | | | | | | | | | | | | | | | | specific code so we should handle it before we get to webkit. CF_HTML needs the source URL to resolve relative URLs so I added that to the format and plumb it through from webcore. I also did some small refactoring so we only have one implementation of converting to/from CF_HTML and regular markup. We can tweak these converters (and add unit tests) in follow up changes. Review URL: http://codereview.chromium.org/11247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5662 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes trees on Hebrew locales. The current code was problematicsky@google.com2008-11-191-2/+26
| | | | | | | | | | | | because SetWorldTransform and a graphics mode of COMPATIBLE don't work together. Instead we must use SetViewportOrgEx. BUG=4515 TEST=see bug Review URL: http://codereview.chromium.org/11253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5654 0039d316-1c4b-4281-b951-d872f2087c98
* put back this change now chromebot has had a chance to runben@chromium.org2008-11-191-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5653 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser window is visible, even if the startup info says that ↵ben@chromium.org2008-11-191-1/+3
| | | | | | | | | it should be hidden. This fixes the problem of invisible browser window when launched from bash. http://crbug.com/4438 Review URL: http://codereview.chromium.org/11454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5652 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that occurs during the browser shutdown process.paulg@google.com2008-11-181-8/+15
| | | | | | | | | | | | | | | | | It is possible that during the shutdown process, the database thread posts tasks back to the IO thread which result in calls to the SafeBrowsing protocol manager object. This object will have been deleted by the time the posted task runs, resulting in a crash. This change checks the enabled_ flag (which is set to false when the shutdown starts) for all tasks posted to the IO thread to protect against access to deleted objects. BUG = http://crbug.com/4531 Review URL: http://codereview.chromium.org/11245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5644 0039d316-1c4b-4281-b951-d872f2087c98
* Add "generated resources" and "localized string" dependenciesnsylvain@chromium.org2008-11-181-278/+276
| | | | | | | on all the new locales. Review URL: http://codereview.chromium.org/11804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5642 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2008-11-181-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5638 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back a bunch of changes to tab dragging that seem to not have helped ↵ben@chromium.org2008-11-186-159/+79
| | | | | | | | | | | reduce the crashiness any :-/ r5335 dragged_tab_controller.cc (delegate NULL setting) r5124 changes to make AutomationProvider::WindowSimulateDrag use SendInput instead of SendMessage r5117 dragged_tab_controller.cc (delegate NULL setting) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5636 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 5607 because it caused a base_unittest failure.maruel@chromium.org2008-11-186-142/+2
| | | | | | Review URL: http://codereview.chromium.org/11234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5608 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-186-2/+142
| | | | | | | Add more DCHECKs. Review URL: http://codereview.chromium.org/10957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5607 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome.sln to build 8 new Indic languages.mal@chromium.org2008-11-181-0/+136
| | | | | | | | | | | | | This adds the terms_xx.html files and the xx.vcproj files to the solution and makes mini_installer depend on them. This only gets the locale DLLs built. Actually being able to use them in the product is another issue (http://crbug.com/4473). R= tony Review URL: http://codereview.chromium.org/10776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5604 0039d316-1c4b-4281-b951-d872f2087c98
* Add .vcproj to build 8 new Indic language dlls.mal@chromium.org2008-11-1817-0/+1856
| | | | | | | | | | | | | | | | This just adds the .vcproj files and the locale_settings.rc files they need. I also updated SConscript. I'll make the changes to chrome.sln and check it in after this is checked in. Just checking these in should not affect the build until chrome.sln is updated. R= tony Review URL: http://codereview.chromium.org/10968 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5603 0039d316-1c4b-4281-b951-d872f2087c98
* Add about:terms support for 8 indic languages.mal@chromium.org2008-11-188-0/+1056
| | | | | | | | | | | | | This rev just adds the _terms files. These are copied from the en-US version. I don't know how these get generated, nor whether translations for the terms exist for these languages. R=glen Review URL: http://codereview.chromium.org/10775 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5601 0039d316-1c4b-4281-b951-d872f2087c98
* Add the flag "--extra-chrome-flags" for all UI tests.ericroman@google.com2008-11-181-0/+8
| | | | | | | | | | | | | This is used to plumb though extra flags to pass to chrome.exe. For example, to run reliability tests with WinHTTP stack: reliability_tests.exe --extra-chrome-flags="--winhttp" Note that no attempt is made to avoid duplicate parameters. Review URL: http://codereview.chromium.org/11436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5599 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 5596 because it broke the buildnsylvain@chromium.org2008-11-1835-192/+268
| | | | | | Review URL: http://codereview.chromium.org/11439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5598 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a friend test declaration.paulg@google.com2008-11-181-1/+2
| | | | | | Review URL: http://codereview.chromium.org/11431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5597 0039d316-1c4b-4281-b951-d872f2087c98
* Last couple of bits of new-frame related cleanup:ben@chromium.org2008-11-1835-268/+192
| | | | | | | | | | | | | - Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND) - Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon). - Replace BrowserType class with an enum on Browser. http://crbug.com/2320 http://crbug.com/3363 Review URL: http://codereview.chromium.org/10786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5596 0039d316-1c4b-4281-b951-d872f2087c98
* At Yahoo!'s request, add a "fr=crmas" identifier to their prepopulate ↵pkasting@chromium.org2008-11-171-69/+103
| | | | | | | | | entries.Also fix up some of the suggest URLs to be more consistent. BUG=4102 Review URL: http://codereview.chromium.org/11214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5577 0039d316-1c4b-4281-b951-d872f2087c98
* It's possible for GetOleInterface() to return NULL. Degrade gracefully in ↵pkasting@chromium.org2008-11-172-3/+10
| | | | | | | | | this case. BUG=3906 Review URL: http://codereview.chromium.org/11213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5576 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing possible crash in ModalHTMLDialogDelegate. It'ssky@google.com2008-11-172-9/+20
| | | | | | | | | | | | | | | | possible to get more than one NOTIFY_WEB_CONTENTS_DISCONNECTED. The first time ModalHTMLDialogDelegate gets a NOTIFY_WEB_CONTENTS_DISCONNECTED it sets the contents_ to NULL. This is problematic because the destructor than removes the observer using a source of NULL. Instead we should remove the observer immediately, then NULL out the contents_. BUG=4129 TEST=covered by QEMU Review URL: http://codereview.chromium.org/11413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5575 0039d316-1c4b-4281-b951-d872f2087c98
* Changes about view to explicitly set the background to white. This waysky@google.com2008-11-171-0/+1
| | | | | | | | | | | | even though the field is disabled you get a white background. BUG=4511 TEST=Bring up about chrome and make sure background of version string is white. Review URL: http://codereview.chromium.org/11421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5574 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback! Now with 25% more HWND.ben@chromium.org2008-11-1715-35/+63
| | | | | | :-/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential race with cookie requests between renderer and gears.mpcomplete@google.com2008-11-171-2/+18
| | | | | | | BUG=1487502 Review URL: http://codereview.chromium.org/10960 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5565 0039d316-1c4b-4281-b951-d872f2087c98
* Makes opening a bookmark activate the window.sky@google.com2008-11-171-2/+4
| | | | | | | | | BUG=4447 TEST=see bug Review URL: http://codereview.chromium.org/10765 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5560 0039d316-1c4b-4281-b951-d872f2087c98
* A workaround fix for Issue 343 "Chinese Sogou input method lose first ↵hbono@chromium.org2008-11-173-3/+12
| | | | | | | | | | | | | | initial letter". This issue is caused by our IME code that does not filter out focus events raised by an IME function of WebKit, WebCore::Editor::setComposition(). Its details are listed below: 1. WebKit sometimes creates a WebCore::EditingText instance and moves the input focus to the instance while updating a composition string in the Editor::setComposition() function; 2. Our IME code automatically finishes the ongoing composition everytime when WebKit moves the input focus to the WebCore::EditingText instance. As a wordaround for this issue, this change ignores focus events while a renderer process updates a composition string with the Editor::setComposition() function. Review URL: http://codereview.chromium.org/10827 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5556 0039d316-1c4b-4281-b951-d872f2087c98
* fixing bustageben@chromium.org2008-11-172-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5555 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HWND from TabContents creation. ben@chromium.org2008-11-1713-60/+32
| | | | | | R=brettw ReviewURL: http://codereview.chromium.org/10967/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5554 0039d316-1c4b-4281-b951-d872f2087c98
* Fix accumulated webkit merge ramifications in the SCons build of Chromesgk@google.com2008-11-169-86/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (plus various renaming ripple effects masked by merge build errors): * Move invocation of recently-created *.scons files from chrome\SConscript into chrome\chrome.scons. * Move the ChromeVersionRC() Builder up into chrome\chrome.scons so it's available in all the newer *.scons files (specifically installer\mini_installer\mini_installer.scons and installer\setup\setup.scons). * Build chrome.dll in a chrome_dll subdirectory, and chrome.exe in a chrome_exe subdirectory, to avoid the name conflict when both try to create a chrome.lib library as part of linking. Re-name them to chrome.{dll,lib,exe} on installation into $DESTINATION_ROOT. * Install underneath Hammer\ ($DESTINATION_ROOT) copies of: themes\default.dll * Portability: link against 'chrome' and 'common' from the LIBS variable, not by explicitly listing 'chrome.lib' and 'common.lib'. * Link interactive_ui_tests.exe links against sdch, not google_update, and add CPPPATH directories for included resource files. * Install a number of necessary ancillary files in explicitly in $DESTINATION_ROOT, not $TARGET_ROOT: chrome.dll, icudt38.dll, rlz.dll, "First Run", themes\*, locales\, Dictionaries. * Add a 'chrome_locales' Alias for the locale .dll files installed into the locales\ subdirectory, and use Requires() to make sure they're installed for chrome.exe regardless of what target is used. * Add a 'chrome_Dictionaries' Alias for the hunspell dictionaries into the Dictionaries\ subdirectory, and use Requires() to make sure they're installed for chrome.exe regardless of what target is used. * Clone() the automated_ui_tests.scons construction environment so its settings don't pollute builds of other targets. * Add explicit dependencies on various generated .rc files (with TODO(sgk) to figure out why they're not picked up by the implicit dependency scan). Review URL: http://codereview.chromium.org/10976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5549 0039d316-1c4b-4281-b951-d872f2087c98
* - Stop rlz from constantly "rebuilding".maruel@chromium.org2008-11-162-2/+2
| | | | | | | | | | | | | | | | | | - Changes dependencies from rlz browser interactive_ui_tests unit_tests to rlz interactive_ui_tests mini_installer unit_tests Review URL: http://codereview.chromium.org/10760 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5548 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 19:59:15 +0000