summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Don't reset the gdk_event_handler in the tab destructor as this overwrites ↵jhawkins@chromium.org2009-06-031-3/+0
| | | | | | | | | | the handler set up by a potentially new tab. BUG=none TEST=Open a new browser window with two tabs. Open a second browser window. Drag a tag in and out of the tabstrip in the second browser window. Review URL: http://codereview.chromium.org/119124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17567 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for extra BreakPad param upload on OSXjeremy@chromium.org2009-06-031-4/+5
| | | | | | | | | | | | | A change in Breakpad upstream caused the custom key/value pairs we specified to no longer be sent to crash server (e.g. process type). This change pulls in an upstream fix and causes our code to use new APIs to specify this information. BUG=13131 TEST=Crash breakpad, look at crash dump on crash server, make sure pytpe field is present. Review URL: http://codereview.chromium.org/119121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17563 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to AutocompletePopup trying to draw the old results when they ↵pkasting@chromium.org2009-06-035-17/+24
| | | | | | | | were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available. This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742 Review URL: http://codereview.chromium.org/119116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17562 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of dragging extensions on the shelf. This part was just about ↵erikkay@google.com2009-06-037-43/+229
| | | | | | | | getting the mechanics of the shelf handle and the dragging correct. Part 2 will actually allow the order to be changed.TEST=hover over an extension toolstrip, grab the handle and drag. release. Review URL: http://codereview.chromium.org/119103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17559 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on the PasswordStoreMac implementation.stuartmorgan@chromium.org2009-06-031-0/+5
| | | | | | | | BUG=11745 TEST=Passwords from Keychain should be filled once the username field is filled and blurred. Review URL: http://codereview.chromium.org/119118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix toolkit_views build.ben@chromium.org2009-06-033-5/+15
| | | | | | Review URL: http://codereview.chromium.org/119119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17556 0039d316-1c4b-4281-b951-d872f2087c98
* Update some comments in url_request.h to clarify that once the request is ↵ericroman@google.com2009-06-031-1/+1
| | | | | | | | | | | | | | | deleted/cancelled, the delegate should never be called again. (The text added to URLRequest::Cancel() was copied from URLRequest::~URLRequest()). The comment change in resource_dispatcher_host.cc is an unrelated name fix. TEST=0 BUG=0 Review URL: http://codereview.chromium.org/118151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17555 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: added overflow checks in the X BackingStore code.agl@chromium.org2009-06-031-2/+12
| | | | | | | http://codereview.chromium.org/119050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17553 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing dialog truncation issues in multiple locales. Some locales needed ↵finnur@chromium.org2009-06-0348-73/+49
| | | | | | | | | | | additional height to accommodate the buttons (in XP classic mode). Some (like .te) needed additional width to accommodate the combobox. BUG=11487 TEST=Open Clear Browsing Data dialog in all languages and make sure no control is being truncated/squished against another control. Review URL: http://codereview.chromium.org/118191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17551 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Source<T> and Details<T> to be instantiated with T = const Foo.pkasting@chromium.org2009-06-034-28/+19
| | | | | | Review URL: http://codereview.chromium.org/118185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17550 0039d316-1c4b-4281-b951-d872f2087c98
* Allow derived classes to access members (channel, thread, etc) of the ↵stoyan@chromium.org2009-06-032-57/+1
| | | | | | | | | AutomationProxy. Move out TabProxyDelegate filter. Review URL: http://codereview.chromium.org/119098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux views build.jcampan@chromium.org2009-06-031-0/+1
| | | | | | | | | BUG=None TEST=None TBR=ben Review URL: http://codereview.chromium.org/118184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17548 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmitting change r17491 that was reverted because of a memory leak.sverrir@google.com2009-06-036-238/+392
| | | | | | | | Fixed the leak. Review URL: http://codereview.chromium.org/118190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17547 0039d316-1c4b-4281-b951-d872f2087c98
* Change PasswordStoreDefault to access the WebDataService from the UI thread ↵stuartmorgan@chromium.org2009-06-0314-225/+246
| | | | | | | | | | | | only. Enables the PasswordStore refactoring yet again (third time's the charm?). BUG=12479 TEST=Password save/autofill should continue to work on Windows. Review URL: http://codereview.chromium.org/118131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17545 0039d316-1c4b-4281-b951-d872f2087c98
* Some previous refactoring I did of the accelerator code had introduced ↵jcampan@chromium.org2009-06-034-64/+46
| | | | | | | | regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox) Review URL: http://codereview.chromium.org/119016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging a tab back into a tabstrip for gtk.jhawkins@chromium.org2009-06-0312-45/+372
| | | | | | | | BUG=none TEST=Open a browser window with two tabs. Drag one of those tabs in and out of the window's tabstrip many times. Open a new window and drag a tab into that window's tabstrip. Review URL: http://codereview.chromium.org/118142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17542 0039d316-1c4b-4281-b951-d872f2087c98
* Split the BackingStoreManager out of backing_store.* and into its own class.brettw@chromium.org2009-06-036-56/+79
| | | | | | Review URL: http://codereview.chromium.org/118179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17539 0039d316-1c4b-4281-b951-d872f2087c98
* Change an include to the right header after the app/gfx/gtk_util -> ↵thestig@google.com2009-06-031-2/+1
| | | | | | | | | | base/gfx/gtk_util merge. BUG=none TEST=Linux compile turns green. Review URL: http://codereview.chromium.org/119111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17538 0039d316-1c4b-4281-b951-d872f2087c98
* Merge app/gfx/gtk_util into base/gfx/gtk_util.thestig@google.com2009-06-038-8/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17535 0039d316-1c4b-4281-b951-d872f2087c98
* FocusManager should accept multiple AcceleratorTargets for each accelerator.yutak@chromium.org2009-06-033-23/+13
| | | | | | | | | | Originally, FocusManager automatically unregisters an old target if multiple AcceleratorTargets are registered to the same accelerator. This behavior is somewhat troublesome, and actually ShelfItemDialog hits a run-time assertion due to the conflict of registrations (issue 12401). This change modifies the behavior of FocusManager to allow multiple targets to be registered for each accelerator. BUG=12401 TEST=See if issue 12401 is resolved. Review URL: http://codereview.chromium.org/114065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix task manager by only adding the table view to the view hierarchy when ↵ben@chromium.org2009-06-031-2/+2
| | | | | | | | | | the task manager view is added. http://crbug.com/12927 TEST=open the task manager, should work Review URL: http://codereview.chromium.org/119105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17532 0039d316-1c4b-4281-b951-d872f2087c98
* plugins: rename GetPluginNativeView to GetNativeView.evan@chromium.org2009-06-0316-31/+30
| | | | | | | | | That's what the function does, and some callers that had nothing to do with plugins were calling GetPluginNativeView. Review URL: http://codereview.chromium.org/118094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17531 0039d316-1c4b-4281-b951-d872f2087c98
* typo fix to unbreak linux build.estade@chromium.org2009-06-031-1/+1
| | | | | | | | TBR=willchan Review URL: http://codereview.chromium.org/118183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17529 0039d316-1c4b-4281-b951-d872f2087c98
* UI Support for Auto Spell Correct. Currently, it is still under the command ↵sidchat@google.com2009-06-039-3/+72
| | | | | | | | line flag --auto-spell-correct, which means that this UI support will appear only when the command line flag is enabled.BUG=www.crbug.com/13102TEST=enable this feature through the command line flag --auto-spell-correct and then use the Languages Options menu check box to toggle this feature on/off - test by typing "teh" in a text box. Review URL: http://codereview.chromium.org/119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17528 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: more bookmark manager stuff.estade@chromium.org2009-06-033-27/+92
| | | | | | | | Display stuff in the right pane. Also fix a bug I introduced in the last patch. Review URL: http://codereview.chromium.org/118178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17527 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Disable a failing test on linux."tc@google.com2009-06-031-3/+0
| | | | | | | | | | | This reverts commit r17517. TBR=willchan Review URL: http://codereview.chromium.org/119100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17518 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a failing test on linux.tc@google.com2009-06-031-0/+3
| | | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/118180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17517 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor print functionality in RenderView..."willchan@chromium.org2009-06-036-393/+238
| | | | | | | | | This broke XP Unit (Purify) TBR=sverrir Review URL: http://codereview.chromium.org/119099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17516 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux unittest that I broke.estade@chromium.org2009-06-031-2/+4
| | | | | | | | TBR=willchan Review URL: http://codereview.chromium.org/118177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17515 0039d316-1c4b-4281-b951-d872f2087c98
* Implement more of the BookmarkBubble, connecting it to the bookmark system.deanm@chromium.org2009-06-036-45/+171
| | | | | | | | | | | | | This allows you to edit the bookmark title, and remove the bookmark. BUG=11738 TEST=Click the bookmark star, you should be able to edit the bookmark title and remove the bookmark. Review URL: http://codereview.chromium.org/119079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17514 0039d316-1c4b-4281-b951-d872f2087c98
* When the contents don't have title, use URL for the name of bookmark entry.brettw@chromium.org2009-06-032-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make it able to drag star even when the contents of address bar is modified. This change makes the behavior of two different bookmarking operation, starring and drag-and-drop, consistent. Currently, bookmarking a page with no title by clicking star creates a bookmark entry with an empty string as its name field, while dragging star to bookmark manager uses URL for name field. As suggested in BUG5965, the behavior of dragging star is better. I've replaced the code in Browser::BookmarkCurrentPage (one for clicking star) with the code in BrowserToolbarView::WriteDragData (one for dragging star) to fix this issue. The former uses NavigationEntry::title() which returns an empty string, while the latter uses TabContents::GetTitle() which returns URL Additionally, I've made the check done in BrowserToolbarView::GetDragOperations() and Browser::BookmarkCurrentPage() such as ToolbarViewModel::ShouldDisplayURL() consistent. Following the suggestion by glen, I've removed ToolbarViewModel::input_in_progress() from the check. TEST=Bookmark page with no title by clicking star and see that the bookmark entry has the URL for its name field. BUG=5965 Original review: http://codereview.chromium.org/113942 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17513 0039d316-1c4b-4281-b951-d872f2087c98
* Shows IDN for "Waiting for <host-name>..." message when Chrome is waiting for abrettw@chromium.org2009-06-031-1/+6
| | | | | | | | | | | | | | server response. TEST=Adds "ja" to Accept-Language, accesses http://www.xn--w22as22a.haun.org/empty.pl, which takes 10 seconds to response, and confirms "Waiting for ..." message has Unicode host name. BUG=3991 Original review URL: http://codereview.chromium.org/118070 Patch by tkent@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NavigationController::ClassifyNavigation() to treat redirection correctly.brettw@chromium.org2009-06-033-4/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we enter an address that redirects to some other page to the address box, it should show the address where we are redirected to after navigation completes. Currently, it doesn't when we follow this procedure more than once as described in BUG 5374. After redirection, the renderer says that it navigated to the same page by returning existing page_id in ViewHostMsg_FrameNavigate_Params, but NavigationController::ClassifyNavigation() compares params.url with pending_entry_->url() and says it's not SAME_PAGE. Therefore, the result is not correctly treated and goes into EXISTING_PAGE handler. It compares the existing entry for the page with pending_entry_. It's false, so it doesn't call DiscardNonCommittedEntriesInternal(). pending_entry_ left not released. Toolbar's view uses this pending_entry_'s url for showing address on the address bar. We should not check URL. Just overwrite entry_ with the response from renderer. TEST= Access http://www.google.com , https://www.google.com , and then https://www.google.com . The address bar should show http://www.google.com . Prepare some site http://example.com which redirects to http://example.org , and then access http://example.com , and then change the redirection to http://example.net . Retry accessing http://example.com . The address bar should show http://example.net . BUG=5374 Original review: http://codereview.chromium.org/115916 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17511 0039d316-1c4b-4281-b951-d872f2087c98
* Change plugin handling in extension from "plugin_dir" to a "plugin" list ofmpcomplete@google.com2009-06-039-36/+96
| | | | | | | | | | | | dictionaries, which allows us to specify properties per plugin. This is the first part of allowing extensions to have plugins only accessible by the extension process. BUG=12960 Review URL: http://codereview.chromium.org/114072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17510 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r17500glen@chromium.org2009-06-031-14/+3
| | | | | | | | | TBR=slightlyoff BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17508 0039d316-1c4b-4281-b951-d872f2087c98
* Display tooltips for gtk tabs that have elided titles.jhawkins@chromium.org2009-06-033-1/+16
| | | | | | | | BUG=none TEST=Navigate to a URL with an elided title in the tab. Hover the mouse over the tab. A tooltip should appear with the full title. Navigate to google.com and hover over the tab. A tooltip should not appear (unless the tab is small enough). Review URL: http://codereview.chromium.org/118161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17507 0039d316-1c4b-4281-b951-d872f2087c98
* Theme the download bar. Mostly this is just changing the background color to ↵glen@chromium.org2009-06-0340-4/+7
| | | | | | | | | | | match the toolbar, and making the button images transparent. BUG=11703 TEST=Verify that the download bar matches the theme that is installed. Review URL: http://codereview.chromium.org/119088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17502 0039d316-1c4b-4281-b951-d872f2087c98
* Theme our bookmark bar buttons.glen@chromium.org2009-06-031-3/+14
| | | | | | | | | BUG=12467 TEST=Apply a theme and verify that bookmark bar text colors changes. Review URL: http://codereview.chromium.org/112092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17500 0039d316-1c4b-4281-b951-d872f2087c98
* Removed focus manager references from the external tab container as we don't ↵ananta@chromium.org2009-06-032-26/+11
| | | | | | | | | | | | | need the focus manager to achieve tabbing in and out of the chrome frame widget. The other change is to add a check for a NULL container window when the tab contents is being freed. This causes an assert to fire in the focus manager code while trying to unsubclass the window. Review URL: http://codereview.chromium.org/119074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17499 0039d316-1c4b-4281-b951-d872f2087c98
* Port 2 more unit tests. Just small differences between platforms.tc@google.com2009-06-033-8/+13
| | | | | | | | | | This allows password_form_manager_unittest.cc and search_provider_unittest.cc to run on linux/mac. Review URL: http://codereview.chromium.org/118137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17497 0039d316-1c4b-4281-b951-d872f2087c98
* Need to unpack setup.exe patch first before applying it to setup.exe.kuchhal@chromium.org2009-06-033-27/+63
| | | | | | | | | | BUG=12832 TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works. Review URL: http://codereview.chromium.org/118144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17495 0039d316-1c4b-4281-b951-d872f2087c98
* Make mini_installer changes for 3 stage updates.kuchhal@chromium.org2009-06-034-160/+231
| | | | | | | | | | BUG=12832 TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works. Review URL: http://codereview.chromium.org/115839 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17494 0039d316-1c4b-4281-b951-d872f2087c98
* Modify script that creates differntial installer to support 3stage update ↵kuchhal@chromium.org2009-06-033-125/+179
| | | | | | | | | | | | installer. BUG=12832 TEST=While building mini_installer try various values of DiffAlgorithm and SetupExeFormat property and make sure generated installer works. Review URL: http://codereview.chromium.org/114073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser hang due to plugin deadlockamit@chromium.org2009-06-034-2/+54
| | | | | | | | | | | | | | | | | | | | | This involves two plugin instances with second instance making sync calls to the renderer while the first one is still servicing an incoming sync request. Our logic to unblock the renderer during the sync call fails since the 'in_dispatch_' counter is maintained per plugin channel (each plugin instance uses its own separate channel). Making 'in_dispatch_' counter static member of PluginChannelBase fixes this deadlock. Added a new NPAPI UI test for this scenario. BUG=12624 TEST=MultipleInstancesSyncCalls Review URL: http://codereview.chromium.org/119052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17492 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor print functionality in RenderView. Moved most of the print ↵sverrir@google.com2009-06-036-238/+393
| | | | | | | | | | | functionality to a new class that will later be the base for asynchronous printing support. This is to make further changes to printing easier. There is no functional change and the code continues to be tested through the RenderView tests. Review URL: http://codereview.chromium.org/99368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17491 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fixed crash 13078 from known list.huanr@chromium.org2009-06-031-6/+0
| | | | | | Review URL: http://codereview.chromium.org/119087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17490 0039d316-1c4b-4281-b951-d872f2087c98
* Linux bookmark manager first cut.estade@chromium.org2009-06-0314-56/+434
| | | | | | | | Also add icons to bookmark tree model. Review URL: http://codereview.chromium.org/118150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17489 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-790/+671
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in the UMR filter file from:erikkay@google.com2009-06-031-18/+18
| | | | | | | | | | http://codereview.chromium.org/118139 TBR=aa Review URL: http://codereview.chromium.org/119084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17484 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-0317-671/+790
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 21:04:53 +0000