summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Update buildbot sample to work with newest APIs.aa@chromium.org2009-10-261-3/+3
| | | | | | Review URL: http://codereview.chromium.org/330015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30070 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when a page action cannot load its icon.aa@chromium.org2009-10-261-1/+2
| | | | | | | | | | | | | | | | | This can happen legitmately if the icon has been moved or corrupted on disk. I think we are hitting it too frequently for that to be the whole explanation, but since this code is moving around a lot shortly, it seems prudent to put in the quick fix and worry about what's really going on post-refactor. BUG=25601 TEST=Remove an extension's page action icon from its folder after installation. Should not crash when attempting to show page action. Review URL: http://codereview.chromium.org/339005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30069 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30062.glen@chromium.org2009-10-263-16/+9
| | | | | | Review URL: http://codereview.chromium.org/338022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98
* Polish to the gmail checker sample.aa@chromium.org2009-10-264-24/+65
| | | | | | | | | | | | * New, crisper icons that are exactly 19x19 * Add a loading animation at the beginning before Gmail responds. * Fix a bug where we sometimes don't update the UI after a logout/login cycle. Review URL: http://codereview.chromium.org/338013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30067 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in the WebKit code samplekathyw@google.com2009-10-262-2/+2
| | | | | | | | | | BUG=25804 TEST=none TBR=aa Review URL: http://codereview.chromium.org/333027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30065 0039d316-1c4b-4281-b951-d872f2087c98
* Set necessary args for tab_switching_test.chase@chromium.org2009-10-261-0/+4
| | | | | | | | | BUG=25200 TEST=running tab_switching_test in VS reports results Review URL: http://codereview.chromium.org/307047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30064 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Change the interface from HostResolver::DisableIPv6() to ↵eroman@chromium.org2009-10-262-3/+7
| | | | | | | | | | HostResolver::SetDefaultAddressFamily(), to make it more general. This came up in a codereview comment, but was after I had checked in. Review URL: http://codereview.chromium.org/303026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30063 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the find bar.ben@chromium.org2009-10-263-9/+16
| | | | | | | | | http://crbug.com/21910 TEST=none Review URL: http://codereview.chromium.org/334019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30062 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make Cmd-[ and Cmd-] work properly again.viettrungluu@chromium.org2009-10-262-80/+674
| | | | | | | | | | | | | I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed). [N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.] BUG=25810 TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift). Review URL: http://codereview.chromium.org/333026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30059 0039d316-1c4b-4281-b951-d872f2087c98
* Only double the buffer when AsyncResourceHandler's caller fill the buffer.erg@google.com2009-10-262-10/+16
| | | | | | | | | | | This is an update to r29904 and came out of a discussion with Darin. BUG=http://crbug.com/24493 TEST=NONE Review URL: http://codereview.chromium.org/335010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30058 0039d316-1c4b-4281-b951-d872f2087c98
* Update TOSlaforge@chromium.org2009-10-262-95/+99
| | | | | | Review URL: http://codereview.chromium.org/334027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt to swap processes on rel=noreferrer, target=blank links.creis@chromium.org2009-10-264-2/+209
| | | | | | | | | | | | | The test timed out on one of the bots last time. This change tries to fix that, and it breaks down the test into multiple tests to isolate the problem in case it isn't fixed. No changes to code outside the test and the test HTML file. Previous review at http://codereview.chromium.org/284015. BUG=24447 TEST=RenderViewHostManagerTest.*SwapProcess* Review URL: http://codereview.chromium.org/328017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30050 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that when a folder is open on the bookmark bar and thesky@chromium.org2009-10-268-125/+235
| | | | | | | | | | | | mouse moves over another folder, the menu for that folder is shown. BUG=355 TEST=thorougly test all possible permutations of bookmark menus you can think of, including drag and drop to the menus. Review URL: http://codereview.chromium.org/328012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make middle-click tab closure cancellable.viettrungluu@chromium.org2009-10-261-1/+8
| | | | | | | | | | | | When middle-clicking a tab to close it, one should be able to move the mouse off the tab before releasing to cancel it. BUG=16019 TEST=Get a 3-button mouse. Make sure middle-clicking tabs to close them still works. Make sure moving the mouse off the tab before releasing the button cancels. Review URL: http://codereview.chromium.org/333021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30048 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 225.0 to 226.0chrome-bot@google.com2009-10-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30040 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix (window modal) sheet placement when bookmark bar is present.viettrungluu@chromium.org2009-10-261-3/+17
| | | | | | | | | BUG=25754 TEST=Check placement of (window modal) sheets (e.g., Open File...) with various combinations of the following: NTP/non-NTP, bookmark bar active/not active, infobar present/not present, and also download bar present/not present. Review URL: http://codereview.chromium.org/337019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30037 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make status bubbles pop properly when mouse leaves content area.viettrungluu@chromium.org2009-10-261-1/+2
| | | | | | | | | | | We hadn't set up our tracking area (in BaseView) to send mouse enter/exits. BUG=22199 TEST=Get a page with lots of links which upon resizing can be made to abut the left edge (e.g., <http://www.nytimes.com/>), and resize/scroll to make it so; hover over a link to show status bubble; move mouse off the window, staying on the same link until off the window. The status bubble should then fade away. Review URL: http://codereview.chromium.org/337016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30033 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send some keyboard shortcuts to the renderersthakis@chromium.org2009-10-262-4/+60
| | | | | | | | | | | | | | | Walking the whole menu on every keypress seems ridiculous. Linux does this too :-/ (Caching is made hard because the user can change key equivalents in system preferences at every point in time, and we're not notified of that. And people only hit max 5 keys/second, so it's not all that ridiculous). There's a UI test for this, but the interactive UI tests are not enabled on OS X, so it's not executed. Menu walking code based on code from CocoatechCore. BUG=5496,15090,24877 TEST=Go to http://unixpapa.com/js/testkey.html , check "keydown", focus the textbox, and make sure that cmd-t still opens tabs, cmd-shift-[ still switches tabs, cmd-w still closes tabs. however, cmd-L should not focus url bar and cmd-1 should not go to the first tab. Review URL: http://codereview.chromium.org/273032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30032 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function that can check if a menu item would be fired by a keypress.thakis@chromium.org2009-10-264-0/+462
| | | | | | | | | BUG=Needed for a CL that I'm writing for 15090. TEST=Unittest included. Review URL: http://codereview.chromium.org/319001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30030 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where popups and app frames lost their titlebars.ben@chromium.org2009-10-261-1/+5
| | | | | | | | | | TBR=pkasting http://crbug.com/25784 TEST=open any popup window or app frame, should have title bar to drag window. Review URL: http://codereview.chromium.org/328026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30029 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 224.4 to 225.0chrome-bot@google.com2009-10-251-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30028 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionApiTest.Storage because it crashes the browser_tests too.nsylvain@chromium.org2009-10-251-1/+2
| | | | | | | | BUG:25746 Review URL: http://codereview.chromium.org/328024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30021 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ExtensionApiTest.BrowserActionPopup because it crashes on the bot.nsylvain@chromium.org2009-10-251-1/+2
| | | | | | | BUG: 25746 Review URL: http://codereview.chromium.org/330012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30019 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the proxy host and port string to start with http:// if it does not already.mdm@chromium.org2009-10-241-1/+5
| | | | | | | | | BUG=21218 TEST=none Review URL: http://codereview.chromium.org/235030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30018 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement dispositions for back/forward buttons (not in drop-downs).viettrungluu@chromium.org2009-10-241-2/+7
| | | | | | | | | | | | | That is, holding Cmd while pressing back/forward will open in a new background tab and holding Cmd+Shift will open in a new foreground tab. Theoretically, it can support holding Shift to open in a new window, but Browser::GoBack()/GoForward() doesn't support this disposition (due to a technical "limitation" of the implementation?). This does *not* implement dispositions in the drop-down menus. BUG=25319 TEST=Navigate to build up some history. Then press back/forward while holding down Cmd or Cmd+Shift. Review URL: http://codereview.chromium.org/330002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30016 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile on Snow Leopard.thakis@chromium.org2009-10-241-1/+1
| | | | | | | | BUG=TEST=phajdan Review URL: http://codereview.chromium.org/333023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30012 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 224.3 to 224.4chrome-bot@google.com2009-10-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30000 0039d316-1c4b-4281-b951-d872f2087c98
* Doc navigation work.kathyw@google.com2009-10-2434-177/+460
| | | | | | | | | | | | This affects the sidenav, so if we go ahead with this I'll regenerate all the files and add them to this CL. BUG=none TEST=none Review URL: http://codereview.chromium.org/338007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29998 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BrowserActions, and add support foraa@chromium.org2009-10-2429-355/+952
| | | | | | | | | | | | | | | | | tab-specific state. Future changelists will move Page Actions over to ExtensionAction2, then replace ExtensionAction and ExtensionActionState with ExtensionAction2. Also, fix a bug in setIcon({path:...}) where it would work only the first time. BUG=24669,24472 Review URL: http://codereview.chromium.org/306044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix premultiplication mismatch inaa@chromium.org2009-10-241-2/+3
| | | | | | | | | | | | | | | chrome.browserAction.setIcon(). SkBitmap expects premultiplied values, canvas returns them not premultiplied. BUG=24643 TEST=install gmail browser action sample. Should not have weird colorful artifacts around edges. Review URL: http://codereview.chromium.org/333011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29996 0039d316-1c4b-4281-b951-d872f2087c98
* Enable HTML5 databases for all extension renderer processes.dumi@chromium.org2009-10-247-9/+12
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/330010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29995 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing WebDatabaseObserver in the renderer process.dumi@chromium.org2009-10-246-0/+88
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/293038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29993 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Try to position info bubbles onscreen.derat@chromium.org2009-10-243-103/+193
| | | | | | | | | | | | | | | | | | | | | | | | | I didn't go so far as to add support for arrows-on-the-bottom in this change; I'm just making the bubble extend left or right as needed. I'll add a parameter to specify the default arrow location (needed for browser action popups) in another CL. Tested by: - dragging a window to the right edge of the screen and confirming that bookmark bubbles open extended to the left - opening a bookmark bubble, using a little X program to move the Chrome window to the right side of the screen (can't drag it there since the pointer is grabbed), and confirming that the bubble gets updated to extend to the left - running in Arabic and confirming that bubbles extend to the left by default but get switched to extend to the right as needed BUG=23373 TEST=see above Review URL: http://codereview.chromium.org/316006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29992 0039d316-1c4b-4281-b951-d872f2087c98
* linux: nuke a NOTIMPLEMENTEDevan@chromium.org2009-10-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/333020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29991 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make bookmark bar primitive drag destination.thakis@chromium.org2009-10-247-6/+129
| | | | | | | | | | | | | | Credits for the bookmark bar fix to dmac; stolen from http://codereview.chromium.org/267082 . BUG=18289 TEST=Drag a link or bookmarklet from the web to the bookmark bar. It should be added at the end of the bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29906 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29908 Review URL: http://codereview.chromium.org/336001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29990 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build breakage (remove page_action_apitest from mac build)rafaelw@chromium.org2009-10-241-0/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/329016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29989 0039d316-1c4b-4281-b951-d872f2087c98
* Increase visual spacing between browser action buttons to 5px.rafaelw@chromium.org2009-10-242-2/+15
| | | | | | | | BUG=25444 Review URL: http://codereview.chromium.org/316019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29988 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionApiTest.PageAction & Enable test on linuxrafaelw@chromium.org2009-10-243-7/+1
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/337015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29987 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up database files. Some changes are due to Google style guide ↵pkasting@chromium.org2009-10-244-143/+100
| | | | | | | | | | violations, some to be consistent with prevailing team style, some merely in hopes of increasing readability. BUG=none TEST=none Review URL: http://codereview.chromium.org/330007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29985 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regression test for the PluginChannel::CleanUp. My earlier ↵jam@chromium.org2009-10-242-0/+66
| | | | | | | | | | | speculative fix was correct. I tracked this down to my earlier change to not leak NPObjects on channel shutdown (which now happens a lot more often because of sudden termination for tab close). Since we now call an NPObject's deallocate function, it's possible that it leads to an NPObjectProxy being deleted, in which case we would delete an object in the listener's array while we're looping across it. BUG=25439 Review URL: http://codereview.chromium.org/332013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29982 0039d316-1c4b-4281-b951-d872f2087c98
* Instructing V8 to disable the binding for the window.openDatabase()dumi@chromium.org2009-10-241-0/+3
| | | | | | | | | | | | function. BUG=none TEST=none Review URL: http://codereview.chromium.org/295053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29980 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove some now-dead code and add a comment.viettrungluu@chromium.org2009-10-243-41/+7
| | | | | | | | | | | I slightly jumped the gun on committing CL 328010, and this patch does some things requested in a review. BUG=23825 TEST=none Review URL: http://codereview.chromium.org/326024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29979 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Compute infobubble target rects correctly.derat@chromium.org2009-10-245-10/+29
| | | | | | | | | | | | | | I misunderstood how allocations work in the original version and wasn't handling the case where there are intermediate GdkWindows between the target widget and its toplevel window correctly. TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3 BUG=23373 Review URL: http://codereview.chromium.org/326017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29978 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pageAction setXXXBadge functions.rafaelw@chromium.org2009-10-244-614/+10
| | | | | | | | | | This only removes the binding to the functions, not their implementation, as we may want to bring back badges for pageActions if we can make them look good. BUG=25552 Review URL: http://codereview.chromium.org/329001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29977 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos build break due to out-of-order member initialization.estade@chromium.org2009-10-231-1/+1
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/337008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29971 0039d316-1c4b-4281-b951-d872f2087c98
* Add a known crash to the reliability bot.brettw@chromium.org2009-10-231-0/+3
| | | | | | | BUG=25689 Review URL: http://codereview.chromium.org/334014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29970 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 29961.glen@chromium.org2009-10-235-30/+11
| | | | | | Review URL: http://codereview.chromium.org/328016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29969 0039d316-1c4b-4281-b951-d872f2087c98
* Um, do the disable right. TBR.ojan@chromium.org2009-10-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/328015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29968 0039d316-1c4b-4281-b951-d872f2087c98
* Disable test failing since r29947. ojan@chromium.org2009-10-231-1/+2
| | | | | | | TBR=tony@chromium.org Review URL: http://codereview.chromium.org/338006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29966 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Extensinos menu item to GTK.estade@chromium.org2009-10-234-7/+13
| | | | | | | | | | Also change windows so that it always shows the Extensions menu item, but greys it out if it's disabled. BUG=25424 Review URL: http://codereview.chromium.org/316017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29964 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 15:04:07 +0000