| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Upload zero bytes if the file size shrinks.
BUG=30850
TEST=uploading an unreadable file works
Review URL: http://codereview.chromium.org/1250002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1519007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
try servers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1048002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- original review URL: http://codereview.chromium.org/1321003
- this reland fixes uniitest build break in translate_manager_unittest.cc
BUG=38548
TEST=none yet (details in original review url)
Review URL: http://codereview.chromium.org/1542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from the SkBitmap backing store to the WebCanvas. I was hoping to share the
code a bit better, but this case is subtly different from the other ones I
found, and there is not actually that much code that would be saved by a shared
implementation.
TEST=run the pepper test plugin and see the gradient circle
BUG=38893
Review URL: http://codereview.chromium.org/1445002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interstitial page wouldn't work.
Also, factor out a method WindowDispositionShouldOpenNewTab that's used to decide if a given window disposition opens in a new tab or the current tab.
BUG=39248
TEST=SSLUITest.TestHTTPSExpiredCertAndGoBackViaButton, SSLUITest.TestHTTPSExpiredCertAndGoBackViaMenu, manual test: Go to www.google.com, then to https://ebay.com to show the HTTPS interstitial, then navigate back using the toolbar.
Review URL: http://codereview.chromium.org/1406001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42971 - Patch the Browser GDI crash with excessive downloads by restricting maximum number of downloads allowed at one time. When this limit is reached, we reprompt the user.
BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001
TBR=inferno@chromium.org
Review URL: http://codereview.chromium.org/1572001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
number of downloads allowed at one time. When this limit is reached, we re-prompt the user.
BUG=39277
TEST=None
Review URL: http://codereview.chromium.org/1417001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pressing ESCAPE key.
Accelerator and label are active only in non-official builds.
BUG=39279
TEST=Build Chrome with macro OFFICIAL_BUILD undefined. Run out/Debug/chrome --login-manager --login-screen=update. Label "Press ESCAPE..." should be visible, and pressing escape should cancel the update and proceed to the login screen. Build Chrome with OFFICIAL_BUILD macro defined. Run previous command, label should not be visible and pressing ESCAPE should have no effect.
Review URL: http://codereview.chromium.org/1222007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 42959 - Make sure we poll immediately on the first syncer loop.
BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds
Review URL: http://codereview.chromium.org/1421003
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/1568003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39557
TEST=Search for a, then search for b. The list should now show the results of b.
Review URL: http://codereview.chromium.org/1537001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is just the first step, mainly to fix a breakage on the Linux 64-bit
Official builder, so the existing "FILES" handling is still mostly intact.
Review URL: http://codereview.chromium.org/1570001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=the world keeps turning
Review URL: http://codereview.chromium.org/1538001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36460
TEST=Try to enable sync on an Ubuntu VM that has been running less than 8 hours, and make sure it succeeds
Review URL: http://codereview.chromium.org/1421003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No need for permission context to hold scoped ref to the arbitrator, so I remvoed it.
(Note this fix still reveals bug https://bugs.webkit.org/show_bug.cgi?id=36535)
BUG=39405
TEST=open page with 2 embedded frames using geolocaiton, answer infobar prompts out of order. Should not crash
Review URL: http://codereview.chromium.org/1542002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(The feature that the TODO states is already implemented.)
BUG=None
TEST=None
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1526002
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Due to broken build (compile).
TBR=kuan
BUG=38548
Review URL: http://codereview.chromium.org/1567001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- this cl implements the UI on Windows and the partial backend of IPC messaging to include error type
- implement error state
- add translate error types
- use a structure as details for IPC messaging between render view and browser so as to include error type (was using std::pair)
- translate delegate handles error state and provides mapping to error messages
- infobar handles visual error states
- modify background painting to handle normal and error backgrounds, and animation of cross-fading between the 2 backgrounds
- infobar now stores state (and translation_pending flag) that it's currently displaying to user, instead of just relying on TransateInfoBarDelegate's
- if infobar receives PAGE_TRANSLAED notification before delegate does (possible because order is not fixed), delegate's state won't be updated to be used by infobar.
- after all the observers have received the notification, both infobar and delegate will end up with matching states, so there's no worries of out-of-sync.
- update unittests accordingly
- update mac and linux code accordingly to make build pass
- jay will implement the remaining backend to pass actual translate error types to the IPC message (tracked by bug 37778)
BUG=38548
TEST=none yet, until bug 37778 is also fixed.
Review URL: http://codereview.chromium.org/1321003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|LocationBarViewMac::PageActionImageView::UpdateVisibility()| updates
|visible_| based on |preview_enabled|. It is called immediately after
|preview_enabled| is set. This means that the only case
where |IsVisible()| is false but |preview_enabled| is true will be the
unit test which contrives that situation to exist.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1511001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On the geolocation bubble, need to StartRow() before AddView() per host.
TEST=As described in the bug.
BUG=39687
Review URL: http://codereview.chromium.org/1522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tests copy built dll to plugins folder so they can be found and loaded. But chrome only loads dlls whose name matches np*.dll pattern. Hence the change.
Review URL: http://codereview.chromium.org/1453001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=ui_tests
BUG=9758
Review URL: http://codereview.chromium.org/1528004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't use the Mozilla code which (a) wasn't designed for lazy writes, and (b) is weird and kind of broken for file URLs.
BUG=29911
TEST=Should be able to drag images (from a local web page) to Finder. Other drag-and-drop functionality (from web content) should continue to work as before.
Review URL: http://codereview.chromium.org/1223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38503
TBR=timurrrr
Review URL: http://codereview.chromium.org/1508003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Refactor CrosInProcessBrowserTest - granular mocks and expectations.
Fix PowerMenuButtonTest.
Review URL: http://codereview.chromium.org/1405001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=38300
Review URL: http://codereview.chromium.org/1289004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
uninstall is happening. For MSI uninstalls, base our decision on the --delete-profile flag which will tell us whether this is a true uninstall or just an upgrade.
Also correct a comment on the --delete-profile flag that suggests it is only relevant if --force-uninstall is specified.
BUG=19370
TEST=Regular and MSI Chrome Frame uninstalls remove the profile directory. MSI upgrades do not.
Review URL: http://codereview.chromium.org/1381002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
operator and it shouldn't be called as 0-arguments function.
BUG=29062
Review URL: http://codereview.chromium.org/1516003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes:
- Add a new subview to the details view for displaying appcache information in the cookie prompt. It is in the style of the existing views.
- The new view has a single info line for the manifest url.
- The label of this line is ^IDS_COOKIES_APPLICATION_CACHE_MANIFEST_LABEL
- The value is bound to content.details.manifestURL
- "hidden" binding set to content.details.shouldShowAppCachePromptDetailsView with a NSBNegateBoolean transformer OR selection.@count with a NSNegateBoolean transformer.
- Adjusted the layout of all of the details subviews, labels and values slightly to improve spacing and make it consistent
Screenshot of prompt for appcache available here:
http://img156.imageshack.us/img156/5941/picture2hj.png
http://img404.imageshack.us/img404/3747/picture3bi.png
Screenshot of adjusted cookie prompt with settable expiration:
http://img337.imageshack.us/img337/2296/picture4g.png
BUG=39288
TEST=manual testing, new unit tests
Review URL: http://codereview.chromium.org/1296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in cookie prompt.
BUG=38979
TEST=set cookie settings to ask, go to google.com
Review URL: http://codereview.chromium.org/1394004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38659
TEST=Unit tests in browsing_data_local_storage_helper_unittest.cc and browsing_data_database_helper_unittest.cc
Review URL: http://codereview.chromium.org/1405002
Patch from Mattias Nissler.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second part of the integration with autofill servers.
1. Corrected signature calculations.
2. Added unit-test
3. Fixed numerous issues, including multiple forms on the page, etc.
BUG=none
TEST=should work correctly with more servers.
Review URL: http://codereview.chromium.org/1516001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The correct behavior is to always have the menu showing,
it is disabled when the page is translated or a Chrome page
(new tab page, history...).
Selecting the translate menu triggers a translation of the
page to the Chrome UI language.
BUG=35480
TEST=Open the page context menu on the new tab page. There
should be a translate menu and it should be disabled.
Navigate to a page in a foreign language. Opne the
context menu. The translate menu should be enabled.
Select it. The page should be translated. Open the
context menu again on the translated page. The
translate menu should be disabled.
Review URL: http://codereview.chromium.org/1402003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Same as Safari, this change just finishes an ongoing IME composition and reset the IME state when a renderer requests.
BUG=26880
TEST=Enable a Chinese IME, type "baobao", click outside from the candidate window, and check if the candidate window is closed.
Review URL: http://codereview.chromium.org/661069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Removed everything above the horizontal line and put an empty NSView there, as container for the geo stuff (maybe later, there should be only one xib file for all bubble types and the container should be filled from the bubble model in all cases. Not in this CL.)
http://imgur.com/AtXiq
BUG=11246
TEST=Start chromium with --enable-geolocation. Go to http://maxheapsize.com/static/html5geolocationdemo.html , click "Allow" or "Deny". Bubble should appear. It should behave like on windows or linux (except that it has buttons instead of links. We only use links for stuff that opens web pages on clicking on OS X.)
Review URL: http://codereview.chromium.org/1542001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Found and fixed the following bug in this test. (yay!)
minimize if no sticky / new notification exists after Remove
* Replaced RunAllPending with InProcessBrowserTest::RunAllPendingEvents
BUG=http://crosbug/2027
TEST=two new browser tests and one updated browser test.
Review URL: http://codereview.chromium.org/1357005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed to use ui_controls::SendKeyPress instead of its own.
BUG=http://crosbug.com/2028
TEST=two new browser tests for CompactLocationBarHost.
Review URL: http://codereview.chromium.org/1463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1529001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/1528001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38714
TEST=watch NaCl integration Linux bot
Review URL: http://codereview.chromium.org/1479001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactored ManifestFetchesBuilder for unit tests. Added a few
unit tests.
BUG=28750
TEST=unittests
Review URL: http://codereview.chromium.org/1402001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38222
TEST=none
Review URL: http://codereview.chromium.org/1309003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
time and size information.
BUG=38463
TEST=Run chrome, navigate to about:appcache-internals.
Review URL: http://codereview.chromium.org/1109009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=35454
BUG=35056
Review URL: http://codereview.chromium.org/1392002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1462001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
measurements to the user data directory instead of the temp directory.
BUG=39098
TEST=none
Review URL: http://codereview.chromium.org/1253006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog. Add two new prefs to track the default profile and credit
card.
BUG=38975
TEST=none
Review URL: http://codereview.chromium.org/1480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=WebDataServiceAutofillTest
Review URL: http://codereview.chromium.org/1385002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added synchronous initialization of the channel to the GPU process, needed
to obey WebGL startup semantics. There are problems with this on the
Windows platform which will be addressed via refactoring in the
GpuProcessHost in a subsequent CL. Implemented offscreen rendering code
path in GGL / GLES2CmdDecoder for Mac OS X.
This new code path is not yet complete for all platforms and is still being
stress tested. The previous in-process WebGL implementation is currently
used when the sandbox is disabled; it will be removed in a subsequent CL.
A one-line code change in WebKit is needed after this CL lands to enable
the new code path.
BUG=29120
TEST=ran WebGL demos on command buffer implementation on Mac
Review URL: http://codereview.chromium.org/1328001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42879 0039d316-1c4b-4281-b951-d872f2087c98
|