summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Handle file descriptor exhaustions a little more gracefully. This prevents ↵stuartmorgan@chromium.org2009-06-121-2/+4
| | | | | | | | | | the browser itself from crashing in Intl2 page cycler tests on the Mac (although the renderer still dies, at least in debug), so that seems like a good idea whatever larger solution we find for the file descriptor issue. TEST=none BUG=none Review URL: http://codereview.chromium.org/125024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18318 0039d316-1c4b-4281-b951-d872f2087c98
* Verify signed .crx extension installationsrafaelw@chromium.org2009-06-1237-301/+473
| | | | | | | | | | | | | | | This is second try of: http://codereview.chromium.org/115682 that was comitted in in 18189 and reverted. BUG=12114 R=erikkay,wtc,aa Review URL: http://codereview.chromium.org/126014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Menu object, converting all the remaining callers to use Menu2. ↵ben@chromium.org2009-06-1219-216/+270
| | | | | | | | | | | I'll rename Menu2->Menu afterwards. TEST=none BUG=none Review URL: http://codereview.chromium.org/122027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18315 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-126-17/+1
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Add headers missing in r18291.thestig@chromium.org2009-06-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/125072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18311 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'theme_dll' a loadable_module, not a shared_library, so dependentsgk@google.com2009-06-121-1/+1
| | | | | | | | | | targets don't expect it to produce an import library (which it doesn't because it has no symbols...). BUG=none TEST=successful build Review URL: http://codereview.chromium.org/125069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18310 0039d316-1c4b-4281-b951-d872f2087c98
* Revert thakis's changes to download_file.cc from r17595.estade@chromium.org2009-06-121-15/+8
| | | | | | | | BUG=13991 Review URL: http://codereview.chromium.org/126066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18307 0039d316-1c4b-4281-b951-d872f2087c98
* Add resources necessary for building chrome.exe via gyp-generated files.sgk@chromium.org2009-06-121-0/+50
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18305 0039d316-1c4b-4281-b951-d872f2087c98
* Use pointers instead of references in SpellCheck function.sidchat@google.com2009-06-122-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18304 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups from post-submit suggestions.mmoss@chromium.org2009-06-121-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/126062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18303 0039d316-1c4b-4281-b951-d872f2087c98
* Change some DCHECKs to CHECKs in hope of tracking down a crash.pkasting@chromium.org2009-06-121-2/+2
| | | | | | | | BUG=13986 TEST=none Review URL: http://codereview.chromium.org/125066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18302 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-1236-119/+202
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18298 (cut over chrome.dll to gyp generation).sgk@google.com2009-06-121-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18299 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.dll over to gyp generation.sgk@google.com2009-06-121-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18298 0039d316-1c4b-4281-b951-d872f2087c98
* Fix object ownership and cleanup issues between ExtensionHost and ↵erikkay@google.com2009-06-122-3/+9
| | | | | | | | | | | | ExtensionView. This was leading to crashes at shutdown as well as shutdown code not cleaning up properly. BUG=13974 TEST=none Review URL: http://codereview.chromium.org/126064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18296 0039d316-1c4b-4281-b951-d872f2087c98
* Changing DelayLoadDLLs from string to listhclam@chromium.org2009-06-121-1/+14
| | | | | | | | | | TBR=nsylvian changing chrome/chrome.gyp Review URL: http://codereview.chromium.org/125064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18295 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6103 -- Individual download items on the download shelf ↵xji@chromium.org2009-06-121-27/+36
| | | | | | | | | | | | | | | | | are not mirrored on RTL locales, and issue 13217 -- Dangerous File warning on the shelf in RTL seems to misplace the buttons Enable UI mirroring for DownloadItemView. During painting each download items, for those items without corresponding mirrored images, flip the canvas to paint the mirrored image. And flip canvas back to normal to paint others. BUG=http://crbug.com/6103 BUG=http://crbug.com/13217 Test=Open Hebrew Chrome, go to "http://build.chromium.org/buildbot/continuous/LATEST/", download mini_installer.exe, the layout of the warning should be "cancel_button ok_button warning_message warning_icon" from left to right. Click "ok" to download, the layout of the download item in download shelf should be "drop_down_icon download_file_name(or download_file_name with download_status) download_progress_animation and download icon" from left to right. Review URL: http://codereview.chromium.org/118260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18292 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-1224-146/+497
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* This makes the network column in the task manager not display NA as network ↵jcampan@chromium.org2009-06-122-10/+3
| | | | | | | | | | usage is available. BUG=http://crbug.com/13958 TEST=Open the task manager, the network column for the browser process should be showing 0. Type something in the location bar, the value should change. Review URL: http://codereview.chromium.org/125056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18290 0039d316-1c4b-4281-b951-d872f2087c98
* Set a fixed guid for theme_resources. amit@chromium.org2009-06-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/126058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18288 0039d316-1c4b-4281-b951-d872f2087c98
* Extract breakpad symbol files for Linux official builds.mmoss@chromium.org2009-06-121-0/+19
| | | | | | | | | | These are archived and submitted to the crash server by the official builder (coming in a separate buildbot CL). Review URL: http://codereview.chromium.org/126015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18286 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change BlockedPopupContainerView to a cairo implementation.erg@google.com2009-06-121-42/+43
| | | | | | | | http://crbug.com/12843 Review URL: http://codereview.chromium.org/126017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18285 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most field trial uses of DNS impact testjar@chromium.org2009-06-121-24/+14
| | | | | | | | | | | | | | | | | The focus on DNS prefetching has moved to optimize primarilly the RequestToFinish time in the renderer. As a result, I've removed most of the modulations of the histogram names other than that focal histogram. I've also extended the duration for RequestToFinish, and enhanced its granularity, changing the name to RequestToFinish_L. Dave: Please review the renderer histogram changes. Will: Please review the network histogram changes. You can also suggest any histograms that you think would be removed at this point. r=davemoore,willchan Review URL: http://codereview.chromium.org/126023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18283 0039d316-1c4b-4281-b951-d872f2087c98
* Histogram count of number of command line argumentsjar@chromium.org2009-06-121-1/+20
| | | | | | | | | | This should help us evaluate which users are manually switching on non-standard options, which in turn may impact stability. r=huanr Review URL: http://codereview.chromium.org/126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18281 0039d316-1c4b-4281-b951-d872f2087c98
* Add back in log info about histogram hashesjar@chromium.org2009-06-121-0/+8
| | | | | | | | | | | | | | | This was seemingly inadvertently deleted in a CL http://src.chromium.org/viewvc/chrome?view=rev&revision=16023 The change should have no semantic impact on the running of the program (unless the user enables logging), and it helps me isolate actual names of histograms for unknown hashes that appear on the histogram dashboard. r=evanm,dpranke Review URL: http://codereview.chromium.org/125011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18280 0039d316-1c4b-4281-b951-d872f2087c98
* Make the logging dir on mac write outside the bundle in debug, this makes ↵thomasvl@chromium.org2009-06-123-51/+82
| | | | | | | | | | | | | | | | the file easier to find, and for unittests that try to scan it (like tab_switching), they then don't have to walk into the bundle. Compile tab_switching_test on mac/linux. Add a dep for app to tab_switching_test so building it also make sure the app is built (since it runs the app) Update tab_switching_test Use FilePath in all cases instead of wstring. Limit how long it will spin looking for the log log file so the test can't hang. TEST=the new test is built on mac/linux BUG=none Review URL: http://codereview.chromium.org/126049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18277 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab dragging test in automated UI test.huanr@chromium.org2009-06-126-122/+312
| | | | | | Review URL: http://codereview.chromium.org/119394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18271 0039d316-1c4b-4281-b951-d872f2087c98
* Adds wiring for tab overview.sky@chromium.org2009-06-122-0/+310
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18267 0039d316-1c4b-4281-b951-d872f2087c98
* Updates prior to cutting over chrome.dll to gyp generation:sgk@chromium.org2009-06-121-1/+24
| | | | | | | | | | | | | | | | * Add dependency on the 'theme_dll' target, commented out to avoid a problem with default.lib not being generated. * Make the location of the generated chrome_dll_version.rc file consistent with other uses of SHARED_INTERMEDIATE_DIR. * Add the necessary generated *_resources.rc to 'sources'. * Remove 'process_outputs_as_sources' from the 'chrome_dll_version' action. It's now that it's in its own target. * Add settings from chrome\app\chrome_dll.vsprops. BUG=none TEST=none Review URL: http://codereview.chromium.org/125021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18254 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage (consistent output directory names for .rc file).sgk@google.com2009-06-121-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18253 0039d316-1c4b-4281-b951-d872f2087c98
* Have 'browser_tests_dll' use the common chrome_dll_version.rc generatedsgk@google.com2009-06-121-52/+2
| | | | | | | | | by the (new) 'chrome_dll_version' target, not by rolling its own. BUG=none TEST=none Review URL: http://codereview.chromium.org/125017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18252 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing memleak found by purify.finnur@chromium.org2009-06-121-0/+2
| | | | | | | | | | | | | | | | This should fix leaks at: extensions_service.cc:495 and 498 ... and since the providers are getting cleaned up, it should take care of: extensions_service.cc:211 ... as well. TBR=erikkay TEST=Covered by automated tests. BUG=None Review URL: http://codereview.chromium.org/126037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18251 0039d316-1c4b-4281-b951-d872f2087c98
* Allow external hosts to handle the context menu and thus be able to ↵ananta@chromium.org2009-06-1222-14/+221
| | | | | | | | | | | | | | | | | | | | customize it. Changes include 1. A HandleContextMenu function which can be implemented by a TabContentsDelegate. Currently only ExternalTabContainer implements this. 2. Removed InitMenu calls from the RenderViewContextMenu subclass constructors, We need the subclasses to be able to override individual AddMenuItem calls. The newly added RenderViewContextMenuExternalWin class derives from RenderViewContextMenuWin whose constructor calls InitMenu. This happens at a time when the vtable is not yet setup. To fix this we added an Init function to the RenderViewContextMenu base class which then calls a virtual function DoInit, which derived classes can override to perform specific initializations. 3. Added automation messages to send over context menu events to external hosts and back amit, please review everything. estade please review changes to tab_contents_view_gtk.cc and render_view_context_menu_gtk.cc. pinkerton please review changes to tab_contents_view_mac.mm and render_view_context_menu_mac.mm Review URL: http://codereview.chromium.org/119429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18250 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out the code that deals with installing external extensions through ↵finnur@chromium.org2009-06-1210-236/+583
| | | | | | | | | | | | Registry and Preferences into separate classes. While I was at it, I removed the EXTERNAL_INSTALL file, since we now keep track of this in the Preferences. This also takes care of the virtualization problem in the unit tests for vista (see bug). BUG=13063 TEST=None, covered by automated tests. Review URL: http://codereview.chromium.org/122004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18247 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in my interstitial page test.willchan@chromium.org2009-06-123-15/+2
| | | | | | | | | | Re-enable leaky web_contents_unittest.cc interstitial test. Remove purify suppressions for leaky test. BUG=http://crbug.com/13937 Review URL: http://codereview.chromium.org/125033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18246 0039d316-1c4b-4281-b951-d872f2087c98
* Spaces are not URL-encoded in the Omnibarmhm@chromium.org2009-06-121-1/+1
| | | | | | | | | | BUG=13818 (http://crbug.com/13818) TEST=tests urls with spaces as well as files Review URL: http://codereview.chromium.org/126025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18241 0039d316-1c4b-4281-b951-d872f2087c98
* Oops, disable the correct test this time :)willchan@chromium.org2009-06-121-3/+3
| | | | | | | | http://crbug.com/13937 Review URL: http://codereview.chromium.org/126026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18239 0039d316-1c4b-4281-b951-d872f2087c98
* Disable leaky web_contents_unittest.cc interstitial test.willchan@chromium.org2009-06-121-1/+2
| | | | | | | | BUG=http://crbug.com/13937. Review URL: http://codereview.chromium.org/125029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18237 0039d316-1c4b-4281-b951-d872f2087c98
* * Avoid doing concurrent DNS resolves of the same hostname in HostResolver.ericroman@google.com2009-06-124-17/+26
| | | | | | | | | | | | | | | | * Add a 1 minute cache for host resolves. * Refactor HostResolver to handle multiple requests. * Make HostResolver a dependency of URLRequestContext. operate the HostResolver in async mode for proxy resolver (bridging to IO thread). TEST=unittests BUG=13163 Review URL: http://codereview.chromium.org/118100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18236 0039d316-1c4b-4281-b951-d872f2087c98
* Add known purify test failures.willchan@chromium.org2009-06-121-0/+13
| | | | | | | | | BUG=http://crbug.com/13937 TBR=erikkay Review URL: http://codereview.chromium.org/126022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18235 0039d316-1c4b-4281-b951-d872f2087c98
* Add a cmd-line flag to chrome to trigger the try chrome experimentcpu@google.com2009-06-112-0/+6
| | | | | | | | | BUG=b/1484308 TEST=none Review URL: http://codereview.chromium.org/126008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18227 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Special case focus handling so that we don't tell webkit it's lost ↵estade@chromium.org2009-06-116-17/+50
| | | | | | | | | | | focus when a context menu is showing. BUG=13404,13554 TEST=copy/paste *via the right-click context menu* works as expected in gmail. Review URL: http://codereview.chromium.org/118339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18225 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix icon theme double free on shutdown by eliminating dupes from icon ↵estade@chromium.org2009-06-112-10/+4
| | | | | | | | | | theme array. Simplify some code in DownloadItemGtk that I previously thought was related to the crash, and so had made complicated. Review URL: http://codereview.chromium.org/124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previous solution change because it breaks the Windows build.brettw@google.com2009-06-111-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18221 0039d316-1c4b-4281-b951-d872f2087c98
* UI tweaks for the tab strip on linux.sky@chromium.org2009-06-112-2/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18219 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_dll dependent on the theme DLL so if you just build and run Chromebrettw@google.com2009-06-111-0/+1
| | | | | | | | | | | it will work. TEST=none R=pkasting BUG=none Review URL: http://codereview.chromium.org/126012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18218 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a layout bug in the fonts and languages dialog wheretc@google.com2009-06-1151-68/+7
| | | | | | | | | | | | | | | buttons get cut off on the right side of the dialog. Instead of sizing the label text based on a constant from the localized resources, use the default text size (no-multiline text). I also tightened up the font preview box to just use the size of the text + a constant padding on all sides. BUG=13366 Review URL: http://codereview.chromium.org/125013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18217 0039d316-1c4b-4281-b951-d872f2087c98
* Added another command line option to run the tests after profile backup.anantha@chromium.org2009-06-117-30/+83
| | | | | | | Also, Changed the hardcoded build labels (1.0, 2.0) to (2.0, 3.0). Review URL: http://codereview.chromium.org/118463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18214 0039d316-1c4b-4281-b951-d872f2087c98
* Change DnsMaster to only access HostResolver only on the IO thread.ericroman@google.com2009-06-115-81/+197
| | | | | | | | | | | | | | | And plumb through an (unused) HostResolver dependency into DnsMaster. This is in preparation for <http://codereview.chromium.org/118100> which turns HostResolver into a (non-thread-safe) shared dependency of the URLRequestContext. After CL 118100, DnsMaster will be issuing host resolves through the main URLRequestContext's HostResolver (now on the IO thread). This will have the effect of warming the shared HostResolver's internal cache. BUG=13163 TEST=existing unit tests Review URL: http://codereview.chromium.org/122028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18212 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure view-source: is applied to RenderView when it is reused for a newbrettw@google.com2009-06-113-1/+60
| | | | | | | | | | | | | | | | | | | | | navigation. On page loading errors, WebFrameImpl::DidFail() will call RenderView::OnEnableViewSourceMode(false) not to show error pages in view source mode. We should overwrite the mode for new navigations not to show view-source: added inputs in non view-source mode. This fix is related to http://code.google.com/p/chromium/issues/detail?id=4516 But this doesn't resolve reloading case. BUG=none TEST=1) View some site using view-source:. 2) let the site return error for example 404 Not Found, and then view using view-source:. 3) make it 200 again and view using view-source:. It must show source code. Original review: http://codereview.chromium.org/119233 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18211 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 13:12:50 +0000