summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Delete the provisional load commit notification since it duplicates the nav ↵brettw@google.com2008-09-176-61/+60
| | | | | | | | | | | entry committed notification. I had to add some more stuff to the nav entry committed structure which now looks suspiciously like the provisional load details structure. I'll see how I can improve this in a future pass. I used the new NotificationRegistrar to automatically unregister for notifications in the SSL manager, which reduces some code. Review URL: http://codereview.chromium.org/3095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2313 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging to file_util::WriteFile to figure out why writingsky@google.com2008-09-173-115/+1
| | | | | | | | | | | | | bookmarks is failing for some people. As a result of this I moved some code from common/win_util to base/win_util so that file_util_win could call it. The only changes to this code are formatting. BUG=none TEST=none Review URL: http://codereview.chromium.org/2931 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2312 0039d316-1c4b-4281-b951-d872f2087c98
* Some initial work on compiling chrome/common/ on Linux.deanm@chromium.org2008-09-1710-159/+162
| | | | | | | | | Patch from Pawel Hajdan Jr. BUG=2410 Review URL: http://codereview.chromium.org/2929 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2311 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up session restore so that it correctly deals with thesky@google.com2008-09-177-40/+232
| | | | | | | | | | | | navigation controller removing entries from the front of its list. BUG=1324021 TEST=covered by unit tests, but make sure you don't see problems with session restore. Review URL: http://codereview.chromium.org/2906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2310 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a referenced file that doesn't exist.maruel@google.com2008-09-171-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2308 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing include and match a constant type better. From phajdan.jr.deanm@chromium.org2008-09-171-1/+4
| | | | | | Review URL: http://codereview.chromium.org/2922 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2300 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the font for the window title if we're not going to be painting a ↵beng@google.com2008-09-178-154/+76
| | | | | | | | | | text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2299 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this fix from earlier. Since I was making the tab icon view ↵beng@google.com2008-09-173-21/+29
| | | | | | | | | | | optional, I needed to adjust the accessibility tests so that they use the right index. Don't initialize the TabIconView if we don't need to. It's expensive to create. http://crbug/2369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2298 0039d316-1c4b-4281-b951-d872f2087c98
* According to reports in the field, some XP machines have a registry flag ↵finnur@google.com2008-09-171-0/+1
| | | | | | | | | | that says "Disable UAC". Possibly, this is governed by a policy setting on corporate networks. In any case, this causes the About box to think we can't perform on-demand updates. We should never block on-demand updates on XP. Review URL: http://codereview.chromium.org/2901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2297 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this fix until I can figure out why it;s crashing the ui testsbeng@google.com2008-09-172-28/+20
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2295 0039d316-1c4b-4281-b951-d872f2087c98
* Don't initialize the TabIconView if we don't need to. It's expensive to create.beng@google.com2008-09-172-20/+28
| | | | | | | | http://crbug.com/2369 Review URL: http://codereview.chromium.org/2917 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this earlier fix since it didn't do any good.beng@google.com2008-09-172-33/+28
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2292 0039d316-1c4b-4281-b951-d872f2087c98
* Always block the request for a sub-resource with anwtc@google.com2008-09-161-14/+5
| | | | | | | | | | SSL certificate error. R=abarth,jcampan BUG=2316 Review URL: http://codereview.chromium.org/3091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2291 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging of loading/saving bookmarks to help me diagnose why somesky@google.com2008-09-163-0/+19
| | | | | | | | | | | folks are having problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/2914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2290 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bookmark bubble bug. If you changed the title, then clicked editsky@google.com2008-09-161-0/+3
| | | | | | | | | | | | the title would revert. BUG=1353834 TEST=Create a bookmark, on the bubble type in a new name, click edit and make sure the editor that pops up has the name you just typed in. Review URL: http://codereview.chromium.org/3093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2289 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=2321, which ↵iyengar@google.com2008-09-161-2/+4
| | | | | | | | | | | | | | | | was an issue with Adobe reader retaining an open handle to the chrome application folder causing issues with subsequent installs. This was because we did not specify the current directory in the ShellExecute call. This resulted in the chrome application folder becoming the current directory and hence the issue. Bug=2321 Review URL: http://codereview.chromium.org/3092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2287 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reduce startup regression by deferring load of inactive window ↵beng@google.com2008-09-162-28/+33
| | | | | | | | | | bitmaps until they're actually needed. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2285 0039d316-1c4b-4281-b951-d872f2087c98
* Move gears.dll location to the versioned directory (alongside chrome.dll). Wempcomplete@google.com2008-09-161-3/+12
| | | | | | | fall back to searching the original plugins/gears/gears.dll for existing users. Review URL: http://codereview.chromium.org/2904 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2282 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of the alternate nav url fetcher from the navigation controller.brettw@google.com2008-09-164-40/+27
| | | | | | | | | | | | This changes the memory model around a bit, and it's not the most clear thing ever, not that it was before. The alternate URL fetcher is now responsible for deleting itself in most cases. BUG=2370 (Assertion when using the alternate URL tracker twice in a row) BUG=1324500 (Move the AlternateNavURLFetcher logic out of NavigationController) Review URL: http://codereview.chromium.org/2905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2279 0039d316-1c4b-4281-b951-d872f2087c98
* Added code for personalization to the new frame classjhaas@chromium.org2008-09-162-1/+48
| | | | | | Review URL: http://codereview.chromium.org/3074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2278 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an explicit call from the NavigationController to the alternate URLbrettw@google.com2008-09-166-54/+177
| | | | | | | | | | | fetcher since there is already a notification that does this. I created a class that will automatically unregister for notifications when it goes out of scope and used it here. I think it will be useful for most consumers of notifications. Review URL: http://codereview.chromium.org/2895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2276 0039d316-1c4b-4281-b951-d872f2087c98
* Create a copy of the test directory before using it.mbelshe@google.com2008-09-161-10/+52
| | | | | | | | | The memory test alters the data, so not doing this causes the next run to be altered. Review URL: http://codereview.chromium.org/2861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2275 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 2243 to check if it's why the startup test regressed.nsylvain@chromium.org2008-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2267 0039d316-1c4b-4281-b951-d872f2087c98
* Touchpad support for laptopsjoshia@google.com2008-09-165-62/+66
| | | | | | | | | | | | | | | | | | | | | | | This fix is a workaround to receive mouse wheel and scroll messages from synaptics touchpad driver used in majority of laptops. Removed fake scroll bars in RenderWidgetHostHwnd so that it can now receive mouse wheel messages from synaptics drivers for Dell, Toshiba laptops. Added fake scroll bars to WebContents so that it can receive scroll messages. WebContents then reflects scroll messages to the view to give it a chance to handle them. BUG=4 TEST=Touchpad scrolling and zooming (control + scroll) on various laptops. Review URL: http://codereview.chromium.org/2878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two crashers in saving page:sky@google.com2008-09-163-15/+18
| | | | | | | | | | | | | | | 1. GetTabID was being called AFTER the process was destroyed, which means we could try and deref NULL. By caching the value we don't have to worry about whether the web contents goes away or not. 2. A PostTask was done, then we assumed the SaveItem still exists. That isn't the case if the user canceled the save. BUG=2206 TEST=none, just make sure save page as still works correctly. Review URL: http://codereview.chromium.org/3034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2261 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Views to support an optional hit-test mask. Make hittest use this.beng@google.com2008-09-166-29/+125
| | | | | | | | | | | Make GetViewForPoint call HitTest instead of rolling its own crude hit testing. Update custom-shaped views to use this framework instead of overriding hittest themselves. B=2273 Review URL: http://codereview.chromium.org/3051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2255 0039d316-1c4b-4281-b951-d872f2087c98
* Remove registration step between NavigationController > Profile.tim@chromium.org2008-09-164-60/+0
| | | | | | | | | No code path requires NavigationControllers to register themselves with a profile. We won't need this moving forward, either. Review URL: http://codereview.chromium.org/2869 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2254 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on the magic frames.beng@google.com2008-09-162-1/+7
| | | | | | | B=1031854 Review URL: http://codereview.chromium.org/3063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2253 0039d316-1c4b-4281-b951-d872f2087c98
* In DefaultPolicy::OnCertError, if a cert error is allowed,wtc@google.com2008-09-161-21/+20
| | | | | | | | | | | | | | | | | | | | we should skip the code that determines what to do about a sub-resource. This is because in some HTTPS implementations, we continue to get errors on a cert after we have ignored that cert's errors. The current code works with WinHTTP because WinHTTP stops sending errors on a cert after we have ignored that cert's errors. This changelist allows the code to work with both kinds of HTTPS implementations. Fix nits (extra semicolons and insufficient whitespace) reported by cpplint.py. R=abarth,jcampan BUG=1272567 Review URL: http://codereview.chromium.org/2816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2252 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where bookmark bar wouldn't animate away but would rather snap ↵beng@google.com2008-09-161-3/+5
| | | | | | | | | closed (new frames) B=1031854 Review URL: http://codereview.chromium.org/3052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2251 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to fix the memory problems in NavigationController. The previous onebrettw@google.com2008-09-151-5/+9
| | | | | | | | | issued a DCHECK when I manlually deleted the NavigationController because the tabs were still there. Calling destroy fixes this, although I have to manually NULL out some test pointers to prevent double-frees. Review URL: http://codereview.chromium.org/3070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2247 0039d316-1c4b-4281-b951-d872f2087c98
* Adding sync plugin messages, and plugin broadcasts to the renderer processeszork@google.com2008-09-1510-18/+163
| | | | | | Review URL: http://codereview.chromium.org/2411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2246 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get a small part of chrome/SConscript building. For now, just ↵tc@google.com2008-09-151-238/+258
| | | | | | build sqlite. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2245 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't execute code from the theme dll.nsylvain@chromium.org2008-09-151-1/+1
| | | | | | | | | Note that this flag might not play well on Windows 2k and XP prior to SP2. BUG:2281 Theme dll file can be used to execute code on pre-Vista OSs Review URL: http://codereview.chromium.org/2857 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2243 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my last fix for a memory leak in the navigation controller tests. Thisbrettw@google.com2008-09-151-2/+2
| | | | | | | causes an assertion in debug mode. I think this needs to be done another way. Review URL: http://codereview.chromium.org/2873 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2239 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the unit tests.brettw@google.com2008-09-151-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2237 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest bustage due to NULL pointer deref (only in unittest mode, I hope).pkasting@chromium.org2008-09-153-12/+18
| | | | | | | | | | | Also commit some comment changes which were supposed to go in my original patch but missed it. TBR=sky BUG=1291 Review URL: http://codereview.chromium.org/2870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2233 0039d316-1c4b-4281-b951-d872f2087c98
* Add test shell WebView and WebWidget host classes. This are stopgaps andamanda@chromium.org2008-09-151-0/+3
| | | | | | | | are subject to change as the rest of the rendering and event handling paths come together. Review URL: http://codereview.chromium.org/3062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2230 0039d316-1c4b-4281-b951-d872f2087c98
* Make the GoogleURLTracker only fetch the Google hostname if the user's ↵pkasting@chromium.org2008-09-156-30/+168
| | | | | | | | | | | default search engine is Google. Our existing restrictions still apply: no fetches before five seconds after startup, and no more than one fetch per run. Because of lazy initialization everywhere, this was hairier than I'd hoped. We have to ensure we don't try to fetch until the profile has been created, lest GetDefaultRequestContext() return NULL. Note that this was actually a bug in the existing product: if you set your startup page to, say, about:blank, and started the browser and did nothing at all for five seconds, we'd crash. BUG=1291 Review URL: http://codereview.chromium.org/1942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2223 0039d316-1c4b-4281-b951-d872f2087c98
* Add preferences for the clear browsing data dialog so thattc@google.com2008-09-154-5/+47
| | | | | | | | | | | the user choices are persistent. Patch by Arthur Lussos <developer0420@gmail.com> Original issue at http://codereview.chromium.org/3014 Review URL: http://codereview.chromium.org/3059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unneeded pending entry from the unit tests.brettw@google.com2008-09-151-17/+0
| | | | | | Review URL: http://codereview.chromium.org/2859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2220 0039d316-1c4b-4281-b951-d872f2087c98
* Occasionally GetLastActiveBrowserWindow fails on the build bots, probably ↵beng@google.com2008-09-151-1/+1
| | | | | | | | | | because of the locked desktop. Replace this call in the non-interactive ui tests with a call to GetBrowserWindow(0), which is what GetActiveTab (called a few lines earlier) does anyway. B=2235 Review URL: http://codereview.chromium.org/2844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2210 0039d316-1c4b-4281-b951-d872f2087c98
* Hit test zone for the new tab button should follow its visible shape.beng@google.com2008-09-141-1/+57
| | | | | | | B=2270 Review URL: http://codereview.chromium.org/2843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert these changes now the experiment is complete.beng@google.com2008-09-143-5/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2208 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another test, this time with a tweak to the find test.beng@google.com2008-09-143-1/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2207 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a debug assertin when running the web contents unit test. The error is inbrettw@google.com2008-09-141-0/+3
| | | | | | | | the test since it would give the same page ID to two different pages in the same site instance, which should not happen. Review URL: http://codereview.chromium.org/2842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2206 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of tweaks to the AeroGlassNonClientView:beng@google.com2008-09-141-2/+2
| | | | | | | | | | - fix broken window resizing using the sizing borders... || should have been an &&, resulted in all non-client areas being treated as window caption. - use the width of the client view to size the tabstrip rather than the width of the non-client view. this was causing the new tab button to be clipped. B=2218,2267 Review URL: http://codereview.chromium.org/2841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2205 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back frame test now buildbots have cycled.beng@google.com2008-09-142-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2204 0039d316-1c4b-4281-b951-d872f2087c98
* Test frames on the builders again to see if notification change helped.beng@google.com2008-09-142-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2203 0039d316-1c4b-4281-b951-d872f2087c98
* Include the area to the right of the tabstrip underneath the window controls ↵beng@google.com2008-09-141-3/+11
| | | | | | | | | in the window caption area. B=1031854 Review URL: http://codereview.chromium.org/2840 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2202 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 09:08:47 +0000