summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Create the PopupView from the EditView, not the PopupModel.deanm@chromium.org2009-03-029-228/+245
| | | | | | | | | | | | | | It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model). This does what makes more sense, create platform specific instances from platform specific code. The AutocompleteEditView now creates the AutocompletePopupView. The AutocompletePopupView now creates the AutocompletePopupModel. This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer. This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h. This is sad but neccessary. This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance. Review URL: http://codereview.chromium.org/28313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10707 0039d316-1c4b-4281-b951-d872f2087c98
* Improved PDF from Cole.pinkerton@chromium.org2009-03-021-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10704 0039d316-1c4b-4281-b951-d872f2087c98
* Implement gfx::Path on GTK.deanm@chromium.org2009-03-026-21/+54
| | | | | | Review URL: http://codereview.chromium.org/28297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10696 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing tests to the GYP+Xcode build.mark@chromium.org2009-03-024-6/+4
| | | | | | Review URL: http://codereview.chromium.org/28309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10695 0039d316-1c4b-4281-b951-d872f2087c98
* GYP it, GYP it good.mark@chromium.org2009-03-023-7753/+0
| | | | | | | | Convert the Mac build to the new GYP-based Xcode build, and remove the old Xcode projects. Review URL: http://codereview.chromium.org/28305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10693 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash; dom_ui_ is destroyed by LoadURL.glen@chromium.org2009-03-011-1/+3
| | | | | | | | BUG=8158 Review URL: http://codereview.chromium.org/27285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10689 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my previous change. It fixed the memory leaks (see ↵jam@chromium.org2009-03-012-15/+4
| | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/2378/steps/purify%20test:%20unit/logs/stdio), but DeleteURLAndFavicon started failing mysteriously after my checkin. Review URL: http://codereview.chromium.org/28304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10688 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for memory leak in unit tests.TBR=erikkayjam@chromium.org2009-03-012-3/+14
| | | | | | Review URL: http://codereview.chromium.org/28301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10685 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent chrome from launching with a chromehtml: argumentsverrir@chromium.org2009-02-281-0/+39
| | | | | | | | | | | unless its preceeded by the switch terminator. This is to prevent chromehtml: urls to supply arguments to Chrome. BUG=5825 Review URL: http://codereview.chromium.org/20469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the misspelling of GetLaunchShortcutKind().mal@chromium.org2009-02-281-3/+3
| | | | | | | TBR= cpu Review URL: http://codereview.chromium.org/27314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10683 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IPCSyncChannelTest.ChattyServer from purify unit tests because it ↵jam@chromium.org2009-02-281-0/+3
| | | | | | | | | takes half the time. TBR=erikkay Review URL: http://codereview.chromium.org/28300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10681 0039d316-1c4b-4281-b951-d872f2087c98
* Run the unload tests in single process mode, after my fix to single process ↵jam@chromium.org2009-02-281-35/+0
| | | | | | | | | mode. BUG=7933 Review URL: http://codereview.chromium.org/27311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10680 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows ifdefs, all views will need to implement this method.deanm@chromium.org2009-02-281-5/+1
| | | | | | Review URL: http://codereview.chromium.org/27274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10679 0039d316-1c4b-4281-b951-d872f2087c98
* Add extensions_ui from r10675 to chrome.gypmark@chromium.org2009-02-281-0/+2
| | | | | | Review URL: http://codereview.chromium.org/29009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10677 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this.ananta@chromium.org2009-02-281-3/+17
| | | | | | | | | | | | | | | | | | | | Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just when it is intercepted the dlls interceptor proc messes up the stack while returning back, which causes random crashes in the browser. The hacky fix for now is to check for this dll and not invoke the API. We will beautify this fix if it works in the wild. This fixes http://code.google.com/p/chromium/issues/detail?id=6418 Bug=6418 Review URL: http://codereview.chromium.org/27298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10676 0039d316-1c4b-4281-b951-d872f2087c98
* Initial work on chrome-ui://extensions/ page. URL now displays a static ↵rafaelw@chromium.org2009-02-289-0/+258
| | | | | | | | template page Review URL: http://codereview.chromium.org/28172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10675 0039d316-1c4b-4281-b951-d872f2087c98
* Fix system menu positioning in fullscreen mode to be at the upper left ↵pkasting@chromium.org2009-02-282-8/+11
| | | | | | | | | corner of the screen. BUG=8151 Review URL: http://codereview.chromium.org/28247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10674 0039d316-1c4b-4281-b951-d872f2087c98
* Bring chrome.gyp up to date with Chromium r10668mark@chromium.org2009-02-281-2/+6
| | | | | | Review URL: http://codereview.chromium.org/27304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10673 0039d316-1c4b-4281-b951-d872f2087c98
* Fix guard to reflect new position in treejrg@chromium.org2009-02-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/28293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10670 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of appending "Downloads" to the user document directory, let each ↵estade@chromium.org2009-02-285-15/+46
| | | | | | | | | | platform specify its own downloads directory. On mac this is unimplemented. On windows it remains the user document directory + "\Downloads\", and on linux we attempt to follow their XDG setting, but fall back to ~/Downloads if they have an unsafe value in their XDG setting. Review URL: http://codereview.chromium.org/28167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10669 0039d316-1c4b-4281-b951-d872f2087c98
* Adapt (and move) mark@chromium.org's Keystone integration to Chromium.jrg@chromium.org2009-02-284-1/+194
| | | | | | | | | | | | | | | | | | | | Call it from the Browser. (no-op if not packaged for branding). Add new build target "app_packaging" to package (if possible). (app_packaging target intentionally left out of "All"). For convenience, here is the app_packaging script embedded in the xcodeproj: PACKAGER="${PROJECT_DIR}/tools/mac/package_chrome.sh" if [ -f "${PACKAGER}" ]; then "${PACKAGER}" fi Mark, I know this is not in gyp... I am happy to have this klobbered and redo it (in gyp) at the appropriate time. Review URL: http://codereview.chromium.org/27293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10668 0039d316-1c4b-4281-b951-d872f2087c98
* Wire chrome shortcuts tooltip (installation)cpu@google.com2009-02-289-13/+41
| | | | | | | | | | | - Not complete since we are waiting for translations - For chromium the tooltip says "Browse the internet" BUG=b/1522969 Review URL: http://codereview.chromium.org/28272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10666 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side to pick up new WebKit API changes.darin@chromium.org2009-02-2810-32/+94
| | | | | | | | | | | | | | | | | | | | | WebKit API now provides: - layoutTestMode - support for registering extra local URL schemes - access to the current WebKitClient WebKitClient was extended to include: - access to the default locale - access to the current time - methods to start/stop the shared timer - method to get work scheduled on the main thread - methods to access cookies - method to prefetch hostnames R=dglazkov Review URL: http://codereview.chromium.org/27276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10665 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of wstring variants of StringToFoo.dsh@google.com2009-02-2815-43/+39
| | | | | | Review URL: http://codereview.chromium.org/28281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10664 0039d316-1c4b-4281-b951-d872f2087c98
* Link applications with -Wl,-ObjC to keep Objective-C implementations availablemark@chromium.org2009-02-281-33/+3
| | | | | | Review URL: http://codereview.chromium.org/28289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10662 0039d316-1c4b-4281-b951-d872f2087c98
* When starting Chrome with the option to go to the home page on start-up, the ↵jcampan@chromium.org2009-02-281-0/+4
| | | | | | | | | | | | | | focus was set to the location bar, not the page. I had previously fixed this problem for restore-session, not for the home page case. BUG=6000 TEST=Set www.google.com as your home page, select "on start-up open my home page". Start Chrome, Google page should be shown, focus should be on the Google search field. Review URL: http://codereview.chromium.org/28287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10660 0039d316-1c4b-4281-b951-d872f2087c98
* Does two changes to appease chrome bot runs:sky@google.com2009-02-2811-5/+34
| | | | | | | | | | | | | | | | | . Changes InfoBubble to properly initialize all fields in member initializer list and set the delegate before show on the off chance the bubble is deleted from show. This should no longer happen after the second change. . Only show the bookmark bubble if the browser window is active. I experimented with conditionally enabling the star and this turns out to be a bit error prone. BUG=none TEST=none Review URL: http://codereview.chromium.org/31016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10659 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor download shelf and prepare for porting.estade@chromium.org2009-02-2815-112/+176
| | | | | | | | Side effect of removing some views dependencies from places they don't belong. Review URL: http://codereview.chromium.org/28252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10657 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Don't call SetPriorityClass if CBSText.dll is loaded in the browsertc@google.com2009-02-271-11/+3
| | | | | | | | | | | | | | | process. The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just" This file is compiled on all platforms and this is windows specific code. This reverts commit r10648. Review URL: http://codereview.chromium.org/29008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10653 0039d316-1c4b-4281-b951-d872f2087c98
* Drop whitespace at end of linewillchan@chromium.org2009-02-277-31/+29
| | | | | | | | | | Fix formatting for initializer list Use ASSERT_GE when appropriate Don't #include a header twice etc Review URL: http://codereview.chromium.org/28137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10650 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. ↵ananta@chromium.org2009-02-271-3/+11
| | | | | | | | | | | | | | | | | The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just when it is intercepted the dlls interceptor proc messes up the stack while returning back, which causes random crashes in the browser. The hacky fix for now is to check for this dll and not invoke the API. We will beautify this fix if it works in the wild. This fixes http://code.google.com/p/chromium/issues/detail?id=6418 Bug=6418 Review URL: http://codereview.chromium.org/27257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10648 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of AudioRendererHosthclam@chromium.org2009-02-278-176/+300
| | | | | | | | | | | | | | | | Completing the implementation of AudioRendererHost in chrome/browser/renderer_host/audio_renderer_host.cc with ResourceMessageFilter actually delegating calls to it when corresponding IPC messages are received. With this patch we should be able to send audio related IPC messages to browser with working audio, but we still need to complete the singleton paradigm for AudioManager to start using it in unit test and renderer. Review URL: http://codereview.chromium.org/21494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10647 0039d316-1c4b-4281-b951-d872f2087c98
* Flatten CustomFrameWindow functionality onto Window.ben@chromium.org2009-02-278-41/+509
| | | | | | | This is not new code, just copying code into Window. None of the added codepaths are executed yet because UseNativeFrame is always true, so all custom frame windows continue to use CustomFrameWindow instead. Review URL: http://codereview.chromium.org/27291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10646 0039d316-1c4b-4281-b951-d872f2087c98
* Update version number for the upgraded French and Polish dictionaries.sidchat@google.com2009-02-271-11/+8
| | | | | | | Issue=7745 Review URL: http://codereview.chromium.org/28196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10645 0039d316-1c4b-4281-b951-d872f2087c98
* Before installing Chrome check that the installation directory doesn't exist ↵kuchhal@chromium.org2009-02-275-17/+51
| | | | | | | | | | | (or can be deleted). BUG=7176 Review URL: http://codereview.chromium.org/27258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10640 0039d316-1c4b-4281-b951-d872f2087c98
* Pull WebKit deps to get transparency fixes, and rebaseline affected layout ↵brettw@chromium.org2009-02-271-2/+5
| | | | | | | | | | | | | | | | | | | tests. Add a helper class to manage Windows' transparency issues. It will create layers and manage transforms in such a way that most effects can be achieved with fonts and form controls on Windows while looking nice. This removes the magic transparency color and associated infrastructure since it is no longer needed. This fixes semitransparent ClearType antialiasing and pngs with alpha channels with opacity applied. BUG=559,2791,3229,6372 Review URL: http://codereview.chromium.org/21201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10637 0039d316-1c4b-4281-b951-d872f2087c98
* When we open a popup window from an app window, we used to identify this ↵mad@chromium.org2009-02-273-21/+23
| | | | | | | | | | | | popup window as an app too. To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those. bug= http://crbug.com/5739 Review URL: http://codereview.chromium.org/28271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10636 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tree view deleting items if there was no root. The oldsky@google.com2009-02-271-4/+3
| | | | | | | | | | | | code would attempt to access an HTREEITEM after it was removed, leading to weird problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/28275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10634 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up sorting of bookmarks to the 'organize menu' in the bookmarksky@google.com2009-02-2721-17/+203
| | | | | | | | | | | | | manager (Glen says no context menus for now). All BookmarkModelObservers have been updated appropriately. BUG=1750 TEST=bring up the bookmark manager and try the 'Reorder by title' menu item, make sure it works and I didn't screw up anything around it. Review URL: http://codereview.chromium.org/27262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10633 0039d316-1c4b-4281-b951-d872f2087c98
* All views::Window objects must have a NonClientView, regardless of whether ↵ben@chromium.org2009-02-276-85/+137
| | | | | | | | or not they fully render their own frame. This simplifies things a bit on the way to unification of Window and CustomFrameWindow. Review URL: http://codereview.chromium.org/27286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10632 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 8200: Pressing Esc should cancel dialogs, not commit.finnur@chromium.org2009-02-271-3/+3
| | | | | | | | | | | | | | | | | | | | | When we create the OK & Cancel dialog buttons in DialogClientView, we were registering OK as a handler for Escape, even though the dialog had a Cancel button. This is because we register for Esc if the member variable |cancel_ button_| is NULL. Problem is, that member isn't created until later on in that function. We should be checking the |buttons| flags instead. TEST=Open the Clear Browsing Data dialog, press Tab twice, press Esc and make sure that the dialog closes and nothing is cleared (from whatever checkbox was selected). BUG=8200 Review URL: http://codereview.chromium.org/28267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10631 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the ExtensionViewTest while I investigate why it's hanging on thempcomplete@google.com2009-02-271-1/+1
| | | | | | | | | buildbots. TBR=aa Review URL: http://codereview.chromium.org/28273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10628 0039d316-1c4b-4281-b951-d872f2087c98
* Make the GYP build aware of new and moved extensions filesmark@chromium.org2009-02-271-2/+4
| | | | | | Review URL: http://codereview.chromium.org/27283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10626 0039d316-1c4b-4281-b951-d872f2087c98
* Add "stop" image to project. Clean up project so app/theme is a proper group ↵pinkerton@chromium.org2009-02-2714-38/+108
| | | | | | | | and its children could be relative to it rather than their grandparent. Plumb loading status into Mac controllers. Add more loading status info to stub TabContents. Make browser window a little taller and wider so NTP didn't show scrollbars. Review URL: http://codereview.chromium.org/31017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10621 0039d316-1c4b-4281-b951-d872f2087c98
* Prototype extension process. This is a proof of concept, with a lot ofmpcomplete@google.com2009-02-2732-85/+452
| | | | | | | | | | rough edges. Mostly this just fires up a renderer with an "extension" object exposed, which right now only has a single method "getTestString". I also did some misc cleanup along the way. Review URL: http://codereview.chromium.org/27187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10620 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure classes only referenced by .xib files end up in the executablemark@chromium.org2009-02-272-6/+39
| | | | | | Review URL: http://codereview.chromium.org/27277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10619 0039d316-1c4b-4281-b951-d872f2087c98
* Fix script to support python 2.6, which has json module built in.erikkay@google.com2009-02-271-1/+6
| | | | | | Review URL: http://codereview.chromium.org/27278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10618 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a few more NOTIMPLEMENTED methods.pinkerton@chromium.org2009-02-273-3/+15
| | | | | | Review URL: http://codereview.chromium.org/28263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10616 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from NOTIMPLEMENTED in RenderWidgetHostViewMac::MovePluginWindows() ↵pinkerton@chromium.org2009-02-271-1/+1
| | | | | | | | to using a bug to track. Cleans up console output significantly. Review URL: http://codereview.chromium.org/28260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10615 0039d316-1c4b-4281-b951-d872f2087c98
* Add --log-level to the list of flags accepted by UI tests.patrick@chromium.org2009-02-273-0/+14
| | | | | | Review URL: http://codereview.chromium.org/27264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10614 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 17:55:32 +0000