| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Checked in for Ben Laurie
Original review: http://codereview.chromium.org/150165
Review URL: http://codereview.chromium.org/151166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
entire test suite.
Bug=None
TEST=None
Review URL: http://codereview.chromium.org/151158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/151133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=12745
Review URL: http://codereview.chromium.org/150122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
independent of the theme provider. Since the Mac needs it to tint its vector resources it's added to the Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This abstracts out the pieces that ExtensionUpdater will depend on, to allow easy mocking.
BUG=http://crbug.com/12117
TEST=none
Review URL: http://codereview.chromium.org/151127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
executables.
TEST=everything should build with no test hangs
BUG=15664
Review URL: http://codereview.chromium.org/151124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12524
TEST=None, we just need to monitor the crash reports from the field.
Review URL: http://codereview.chromium.org/150136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
where and the list of most recent redirects for each of those URLs.
Review URL: http://codereview.chromium.org/151057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoadAlternateHTMLString, changing types to WebKit API types and
allowing for more flexibility (supports loading non-HTML data).
LoadHTMLString is modified to support some optional parameters.
Note: Since WebFrame is going to soon be part of the WebKit API,
it is OK style-wise for it to use optional parameters.
This patch also includes a change to remove the securityInfo
property from WebURLRequest. I did this so that I could eliminate
the need to pass a WebURLRequest to LoadData / LoadHTMLString.
This also fixes a TODO of mine to eliminate this field on
WebCore::ResourceRequest since securityInfo (SSL cert info) is
really more of a response property. It was only part of the
request as a hack to support certain error pages. I work around
that by leveraging NavigationState in chrome/renderer.
I added some templatized, implicit constructors to WebData for
convenience. I plan to make similar changes to WebCString and
WebString in a future CL.
This CL is a incremental step toward moving ResourceFetcher out
of WebFrame.
BUG=15648
TEST=none
R=dglazkov
Review URL: http://codereview.chromium.org/150146
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556.
BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link.
Review URL: http://codereview.chromium.org/147247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11392
TEST=none
Review URL: http://codereview.chromium.org/151154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
going to need it again shortly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Implement displaying of notification, menu of popups still to come.
BUG=13160
TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab.
Review URL: http://codereview.chromium.org/150132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13160
TEST=none
Review URL: http://codereview.chromium.org/150163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hard, mmkay?).
BUG=12902
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15691
R=cpu
TEST=Set language to 'ru', run setup.exe with --show-eula
Review URL: http://codereview.chromium.org/150126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fixed a bug in ClearBrowsingDataController: checking Delete Form Data would end
up deleting passwords instead. Patch from Jens Alfke (snej@google.com).
BUG=12902
TEST=deleting form data should actually delete the form data.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overlapping views, including the findbar and resize widget. Three
classes currently inherit from BaseView: TabContentsViewCocoa,
RenderWidgetHostViewCocoa, and SadTabView (Mac).
BUG=http://crbug.com/10887
BUG=http://crbug.com/13150
TEST=Findbar should never disappear when searching. Resize
widget should never disappear. Clicking and dragging in a webpage should not move the window around.
Review URL: http://codereview.chromium.org/150104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
test, otherwise the test will hang waiting for reponse from the front-end.
Review URL: http://codereview.chromium.org/151143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy.
BUG=13936
Review URL: http://codereview.chromium.org/126137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=15677
Review URL: http://codereview.chromium.org/151140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
injection, and user script injection.
Also adds unit tests that EXTENSIONS_READY always gets fired.
Also removes some old test data that we weren't using.
Review URL: http://codereview.chromium.org/149120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, PageTransition::CHAIN_END flag is removed from a History database
entry for a redirect source, even when the redirect is user initiated.
This change prevents the flag removal for user-initiated redirects.
TEST=Open http://www.google.com/ig and click on tabs multiple times. Without
this change, only the last tab clicked appears in the History page (CTRL+H).
With this change, all the tabs should appear.
TESTED=gcl try, manually
BUG=11355
Review URL: http://codereview.chromium.org/147145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue is caused by my another mistake that I forgot setting the modifier-key state in creating a Char event in RenderWidgetHostViewGtkWidget::ForwardCharEvent().
Since the GtkIMContext signal-handlers don't use GdkEventKey objects and cannot get the modififer-key state, this change save the state in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent() before dispatching a key event to the GtkIMContext object.
Also, this change adds gtk_im_context_focus_in() and gtk_im_context_focus_out() calls to fix compatibility problems with ibus.
BUG=10953 "IME support"
BUG=15531 "regression: shift-space doesn't scroll the page backwards"
TEST=Open a test page in <http://crbug.com/15531>, press shift+space keys, and observe ev.shiftKey is true.
Review URL: http://codereview.chromium.org/151010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We also add ellipses to the bookmark title.
TEST = A bookmark with a title that has a UTF-8 character that spans
the 15 character truncation point should not cause "Gtk: Invalid input
string" errors. See http://dev.chromium.org/developers/coding-style
for an example of the problem. The title in that case is as follows:
"Coding Style \u200E(Chromium Developer Documentation)\u200E"
Review URL: http://codereview.chromium.org/147207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- set a better default size
- ellipsize columns
- allow users to change column widths
- remember user-modified column widths
BUG=http://crbug.com/14742
TEST=none
Review URL: http://codereview.chromium.org/151134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The optimization failed to account for the possiblity of consecutive reshapes with different sizes. Instead of making the optimization smarter, just get rid of it, as it isn't clear it helps anything.
BUG=none
TEST=resize browser with custom frame on.
Review URL: http://codereview.chromium.org/151132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- During first run (confusing the newbie)
- In other special situations when we show UI before the main chrome window is created
BUG=14192
TEST=see bug
Review URL: http://codereview.chromium.org/151061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added a stub for an unused method on Canvas in order to link.
TEST=Selecting "Open" from the shelf menu will open a download
BUG=15661
Review URL: http://codereview.chromium.org/150079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/150147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL.
BUG=12686
TEST=no
Review URL: http://codereview.chromium.org/150125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Although it will always be empty at this point, since storage isn't implemented yet.)
BUG=11745
TEST=none (no user-visible effect yet)
Review URL: http://codereview.chromium.org/147044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A call to Init had been removed.
BUG=http://crbug.com/15680
TEST=Download a file. Open the download page (CTRL-J) it should show the download.
Review URL: http://codereview.chromium.org/151110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15338
Review URL: http://codereview.chromium.org/151085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Port rest of window_sizer_unittest.cc to non-Windows.
Review URL: http://codereview.chromium.org/149035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents. I put a more accurately named static function in
ResourceDispatcherHost which is what really controls this request data.
I also moved a couple of static functions from the header to the cc in
resource_dispatcher.
Review URL: http://codereview.chromium.org/150124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/151089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15338
Review URL: http://codereview.chromium.org/150117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19670 0039d316-1c4b-4281-b951-d872f2087c98
|