| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Browser should pop up status when usb is inserted.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/547009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27214
TEST=Install Porsche theme. Change the window size. The silhouette of the Porsche should stay the same size (and not be stretche), remain the same absolute distance from the left, and be clipped off (and not shown) when the window is too narrow. Compare the behaviour on Windows.
Review URL: http://codereview.chromium.org/545018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add overloads to bookmark model for string16. Wrap wstring
versions in #if !defined since string16 is just a typedef of
wstring on windows.
TEST=exist
BUG=32013
Review URL: http://codereview.chromium.org/536013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to wrar42 for pointing it out.
BUG=30657
TEST=set nonexistant PATH, run chrome, try to open proxy configuration
Review URL: http://codereview.chromium.org/541014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In an earlier checkin I had removed the images from the IB files that used HoverCloseButtons, relying on them to be set programmatically. It seems that this causes a flaky sizing problem when loading from a NIB, which only manifested in the DownloadShelf for some reason.
Also change DownloadShelf.xib so that the close button is a child of the main view, not of the GTMWidthTweaker, which seems to eat redraw messages.
BUG=31785
TEST=Try out the download shelf a few times. You need to quit the whole app a few times to ensure it doesn't come back.
Review URL: http://codereview.chromium.org/540001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the renderer for a snapshot of the page.
BUG=19274
TEST=Manual testing on Mac,Linux,Win
Review URL: http://codereview.chromium.org/502034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26947
TEST=bookmark menu should behave normally but folders should now have icons too.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=31857
TEST=none
Mike Pinkerton recommended I use the cross-platform menu utilities for this; I decided not to do that yet, in this patch, for a few reasons:
(1) I'm in the midst of doing heavy refactoring of the tree/list controller classes in a local branch, so anything I do now would have to get changed a lot in that branch anyway.
(2) The Windows and GTK bookmark managers don't use them, so there's not existing common code to hook into. This means I'd have to write all that code, and presumably retrofit the other platform managers to use it. But we really want to get this patch into the upcoming (tonight?) dev-channel build to avoid user confusion.
I have not added a menu to the nib. I've added code to BookmarkManagerController to create the NSMenu programmatically. I can switch to the cross-platform utilities after my refactoring.
Another note: Yes, there is some duplication of code between the Groups and Tree controller classes. I'm not worrying about this because the Groups controller class is going away completely in my refactoring, so it only has a few more days to live. :-)
Review URL: http://codereview.chromium.org/549010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Augments the loadTimes() API with a new field, "wasFetchedViaSpdy".
BUG=31615
TEST=flip_network_transaction_unittest
Review URL: http://codereview.chromium.org/518039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if they aren't at the beginning of a line. Greasemonkey
allows this.
BUG=31076
TEST=Install http://userscripts.org/scripts/review/29876. The
install dialog should say 'Sans-serif default', not
29876.user.js.
Review URL: http://codereview.chromium.org/545002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when trying to unload a half-crashed extension.
TEST=none
BUG=30405
Review URL: http://codereview.chromium.org/523163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RenderViewHost for the TabContents of a DraggedGtkTab was changing,
and the dragged tab was using the backing store associated with the invalidated
RenderViewHost.
BUG=22731
TEST=See issue description
Patch from Garret Kelly <gdk@chromium.org>
Review URL: http://codereview.chromium.org/550002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This partially solves the issue in 30721, as it makes sure that
there is a Chrome message loop for the SSL socket adapter on
OS X/Linux. However, although it has stopped crashing, gaia
authentication still times out.
Renamed GaiaAuth::WorkerThread to GaiaAuth::WorkerTask and cleaned
it up.
BUG=30721
TEST=manual
Review URL: http://codereview.chromium.org/542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'YOU HAVE x FLAKY TESTS' as a test name.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- -[NSTableView selectRow:byExtendingSelection:] was deprecated in 10.3 and
is superseded by -[NSTableView selectRowIndexes:byExtendingSelection:].
- -[BookmarkGroupsController tableView:shouldEditTableColumn:row:] must be
declared in an @interface if it is to be called.
- In BookmarksOutlineView, -[NSOutlineView delegate]'s
id<NSOutlineViewDelegate> must be cast to BookmarkTreeController* before
using as a BookmarkTreeController*.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Refactored CompactLocationBar to Host/View to use DropdownBarHost/View.
* Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar.
Following features are not implemented yet.
* Window cripping while animating.
* Adjust location when toolbar is shown (it's always under tab)
* clipping autocomplete dropdown.
Timer code is no longer used right now, but is left intentionally as we may put it back.
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35674
Review URL: http://codereview.chromium.org/525018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/547005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/519009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids retaining navigation history relating to the incognito window.
I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary.
BUG=24629
Review URL: http://codereview.chromium.org/523076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobar has been shown to the user. autofill.enabled is true if the user has accepted the autofill confirmation infobar.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
item for "common missteps" (was in the wrong section).
BUG=31655
TEST=None
Review URL: http://codereview.chromium.org/541011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly.
2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this).
BUG=21699
TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line.
Review URL: http://codereview.chromium.org/381009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
over the Omnibox while it was out of focus.
BUG=31449
TEST=Hover over the omnibox when it is out of focus (but the app is in focus). Observe that the I-Beam is shown instead of the arrow cursor.
Review URL: http://codereview.chromium.org/544007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. On X changing fullscreen is asynchronous. This means we have to ask
the window to change it's fullscreen state, then once changed update
the necessary things.
. ExtensionShelf is needlessly triggering a bunch of layouts when we
toggle fullscreen state.
BUG=31143
TEST=see bug
Review URL: http://codereview.chromium.org/542001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
interpreted as format strings.
BUG=31085
Review URL: http://codereview.chromium.org/523131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=26050
TEST=Updated existing unit tests ExtensionTest.InitFromValue*, manual testing on Linux.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35802
Review URL: http://codereview.chromium.org/523132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
To send unhandled keyboard events to the system default handler, so that system accelerators can work as normal.
BUG=30707: Keyboard shortcuts failed to work on Bookmark sync Sign in Authentication dialog
TEST=See bug report.
Review URL: http://codereview.chromium.org/525112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clicking on the bookmark bar. The regression is the result of
introducing AccessibleToolbarView as a superclass of BookmarkBarView
and having it override ShowContextMenu.
BUG=none
TEST=right click on an empty spot of the bookmark bar and make sure
you get a context menu.
Review URL: http://codereview.chromium.org/544001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality.
Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.
Next try: Submitting to get perf numbers, will revert.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883
Review URL: http://codereview.chromium.org/549002
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/536009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality.
Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.
Next try: Submitting to get perf numbers, will revert.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883
Review URL: http://codereview.chromium.org/549002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality.
Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.
Submitting to get perf numbers, will revert.
Review URL: http://codereview.chromium.org/549002
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/544004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality.
Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though.
Submitting to get perf numbers, will revert.
Review URL: http://codereview.chromium.org/549002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make EntryKernel have only private data members.
When we switch to protobuf based storage, we'll need to use getters and
setters.
BUG=30041
TEST=unit tests
Review URL: http://codereview.chromium.org/500113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: Connect "Task Manager" to first responder's commandDispatch:, give it tag 40005 (IDC_TASK_MANAGER in chrome/app/chrome_dll_resource.h), check "Enabled" checkbox (this has no effect, but is consistent with the rest of the nib).
Due to http://codereview.chromium.org/518085 , the task manager is still disabled, but it's easier to turn on after this CL (only one small change in browser.cc).
BUG=13156
TEST=Click View->Developer. "Task Manager" should still be disabled.
Review URL: http://codereview.chromium.org/541005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This was stolen from Finnur's internal wave mostly.
TBR=finnur@chromium.org,kathyw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It's failing continuously on Valgrind Mac build bot.
BUG=28445
TBR=japhet,lzheng
Review URL: http://codereview.chromium.org/545004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TaskManagerBrowserTest.NoticeExtensionChanges is crashing occasionally on XP.
BUG=31663
TBR=japhet,lzheng
Review URL: http://codereview.chromium.org/536007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The window manager side of this change (already committed) is
described at http://codereview.chromium.org/527005. This
change also makes Chrome report the version of the IPC messages
that it's using to the window manager at startup.
TEST=built and tested that panel-dragging works as expected
BUG=none
Review URL: http://codereview.chromium.org/521070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
includes base/logging.h which is difficult to compile under nacl. base-logging is stubbed in gpu by gpu/common/logging.h.
BUG=26104
Review URL: http://codereview.chromium.org/527009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We rename implicit downloads so they don't conflict with existing
files, but we should prompt if you manually type in an existing
filename.
BUG=26117
Review URL: http://codereview.chromium.org/537005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind bots are up (they're still red tho).
I believe it's ready to check this in.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/487003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
present but no 'ap' child). Also made recognizing beta/dev a touch
more general.
BUG=31772
Review URL: http://codereview.chromium.org/534005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GTK dialogs size to their contents, but sometimes the title is the
longest string available.
BUG=28024
Review URL: http://codereview.chromium.org/534006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/535005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make it use the same font as other 'domUI' pages.
While doing so, get rid of some unnecessary string conversions in browser_about_handler.cc
BUG=31782
TEST=Run Chrome with --lang=ar / --lang=he on Windows (or LANGUAGE=ar or LANGUAGE=he on Linux) and go to 'about:plugins' page. The page should be properly 'RTLized'.
Review URL: http://codereview.chromium.org/523153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
message loop returns. The problem with the old approach was we created
a bunch of windows than exited the nested message loop. But because
exit isn't processed immediately it meant someone could also ask for
the nested loop to be exited and then you're hosed (one nested message
loop still running).
BUG=22878
TEST=none
Review URL: http://codereview.chromium.org/519090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35850 0039d316-1c4b-4281-b951-d872f2087c98
|