| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the data of the image, where as XDestroyImage does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/386003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
is already registered as an NPAPI plugin, keep that registration information up to date across updates.
Review URL: http://codereview.chromium.org/385015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't fix bug 26979, but I want to get these DCHECKs in as I continue
to investigate that bug.
BUG=26979
TEST=don't hit these DCHECKs
Review URL: http://codereview.chromium.org/385043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the external change.
BUG=26826
TEST=none
Review URL: http://codereview.chromium.org/388011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
BUG=19361
Review URL: http://codereview.chromium.org/384050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
another tab.
(This really fixes 3 issues)
1. When the bookmarks bar is not docked, it toggles on and off when switching between the NTP and another tab. Since it is part of the UI, this causes the TabContents to be resized. This causes ugly re-layout of some webpages and also causes the NTP to jump when you switch to it, if themed. The solution is to toggle the floating bookmarks bar at a time when no TabContents is attached - that is, after detaching the first one but before attaching the second one.
2. Changing the info-bar can also cause a resize, so we also want to do this when no TabContents is attached.
3. Finally, when the NTP is displayed and another, floating tab is dragged and inserted to the left of the NTP, the selected tab index will not be set correctly. As a result, the NTP will be resized incorrectly before the tabs are even switched.
R=beng
BUG=23925
TEST=1. Apply Ratchet and Clank theme. Open NTP and Google Calendar in tabs. Switch back and forth between them. The NTP background should not jump or flicker, and Calendar should not re-layout. 2. Try switching between the NTP (or Calendar) and a tab that has an info-bar. 3. Open NTP and another tab. Drag the other tab until it detaches from the windows and floats. Re-attach and detach the tab repeatedly, so that the window switches between displaying the two tabs, and make sure you insert the other tab to the *left* of the NTP. The NTP should never jump.
Review URL: http://codereview.chromium.org/376018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notes:
- did not include startslim as its popularity was too low (as reported by Alexa)
- did not use espanol.yahoo.com for bolivia, instead used yahoo.com (as with most Latin American countries). espanol.yahoo.com seems to be aimed at es_US
- Did not remove fr_CA engines, because it seems prudent to use localized engines when possible
- Switzerland - 14 engines were listed. I took the 6 that I thought were probably most popular.
- did not include Onkosh as its popularity was too low (as reported by Alexa)
- yp.com.hk - this is Yellow Pages Hong Kong, not a web search. Did not include it.
- virgilio - I am super confused as to whether it's virgilio or virgilio.alice.it. Left it alone.
- Did not remove delfi_lt because it is a really popular site (probably popular search engine) in Lithuania. The fact that it is localized is not a mark against it.
- xalo.vn - again not popular enough
List of completely removed engines (i.e. engines no longer in use for _any_ country):
- adonde
- aeiou
- aladin
- altavista_es
- altavista_mx
- aol_fr
- aonde
- ask_de
- ask_uk
- biglobe
- bigmir
- bluewin
- conexcol
- delfi_ee
- embla
- empas
- eniro_dk
- finna
- forthnet
- gigabusca
- goo
- iafrica
- ilse
- jamaicalive
- krstarica
- live*
- lycos*
- matkurja
- meta
- msn*
- mweb
- mywebsearch
- nan10
- netindex
- nifty
- ohperu
- orange
- sesam
- sogou
- soso
- szm
- t_online
- terra_ec
- terra_mx
- terra_pe
- toile
- vinden
- voila
- web_de
- yagua
- yam
BUG=23909
Review URL: http://codereview.chromium.org/385032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/387027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/390010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Causes tab_switching_test to go red. Reverting this commit
which is part of the investigation.
BUG=4104
TEST=tab_switching_test goes green
Review URL: http://codereview.chromium.org/384049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27351
TEST=none
Review URL: http://codereview.chromium.org/385034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.
I modified the tab switching test to use the new tab
switch paint duration histogram in place of the whiteout
duration histogram. As a measure, whiteout duration
would not carry a value if we kept the backing store
around for a tab, and we would end up with a result of
zero instead of a useful result. Local results with the
new measure are consistent with the number of operations
we perform on the tabs.
The tab switching test now fails if it cannot locate
the correct histogram. In that case, it will output
the contents of the log file for remote debugging.
BUG=4104
TEST=count of tab switch paint duration histogram
results in tab switching test equals number of tabs
used in test
First committed as: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632
Reverted in: 31645
Review URL: http://codereview.chromium.org/378038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27156
TEST=Install an extension, the installed successful bubble should have a close button with an x image that will close the bubble when clicked.
Review URL: http://codereview.chromium.org/384026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
figure out how to use the system icon without regressing startup time.
BUG=26457
TEST=Look at bookmarks bar. The folder icon, while not being the system folder icon, is at least blue.
Review URL: http://codereview.chromium.org/389012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Allow non-windows BalloonCollections to create non-viewable balloons (so that non-viewing aspects are cross-platform testable)
* Makes NotificationObjectProxy overridable by a mock object which logs instead of calls to JS
* Move Layout code from private to protected in BalloonCollection to enable verification of position code.
BUG=none
TEST=these
Review URL: http://codereview.chromium.org/371041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27366
TEST=DevToolsSanityTest.TestPauseWhenLoadingDevTools
Review URL: http://codereview.chromium.org/392002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27379
TEST=creating new windows with app modals, tab modal, window modals
Review URL: http://codereview.chromium.org/387025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24419
TEST=TSAN
Review URL: http://codereview.chromium.org/391017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
InitWindowCreatePoint when making a tab pinned, which is only save to
invoke when the drag starts.
BUG=27329
TEST=make sure no regressions in tab dragging.
Review URL: http://codereview.chromium.org/391006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and more solid.
Sleeping for about 6 seconds is not a good idea.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/385010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser's status.
* Update the states of menu before showing menu like Window's menu does.
* Don't fire activate signal when the state is chagned via API.
* Eliminated UpdateStateData and replace it with the NativeMenuGtk and the position
stored in the gtk widget.
* Fixed StateAreaView to check bookmark bar status.
BUG=27210
TEST=Run linux builds (gtk/views/chromeos) check if the bookmark bar menu's status is in sync with the bookmark bar.
Review URL: http://codereview.chromium.org/383012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserActionView because RemoveChild() does not delete it.
This could maybe cause OnImageLoaded() to be called when
there is no parent. I couldn't see any other path that could
lead to that.
BUG=27167
TEST=none
Review URL: http://codereview.chromium.org/385031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller.
Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it. Happily, this also seems to save quite a bit of code.
BUG=20511
TEST=Type a character in the omnibox, minimize the window, and restore it. The dropdown should have disappeared.
Review URL: http://codereview.chromium.org/391011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on http://codereview.chromium.org/342103 .
I will land this to see the startup perf impact, then revert this after a short while, and then send it out for review.
BUG=26457
TEST=Look at bookmark bar's "Other bookmarks". Should have blue folder.
Review URL: http://codereview.chromium.org/384039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=chase@chromium.org
TEST=tab_switching_test
BUG=none
Review URL: http://codereview.chromium.org/389006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
backed up by Time Machine. The bug describes appropriate long-term solutions to this problem.
BUG=259595
TEST=Launch Chrome. Inspect the following files found in ~/Library/Application Support/Chromium/Default/: a) History, b) History-journal, c) Thumbnails, and d) Thumbnails-journal and verify that they are not being backed up by Time Machine.
Review URL: http://codereview.chromium.org/387016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27226
TEST=open task manager, enable column, compare with V8 heap profiler
Review URL: http://codereview.chromium.org/377037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27322
TEST=none
Review URL: http://codereview.chromium.org/384031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes leak in BackingStore as shown by valgrind. XFree doesn't free
the data of the image, where as XDestroyImage does.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/391008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RWH_TabSwitchPaintDuration histogram calculates
the amount of time it took after a particular view was
selected for it to be fully painted.
I modified the tab switching test to use the new tab
switch paint duration histogram in place of the whiteout
duration histogram. As a measure, whiteout duration
would not carry a value if we kept the backing store
around for a tab, and we would end up with a result of
zero instead of a useful result. Local results with the
new measure are consistent with the number of operations
we perform on the tabs.
The tab switching test now fails if it cannot locate
the correct histogram.
BUG=4104
TEST=count of tab switch paint duration histogram
results in tab switching test equals number of tabs
used in test
Review URL: http://codereview.chromium.org/378038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
appear when rtl.
BUG=26376
TEST=see bug
Review URL: http://codereview.chromium.org/384021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19784
TEST=On a system with two network adapters, ensure one has an active internet
connection, and the other does not. Disconnect the active one, and check that
in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to
network_alive->alive() returns false.
Review URL: http://codereview.chromium.org/377019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Creating RenderWidgetHostView for gtk
* Fix assertion failure in BrowserBubble
* Don't change the window size if the size is empty, which causes gtk assertion error.
With this change, most of extension tests in browser passes except for toolstrip.
Given that toolstrip is obsolete, may be we should just remove it from test.
BUG=None
TEST=Run browesr_tests. All tests for extension must pass except for ExtensionApiTest.Toolstrip
Review URL: http://codereview.chromium.org/390006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only paint portions of their backing store.
This also implements correct memory management on the chrome side. We can now
supply more than one backing store, and will delete them properly when requested
by the plugin.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/371093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to
render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g.
Windows XP with no RTL fonts installed).
BUG=23425
TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs.
Review URL: http://codereview.chromium.org/384018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Create a GtkChromeLinkButton, and then use gtk_chrome_link_button_set_label() to change the text. The displayed text should be the new text.
Review URL: http://codereview.chromium.org/391005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31618 0039d316-1c4b-4281-b951-d872f2087c98
|