| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=47179
Review URL: http://codereview.chromium.org/2884008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The database will no longer store the thumbnails - TopSites is storing it's own thumbnails.
BUG=None
TEST=ThumbnailDatabaseTest
Review URL: http://codereview.chromium.org/2842034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
usage of the std::string substr() API.
BUG=47624
TEST=See bug
Review URL: http://codereview.chromium.org/2876024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains SETTINGS:
Made certificate_path_ a string instead of a FilePath.
Modify ConnectToWifiNetwork to take std::string.
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/2869019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently hang up the IO thread.
R=wtc
BUG=148
TEST=verify that downloads, etc., are not interrupted by a <keygen>
Review URL: http://codereview.chromium.org/2854007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding: http://codereview.chromium.org/2860037 The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2854032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support -- not hooked up at this point.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2866025
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/2866035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds space between the button(s) and the overflow chevron (or the separator if there is no overflow menu). It makes the spacing match windows on the right (the left is kind of hard to judge since windows now hides the gripper).
BUG=47487
TEST=manual
Review URL: http://codereview.chromium.org/2857031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hooked up at this point.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2866025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only an incognito window was visible.
BUG=41087
Review URL: http://codereview.chromium.org/2881004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This failure was actually due to r51159.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2864029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=cros:4372
TEST=Verify that both image from camera and picture taken when camera image is clicked are mirrored.
Review URL: http://codereview.chromium.org/2872021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(ChromeOS Bug id)
BUG=4405
TEST=passed linux try server
Review URL: http://codereview.chromium.org/2885008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47386
TEST=manual
Review URL: http://codereview.chromium.org/2799044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=DockInfoTest
Patch by Xiaotian Chen <sargrass@google.com>
Review URL: http://codereview.chromium.org/2805049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2831032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fixed.
BUG=47843,47863
TEST=none
Review URL: http://codereview.chromium.org/2867033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using NSTextInputClient protocol somehow causes beep when typing.
BUG=25037 Use NSTextInputClient instead of NSTextInput ?
BUG=47890 [Leopard] Typing any letter beeps in the normal edit box
TEST=Typing in text box should not beep.
Review URL: http://codereview.chromium.org/2810040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
across platform implementations.
BUG=38736
TEST=gpu unittests
Review URL: http://codereview.chromium.org/2830025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make the rendering for multiple buttons pretty by unifying sequnces of
buttons.
- Add the zoom label control and make the wrench menu model listen for
notifications about zoom percentage changing.
- Fixes crash that would have gone away once this was taken out from behind a flag
BUG=45757
TEST=none
Review URL: http://codereview.chromium.org/2799043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds support for language detection on the server side.
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
Original review:
http://codereview.chromium.org/2859013/show
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2860037
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2873035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CLD can sometimes fail to detect the language of a page, in which case the translate server might be able to. This CL ensures the browser deals with the server side language detection properly.
Also added a new factory method to create error translate infobar delegates that does not assert when the language code is incorrect.
Also changed the enums in TranslateInfoBarDelegate2 to use the constant name style, as it is the preferred naming for enums according to the style guide.
Original review:
http://codereview.chromium.org/2859013/show
BUG=40857
TEST=Visit http://www.saanconf.org/saanday.htm, use the context menu
to translate the page. You should get an error mentioning the
page is already in English.
Review URL: http://codereview.chromium.org/2860037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
should select all, accessibility focus should be preserved when the whole
window loses and regains focus, and clicking on the location bar should exit
accessibility focus mode.
BUG=47380
BUG=36070
BUG=47784
TEST=none
Review URL: http://codereview.chromium.org/2833040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
BUG=47979
TEST=Greener Linux bots
Review URL: http://codereview.chromium.org/2811038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=zelidrag
BUG=47977
TEST=Green ChromeOS bot
Review URL: http://codereview.chromium.org/2833043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renegotiation extension was introduced into TLS in [1], to address
the attack described in [2]. In order to fully protect ourselves,
clients need to require support from servers. However, these things
take a long time to roll out.
As an initial measure, we start to require the extension from a
whitelist of servers that we known to support the extension. We are
then protected from prefix attacks against these servers. Over time,
if the list grows we might want to share it with Mozilla, but we'll
start simple.
[1] http://tools.ietf.org/html/rfc5746
[2] http://www.educatedguesswork.org/2009/11/understanding_the_tls_renegoti.html
http://codereview.chromium.org/2045006/show
TEST=Setup a dummy TLS server without renegotiation extension support (Hardy) will do and force mail.google.com to it using /etc/hosts. Navigate to https://mail.google.com and check for ERR_SSL_UNSAFE_NEGOTIATION.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45737
TEST=opening and closing tabs really fast
Review URL: http://codereview.chromium.org/2863033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugins.
GetPluginInfo() now returns true if the plugin is found, whether it's enabled or not. To find out whether the plugin is enabled, check the enabled flag in the WebPluginInfo struct output parameter. This enables getting information about disabled plugins.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2858035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=LinkInfoBarControllerTest.*
BUG=47728
Review URL: http://codereview.chromium.org/2842031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Correct descriptions in ADM/ADMX template and change registry key to "Chrome" from "Google Chrome".
Fix numerous punctuation, verbiage and wording issues.
Fix HomepageIsNewTabPage so that not checking the checkbox actually forces the hompage to the homepage URL.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2806040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add 10% when checking for update. If image is not cached on server it will take some time.
BUG= http://crosbug.com/4208, http://crosbug.com/4003
TEST=Manual. Start with fresh install. After Sign In screen is shown, select BWSI and then Sign out. OOBE should not be started again.
Review URL: http://codereview.chromium.org/2833038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/4116
TEST=Language menu should be focusable by keyboard on new user login.
Review URL: http://codereview.chromium.org/2815037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
show of login screen.
BUG=cros:4356
TEST=Verify that no white rectangles flicker near user pods on initial show.
Review URL: http://codereview.chromium.org/2887002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Review URL: http://codereview.chromium.org/2802018
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2861039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Review URL: http://codereview.chromium.org/2802018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Handle registration events properly.
BUG=34647
TEST=new unittests
Review URL: http://codereview.chromium.org/2861034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems we can use this function in other environments.
BUG=47277
TEST=none
Review URL: http://codereview.chromium.org/2807029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32413
TEST=manual
Review URL: http://codereview.chromium.org/2833042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
several tests to fail their SaveChanges()es. Add unit test for the DBS migrations.
BUG=47466
TEST=sync_unit_tests (and included new tests).
Review URL: http://codereview.chromium.org/2830027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'll use the function to implement crosbug.com/2619 (Implement input language selector on the log in page)
BUG=none
Review URL: http://codereview.chromium.org/2861022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2817042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remoting/remoting.gyp.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/2885005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47843,47863
TEST=unittests, valgrind
Review URL: http://codereview.chromium.org/2872024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
original review: http://codereview.chromium.org/2885006
----------
This is almost certainly caused by a start-up or shut-down race, but CreateWindowValue doesn't have much meaning without a window attached to the browser, so just return an error in those cases
BUG=47808
TEST=none.
TBR=asargent
Review URL: http://codereview.chromium.org/2858036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2805047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/2815034
BUG=45546
TEST=Open content settings dialog. Should have a list on the left instead of tabs on top. Other than that, the dialog should work as before.
Review URL: http://codereview.chromium.org/2799042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new tab page.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.
TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429
Review URL: http://codereview.chromium.org/2835009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46075
TEST=see bug
Review URL: http://codereview.chromium.org/2828014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51202 0039d316-1c4b-4281-b951-d872f2087c98
|