| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TEST=NONE
BUG=NONE
Review URL: http://codereview.chromium.org/1582023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first pass. A few more may be deleted once I clean up the bookmark
context menu code.
BUG=38908
TEST=everything still works
Review URL: http://codereview.chromium.org/1763017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=CrOS Valgrind bots compile.
TBR=yusukes
Review URL: http://codereview.chromium.org/1723017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removes extra retains in unit tests that are now unneeded. Triggered valgrind report.
BUG=42051
TEST=BookmarkBarFolderHoverStateTest.HoverState
Review URL: http://codereview.chromium.org/1756016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42466
TEST=see bug. Also, drags from firefox bookmark bar to tabbed bookmark manager should work.
Review URL: http://codereview.chromium.org/1691018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Context menu code still needs cleanup/refactoring.
String resources still need to be deleted.
BUG=38908
TEST=everything still works
Review URL: http://codereview.chromium.org/1730015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We had some info in the man page and other info in the about page.
This change makes the about page refer to the man page, and updates
the man page with missing info.
While I'm at it, make the HTML slightly prettier.
Review URL: http://codereview.chromium.org/1695023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just manually blacklist one of the copies. We already do
this for some other modules.
BUG=42663
Review URL: http://codereview.chromium.org/1803004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36384
TEST=none
Review URL: http://codereview.chromium.org/1699016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Link the name of the extension on the management page to the
gallery page, if the extension is from the gallery.
BUG=29739
TEST=Install a gallery extension and a thirdparty extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).
Review URL: http://codereview.chromium.org/1792006
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/1807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of the AddString() and AddStringLiteral() methods.
- Make EventParameters able to serialize to JSON, instead of a string.
BUG=37421
Review URL: http://codereview.chromium.org/1716007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gallery page, if the extension is from the gallery.
BUG=29739
TEST=Install a gallery extension and a third-party extension and make sure the gallery extension name is a link (whereas the third party extension name is static text).
Review URL: http://codereview.chromium.org/1792006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1703010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
determining text to copy to clipboard.
BUG=41493
TEST=see bug
Review URL: http://codereview.chromium.org/1765008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/42321
TEST=as in bug
Review URL: http://codereview.chromium.org/1758012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue with bookmark hover where button target is dealloc'd without properly
cancelling delayed hover button open.
BUG=42051
TEST=Manual according to steps in bug.
Review URL: http://codereview.chromium.org/1706017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
browser to test plugins.
BUG=28716
TEST=Building the plugin_tests target also builds the chrome target.
Review URL: http://codereview.chromium.org/1734010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes adding a few methods to ExtensionPrefs that I'm going to need to
use inside ExtensionUpdater for implementing the "do updates at idle" feature.
Instead of adding more call-through stubs to the interface that
ExtensionsService providers to the ExtensionUpdater, I instead decided it was
time to do some refactoring to expose a ExtensionPrefs getter in the interface.
TEST=(Should be covered by unit/browser tests)
BUG=37971
Review URL: http://codereview.chromium.org/1695018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visual inspection.
Review URL: http://codereview.chromium.org/1701015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we can rely on toolkit_views to be set when appropriate,
we can simplify a bunch of logic in gyp.
TEST=compiles
Review URL: http://codereview.chromium.org/1741010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/491
BUG=crosbug.com/2623
TEST=manual
Review URL: http://codereview.chromium.org/1694017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the forms once translation has occurred. This change also includes another
variaton of the Name field, with tests. In addition, this change fixes parsing
labels whose text element is not the first child of the label element.
BUG=41694
TEST=FormManagerTest.LabelsWithSpans,NameFieldTest.FirstLast
Review URL: http://codereview.chromium.org/1801002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=42641
Review URL: http://codereview.chromium.org/1708011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.xib changes: change all ToolbarButtonCells to GradientButtonCells.
(Previously committed at r45698, reverted at r45703. I don't know why the local
build and the try succeeded. This time, I fixed the slightly-broken include.)
BUG=42582
TEST=builds properly *and* toolbar buttons and find bar buttons still work as before
Review URL: http://codereview.chromium.org/1762012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
favicons when changed via Javascript.
BUG=none
TEST=BrowserTest.FaviconChange
Review URL: http://codereview.chromium.org/1747015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40020
TEST=DirectoryBackingStoreTest.Corruption
Review URL: http://codereview.chromium.org/1733008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=all try bots passed
BUG=none
Review URL: http://codereview.chromium.org/1774006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
That would allow us to spot it immediately if it reappears.
BUG=39734
Review URL: http://codereview.chromium.org/1723015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.xib changes: change all ToolbarButtonCells to GradientButtonCells.
BUG=42582
TEST=toolbar buttons and find bar buttons still work as before
Review URL: http://codereview.chromium.org/1697011
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/1695020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib change: removed "Page Setup" menu item
BUG=http://crbug.com/36653
TEST=as in bug
Review URL: http://codereview.chromium.org/1741011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
determining text to copy to clipboard. I also added call to
WriteBookmark and fixed up setting selected_text_.
BUG=41493
TEST=make sure copy/paste from the omnibox work sanely on linux. Seriously
though, see the three bugs for specifics.
Review URL: http://codereview.chromium.org/1801001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1725010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
.xib changes: change all ToolbarButtonCells to GradientButtonCells.
BUG=42582
TEST=toolbar buttons and find bar buttons still work as before
Review URL: http://codereview.chromium.org/1697011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes Evan's patch: http://codereview.chromium.org/1611033
This roll sits after a revert to Skia's hairline change so,
hopefully, doesn't need any rebaselines. The try servers mostly agree
although there's one (clip-path-text-and-shape.svg on Windows) that I
need to keep on eye on. (That's why I'm landing this before MTV is
active.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no change
Review URL: http://codereview.chromium.org/1791004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- During keystone registration pull in the brand file at user to system level.
- Clean up old user level brand files after moving to a system ticket.
- During keystone ticket promotion, use the pref flight script to copy the brand information out to the system level.
- When updating check to see if the user had manually updated the app and gotten a new brand code, if so, migrate that code into the right location.
BUG=39131
TEST=email from tvl to QA with details.
Review URL: http://codereview.chromium.org/1687012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen.
Block buttons/keyboard on login window when sign in is in process.
BUG= http://crosbug.com/2573, http://crosbug.com/2528
TEST=Run through OOBE screens and observe spinner when network response is more than 0.5 seconds.
Review URL: http://codereview.chromium.org/1755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1800002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac (prior EasyStreet), http://www.google.com might be redirected to
wifi.corp.google.com, so that google:baseURL would be set to
wifi.corp.google.com, but user might want to use the URL for default search.
BUG=38472
TEST=GoogleURLTrackerTest.CheckAndConvertURL passes
Review URL: http://codereview.chromium.org/1780006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Committing for rsimha@chromium.org. Original review: http://codereview.chromium.org/1739007/show
Added a boolean field to class ChromeTestSuite, called "created_user_data_dir_". It defaults to false, and is set to true if no value is passed for --user_data_dir via command line. If the flag is false, the directory specified by the user is not deleted after test execution, and if it is true, the directory is deleted, as it always has been.
Note: user_data_dir is emptied before test execution -- this behavior remains unaltered.
BUG=42374
TEST=User profile directory still exists after running a test with --user-data-dir.
Review URL: http://codereview.chromium.org/1755009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40037
TEST=Linux Views bot goes green?
TBR=oshima
Review URL: http://codereview.chromium.org/1792004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42514
TEST=CrOS bot goes green.
TBR=oshima
Review URL: http://codereview.chromium.org/1726010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes copy prefix the text with http if the user hasn't edited the
text, and the scheme is http but the text doesn't include http.
. Makes copying use the url as the text if the user hasn't edited the
text and it's http/https.
. Makes control-insert/shift-insert use our copy/paste.
BUG=41639 41489 41493
TEST=make sure copy/paste from the omnibox work sanely. Seriously
though, see the three bugs for specifics.
Review URL: http://codereview.chromium.org/1761002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) When one of the mini tabs is an app (nano) tab, we
now increase the margin between the mini tabs and the
regular tabs by a few pixels.
This is because with the large icons for nano tabs, it
looks a little squished against the regular tabs in the
tabstrip.
2) When dragging a nano tab within the tab strip, the
background "handle" would grow to be as large as a
regular tab (while dragging) due to the fact that
UpdateData (that DraggedTabView calls) was not
transferring the app tab bit to the new Tab.
BUG=None
TEST=Visual inspection.
Review URL: http://codereview.chromium.org/1700016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42514
TEST=Bot goes green.
TBR=oshima
Review URL: http://codereview.chromium.org/1794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PasswordStoreMac
so that the sync backend can register as an observer.
BUG=35038
TEST=none
Review URL: http://codereview.chromium.org/1752007
TBR=albertb@chromium.org
Review URL: http://codereview.chromium.org/1763013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1723014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45659 0039d316-1c4b-4281-b951-d872f2087c98
|