summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Reland r68893 after fixing allowing blocking IO on shutdown.willchan@chromium.org2010-12-143-0/+17
| | | | | | | | | | | | | | | | | | This time I just turned off the checking for Chrome/Windows because Chrome/Windows shutdown is a clusterf***. TODO(willchan): Give a shit about Windows, get a machine that runs Windows, debug Chrome shutdown on Windows, enable this ThreadRestrictions for Chrome/Windows. Consider PlatformThread::Join() to be blocking IO. Marks PlatformThread::Join() as blocking IO using ThreadRestrictions. Whitelists existing spots where we join on the UI/IO threads. Also noteworthy is I allow blocking IO on shutdown. BUG=65530, 66077, 66082 TEST=existing Review URL: http://codereview.chromium.org/5750003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69079 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ResourceMessageFilter to RenderMessageFilter, since that's what it ↵jam@chromium.org2010-12-1427-323/+317
| | | | | | | | actually is. I will add a ResourceMessageFilter just for resource IPCs in a future change. Review URL: http://codereview.chromium.org/5701004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69076 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-12-141-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69075 0039d316-1c4b-4281-b951-d872f2087c98
* webkit: use string16 in ContextMenuParamsevan@chromium.org2010-12-148-8/+15
| | | | | | | | | BUG=23581 TEST=compiles Review URL: http://codereview.chromium.org/5712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69074 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension packer command-line code for Mac. Instead of blocking in a ↵andybons@chromium.org2010-12-137-101/+109
| | | | | | | | | | | | | janky way by running the message loop, I added an option to run the extension packer job synchronously. One thing to note as it pertains to the bug report is that the path must be fully qualified. ~/ for home directories doesn't work for me. BUG=65645 TEST=none Review URL: http://codereview.chromium.org/5703004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69073 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for safebrowsing service.lzheng@chromium.org2010-12-137-35/+455
| | | | | | | | BUG=none TEST=safe_browsing_service_browsertest Review URL: http://codereview.chromium.org/5544008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69072 0039d316-1c4b-4281-b951-d872f2087c98
* Added 'dry run' tag to the print job, to test proxy health without wasting ↵gene@google.com2010-12-1310-9/+76
| | | | | | | | | | | paper/ink. BUG=none TEST=Make sure 'dry run' jobs does not get printed. Review URL: http://codereview.chromium.org/5736004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69071 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix stuck hover state in bookmark buttonsail@chromium.org2010-12-131-10/+42
| | | | | | | | | | | | | | | | Bookmark buttons would get stuck with a hover state if they were obscured while the mouse was inside the button. The problem was that the hover state only tracked the mouse entered and exited events. Unfortunately if the button is obscured because it has been removed from the window then a mouse exited event is not sent. Fix was to also update the hover state in the -[NSCell resetCursorRect:inView:] event. This change also improves the mouse tracking code by checking if the mouse is already in over the button. BUG=27073 TEST=Changed tabs with the mouse over a bookmark button. Verified that the hover effect was no longer there after closing the new tab. Did a similar test by entering full screen. Verified that the hover effect was no longer there. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69068 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Workaround issue 45478: IME dysfunctional after BACKSPACEsuzhe@google.com2010-12-132-15/+38
| | | | | | | | | | | | | | The reason of the issue is ibus intercepts all key events and does not forward them to chrome at all, while webkit relies on key events to reset one of its internal flag. This CL just fakes key down/up events if the input method intercepts all key events. BUG=45478 TEST=see bug report. Review URL: http://codereview.chromium.org/5787004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69067 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Rename PasswordsException* to PasswordManager*.jhawkins@google.com2010-12-1311-82/+83
| | | | | | | | | BUG=59282 TEST=none Review URL: http://codereview.chromium.org/5810002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69065 0039d316-1c4b-4281-b951-d872f2087c98
* Single deinlining in first_run.{cc,h}erg@google.com2010-12-132-8/+18
| | | | | | | | | | | (This used to break chrome_frame linking, but after rebasing, there doesn't seem to be any issue.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5708004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69064 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix Shift+Ctrl selection of the list for Windows.arv@chromium.org2010-12-131-1/+2
| | | | | | | | | | | | | BUG=64964 TEST=1. On Windows go to Bookmarks manager. 2. Go to a folder with multiple bookmarks. 3. Select a bookmark 4. Hold down Shift and Ctrl. Click on another bookmark. All the bookmarks between the items should also be selected. Review URL: http://codereview.chromium.org/5780002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69063 0039d316-1c4b-4281-b951-d872f2087c98
* Update OTR icon; deeper shadows match the other platforms better.avi@chromium.org2010-12-131-189/+261
| | | | | | | | | BUG=none TEST=OTR icon's glasses are near-black, not gray Review URL: http://codereview.chromium.org/5808002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where icon is not displayed in extension install bubblesaa@chromium.org2010-12-134-8/+22
| | | | | | | | | | | | when installed from store. BUG=65346 TEST=Install any extension from the web store. Should see icon in install success bubble. Review URL: http://codereview.chromium.org/5690004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69060 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove obsolete dump_signature.py.thestig@chromium.org2010-12-131-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5721004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69058 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems from my change to IndexedDBDispatcherHost.jam@chromium.org2010-12-131-0/+20
| | | | | | | TBR=jorlow Review URL: http://codereview.chromium.org/5696003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69057 0039d316-1c4b-4281-b951-d872f2087c98
* fix bad mergejam@chromium.org2010-12-131-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with my last change ↵jam@chromium.org2010-12-131-0/+1
| | | | | | | | | (http://src.chromium.org/viewvc/chrome?view=rev&revision=69050). TBR=jorlow Review URL: http://codereview.chromium.org/5809002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69053 0039d316-1c4b-4281-b951-d872f2087c98
* Make IndexedDBDispatcherHost be a message filter and move its messages into ↵jam@chromium.org2010-12-1321-1515/+1306
| | | | | | | | a separate file. Review URL: http://codereview.chromium.org/5680007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69050 0039d316-1c4b-4281-b951-d872f2087c98
* Make DOMStorageDispatcherHost be a message filter (and rename it ↵jam@chromium.org2010-12-1328-747/+651
| | | | | | | | accordingly). It now derives from BrowserMessageFilter and hence gets message dispatching to different threads for free. Review URL: http://codereview.chromium.org/5722003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69049 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillField::set_heuristic_type: avoid redundant logic in DCHECKisherman@chromium.org2010-12-131-3/+6
| | | | | | | | | | | Just a bit of code cleanup BUG=none TEST=none Review URL: http://codereview.chromium.org/5241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69048 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillProfile: don't replicate logic in Clone()isherman@chromium.org2010-12-132-12/+13
| | | | | | | | | BUG=none TEST=unit_tests --gtest_filter=AutoFillProfileTest.Clone Review URL: http://codereview.chromium.org/5608004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69047 0039d316-1c4b-4281-b951-d872f2087c98
* Verify that previously saved username/password shows up in Regular Window, ↵nirnimesh@chromium.org2010-12-131-0/+30
| | | | | | | | NTP and incognito window. Review URL: http://codereview.chromium.org/5675001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69046 0039d316-1c4b-4281-b951-d872f2087c98
* Remove layer of indirection in PhoneNumberTestisherman@chromium.org2010-12-132-36/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5728005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69045 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in instant where we wouldn't initially tell the page thesky@chromium.org2010-12-135-16/+76
| | | | | | | | | | | | | | | | real bounds of the omnibox. The bug occurred because we didn't initially send down the bounds so that when the init script ran it sent a bounds of 0x0. When the browser then processed the response that the page supported instant it incorrectly assumed the page was told the right bounds. BUG=65463 TEST=see bug (specifcally comment 5). this is now covered by an interactive ui test as well. Review URL: http://codereview.chromium.org/5697003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69043 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-1378-319/+721
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded browser_thread.h usage.thestig@chromium.org2010-12-1354-71/+46
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5676004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69037 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix painting issues caused by the X message pump.sadrul@chromium.org2010-12-132-5/+11
| | | | | | | | | | | | | | | | WidgetGtk has two GtkWidgets, |widget_|, and |window_contents_| inside it. |window_contents_| is the widget that receives the GTK+ expose events and shows up on top of |widget_|. However, RenderWidgetHostViewViews paints on |widget_|s window, because |widget_| is considered as the NativeView. So change native_view() to return |window_contents_| instead of |widget_| so that the correct canvas is used for painting. BUG=None TEST=Webpages show up correctly with the X message pump. Review URL: http://codereview.chromium.org/5776002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69036 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'Delete' key to cookies tree in settings UI.xiyuan@chromium.org2010-12-131-0/+18
| | | | | | | | | BUG=chromium:65320 TEST=Verify fix for chromium:65320 Review URL: http://codereview.chromium.org/5745001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69035 0039d316-1c4b-4281-b951-d872f2087c98
* Add TEXT_PLAIN as a drag and drop target. And accept TEXT_PLAIN as a target ↵pinkerton@chromium.org2010-12-136-29/+99
| | | | | | | | | | | | | at CompleteDrop(). In the function classify the word and make the URL.(Linux) If the drop source is not URL, use the source as plain text and pass it to tab_strip_controller and classify it. To pass if the source is URL or plain text, use is_plain_text flag. (Mac) patch from takano.naoki@gmail.com BUG=42797 TEST= 1. Open any site which has text. (news.google.com) 2. Select 2-3 words of text and drag n drop selected text to tabstrip. 3. Chrome opens a new tab with search results (using selected search engine in preferences). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69034 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Settings: UTH: Fix up the Privacy checkboxes text.kmadhusu@chromium.org2010-12-133-10/+8
| | | | | | | | | BUG=63834 TEST=none Review URL: http://codereview.chromium.org/5797001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69033 0039d316-1c4b-4281-b951-d872f2087c98
* [gtk] tabcontents fade-out for instant.estade@chromium.org2010-12-1313-40/+135
| | | | | | | | | BUG=58937 TEST=manual Review URL: http://codereview.chromium.org/5790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69032 0039d316-1c4b-4281-b951-d872f2087c98
* Make DatabaseDispatcherHost be a message filter so that ↵jam@chromium.org2010-12-1318-605/+464
| | | | | | | | ResourceMessageFilter doesn't have to know about it. Review URL: http://codereview.chromium.org/5757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69031 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the malware warning ui. Remove the 'more info'/'less info' button, ↵lzheng@chromium.org2010-12-133-138/+35
| | | | | | | | | | | | | | | instead directly show the content above the 'go back' button. sample screenshot: https://docs0.google.com/document/edit?id=1Kk2wxsj8JjIjlC1WUPamDlEPWZH-iWUoECMRdyQ9t_4&hl=en&authkey=CJKfrM0D# Patch from Ke Wang <kewang@google.com> BUG=60813 TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist. Review URL: http://codereview.chromium.org/5623007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69028 0039d316-1c4b-4281-b951-d872f2087c98
* Repoint the ESET error Learn More link.agl@chromium.org2010-12-131-1/+1
| | | | | | | | | | | | | The ESET error occurs when Chrome's HTTPS connections are intercepted by ESET. However, the Learn More link on the error page points to an HTTP URL which redirects to an HTTPS URL. Since the user cannot view HTTPS pages, that's unhelpful. This change points the link to a page on ESET's knowledge base instead. http://codereview.chromium.org/5705003/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69023 0039d316-1c4b-4281-b951-d872f2087c98
* Error out on user scripts that are not UTF8 encoded.skerner@chromium.org2010-12-133-0/+21
| | | | | | | | | BUG=64456 TEST=ExtensionFromUserScript.NotUTF8 Review URL: http://codereview.chromium.org/5767001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69022 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in the malware_details unittest.panayiotis@google.com2010-12-131-3/+6
| | | | | | | | | BUG=66277 TEST=unit_tests with valgrind Review URL: http://codereview.chromium.org/5707004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69021 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky testIncognitoDBPersistentAcrossTabsnirnimesh@chromium.org2010-12-131-0/+2
| | | | | | | | BUG=66714 Review URL: http://codereview.chromium.org/5693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69020 0039d316-1c4b-4281-b951-d872f2087c98
* Spdy Histogram cleanup:mbelshe@chromium.org2010-12-131-9/+9
| | | | | | | | | | | | * Remove the unnecessary "SpdyTrial" from a bunch of histogram names * Rework the names of the "SpdyCwnd" trial to use "_" instead of ".spdy." BUG=none TEST=none Review URL: http://codereview.chromium.org/5738006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69019 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Instant suggest issues in Linux Views port.suzhe@google.com2010-12-134-46/+103
| | | | | | | | | | | | | | | | | | This CL changes Linux Views port to use the same code of Linux Gtk port for displaying Instant suggest rather than using the code of Windows port. The reason is: GtkTextView used by AutocompleteEditViewGtk can't work with SuggestedTextView very well. This CL also fixes some issues in AutocompleteEditViewGtk related to RTL text. BUG=66167 BUG=66151 TEST=See issue report. Review URL: http://codereview.chromium.org/5698006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69017 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fetch cookies after online authentication is successful.nkostylev@chromium.org2010-12-137-28/+98
| | | | | | | | | BUG=chromium-os:9814 TEST=Manual. Checked that web properties load w/o auth request for new user/existing user/existing with cookies cleared/existing with changed password. Review URL: http://codereview.chromium.org/5641001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69016 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Fix showing sad tabs.sadrul@chromium.org2010-12-132-4/+10
| | | | | | | | | BUG=sad tab (e.g. about:crash) does not work. TEST=about:crash works Review URL: http://codereview.chromium.org/5698007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69015 0039d316-1c4b-4281-b951-d872f2087c98
* Update the links to the store to point at the new URL.aa@chromium.org2010-12-135-3/+5
| | | | | | | | | BUG=65385 TEST=hover over web store links in launcher -- should point to chrome.google.com/webstore, not /extensions. Links should still work. Click linked headings in chrome://extensions/, should go to extension detail page. Review URL: http://codereview.chromium.org/5700006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69011 0039d316-1c4b-4281-b951-d872f2087c98
* Switch a bunch of remaining filters to derive from BrowserMessageFilters so ↵jam@chromium.org2010-12-1332-794/+502
| | | | | | | | that ResourceMessageFilter doesn't have to know about them and vice versa. A bunch of small cleanup in the process. I've added new message files for classes that want their messages dispatched on threads other than the IO. Review URL: http://codereview.chromium.org/5698008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69008 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-1341-96/+116
| | | | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. This primarily covers files in chrome os and other directories, missed in the previous CL. In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
* Reset NTP document height when sections are minimized/hidden. Update ↵jstritar@chromium.org2010-12-132-9/+25
| | | | | | | | | | | position_util to properly handle 'fixed' positioned elements. BUG=62747 TEST=See bug. Review URL: http://codereview.chromium.org/5445002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69005 0039d316-1c4b-4281-b951-d872f2087c98
* Add utility function to determine if a locale is valid syntax; this willdmazzoni@chromium.org2010-12-134-48/+5
| | | | | | | | | | | | be used by the TTS extension API. Moved some locale utility functions from extension_l10n_util to l10n_util. BUG=none TEST=Adds new unit test Review URL: http://codereview.chromium.org/5643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69004 0039d316-1c4b-4281-b951-d872f2087c98
* Make use of new functionality of SignedSettings to tell if a settings is ↵dilmah@chromium.org2010-12-131-48/+42
| | | | | | | | | | | | | missing. Removed previous stubs and enforce security. BUG=chromium-os:9818 TEST=Manual Review URL: http://codereview.chromium.org/5692007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69001 0039d316-1c4b-4281-b951-d872f2087c98
* Compile fix for touchui.sadrul@chromium.org2010-12-131-4/+4
| | | | | | | | | | | | views::ViewStorage::GetSharedInstance didn't get renamed to GetInstance in a previous CL. BUG=chrome doesn't compile with touchui=1 TEST=see bug Review URL: http://codereview.chromium.org/5807001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68999 0039d316-1c4b-4281-b951-d872f2087c98
* Add a CEEE mode to the ChromeFrame distribution class.robertshield@chromium.org2010-12-1326-163/+300
| | | | | | | | | | | | | | Pass a MasterPreferences into BrowserDistribution et al. to allow for preferences-based behaviour. Add a GetComDllList() method that returns the set of registerable components for that distribution. Change GetKeyFile() on BrowserDistribution to GetKeyFiles(). Refactor GetMasterPreferencesForCurrentProcess into a static method on MasterPreferences. BUG=61609 TEST=None Review URL: http://codereview.chromium.org/5558006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68996 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 16:45:09 +0000