| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The typo led to access of undefined javascript variable on chrome://net-internals when the load flags were 0.
Review URL: http://codereview.chromium.org/2089015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The start/end events would get smashed together when the start event had extra parameters (the case where the end event had extra parameters was already being handled properly).
Review URL: http://codereview.chromium.org/2068008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Here are some examples showing what it looks like now (the stuff in parenthesis is new):
--> load_flags = 8240 (DISABLE_CACHE | DISABLE_INTERCEPT | DO_NOT_SAVE_COOKIES)
--> net_error = -105 (NAME_NOT_RESOLVED)
BUG=37421
Review URL: http://codereview.chromium.org/2115007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
might not be a perfect solution right now, but its a simple stopgap.
BUG=chromium-os:3242
TEST=none
Review URL: http://codereview.chromium.org/2077006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31584
TEST=none
Review URL: http://codereview.chromium.org/2113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also remove the associated button.
BUG=43351
TEST=Add enough bookmarks to the bookmar bar to cause the off-the-side chevron to appear. Pop up the off-the-side folder menu. Delete one of the bookmarks shown therein using the contextual menu. Verify that the bookmark button disappears. Mouse over other bookmarks in the menu and verify no crash occurs.
Review URL: http://codereview.chromium.org/2122010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DO round the corners AND draw the correct shadow in GTK+ theme mode.
DONT round the corners OR draw the shadow if the browser is maximized or using the system frame (regardless of theme mode).
BUG=43632
TEST=manual
Review URL: http://codereview.chromium.org/2109005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I messed this up with r46767
BUG=44244
TEST=cut and copy both prepend the protocol when used on the entire omnibox contents.
Review URL: http://codereview.chromium.org/2081005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
handler.
BUG=38398
TEST=none
Review URL: http://codereview.chromium.org/841006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on cloud print for Chromium OS by default. Replace the placeholder URL of the URL for the to-be service. Add in a profile item for the cloud print service root URL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2078010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bit, FILTER_EXTENSION_MESSAGES, into a bool that's only passed to places that really need it.
Also renames ExtensionMessageFilterPeer to ExtensionLocalizationPeer in hopes of making its one use more apparent. I added a couple comments too.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2105006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
investigate why it hangs every now and then.
BUG=43836
TEST=none
Review URL: http://codereview.chromium.org/2051012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to standardize on a consistent naming scheme.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2069005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33406
TEST=Chromium-->Preferences-->Under the Hood-->Change font settings-->Change. Type into the size field. The font size changes.
Review URL: http://codereview.chromium.org/2136014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2068007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
update its URL and title and then move to its new parent only if necessary.
BUG=44094
TEST=1) Edit a bookmark on the bookmark bar without changing its parent (moving it to a folder) and verify that there is no 'poof' animation. 2) Edit a bookmark on the bookmark bar but change its parent to be a folder and verify that it moved to the last place in the new parent and does not show the poof animation. 3) Edit a bookmark in a folder moving it to the bookmark bar and verify that it moves to the last position on the bar and does not show a poof animation.
Review URL: http://codereview.chromium.org/2120006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pass in Chrome. Mostly, this involves better error checking.
The most substantial change is that I made TransportDIB able to return NULL on failure to make a PlatformCanvas, which we run into when makeing too large of a canvas from a plugin. I checked all the callers of this function to make sure they all handled the problem (many already did).
TEST=pulls Pepper test
BUG=-none
Review URL: http://codereview.chromium.org/2101004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are save as (such as images)
BUG=chromium-os:1581
TEST=none
Review URL: http://codereview.chromium.org/2074009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement drag of other bookmark and URL sources such as from the Desktop or a text selection.
BUG=39884,44228
TEST=Note: For all drag operations verify that the appropriate drop indicator is presented while dragging. When dragging onto a bookmark bar folder the folder button should be highlighted and, after a short delay, open into a menu. When dragging between folders or on top of a non-folder bookmark an insertion bar (vertical when in the bookmark bar, horizontal when in a folder menu) should be presented. For 'copy' moves the drag image should be adorned with a plus sign in a green circle. A non-copy move should show no such tag.
1) Drag a non-folder bookmark from the bookmark manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the bookmark is moved to be on the bar just before the bookmark upon which is was dropped.
2) Drag a folder bookmark from the manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the folder (as a folder) is moved to be on the bar just before the bookmark upon which is was dropped.
3) Drag a bookmark from the manager to a folder on the bookmark bar. Verify that the bookmark is added to the folder at the end and removed from the old location in the manager.
4) Drag a bookmark from the manager to a folder on the bookmark bar and wait for the folder to open and then drag to within the folder. Verify that dropping places the bookmark and removes it from the old location in the manager.
5) Drag a bookmark from the bar to the manager and verify that the manager now shows the dragged bookmark. (Note that this should be a 'move' but is currently a 'copy'. See http://crbug.com/44039.)
6) Drag a bookmark clipping from the Finder Desktop to the bookmark bar. Verify that it is added to the bar as a new bookmark.
7) Drag a bookmark clipping from the Finder Desktop to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder as a new bookmark.
8) Create a URL in TextEdit or Stickies, select it and drag to the bookmark bar. Verify that it is added to the bar.
9) Create a URL in TextEdit or Stickies, select it and drag to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder.
Review URL: http://codereview.chromium.org/2066001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the disk cache.
BUG=32407
TEST=None
Review URL: http://codereview.chromium.org/1698001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44457
TEST=none
Review URL: http://codereview.chromium.org/2129011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=finnur
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses a popup window that is carefully positioned to be placed over the icon on the NTP. The popup fades out after a short delay.
BUG=None
TEST=Start with --enable-apps and launch an app. The icon should *stick* for a very short period and then fade out.
Review URL: http://codereview.chromium.org/2095008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manually. Run out/Debug/chrome --first-run. Everything should works as before.
Review URL: http://codereview.chromium.org/1998013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make it compatible with the UI language code used in Chrome.
zh-CN is used for UI language code of Simplified Chinese.
BUG=chromium-os:2843
TEST=added a unit test and ran out/Release/unit_tests --gtest_filter='LanguageLibrary*'
Review URL: http://codereview.chromium.org/2102008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3053
TEST=N/A
Review URL: http://codereview.chromium.org/2076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "Reload" button was used to refresh the stats + cache listings.
With this change, I poll the statistics for updates, so the reload button is unecessary.
Note that the cache listing is too expensive to poll, so I replaced it with a link to a listings page.
Lastly, updated the text dump to include the http cache statistics.
BUG=37421
Review URL: http://codereview.chromium.org/2085005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it into 2 distinct buildbot phases. Add changes to reduce size or
increase speed of coverage builds.
Add 'bundle files' mechanism to process_coverage.py to make the above
split easier. Add unit test for said mechanism.
TEST=build coverage on 10.6 and watch it work.
Review URL: http://codereview.chromium.org/2121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Even with r47236, the Chinese characters look still small on the netbook.
BUG=chromium-os:2904
TEST=manually
Review URL: http://codereview.chromium.org/2136006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The root cause of the problem was a hack for ibus-anthy, that is no longer
necessary. Get rid of the hack.
Change the code to show the auxiliary text in the footer area when the
orientation is vertical.
BUG=chromium-os:3301
TEST=manually
Review URL: http://codereview.chromium.org/2087008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40083
TEST=compiles
Review URL: http://codereview.chromium.org/2013008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=python chrome/test/functional/prefs.py prefs.PrefsTest.testToolbarButtonsPref
Review URL: http://codereview.chromium.org/2117009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement several flavors of TCP/IP speculative preconnection
under a command line flag (not yet on by default).
The first area of preconnection takes place when a user types
a query into the omnibox, as we preconnect to the search service
when the omnibox suggests it is going to do a search.
The second area involves subresources, such as images.
When a navigation takes place, and we've seen navigations
to that domain/port before, and the history-based
probabability that we'll need to make a connection to
a second site (host/port) is sufficiently large, then we
preconnect to that second site while we are still connecting
to the primary site (and before we've gotten content from
the primary site.
We also fall-back to mere DNS pre-resolution of subresource
hostnames when the probability of a connection to the
subresource is not high enough.
BUG=42694
r=pkasting,willchan,mbelshe
Review URL: http://codereview.chromium.org/1585029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works on both the location bar and the find bar, the only places I could
find where we do weird stuff with widgets. We still force font sizes in
chrome-theme mode.
Effectively, while this doesn't completely solve 22614, it should mitigate the
symptoms in a lot of cases.
BUG=12195,22614
TEST=In GNOME, change your system font while chrome is in gtk-theme mode. The font in the location bar and in the find bar should match the application font.
Review URL: http://codereview.chromium.org/2124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(It was possible to get unmatched start/end before).
Also renamed the event to URL_REQUEST_START_JOB, since it is really a superset of URLRequest::Start().
Review URL: http://codereview.chromium.org/2091009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2089012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A hack in media::PipelineImpl::BroadcastMessageTask() was previously required to remove the mime_type of the disabled renderer.
Since the only use of media::PipelineImpl::BroadcastMessage() is to disable the audio renderer, refactor BroadcastMessage() to DisableAudioRenderer() and refactor media::MediaFilter::OnReceivedMessage() to OnAudioRendererDisabled().
Patch by boliu@google.com:
http://codereview.chromium.org/2042014/show
BUG=19384
TEST=media_unittests
Review URL: http://codereview.chromium.org/2069006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extensions.
BUG=42787
Review URL: http://codereview.chromium.org/2110007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=python chrome/test/functional/omnibox.py omnibox.OmniboxTest.testSelect
Review URL: http://codereview.chromium.org/2136010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42116
TEST=None
Review URL: http://codereview.chromium.org/2102007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fix variable name that seems to be cut© error. (loader_ makes sense only for library_loader, and others should be lib_)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2128007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testNavigationStateOnSessionRestore -- from Sunand
testDownloadDirPref -- from Deepak
testToolbarButtonsPref, testHomepagePrefs -- from Rohit
TEST=python chrome/test/functional/prefs.py
Review URL: http://codereview.chromium.org/2087005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
values.
BUG=none
TEST=CookiesWindowControllerTest.*
Review URL: http://codereview.chromium.org/2129006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
resize to a wrong size.
BUG=None
TEST=On ChromeOS, press the new tab button, the app launcher should show
correctly.
Review URL: http://codereview.chromium.org/2108007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44371
Review URL: http://codereview.chromium.org/2066008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Ensure that the About Chrome dialog has proper accessibility role.
BUG=none
Review URL: http://codereview.chromium.org/1838002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We already don't compile the code to load the library for 64-bit, this makes it so we also don't try to build anything into it.
BUG=None
TEST=Eventually we should be able to compile for 64-bit on the Mac.
Review URL: http://codereview.chromium.org/2090007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Window Manager sends us a NOTIFY_SYSKEY_CLICKED message,
we adjust the volume accordingly. Currently just calling
amixer as WM was doing before. There will be a different
change submitted for WM to send this message instead of
calling amixer itself.
Patch by davej@chromium.org:
http://codereview.chromium.org/2102001/show
BUG=cros/525
TEST=none
Related to issue 2107001.
Review URL: http://codereview.chromium.org/2107010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
timeticks.
Also use a prettier display for the DNS cache and "bad proxy" cache.
BUG=37421
Review URL: http://codereview.chromium.org/2120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47450 0039d316-1c4b-4281-b951-d872f2087c98
|