| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and a few related cleanups:
- DCHECK in ctor to fail early
- fix infinite loop in WebUI mock
- ASSERT_TRUE to avoid crashes
BUG=90443
Review URL: http://codereview.chromium.org/7830028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=93149
TEST=Click X on a bookmark to delete or drag item to the trash can.
Verify you can't delete the "Other Bookmarks" folder.
R=csilv
Review URL: http://codereview.chromium.org/7756019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=95232
TEST=see bug
Review URL: http://codereview.chromium.org/7824052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and add callbacks to ContentMainDelegate to handle the Chrome specific pieces.
BUG=90445
Review URL: http://codereview.chromium.org/7792080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also renamed hasPendingPrintReadyDocumentRequest to isPrintReadyMetafileReady (and reversed true <-> false), I find this to be less confusing.
BUG=95000
TEST=See bug description.
Review URL: http://codereview.chromium.org/7824005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On OSX:
- Read the computer name, falling back to reading hw.model and stripping any trialing numbers. This will give us
something like MacBookPro, iMac, MacBookAir.
On Linux:
- Use distro name which gives something like "Ubuntu 10.04.2 LTS".
On Windows:
- Use the computer name
On ChromeOS:
- Use "Chromebook"
BUG=94693, 59672
TEST=enable session sync, sync two clients, and then look at the entries in about:sync and see that the "client_name" is set
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99391
Review URL: http://codereview.chromium.org/7740055
Patch from Yaron Friedman <yfriedman@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I reverted some of the capitialization changes to be consistent with existing entries in service_constants.h that are being used by shill.
BUG=none
TEST=Chrome compiles
Review URL: http://codereview.chromium.org/7826024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with or without Autofill.
BUG=none
TEST=unit_tests --gtest_filter=AutofillMetricsTest.*
Review URL: http://codereview.chromium.org/7740070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HtmlDialogUIDelegate::OnDialogClosed() was getting invoked
twice in some cases: once in response to the actual message
from chrome.send(), and a second time when the window closed
(see r64695). This change makes the second invocation only
happen if the first one didn't.
I'm also cleaning up some things in the WebUI HTTP auth
dialog and adding a bunch of missing OVERRIDEs.
BUG=chromium-os:18829
TEST=manual: HTTP auth dialog appears to still work on chrome os
Review URL: http://codereview.chromium.org/7827026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93260,91768
TEST=This test
Review URL: http://codereview.chromium.org/7821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the build/installer output.
BUG=94920
TEST=Do an Official build in mac and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory.
Review URL: http://codereview.chromium.org/7827021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7828056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GViewRequestInterceptor.
BUG=80794
TEST=GViewRequestInterceptorTest.*
Review URL: http://codereview.chromium.org/7541076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this bug manifested itself in 2 ways:
1) most visited tiles frequently didn't have a color stripe
2) bookmark tiles frequently had the wrong color
the bug stems from the fact the Most Visited and Bookmark ID sets were overlapping (integers 0-7 for Most Visited, and integers starting at 0 counting up for bookmarks). I changed it to use a string (specifically, the DOM ID of the relevant tile contents) as the key.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7825021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/7824030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options pages.
This seemed to be causing failures of the
WebUIBidiCheckerBrowserTest.TestSettingsAutofillPageLTR
browser test on Windows XP (dbg)
BUG=87378
TEST=The new settings page (chrome://settings/extensionSettings) should work the same as the old one (chrome://extensions).
Review URL: http://codereview.chromium.org/7794023
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/7830047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=95069
TEST=none
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/7832008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We never destroyed the button.
BUG=94808
TEST=none
Review URL: http://codereview.chromium.org/7824028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The file should be owned by chronos or else we fail the PlatformPermissions tests.
BUG=chromium-os:19942
TEST=security_ProfilePermissions
Review URL: http://codereview.chromium.org/7831038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94323
TEST=Have a lot of bookmarks on the bar. Make the window smaller. The chevron menu appears and only shows items not visible on the bar.
Review URL: http://codereview.chromium.org/7827029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
local history DB.
This can happen if we delete a URL while there's a pending change for it on the server.
BUG=94926
TEST=Don't have a repro for this bug, just a report from the field.
Review URL: http://codereview.chromium.org/7826026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=creis@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7832009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=asargent@chromium.org
Review URL: http://codereview.chromium.org/7830045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
registering for NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY.
BUG=None
TEST=Run trybots.
Review URL: http://codereview.chromium.org/7795007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Better divide up the responsibilities between Show() and the constructor, create some helper methods, and remove unnecessary ExtensionView::Container implementation.
BUG=chromium-os:19989
TEST=browser_tests, FileManagerDialogTest.*
Review URL: http://codereview.chromium.org/7792101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:policy (to access policy status information):
Added a FetchUserPolicies() method to BrowserPolicyConnector and removed an "only for testing" comment.
Changed a comment in CloudPolicySubsystem
Changes to BrowserPolicyConnector and CloudPolicySubsystem for about:policy.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7827042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AFAICT, this target is no longer needed, but just to be safe, I'm
going to remove the dependencies incrementally. This change removes
the third_party entries and loads 5 less vcproj files in chrome.sln.
BUG=94622
Review URL: http://codereview.chromium.org/7828048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mcgrathr
BUG=
TEST=
Review URL: http://codereview.chromium.org/7831046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
original CL w/LGTMs: http://codereview.chromium.org/7812036/
Review URL: http://codereview.chromium.org/7824041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update automation connection code to wait for webui login screen to become ready.
NativeUI login automation continues to work as is.
BUG=chromium-os:18271, chromium-os:17712
TEST=
Review URL: http://codereview.chromium.org/7819013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make this easier, the extension install dialog was changed from doing layout
by hand to using GridLayout (thus no longer necessitating overrides of
GetPreferredSize/Layout or lots of math).
To lessen the repeated logic between the inline install UIs,
ExtensionInstallUI::Prompt was beefed up to return formatted data directly
(and in the case of rating stars, include the logic for which ones to show).
Also includes some other tweaks:
- Rename inline install dialog to "Add to Chrome" and the install button in it
to "Add"
- Use the final webstore JSON data URLs
R=asargent@chromium.org
BUG=93380
TEST=no
Review URL: http://codereview.chromium.org/7826029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=87378
TEST=The new settings page (chrome://settings/extensionSettings) should work the same as the old one (chrome://extensions).
Review URL: http://codereview.chromium.org/7794023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
verification and buffering.
Review URL: http://codereview.chromium.org/7791015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=creis
Review URL: http://codereview.chromium.org/7831043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=added test to ExtensionManagementApiTest.Basics
Review URL: http://codereview.chromium.org/7826020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to flaky test. Turns out there was a race condition: the cookie store api for deleting cookies is exclusive of the end time, and in the test, on Windows, we often got around to deleting the cookie we had created the same millisecond (hence, it was excluded from deletion).
This change updates the Browsing Data Remover to use the new asynchronous Cookie Store API.
BUG=68657
TEST=unit_tests / BrowsingDataRemoverTest.RemoveCookieForever
TBR=jochen
Review URL: http://codereview.chromium.org/7740084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17621,chromium-os:19796
TEST=Verify fix for chromium-os:17621,chromium-os:19796.
Review URL: http://codereview.chromium.org/7825023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the default font would override the user's preferences when viewing
a page in their "native" language.
BUG=95032
TEST=in Chrome OS (or Windows), switch locale to Japanese. In preferences, set
font to some font. View a page that uses -webkit-locale=ja. Verify that the
font is as in preferences and not the default "IPAPGothic" ("MS Gothic").
Review URL: http://codereview.chromium.org/7827002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
devices types for synced sessions.
On OSX:
- Read the computer name, falling back to reading hw.model and stripping any trialing numbers. This will give us
something like MacBookPro, iMac, MacBookAir.
On Linux:
- Use distro name which gives something like "Ubuntu 10.04.2 LTS".
On Windows:
- Use the computer name
On ChromeOS:
- Use "Chromebook"
BUG=94693, 59672
TEST=enable session sync, sync two clients, and then look at the entries in about:sync and see that the "client_name" is set
Review URL: http://codereview.chromium.org/7740055
Patch from Yaar Friedman <yfriedman@chromium.org>.
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/7792102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"If you're seeing this frequently, try these suggestions."
Link "these suggestions" to the "Learn more" help article.
Update Views, GTK, and Cocoa implementations.
chrome://kill (unused) changes on Mac, but not on Views nor GTK.
Not wrapping this line on overflow for Views and GTK seems acceptable.
Strings: Add sad tab help message and embedded link resources.
Views: Rewrite the SadTabView to use ImageView, GridLayout, etc.
GTK: Add new prefix and suffix Label Widgets to an hbox with the link.
Cocoa Support: Create HyperlinkTextView for non-selectable text & link.
Cocoa IB: Replace SadTab.xib NSButton with a NSTextfield placeholder.
Cocoa: Replace the placeholder with a customized HyperlinkTextView.
BUG=80428
TEST=chrome://crash and chrome://kill on all platforms.
Review URL: http://codereview.chromium.org/7610011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to keep different SSLConfig objects for HTTPS Proxies vs
HTTPS Servers.
Add an is_proxy field to SSLCertRequest indicating if the
request came from a proxy or from an origin server.
BUG=95071
Review URL: http://codereview.chromium.org/7768002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On OSX:
- Read the computer name, falling back to reading hw.model and stripping any trialing numbers. This will give us
something like MacBookPro, iMac, MacBookAir.
On Linux:
- Use distro name which gives something like "Ubuntu 10.04.2 LTS".
On Windows:
- Use the computer name
On ChromeOS:
- Use "Chromebook"
BUG=94693, 59672
TEST=enable session sync, sync two clients, and then look at the entries in about:sync and see that the "client_name" is set
Review URL: http://codereview.chromium.org/7740055
Patch from Yaar Friedman <yfriedman@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80794
TEST=none
Review URL: http://codereview.chromium.org/7799024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94925
TEST=None
Review URL: http://codereview.chromium.org/7824011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wording changed as follows:
- from: Sign in to Chrome
to: Set up Chrome sync...
- from: Signed in to Chrome as pat@example.com
to: Synced to pat@example.com
BUG=
TEST=
Review URL: http://codereview.chromium.org/7824008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ContentSettingsHandler.
Also, check on initialization of a PrefMember that the preference is registered, to prevent this in the future.
BUG=95030
TEST=no crash
Review URL: http://codereview.chromium.org/7828028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=tony@chromium.org
Review URL: http://codereview.chromium.org/7830018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7826031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=cpu@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/7820004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99374 0039d316-1c4b-4281-b951-d872f2087c98
|