summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Don't send queries when URL is like:darin@chromium.org2008-09-104-16/+52
| | | | | | | | | | | | | | | - starts with http:// or https:// and includes username (e.g. http://me@test.com/) - starts with http:// or https:// and includes query (e.g. http://test.com/?q=x) - starts with https:// and includes path component (e.g. https://test.com/path) so as not to leak user data to the suggest server. Patch by takayoshi.kochi@gmail.com BUG=1647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1978 0039d316-1c4b-4281-b951-d872f2087c98
* Update the reference build to 1912.maruel@google.com2008-09-1048-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1954 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug with positioning windows from a secondary monitor.mpcomplete@google.com2008-09-091-2/+4
| | | | | | | BUG=1327320 Review URL: http://codereview.chromium.org/1864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1946 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with resizeBy in Gears dialogs.mpcomplete@google.com2008-09-091-11/+1
| | | | | | | BUG=1340253 Review URL: http://codereview.chromium.org/1867 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1945 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-0938-75/+72
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Create "ap" key to fallback on full installer even if the key didnt exist ↵kuchhal@chromium.org2008-09-092-10/+132
| | | | | | (for Google Chrome only). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1943 0039d316-1c4b-4281-b951-d872f2087c98
* backing out checkin to closed treebeng@google.com2008-09-091-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1938 0039d316-1c4b-4281-b951-d872f2087c98
* Bounds check the tab index before attempting to index into the TabStripModel ↵beng@google.com2008-09-091-6/+6
| | | | | | | | | using it. Under some circumstances, it seems like it's possible for the user to close or otherwise manipulate a Tab whose corresponding entry has already been removed from the model. This might be related to animations and performance constraints. B=1366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1936 0039d316-1c4b-4281-b951-d872f2087c98
* Don't index https content. This uses the toplevel brettw@google.com2008-09-091-0/+9
| | | | | | Review URL: http://codereview.chromium.org/1646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1927 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in TableView where by we return nothing as selected whensky@google.com2008-09-092-36/+22
| | | | | | | | | | | there was a selection. This appears to be a bug in Vista. I've worked around it by iterating over the elements. BUG=1499 TEST=See my steps in bug. Test on both XP and Vista. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1915 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from Szymon Piechowicz <szymonpiechowicz@o2.pl>beng@google.com2008-09-091-6/+6
| | | | | | | | | Moves the New Tab, Window, Incognito Window menu items from the Page menu to the Wrench menu. Code review: http://codereview.chromium.org/1826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1903 0039d316-1c4b-4281-b951-d872f2087c98
* Update stringstc@google.com2008-09-097-10/+10
| | | | | | | TBR=mal Review URL: http://codereview.chromium.org/1663 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1901 0039d316-1c4b-4281-b951-d872f2087c98
* Add an AtExitManager to test_chrome_plugin. It uses Time::Now(), which now ↵deanm@chromium.org2008-09-091-0/+5
| | | | | | | | uses a Singleton. Review URL: http://codereview.chromium.org/1843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1895 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a CHECK in a memcpy that it is not trivial to understand.cpu@google.com2008-09-091-3/+3
| | | | | | Review URL: http://codereview.chromium.org/1630 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1883 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome.7z archive on buildbots. The earlier change didn't work 100%.rahulk@google.com2008-09-082-8/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1880 0039d316-1c4b-4281-b951-d872f2087c98
* add debug statementrahulk@google.com2008-09-081-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1876 0039d316-1c4b-4281-b951-d872f2087c98
* add debug statementrahulk@google.com2008-09-081-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1875 0039d316-1c4b-4281-b951-d872f2087c98
* Pages with mixed content were shown as secure.jcampan@google.com2008-09-081-0/+4
| | | | | | | | BUG=1347301 TEST=Go to https://www.corp.google.com the page should not be reported as safe (the location bar should not show a lock). Review URL: http://codereview.chromium.org/2201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1874 0039d316-1c4b-4281-b951-d872f2087c98
* Change the external protocol handler to look at thensylvain@google.com2008-09-084-18/+35
| | | | | | | | | | | command that will be run before warning the user. If the command is empty, there is no reason to warn. I removed a dcheck. This dcheck is good, but unfortunately we can't use g_browser_process in the io_thread. Review URL: http://codereview.chromium.org/1632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1871 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all instances of <hash_map> with a "base/hash_tabe.h",erg@google.com2008-09-0827-99/+63
| | | | | | | | | | | which does the right thing based on whatever platform we're compiling for, along with changing the hardcoded "stdext::", which is a MSVC++ism to use base::hash_{map,set}. B=1869 Review URL: http://codereview.chromium.org/1629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1862 0039d316-1c4b-4281-b951-d872f2087c98
* Use FRIEND_TEST() instead of guessing the test class name (!)maruel@google.com2008-09-082-6/+9
| | | | | | Review URL: http://codereview.chromium.org/1626 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1857 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a flakey test.deanm@google.com2008-09-081-2/+2
| | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=1880 Review URL: http://codereview.chromium.org/1816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1852 0039d316-1c4b-4281-b951-d872f2087c98
* A couple of quick TODO and other cleanups.beng@google.com2008-09-084-13/+1
| | | | | | | | B=1031854 Review URL: http://codereview.chromium.org/1624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1850 0039d316-1c4b-4281-b951-d872f2087c98
* Support WM_APPCOMMAND on Window. Make it just pass through to ↵beng@google.com2008-09-085-0/+67
| | | | | | | | | | | | WindowDelegate::ExecuteWindowsCommand. The delegate needs to pre-translate for it. This allows my mouse's back and forward buttons to work on the new frames. B=1031854 Review URL: http://codereview.chromium.org/1620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix binary patching for localized OS. Not sure how it was working till now.rahulk@google.com2008-09-081-6/+6
| | | | | | | | BUG=1557 Review URL: http://codereview.chromium.org/268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1848 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully remove 102 unneeded static initializers. This should require less ↵deanm@google.com2008-09-081-197/+198
| | | | | | | | memory, since now we will share the PrepopulatedEngines across the language locales. Review URL: http://codereview.chromium.org/1619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1846 0039d316-1c4b-4281-b951-d872f2087c98
* Makes new tab page update properly when its told bookmarks aresky@google.com2008-09-081-5/+10
| | | | | | | | | | | changed. BUG=1861 TEST=see bug Review URL: http://codereview.chromium.org/1618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1845 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is from Andrew Brampton <me@bramp.net>.sky@google.com2008-09-084-8/+16
| | | | | | | | | | | | | | This patches allows menu items in PopUpMenus to be clicked with the right mouse button. menu.cc controls the web content popup menus, and some others chrome_menu{.cc,.h} controls popup menu on the chrome, for example right clicking on a tab. BUG=718 TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a custom memcpy(wchar_t*) with the new safer lcpy API. Pass ↵deanm@google.com2008-09-081-4/+14
| | | | | | | | MAX_PATH not MAX_PATH+1 to GetSaveFileName, and log failures better. Review URL: http://codereview.chromium.org/1609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash (visible sometimes in the single process UI tests inbrettw@google.com2008-09-081-2/+7
| | | | | | | RestoreToDifferentWindow). Review URL: http://codereview.chromium.org/1809 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1833 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the browser is destroyed during DestroyBrowser because EndSession ↵beng@google.com2008-09-081-1/+9
| | | | | | | | | handling needs it to be synchronously deleted, rather than by the Window's destruction. B=1031854 Review URL: http://codereview.chromium.org/452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSL state in the URL bar being incorrect. Going to an EV site like ↵brettw@google.com2008-09-0710-53/+119
| | | | | | | | | | | | | https://www.verisign.com/ would not should the EV name in the URL bar unless you did something like switch tabs away and back because in my cleanup I removed the notification that this was depending on. This patch adds a new NOTIFY_SSL_STATE_CHANGED notification which is broadcast by the various SSL components when they update the flags. The browser now listens for this notification and will update the URL bar. BUG=1359547 TEST=see repro steps in bug Review URL: http://codereview.chromium.org/436 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1831 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reinvent the wheel - base::wclscpy does this work in one line of code.beng@google.com2008-09-072-12/+3
| | | | | | Review URL: http://codereview.chromium.org/1807 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1828 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild chrome.7z archive by default to get new executables.rahulk@google.com2008-09-063-13/+13
| | | | | | | | BUG=936 Review URL: http://codereview.chromium.org/263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1823 0039d316-1c4b-4281-b951-d872f2087c98
* Adds missing virtual destructors on a couple of interface classes.darin@google.com2008-09-062-0/+4
| | | | | | | | | Patch contributed by knorton@google.com See http://codereview.chromium.org/270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1822 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the import lock dialog to be sized by locale.tc@google.com2008-09-0644-12/+105
| | | | | | | | | Also increase the height of the Italian first run bubble. BUG=1334381,1359145 Review URL: http://codereview.chromium.org/482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1819 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak introduced in the SafeBrowsing prefix cache test.paulg@google.com2008-09-061-1/+5
| | | | | | | BUG=1484 Review URL: http://codereview.chromium.org/481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1817 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp open file name size.beng@google.com2008-09-052-5/+14
| | | | | | | B=1362425 Review URL: http://codereview.chromium.org/476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1810 0039d316-1c4b-4281-b951-d872f2087c98
* Readding UI test I pulled yesterday; hopefully the bots will like it more ↵finnur@google.com2008-09-0519-9/+160
| | | | | | | | now. I need to wait for the bookmark bar to become visible so I plumbed in similar code as for the Find box instead of using Sleep's. Review URL: http://codereview.chromium.org/473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1809 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes keyword editor to show error image when keyword isn't valid.sky@google.com2008-09-053-3/+2
| | | | | | | | | | | BUG=1318 TEST=Edit a keyword in the keyword editor. Change the keyword to one that is being used by another keyword. Make sure the icon updates appropriately. Review URL: http://codereview.chromium.org/258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1803 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash that occurred because DialogClientView::AcceptWindow wassky@google.com2008-09-052-0/+15
| | | | | | | | | | | | | | | | | getting invoked twice. It appears that because we hide the window then destroy the window after a delay, it is possible for messages to get dispatched after the hide. Dispatching messages after the window was closed made it possible for two enters to be dispatched, which triggered a crash. I've modified the FocusManager to only dispatch key messages if the window is visible. BUG=1361863 TEST=See bug, but also make sure there are no weird focus traversal/accelerator issues in our dialogs. Review URL: http://codereview.chromium.org/251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1802 0039d316-1c4b-4281-b951-d872f2087c98
* Dupe of http://codereview.chromium.org/238jungshik@google.com2008-09-053-8/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The download page was quickly changed to address bug 1358202, but still there's a problem that the UI langauge of Chrome set-up program is different from what a user choose in the following scenarios: * English is chosen on non-en-US OS * Hebrew is chosen on non-Hebrew OS * Norwegian Bokmal is selected on non-Norwegian Bokmal OS Once these changes go in for next-point-release, the change made on the download server can be reverted. 1. Aliases {iw,no,tl} to {he,nb,fil}. 2. Also map en to en-US. 3. Map {zh-HK, zh-MK, zh-SG} to {zh-TW, zh-TW, zh-CN} This does not yet deal with other potentially problematic cases. Added a similar change for l10n_string_util.cc for installer . Tony already LGTM'd 238 so that I'm tbr'ing here. BUG=1358202 TEST=L10n* unittest TBR=tc Review URL: http://codereview.chromium.org/260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1800 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve Array Overflow.sidchat@google.com2008-09-051-7/+10
| | | | | | | BUG=1362175 Review URL: http://codereview.chromium.org/474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1796 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback revisions 1785-1786 due to purify regression.aa@google.com2008-09-052-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1795 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to begin compiling the files that implemen the HTML5aa@google.com2008-09-052-0/+2
| | | | | | | | | | | database API. This time, I added a project dependency from WebCore to sqlite on every solution that includes WebCore. Review URL: http://codereview.chromium.org/466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1785 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash. I believe this is happening during sessionsky@google.com2008-09-056-2/+44
| | | | | | | | | | | | | | | | end, which has a different shutdown path and is possible for the model to be deleted before the view. I'm also adding checking to XPFrame/VistaFrame to make sure the BookmarkBarView doesn't have a parent in the destructor. This shouldn't be possible, but I'm adding the check to be sure;) BUG=1359852 TEST=make sure you don't see problems with bookmarks Review URL: http://codereview.chromium.org/440 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1754 0039d316-1c4b-4281-b951-d872f2087c98
* Same CL as 448. Had to redo it.cpu@google.com2008-09-055-21/+41
| | | | | | | | | | | | | Change the default download path if needed, in Vista it could be set tothe destkop which is a risky location.- Remove reading the download location from IE in vista.BUG=b/1355855 This was already LGTmed Review URL: http://codereview.chromium.org/462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1753 0039d316-1c4b-4281-b951-d872f2087c98
* Cache empty responses from the SafeBrowsing servers for GetHashpaulg@google.com2008-09-056-11/+67
| | | | | | | | | | | requests so that we don't keep asking for full hashes that don't exist. We flush this cache with each update, which is a little aggressive, but on the safe side. BUG=1358225 Review URL: http://codereview.chromium.org/454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1748 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crashing bug when shutting down the plugin process.michaeln@google.com2008-09-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1747 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-10-26 17:28:22 +0000