summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Remvoing ws_32.dll from libxml triggered a improvised explosive devicecpu@google.com2009-04-121-2/+1
| | | | | | | | | | | - Now build is busted. TBR=maruel Review URL: http://codereview.chromium.org/71007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13570 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the Activex shim plugin from the list of default plugins caused ↵ananta@chromium.org2009-04-111-1/+1
| | | | | | | | some activex shim tests to fail. This basically fails for pages which instantiate the media player like an activex only. To handle this case we attempt to map the clsid to a NPAPI mime type if possible in the shim. If we succeed then the shim is instantiated as an NPAPI plugin as before. It internally loads the media player activex. Review URL: http://codereview.chromium.org/66072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13558 0039d316-1c4b-4281-b951-d872f2087c98
* Enable zooming in on Linux.thestig@chromium.org2009-04-111-1/+9
| | | | | | Review URL: http://codereview.chromium.org/66068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13556 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Activex shim registration for generic Activex controls. The ↵ananta@chromium.org2009-04-111-1993/+1978
| | | | | | | | | | | | | | | | | | | | | | | | Activex shim only handles windows media player in the wild and will continue to do so for the forseeable future. This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which is basically related to our NPAPI plugin installer not getting instantiated on pages which instantiated flash using an object tag, which would result in webkit attempting to instantiate the activex shim. The shim only loads the windows media player classid, thus causing this issue. Added a test shell test which tests whether the default plugin loaded correctly. This is done by attempting to instantiate a special mime type application/chromium-test-default-plugin, which serves as an indicator to the default plugin to call a function in the page indicating that the test succeeded. I also made a change to ensure that the default plugin is loaded in test_shell_tests. Removed the activexshim dll project from chrome.sln Bug=8584 Review URL: http://codereview.chromium.org/63151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13555 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we can handle favicons that are provided as data: URLsarv@chromium.org2009-04-112-1/+30
| | | | | | | | BUG=9881 Review URL: http://codereview.chromium.org/67042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13551 0039d316-1c4b-4281-b951-d872f2087c98
* This adds link[rel=icon] elements to the DOM UI html files for downloads and arv@chromium.org2009-04-102-0/+2
| | | | | | | | | | | | history. It also adds code to inline the resources for <link rel="icon"> elements BUG=9805 Review URL: http://codereview.chromium.org/66041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13550 0039d316-1c4b-4281-b951-d872f2087c98
* Make linux link buttons pretty.estade@chromium.org2009-04-103-12/+64
| | | | | | | | | - set text to red while button is active - get rid of border spacing Review URL: http://codereview.chromium.org/66058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13545 0039d316-1c4b-4281-b951-d872f2087c98
* Remove histogram connection to base classes in stats_counterjar@chromium.org2009-04-105-0/+5
| | | | | | | | | | | | | | | | Now that histograms move data from renderer to browser, there is less reason to connect to stats counters. Stats counters were using shared memory, and now they may plausibly use the histogram's IPC mechanism instead to move data to the browser. The first step is remove the inheritance, and teh next (plausible/future) step would be to implement counters as histograms with only one bucket. r=mbelshe Review URL: http://codereview.chromium.org/66029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13544 0039d316-1c4b-4281-b951-d872f2087c98
* Use favicons in the bookmark bar under GTK.erg@google.com2009-04-102-11/+34
| | | | | | Review URL: http://codereview.chromium.org/66056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13543 0039d316-1c4b-4281-b951-d872f2087c98
* Removing --enable-video and instead relying on having DLLs present.scherkus@chromium.org2009-04-104-7/+1
| | | | | | | | | | | | I measured a ~10ms startup regression when the DLLs are not present and a ~20ms regression when the DLLs are present and loaded in render_process.cc. Not sure how else to tackle this problem since we need these DLLs loaded before the sandbox is engaged. Review URL: http://codereview.chromium.org/63101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13542 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing virtual GetModel().shess@chromium.org2009-04-102-0/+7
| | | | | | | | | GetModel() was added by http://codereview.chromium.org/67035 which running my change on the trybots, and I trusted the merge. Review URL: http://codereview.chromium.org/66054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - make sure GTK Autocomplete edit/popup implement the ↵ben@chromium.org2009-04-103-4/+7
| | | | | | | | | GetModel interface method. TBR=deanm Review URL: http://codereview.chromium.org/66052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13539 0039d316-1c4b-4281-b951-d872f2087c98
* Allow a different omnibox popup to be enabled via the command line ↵ben@chromium.org2009-04-1015-16/+202
| | | | | | | | | | | | (--enable-omnibox2). This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX. Also adds new images from Nicholas. Review URL: http://codereview.chromium.org/67035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
* Make OSX TestShell able to run workers, using a new test_worker.dylib which ↵dimich@google.com2009-04-102-4/+20
| | | | | | | | is basically a webkit+v8+helpers to simulate separate process with worker v8 threads. This is similar way we do on Win32. Review URL: http://codereview.chromium.org/66043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13537 0039d316-1c4b-4281-b951-d872f2087c98
* Give the filter setup more context so it can figure out whether it's ↵thestig@chromium.org2009-04-101-0/+2
| | | | | | | | | downloading a file or not. Only refuse to gunzip svgz files on download, so we can send an uncompressed svgz file to webkit. BUG=9737 Review URL: http://codereview.chromium.org/62111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13536 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-1012-42/+967
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13534 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with work area change notifications so that we now ↵pkasting@chromium.org2009-04-102-46/+115
| | | | | | | | | (hopefully) move/resize correctly whenever the work area changes, no matter why. BUG=8873 Review URL: http://codereview.chromium.org/67023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PCH-related build breakpkasting@chromium.org2009-04-101-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13532 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with the window_sizer code.pkasting@chromium.org2009-04-103-128/+124
| | | | | | | | | | AdjustBoundsToBeVisibleOnMonitorContaining() is somewhat misnamed (but I can't think of a better name, so I just commented to this effect). It tries to ensure each edge is visible on *some* monitor (although it doesn't actually even do that in pathological cases), and adjusts things to be "on the desired monitor" if not. There were various bugs in this, including checking the wrong coordinates for work areas off the right/bottom sides of the primary work area, and adjusting to the wrong top/left coordinates when the desired monitor's work area was not at (0,0). Additionally, PositionIsOffscreen() actually returned whether the position is _onscreen_, which confused me greatly.In addition, this code used a cache of work area sizes, which is unfortunately wrong since work areas can change as the program is running. Now it re-gets the work areas, which is a little slower, but presumably doesn't actually matter. This also simplified the unittest code some (making it more correct in the process) and added a few tests for cases that my original version of this got wrong but which didn't trigger test failures. Review URL: http://codereview.chromium.org/65013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo (LOAD_ENABLE_FILE) in a comment added in r11661.wtc@chromium.org2009-04-101-1/+2
| | | | | | | R=hclam Review URL: http://codereview.chromium.org/67043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13530 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto commit from TestTabContents. This is the thing preventing me frombrettw@chromium.org2009-04-105-39/+41
| | | | | | | replacing it with WebContents. Fortunately, only one test was affected. Review URL: http://codereview.chromium.org/66003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13527 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement link info bars (first cut).estade@chromium.org2009-04-102-16/+61
| | | | | | | | Also make GetIcon a function in InfoBarDelegate since all its inheritors have a function of that name, and putting it in InfoBarDelegate allows us to make InfoBar more generic. Review URL: http://codereview.chromium.org/66025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13526 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out MakeLinkButton into its own class.estade@chromium.org2009-04-105-60/+115
| | | | | | | This also gets rid of the event box, which means we can stick it in widgets that are custom painted. Review URL: http://codereview.chromium.org/66023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13525 0039d316-1c4b-4281-b951-d872f2087c98
* Take two converting to scoped pointers, without ui_test failures.pinkerton@chromium.org2009-04-104-28/+32
| | | | | | Review URL: http://codereview.chromium.org/67039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13522 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure one cannot cut or copy from a passwordjcampan@chromium.org2009-04-104-4/+134
| | | | | | | | | | | text-field. And assorted unit-tests. BUG=9425 TEST=Visit a page with basic auth (ex: http://prism.library.cornell.edu/control/authBasic/authTest/). Type some text in the password field. Select the text and try to cut/copy with CTRL-X, CTRL-V and right click menu. You should not be able to cut/copy the text. Review URL: http://codereview.chromium.org/63053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13520 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in NOTIMPLEMENTEDs in BookmarkBarGtk. Can now reorder bookmarks.erg@google.com2009-04-102-51/+198
| | | | | | Review URL: http://codereview.chromium.org/66022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13518 0039d316-1c4b-4281-b951-d872f2087c98
* Remove fixed crash from known list.huanr@chromium.org2009-04-101-6/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warnings when -Wall got re-enabled for Linux.willchan@chromium.org2009-04-104-13/+12
| | | | | | | | | | | | | | | browser/gtk/bookmark_bar_gtk.cc: In static member function 'static gboolean BookmarkBarGtk::OnToolbarDragLeave(GtkToolbar*, GdkDragContext*, guint, BookmarkBarGtk*)': browser/gtk/bookmark_bar_gtk.cc:372: warning: control reaches end of non-void function /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h: In constructor 'TabRendererGtk::TabRendererGtk()': /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:241: warning: 'TabRendererGtk::loading_animation_' will be initialized after /usr/local/google/chromium3/src/chrome/browser/gtk/tabs/tab_renderer_gtk.h:238: warning: 'TabRendererGtk::CloseButtonState TabRendererGtk::close_button_state_' browser/gtk/tabs/tab_renderer_gtk.cc:139: warning: when initialized here browser/gtk/tabs/tab_strip_gtk.cc: In member function 'GdkRegion* NewTabButton::MakeRegionForButton() const': browser/gtk/tabs/tab_strip_gtk.cc:152: warning: unused variable 'h' Review URL: http://codereview.chromium.org/67038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13516 0039d316-1c4b-4281-b951-d872f2087c98
* The dialog delegate for the in-progress download warning was deleted twice. ↵jcampan@chromium.org2009-04-101-5/+3
| | | | | | | | | | | | | | It is the content view for the dialog and as such is automatically deleted when the dialog is closed. So it does not need to delete itself on the DeleteDelegate() callback. We were also leaking the label_. BUG=9959 TEST=Start a big download, close the browser while the download is in progress. A dialog pops-up. Try the close button. The browser should close (and not crash!). Try again but this time with "Wait for donwloads to finish". Review URL: http://codereview.chromium.org/66038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13515 0039d316-1c4b-4281-b951-d872f2087c98
* backing out r13504 due to ui_test issuespinkerton@chromium.org2009-04-102-24/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13512 0039d316-1c4b-4281-b951-d872f2087c98
* Add #9975 to known crash list.huanr@chromium.org2009-04-101-0/+3
| | | | | | Review URL: http://codereview.chromium.org/66035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13507 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dtor ordering, browser must destruct last.pinkerton@chromium.org2009-04-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13506 0039d316-1c4b-4281-b951-d872f2087c98
* Force c++ dtors to get called in objc interfaces (it was always on since ↵pinkerton@chromium.org2009-04-102-25/+24
| | | | | | | | gcc4.2, but this makes it explicit). Use scoped_* goodness. Review URL: http://codereview.chromium.org/70001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13504 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some ifdefs so that test_shell can be compiled on linuxsky@chromium.org2009-04-108-10/+22
| | | | | | | | | | | | | without GTK. I had to recreate this patch as my workspace for various resonds. UGH! BUG=none TEST=none Review URL: http://codereview.chromium.org/67024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools. Add V8 Application Remote Debugging Protocol support by apavlov. ↵pfeldman@chromium.org2009-04-1022-10/+2042
| | | | | | | | Original CL: http://codereview.chromium.org/56109 Review URL: http://codereview.chromium.org/66031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13502 0039d316-1c4b-4281-b951-d872f2087c98
* Flesh out more extensions tab api (added getTab, removeTab, updateTab)rafaelw@chromium.org2009-04-108-8/+1449
| | | | | | Review URL: http://codereview.chromium.org/62178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13497 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome side of the WebKit popup changes.paulg@google.com2009-04-102-11/+11
| | | | | | | | | | | Implements HTML select popups on Mac OS X as native Cocoa controls. BUG=5095 (http://crbug.com/5095) Review URL: http://codereview.chromium.org/67018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13495 0039d316-1c4b-4281-b951-d872f2087c98
* Scrape search definitions from forms that have onsubmit handlers. The ↵ben@chromium.org2009-04-106-11/+147
| | | | | | | | | | | | | | | | scraping is done after submit events are handled by the page DOM so doing this is safe. Adds test infrastructure for determining that scraping occurs on submit: - allow testserver to be configured to serve pages from / on the server - provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission Eric, please review the test server changes. Scott, please look over everything else. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444 Review URL: http://codereview.chromium.org/62145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13491 0039d316-1c4b-4281-b951-d872f2087c98
* Remove instances of the New Tab button images that are not being used anymore.jhawkins@chromium.org2009-04-102-8/+0
| | | | | | | TBR=tony Review URL: http://codereview.chromium.org/66027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13490 0039d316-1c4b-4281-b951-d872f2087c98
* Comment the unselected_width parameter to the newly-added LayoutNewTabButton ↵jhawkins@chromium.org2009-04-102-7/+9
| | | | | | | | | method. Also remove some c-style comments that slipped in. TBR=evan Review URL: http://codereview.chromium.org/66026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13489 0039d316-1c4b-4281-b951-d872f2087c98
* Add the New Tab button for Linux tabstrip.jhawkins@chromium.org2009-04-102-7/+248
| | | | | | Review URL: http://codereview.chromium.org/67025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove content script unit test. Too flakey. Will revisitaa@chromium.org2009-04-101-6/+3
| | | | | | | | and try to use something lower-level, like a RenderView directly. Review URL: http://codereview.chromium.org/66021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13486 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 13480 (change to gyp for webkit on windows).bradnelson@google.com2009-04-101-1899/+2012
| | | | | | | | Too many loose ends. Review URL: http://codereview.chromium.org/66020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13485 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing missing dependency in chrome.slnbradnelson@google.com2009-04-101-0/+1
| | | | | | Review URL: http://codereview.chromium.org/68005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13484 0039d316-1c4b-4281-b951-d872f2087c98
* Switching webkit to gyp on windows.bradnelson@google.com2009-04-091-2012/+1899
| | | | | | Review URL: http://codereview.chromium.org/63152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13480 0039d316-1c4b-4281-b951-d872f2087c98
* Restore -Wall to Linux build and set up for -Werror.sgk@google.com2009-04-092-4/+1
| | | | | | | | | | | | | | | * Add -Wall to build/common.gypi (and -Werror, commented out for now). * Have build/external_code.gypi remove -Wall (and -Werror). * Remove chromium_code definition from build/all.gyp. * Remove chromium_code definitions from third_party/ *.gyp files. * Remove scons-specific -Werror removal in webkit.gyp. * Remove unused variables from: base/clipboard_linux.cc chrome/browser/gtk/download_shelf_gtk.cc chrome/browser/gtk/bookmark_bar_gtk.cc Review URL: http://codereview.chromium.org/66001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13478 0039d316-1c4b-4281-b951-d872f2087c98
* Replace chrome_process_filter with chrome_process_util.estade@chromium.org2009-04-0922-159/+345
| | | | | | | | | | | | | | - move code only used by tests to chrome/test - make a better, more portable abstraction For now, it still only works on Windows. But this is the first step to porting this part of code. Patch by phajdan.jr@chromium.org: <http://codereview.chromium.org/54003> Review URL: http://codereview.chromium.org/67004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13476 0039d316-1c4b-4281-b951-d872f2087c98
* The profile Source parameter of a BookmarkModelLoaded event can be null ↵tim@chromium.org2009-04-092-4/+6
| | | | | | | | | | during testing. MetricsService and WebContents weren't handling this case properly. Review URL: http://codereview.chromium.org/66007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13475 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing gyp description for windows with webkit/test_shell.bradnelson@google.com2009-04-091-1/+2
| | | | | | | | This does not throw the switch to turn it on for the world yet. Review URL: http://codereview.chromium.org/66008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13474 0039d316-1c4b-4281-b951-d872f2087c98
* Change the download UI not to report xx bytes of 0 bytes. Just report "xx ↵thestig@chromium.org2009-04-091-11/+14
| | | | | | | | | | bytes" instead, so this does not require additional translations. BUG=9782 Review URL: http://codereview.chromium.org/67005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13467 0039d316-1c4b-4281-b951-d872f2087c98