| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3109025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens mainly in chrome frame where password manager
or the web data service could be invalid due to failed sqllite
initialization. The failure is due to chrome.exe running in low
integrity mode while deleting browser history. This a temporary
fix to avoid crash the right fix is to run chrome.exe at medium
integrity and that involves some investigation.
Now why chrome.exe runs in the low integrity mode is a long
story. Chrome Frame implements IDeleteBrowsingHistory to
participate in history/user data deletion. IE8 tries to be
smart and invokes IDeleteBrowsingHistory methods in by
launching a separate process, rundll32.exe. However, when
npchrome_frame.dll's implementation is invoked the container
rundll32.exe is in low integrity. IE's elevation policy does
not work for us to elevate chrome_launcher.exe to medium in
this case (since this is not IE). so we end up launching
chrome.exe in low integrity.
BUG=51949
TEST=load gcf:about:version in Chrome Frame with IE8 on Win7
and delete browsing history.
Review URL: http://codereview.chromium.org/3133019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
some logics are moved into system memory path only. ( such as allocation of output buffer, and usage of FTBDoneACK messages.
Review URL: http://codereview.chromium.org/3141014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part of http://codereview.chromium.org/3191002 missed during checkin.
BUG=49091
TEST=None
Review URL: http://codereview.chromium.org/3149018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on NDEBUG builds too.
TBR: zelidrag
BUG=48920
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Spotted in previous review.
BUG=23581
Review URL: http://codereview.chromium.org/3152019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51449
TEST=JsonSchemaTest.TestNumber
Review URL: http://codereview.chromium.org/3158015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3165027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
as navigation state.
Review URL: http://codereview.chromium.org/3110018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
layout tests
BUG=45080,46299
Review URL: http://codereview.chromium.org/3116015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49091
TEST=Open DOMUI prefs, and click the "Manage..." button for search engines. Search engines should be listed, the default should be changeable, and entries should be removable.
Review URL: http://codereview.chromium.org/3191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
content_setting_bubble_contents.[cc/h]
(Note: that was a TODO for bulach).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3177016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Unit tests in file_watcher_unittest.cc.
Review URL: http://codereview.chromium.org/3149004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and margin.
BUG=51124
TEST=none
Review URL: http://codereview.chromium.org/3184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/5376
TEST=Manual
Review URL: http://codereview.chromium.org/3114011/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51729
TEST=see bug
Review URL: http://codereview.chromium.org/3145016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=56332
BUG=45535
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the chromium side of https://bugs.webkit.org/show_bug.cgi?id=43922.
For all speech input requests WebKit now sends a 'requestId' which identifies the input element within the page. This requestId is returned back to WebKit in all the speech input callbacks/events. Within chromium, the pair (render view id, request id) uniquely identifies a caller and we introduce the SpeechInputCallerId to hold this data. All code which was previously using render view id now uses this caller id.
Once this is working fully on both ends I'll add relevant browser tests.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3130018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implementation of a location provider that uses the Windows 7 Location API. Currently uses polling to get the users location, I will update this to use signals provided by the API in a future patch.
BUG=45535
TEST=Two test files included.
Review URL: http://codereview.chromium.org/3015053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=IndexedDBBrowserTest, IndexTest
Review URL: http://codereview.chromium.org/3148009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resize controls.
BUG=51778
TEST=Automatically saved windows are correctly restored (see bug), unit test: WindowSizeAutosaverTest.*
Review URL: http://codereview.chromium.org/3115005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added a check to see if tab_contents is NULL before adding the next infobar. If it is NULL the pending request will be canceled and it will continue to search for more pending requests.
BUG=51787
TEST=Find a site with two geolocation permission requests (maybe iGoogle?) leave two pending permission requests and navigate to another site, Chrome should no longer crash.
Review URL: http://codereview.chromium.org/3112006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
active languages.
When removing a language, we disable input methods associated with the language.
However, we should not disable input methods if these are used in other active
languages.
BUG=chromium-os:5798
TEST=manually
Review URL: http://codereview.chromium.org/3162014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3130022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the domain.
This patch only affectes the gtk ui. Here is what it looks like: http://imgur.com/g6Gox
If third party cookies are blocked, a warning is shown. Next to each domain, the content setting is displayed that applies (or nothing if the default applies). When the user selects some domains and presses an button, the labels are updated accordingly.
BUG=49826
TEST=unit_tests
Review URL: http://codereview.chromium.org/3096001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually
BUG=none
Review URL: http://codereview.chromium.org/3146020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- implement NSServiesRequests protocol on BrowserWindowCotroller to provide selection text to the services framework.
See http://developer.apple.com/mac/library/documentation/cocoa/conceptual/SysServices/Articles/using.html for services implementation.
Patch contributed by Hajime Morita <morrita@google.com>.
Original review URL: http://codereview.chromium.org/2883062
BUG=20868
TEST=manual
Review URL: http://codereview.chromium.org/3174012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
TBR=viettrungluu@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/3156019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get{Boolean,Integer,Real,Binary,Dictionary,List}().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3187004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since r56268, "value" of a preference change event is a dictionary of
"value" and "managed", hence the client code has to be changed from
e.value to e.value.value.
TEST=manually
BUG=chromium-os:5789
Review URL: http://codereview.chromium.org/3193001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this has using
directives for the functions so I don't have to change all files to use the namespace.
No code changes to logic.
TEST=it compiles + the included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3181016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
variants).
BUG=52346
TBR=mpcomplete
Review URL: http://codereview.chromium.org/3109024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38737
TEST=none
Review URL: http://codereview.chromium.org/3119021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a temporary workaround so that server-issued notifications work
for new sync data types.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3114012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Anna Popinova <annapop@chromium.org>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3109020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if CommandLine was never initialized, CommandLine::ForCurrentProcess() will
DCHECK. That causes DisplayDebugMessageInDialog() to run...which calls
CommandLine::ForCurrentProcess(), which can DCHECK.
Also, Chrome OS doesn't have xmessage, so we don't want to try to pop up a
message using that mechanism.
BUG=None
TEST=Run a binary that doesn't initialize CommandLine (a chrome os unittest binary, for example) and make it CHECK(false). Instead of looping until the stack explodes, it should print messages for the check failures and exit.
Review URL: http://codereview.chromium.org/3151016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikkay
TEST=no
BUG=no
Review URL: http://codereview.chromium.org/3152022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications.
BUG=50386
TEST=see bug
Review URL: http://codereview.chromium.org/3095007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are now able to access remoting directory token and talk token through
the chromoting setup dialog.
These information are sent to the service process for enabling the chromoting
host and perform the host registration.
All the plumbing for starting the service process, enabling the chromoting
host through through IPC commands are in place but host registration is
stubbed out and will be completed in next patch.
Review URL: http://codereview.chromium.org/3176014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuartmorgan in http://codereview.chromium.org/3010054 .
BUG=51748
TEST=visited YouTube and ensured video shows up; 3D CSS demos; WebGL demos
Review URL: http://codereview.chromium.org/3185004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove the non-working methods from the os object on d8 on Windows
so you can test for their presence with if (os.system).
* Add a test (not run by default since it only works on d8).
* Fix incorrect use of wait that left defunct processes (zombies).
Committed: http://code.google.com/p/v8/source/detail?r=1650
Review URL: http://codereview.chromium.org/56107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding more setup content to remoting. Including the gaia authenication
and done message. This provides the basic flow for the setup.
There's a lot still needs to be worked on:
1. Merge RemotingSetupFlow and RemotingSetupMessageHandler because we shouldn't
splitting the logic into two separate classes.
2. Cleanup the memory ownership.
3. Perform the actual gaia login.
4. Perform host registration.
Review URL: http://codereview.chromium.org/3160016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cycler.
BUG=51411,52103
TEST=page cycler
Review URL: http://codereview.chromium.org/3170020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46512
TEST=manual
Review URL: http://codereview.chromium.org/3186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
themselves based on their managed state.
- Disable the proxy settings button if they are managed.
BUG=52335
TEST=Verify appropriate options are disabled in Enterprise version w/ --enable-tabbed-options.
Review URL: http://codereview.chromium.org/3122021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, it fixes another ancient bug that prevented downloads search
from working in Incognito mode.
The design of DownloadHistory is also nicer now, with no dependencies
on DownloadManager.
TEST=see bug
BUG=51955
Review URL: http://codereview.chromium.org/3112011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove call to WaitForInfobarCount(0) so test doesn't hang on Win and look for better solution.
Review URL: http://codereview.chromium.org/3169015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stuff page.
Remove the trigger for showing list.
Make the remove button work.
BUG=49093
TEST=None
Review URL: http://codereview.chromium.org/3137011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem here was that in the case where the container was sized all the way open, we never saved the result, because we never called Animate(). Having the size saving happen at the end of animation seemed subtle, so this:
* Saves at the beginning, not end, of animation (so shutdowns during animation don't forget the right size)
* Renames Animate() to make it clearer that it's also saving the desired size
* In general simplifies things by basing animation on a target number of icons instead of a target width
BUG=51179
TEST=Size browser actions container to hide one action (and show the rest); restart; size to show all; restart. On both restarts, you should see the same number of visible actions as at shut down.
Review URL: http://codereview.chromium.org/3114014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56258 0039d316-1c4b-4281-b951-d872f2087c98
|